214673 2020-07-22 21:12:41 -0700 [Win10] js/weakref-finalizationregistry.html is frequently timing out 2023-11-23 12:56:44 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified NEW InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned fujii keith_miller webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1674107 0 ryanhaddad 2020-07-22 21:12:41 -0700 js/weakref-finalizationregistry.html has been frequently timing out on Win10 bots since it was added with r264617. --- /home/buildbot/worker/win10-release-tests/build/layout-test-results/js/weakref-finalizationregistry-expected.txt +++ /home/buildbot/worker/win10-release-tests/build/layout-test-results/js/weakref-finalizationregistry-actual.txt @@ -1,4 +1,6 @@ +FAIL: Timed out waiting for notifyDone to be called PASS successfullyParsed is true TEST COMPLETE +Error https://results.webkit.org/?suite=layout-tests&test=js%2Fweakref-finalizationregistry.html 1674108 1 webkit-bug-importer 2020-07-22 21:13:04 -0700 <rdar://problem/65971901> 1674109 2 ryanhaddad 2020-07-22 21:15:51 -0700 Marked test as flaky in r264744 1674111 3 keith_miller 2020-07-22 21:21:11 -0700 Man, gc tests are a real nightmare... 1994290 4 fujii 2023-11-21 21:58:55 -0800 WinCairo Debug and Release tester are constantly timing out. GTK Debug is ramdomly timing out. https://results.webkit.org/?suite=layout-tests&test=js%2Fweakref-finalizationregistry.html 1994291 5 fujii 2023-11-21 22:02:14 -0800 It's flaky timeout for WinCairo Debug on my PC. But, it will pass constantly by applying this patch. diff --git a/LayoutTests/js/script-tests/weakref-finalizationregistry.js b/LayoutTests/js/script-tests/weakref-finalizationregistry.js index 130c6c81d4de..be85642f01f0 100644 --- a/LayoutTests/js/script-tests/weakref-finalizationregistry.js +++ b/LayoutTests/js/script-tests/weakref-finalizationregistry.js @@ -18,7 +18,7 @@ function turnEventLoop() { setTimeout(() => { gc(); resolve(); - }, 1); + }, 30); }); } Does GC thread need a time to collect? 1994579 6 fujii 2023-11-23 12:56:44 -0800 The commit message of 248952@main explains why it wait for 1ms. > * js/script-tests/weakref-finalizationregistry.js: > (turnEventLoop): Use a timeout of 1ms instead of 0ms so that > the deferred work task that calls the JS FinalizationRegistry > callback gets a chance to run before we continue on to the > assertion that it was run.