214671 2020-07-22 19:25:38 -0700 [CMake][Win] Build StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm only for AppleWin 2020-07-23 13:38:19 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii fujii achristensen annulen bfulgham don.olmstead ews-watchlist gyuyoung.kim pvollan ross.kirsling ryuan.choi sergio oldest_to_newest 1674089 0 fujii 2020-07-22 19:25:38 -0700 [CMake][Win] Build StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm only for AppleWin StructuredExceptionHandlerSuppressor is used only by AppleWin port (in Source/WebCore/platform/graphics/ca/win/LayerChangesFlusher.cpp) makesafeseh.asm causes building problem for WinCairo because it is using OBJECT library type for WebCore. 1674090 1 405009 fujii 2020-07-22 19:29:52 -0700 Created attachment 405009 Patch 1674201 2 405009 pvollan 2020-07-23 07:12:30 -0700 Comment on attachment 405009 Patch R=me. 1674341 3 fujii 2020-07-23 13:38:19 -0700 Thank you for the review. Committed r264786: <https://trac.webkit.org/r264786> 405009 2020-07-22 19:29:52 -0700 2020-07-23 07:12:30 -0700 Patch bug-214671-20200723112950.patch text/plain 3344 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTVhMGUxMGUzYTFlMDc1 OTNmMWZkNGViYTk1ZTQ5YWMzNzRmNzZiYi4uYmViMGYyM2M0MDZmNTY1ODk1NmQxMjU0MmU5N2Ey YWIzNTBkZjQ0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA3LTIyICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV1b V2luXSBCdWlsZCBTdHJ1Y3R1cmVkRXhjZXB0aW9uSGFuZGxlclN1cHByZXNzb3IuY3BwIGFuZCBt YWtlc2FmZXNlaC5hc20gb25seSBmb3IgQXBwbGVXaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDY3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0cnVjdHVyZWRFeGNlcHRpb25IYW5kbGVyU3VwcHJl c3NvciBpcyB1c2VkIG9ubHkgYnkgQXBwbGVXaW4gcG9ydAorICAgICAgICBpbiBwbGF0Zm9ybS9n cmFwaGljcy9jYS93aW4vTGF5ZXJDaGFuZ2VzRmx1c2hlci5jcHAuCisgICAgICAgIG1ha2VzYWZl c2VoLmFzbSBjYXVzZXMgYSBidWlsZGluZyBwcm9ibGVtIGZvciAzMmJpdCBXaW5DYWlybworICAg ICAgICBiZWNhdXNlIGl0IGlzIHVzaW5nIE9CSkVDVCBsaWJyYXJ5IHR5cGUgZm9yIFdlYkNvcmUu CisKKyAgICAgICAgKiBQbGF0Zm9ybUFwcGxlV2luLmNtYWtlOiBBZGRlZCBidWlsZCBydWxlcyBm b3IgdGhlbS4KKyAgICAgICAgKiBQbGF0Zm9ybVdpbi5jbWFrZTogUmVtb3ZlZCBidWlsZCBydWxl cyBmb3IgdGhlbS4KKwogMjAyMC0wNy0yMiAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWpp aUBzb255LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dWzMyYml0XSBKUEVHMjAwMEltYWdlRGVj b2Rlci5jcHA6IGVycm9yIEMyNjY0OiAnc3RkOjp1bmlxdWVfcHRyPC4uLj46OnVuaXF1ZV9wdHIo Li4uKSc6IGNhbm5vdCBjb252ZXJ0IGFyZ3VtZW50IDIgZnJvbSAndm9pZCAoX19zdGRjYWxsICop KG9wal9jb2RlY190ICopJyB0byAnY29uc3QgX0R4ICYnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9QbGF0Zm9ybUFwcGxlV2luLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1BcHBs ZVdpbi5jbWFrZQppbmRleCA1ZDE3NzQzZWQzODQzMDExZmE4NmNlNTExYmU5MjkzMzA5OTI5MmU1 Li5kOTRmZDY5Y2Q3ZWRlY2EzYzg2MDYxYWYzMjBhYmJjYWIyOGM4MDNmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUFwcGxlV2luLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3Jl L1BsYXRmb3JtQXBwbGVXaW4uY21ha2UKQEAgLTUzLDYgKzUzLDggQEAgbGlzdChBUFBFTkQgV2Vi Q29yZV9TT1VSQ0VTCiAgICAgcGxhdGZvcm0vbmV0d29yay9jZi9TeW5jaHJvbm91c0xvYWRlckNs aWVudENGTmV0LmNwcAogCiAgICAgcGxhdGZvcm0vdGV4dC9Mb2NhbGVOb25lLmNwcAorCisgICAg cGxhdGZvcm0vd2luL1N0cnVjdHVyZWRFeGNlcHRpb25IYW5kbGVyU3VwcHJlc3Nvci5jcHAKICkK IAogbGlzdChBUFBFTkQgV2ViQ29yZV9QUklWQVRFX0ZSQU1FV09SS19IRUFERVJTCkBAIC0xODQs MyArMTg2LDEyIEBAIGVsc2UgKCkKICAgICAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvY2cvVVRJUmVn aXN0cnkuaAogICAgICkKIGVuZGlmICgpCisKK2lmIChDTUFLRV9TSVpFT0ZfVk9JRF9QIEVRVUFM IDQpCisgICAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTICR7V2ViQ29yZV9ERVJJVkVEX1NP VVJDRVNfRElSfS9tYWtlc2FmZXNlaC5vYmopCisgICAgYWRkX2N1c3RvbV9jb21tYW5kKAorICAg ICAgICBPVVRQVVQgJHtXZWJDb3JlX0RFUklWRURfU09VUkNFU19ESVJ9L21ha2VzYWZlc2VoLm9i agorICAgICAgICBERVBFTkRTICR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL3dpbi9tYWtlc2FmZXNl aC5hc20KKyAgICAgICAgQ09NTUFORCBtbCAvc2FmZXNlaCAvYyAvRm8gJHtXZWJDb3JlX0RFUklW RURfU09VUkNFU19ESVJ9L21ha2VzYWZlc2VoLm9iaiAke1dFQkNPUkVfRElSfS9wbGF0Zm9ybS93 aW4vbWFrZXNhZmVzZWguYXNtCisgICAgICAgIFZFUkJBVElNKQorZW5kaWYgKCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtV2luLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxh dGZvcm1XaW4uY21ha2UKaW5kZXggNDFhOGQ0MWJmMGVlNWE4ZTA1ZjFiYzZjYTg1ZGFkZWE3YmRj Y2ZlNy4uZDY4NGU5ZTRjNGM4Y2U1NWE2ODQxNmJkZjVkOWZmNTNkOTNhYjMwZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XaW4uY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUv UGxhdGZvcm1XaW4uY21ha2UKQEAgLTk3LDcgKzk3LDYgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9T T1VSQ0VTCiAgICAgcGxhdGZvcm0vd2luL1NlYXJjaFBvcHVwTWVudURCLmNwcAogICAgIHBsYXRm b3JtL3dpbi9TZWFyY2hQb3B1cE1lbnVXaW4uY3BwCiAgICAgcGxhdGZvcm0vd2luL1NoYXJlZEJ1 ZmZlcldpbi5jcHAKLSAgICBwbGF0Zm9ybS93aW4vU3RydWN0dXJlZEV4Y2VwdGlvbkhhbmRsZXJT dXBwcmVzc29yLmNwcAogICAgIHBsYXRmb3JtL3dpbi9TeXN0ZW1JbmZvLmNwcAogICAgIHBsYXRm b3JtL3dpbi9Vc2VyQWdlbnRXaW4uY3BwCiAgICAgcGxhdGZvcm0vd2luL1dDRGF0YU9iamVjdC5j cHAKQEAgLTIwMiwxNSArMjAxLDYgQEAgZWxzZSAoKQogICAgICkKIGVuZGlmICgpCiAKLWlmIChD TUFLRV9TSVpFT0ZfVk9JRF9QIEVRVUFMIDQpCi0gICAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VS Q0VTICR7V2ViQ29yZV9ERVJJVkVEX1NPVVJDRVNfRElSfS9tYWtlc2FmZXNlaC5vYmopCi0gICAg YWRkX2N1c3RvbV9jb21tYW5kKAotICAgICAgICBPVVRQVVQgJHtXZWJDb3JlX0RFUklWRURfU09V UkNFU19ESVJ9L21ha2VzYWZlc2VoLm9iagotICAgICAgICBERVBFTkRTICR7V0VCQ09SRV9ESVJ9 L3BsYXRmb3JtL3dpbi9tYWtlc2FmZXNlaC5hc20KLSAgICAgICAgQ09NTUFORCBtbCAvc2FmZXNl aCAvYyAvRm8gJHtXZWJDb3JlX0RFUklWRURfU09VUkNFU19ESVJ9L21ha2VzYWZlc2VoLm9iaiAk e1dFQkNPUkVfRElSfS9wbGF0Zm9ybS93aW4vbWFrZXNhZmVzZWguYXNtCi0gICAgICAgIFZFUkJB VElNKQotZW5kaWYgKCkKLQogaWYgKCR7V1RGX1BMQVRGT1JNX1dJTl9DQUlST30pCiAgICAgaW5j bHVkZShQbGF0Zm9ybVdpbkNhaXJvLmNtYWtlKQogZWxzZSAoKQo=