214666 2020-07-22 17:18:10 -0700 [Cocoa|WebM] Decode error when seeking 2020-07-22 20:01:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble eric.carlson peng.liu6 webkit-bug-importer oldest_to_newest 1674051 0 jer.noble 2020-07-22 17:18:10 -0700 [Cocoa|WebM] Decode error when seeking 1674052 1 jer.noble 2020-07-22 17:22:13 -0700 <rdar://problem/65961804> 1674053 2 404999 jer.noble 2020-07-22 17:22:32 -0700 Created attachment 404999 Patch 1674060 3 404999 eric.carlson 2020-07-22 18:03:36 -0700 Comment on attachment 404999 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404999&action=review > Source/WebCore/ChangeLog:8 > + A decoder error is hit when seeking because we think all samples coming out of the SourceBufferParserWebM is a sync-sample. There is a tense problem here: "all samples ... is a sync-sample" 1674062 4 405003 jer.noble 2020-07-22 18:07:05 -0700 Created attachment 405003 Patch for landing 1674095 5 ews-feeder 2020-07-22 20:01:29 -0700 Committed r264742: <https://trac.webkit.org/changeset/264742> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405003. 404999 2020-07-22 17:22:32 -0700 2020-07-22 18:03:36 -0700 Patch bug-214666-20200722172232.patch text/plain 2821 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk5YzgwOGM3ZjZjNGQ2 MGViOTFhMTQ0OGNlNjg1OTViMTMzM2M3Ny4uNzczYmMxZjliMjYwYjllNWFjMmI5MzkwM2JmNTZj OWIzYjRkNGVkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA3LTIyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYXxXZWJNXSBEZWNv ZGUgZXJyb3Igd2hlbiBzZWVraW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTQ2NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBIGRlY29kZXIgZXJyb3IgaXMgaGl0IHdoZW4gc2Vla2luZyBiZWNhdXNl IHdlIHRoaW5rIGFsbCBzYW1wbGVzIGNvbWluZyBvdXQgb2YgdGhlIFNvdXJjZUJ1ZmZlclBhcnNl cldlYk0gaXMgYSBzeW5jLXNhbXBsZS4KKyAgICAgICAgVGhpcyBpcyBiZWNhdXNlIHRoZSBhdHRh Y2htZW50IGFkZGVkIHdpdGggQ01TZXRBdHRhY2htZW50KCkgaXMgaWdub3JlZDsgdGhlIGNvcnJl Y3Qgd2F5IHRvIHNldCBzYW1wbGUgYXR0YWNobWVudHMgaXMgYnkKKyAgICAgICAgZ2V0dGluZyB0 aGUgc2FtcGxlIGF0dGFjaG1lbnRzIGFycmF5IHdpdGggQ01TYW1wbGVCdWZmZXJHZXRTYW1wbGVB dHRhY2htZW50c0FycmF5KCksIGFuZCB0aGVuIGl0ZXJhdGluZyBvdmVyIHRoZSBhdHRhY2htZW50 cworICAgICAgICBhbmQgYWRkaW5nIGtleXMgdG8gdGhlIHVuZGVybHlpbmcgbXV0YWJsZSBDRkRp Y3Rpb25hcnkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Tb3VyY2VCdWZm ZXJQYXJzZXJXZWJNLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNvdXJjZUJ1ZmZlclBhcnNlcldl Yk06Ok9uRnJhbWUpOgorCiAyMDIwLTA3LTIyICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgU2FmYXJpIGRvZXMgbm90IHByZXNlbnQgQ2VydGlm aWNhdGVJbmZvIGZvciBzZXJ2aWNlLXdvcmtlciBzZXJ2ZWQgZG9jdW1lbnRzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Tb3VyY2VCdWZmZXJQYXJz ZXJXZWJNLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1NvdXJj ZUJ1ZmZlclBhcnNlcldlYk0uY3BwCmluZGV4IDNkN2E3ODgxOTc4YzEzOTU4NjA4MGRiZTdmOTJk YTQzMDU0MWFhODAuLjRkY2JlNWQ2ZWNjNjE2NTQwMTlmZmJkODc5Y2UzNzY3YzFlYjc2OWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1NvdXJjZUJ1 ZmZlclBhcnNlcldlYk0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NvY29hL1NvdXJjZUJ1ZmZlclBhcnNlcldlYk0uY3BwCkBAIC00Miw2ICs0Miw3IEBACiAjaW5j bHVkZSA8d3RmL0FsZ29yaXRobXMuaD4KICNpbmNsdWRlIDx3dGYvRGVxdWUuaD4KICNpbmNsdWRl IDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KKyNpbmNsdWRlIDx3dGYvY2YvVHlwZUNhc3RzQ0YuaD4K ICNpbmNsdWRlIDx3dGYvZGFyd2luL1dlYWtMaW5raW5nLmg+CiAKIFdURl9XRUFLX0xJTktfRk9S Q0VfSU1QT1JUKHdlYm06OnN3YXApOwpAQCAtNzkzLDggKzc5NCwxNiBAQCB3ZWJtOjpTdGF0dXMg U291cmNlQnVmZmVyUGFyc2VyV2ViTTo6T25GcmFtZShjb25zdCBGcmFtZU1ldGFkYXRhJiBtZXRh ZGF0YSwgUmVhZAogICAgICAgICB0cmFja0RhdGEtPmN1cnJlbnRCbG9ja0J1ZmZlciA9IG51bGxw dHI7CiAgICAgICAgIHRyYWNrRGF0YS0+Y3VycmVudEJsb2NrQnVmZmVyUG9zaXRpb24gPSAwOwog Ci0gICAgICAgIGlmICghaXNTeW5jKQotICAgICAgICAgICAgQ01TZXRBdHRhY2htZW50KHNhbXBs ZUJ1ZmZlci5nZXQoKSwga0NNU2FtcGxlQXR0YWNobWVudEtleV9Ob3RTeW5jLCBrQ0ZCb29sZWFu VHJ1ZSwga0NNQXR0YWNobWVudE1vZGVfU2hvdWxkUHJvcGFnYXRlKTsKKyAgICAgICAgaWYgKCFp c1N5bmMpIHsKKyAgICAgICAgICAgIGF1dG8gYXR0YWNobWVudHNBcnJheSA9IENNU2FtcGxlQnVm ZmVyR2V0U2FtcGxlQXR0YWNobWVudHNBcnJheShzYW1wbGVCdWZmZXIuZ2V0KCksIHRydWUpOwor ICAgICAgICAgICAgQVNTRVJUKGF0dGFjaG1lbnRzQXJyYXkpOworICAgICAgICAgICAgaWYgKCFh dHRhY2htZW50c0FycmF5KQorICAgICAgICAgICAgICAgIHJldHVybiBTa2lwKHJlYWRlciwgYnl0 ZXNSZW1haW5pbmcpOworICAgICAgICAgICAgZm9yIChDRkluZGV4IGkgPSAwLCBjb3VudCA9IENG QXJyYXlHZXRDb3VudChhdHRhY2htZW50c0FycmF5KTsgaSA8IGNvdW50OyArK2kpIHsKKyAgICAg ICAgICAgICAgICBDRk11dGFibGVEaWN0aW9uYXJ5UmVmIGF0dGFjaG1lbnRzID0gY2hlY2tlZF9j Zl9jYXN0PENGTXV0YWJsZURpY3Rpb25hcnlSZWY+KENGQXJyYXlHZXRWYWx1ZUF0SW5kZXgoYXR0 YWNobWVudHNBcnJheSwgaSkpOworICAgICAgICAgICAgICAgIENGRGljdGlvbmFyeVNldFZhbHVl KGF0dGFjaG1lbnRzLCBrQ01TYW1wbGVBdHRhY2htZW50S2V5X05vdFN5bmMsIGtDRkJvb2xlYW5U cnVlKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQogCiAgICAgICAgIGF1dG8gdHJhY2tJRCA9 IHRyYWNrLnRyYWNrX3VpZC52YWx1ZSgpOwogCg== 405003 2020-07-22 18:07:05 -0700 2020-07-22 20:01:30 -0700 Patch for landing bug-214666-20200722180704.patch text/plain 2819 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk5YzgwOGM3ZjZjNGQ2 MGViOTFhMTQ0OGNlNjg1OTViMTMzM2M3Ny4uMTA4MjlmMTQ2NTEyN2NlY2JmZjliNTZkMjIxODc2 YjZhNzRjMjA5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA3LTIyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYXxXZWJNXSBEZWNv ZGUgZXJyb3Igd2hlbiBzZWVraW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTQ2NjYKKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24u CisKKyAgICAgICAgQSBkZWNvZGVyIGVycm9yIGlzIGhpdCB3aGVuIHNlZWtpbmcgYmVjYXVzZSB3 ZSB0aGluayBhbGwgc2FtcGxlcyBjb21pbmcgb3V0IG9mIHRoZSBTb3VyY2VCdWZmZXJQYXJzZXJX ZWJNIGFyZSBzeW5jLXNhbXBsZXMuCisgICAgICAgIFRoaXMgaXMgYmVjYXVzZSB0aGUgYXR0YWNo bWVudCBhZGRlZCB3aXRoIENNU2V0QXR0YWNobWVudCgpIGlzIGlnbm9yZWQ7IHRoZSBjb3JyZWN0 IHdheSB0byBzZXQgc2FtcGxlIGF0dGFjaG1lbnRzIGlzIGJ5CisgICAgICAgIGdldHRpbmcgdGhl IHNhbXBsZSBhdHRhY2htZW50cyBhcnJheSB3aXRoIENNU2FtcGxlQnVmZmVyR2V0U2FtcGxlQXR0 YWNobWVudHNBcnJheSgpLCBhbmQgdGhlbiBpdGVyYXRpbmcgb3ZlciB0aGUgYXR0YWNobWVudHMK KyAgICAgICAgYW5kIGFkZGluZyBrZXlzIHRvIHRoZSB1bmRlcmx5aW5nIG11dGFibGUgQ0ZEaWN0 aW9uYXJ5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvU291cmNlQnVmZmVy UGFyc2VyV2ViTS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXJQYXJzZXJXZWJN OjpPbkZyYW1lKToKKwogMjAyMC0wNy0yMiAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIFNhZmFyaSBkb2VzIG5vdCBwcmVzZW50IENlcnRpZmlj YXRlSW5mbyBmb3Igc2VydmljZS13b3JrZXIgc2VydmVkIGRvY3VtZW50cwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvU291cmNlQnVmZmVyUGFyc2Vy V2ViTS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Tb3VyY2VC dWZmZXJQYXJzZXJXZWJNLmNwcAppbmRleCAzZDdhNzg4MTk3OGMxMzk1ODYwODBkYmU3ZjkyZGE0 MzA1NDFhYTgwLi40ZGNiZTVkNmVjYzYxNjU0MDE5ZmZiZDg3OWNlMzc2N2MxZWI3NjlkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Tb3VyY2VCdWZm ZXJQYXJzZXJXZWJNLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j b2NvYS9Tb3VyY2VCdWZmZXJQYXJzZXJXZWJNLmNwcApAQCAtNDIsNiArNDIsNyBAQAogI2luY2x1 ZGUgPHd0Zi9BbGdvcml0aG1zLmg+CiAjaW5jbHVkZSA8d3RmL0RlcXVlLmg+CiAjaW5jbHVkZSA8 d3RmL05ldmVyRGVzdHJveWVkLmg+CisjaW5jbHVkZSA8d3RmL2NmL1R5cGVDYXN0c0NGLmg+CiAj aW5jbHVkZSA8d3RmL2Rhcndpbi9XZWFrTGlua2luZy5oPgogCiBXVEZfV0VBS19MSU5LX0ZPUkNF X0lNUE9SVCh3ZWJtOjpzd2FwKTsKQEAgLTc5Myw4ICs3OTQsMTYgQEAgd2VibTo6U3RhdHVzIFNv dXJjZUJ1ZmZlclBhcnNlcldlYk06Ok9uRnJhbWUoY29uc3QgRnJhbWVNZXRhZGF0YSYgbWV0YWRh dGEsIFJlYWQKICAgICAgICAgdHJhY2tEYXRhLT5jdXJyZW50QmxvY2tCdWZmZXIgPSBudWxscHRy OwogICAgICAgICB0cmFja0RhdGEtPmN1cnJlbnRCbG9ja0J1ZmZlclBvc2l0aW9uID0gMDsKIAot ICAgICAgICBpZiAoIWlzU3luYykKLSAgICAgICAgICAgIENNU2V0QXR0YWNobWVudChzYW1wbGVC dWZmZXIuZ2V0KCksIGtDTVNhbXBsZUF0dGFjaG1lbnRLZXlfTm90U3luYywga0NGQm9vbGVhblRy dWUsIGtDTUF0dGFjaG1lbnRNb2RlX1Nob3VsZFByb3BhZ2F0ZSk7CisgICAgICAgIGlmICghaXNT eW5jKSB7CisgICAgICAgICAgICBhdXRvIGF0dGFjaG1lbnRzQXJyYXkgPSBDTVNhbXBsZUJ1ZmZl ckdldFNhbXBsZUF0dGFjaG1lbnRzQXJyYXkoc2FtcGxlQnVmZmVyLmdldCgpLCB0cnVlKTsKKyAg ICAgICAgICAgIEFTU0VSVChhdHRhY2htZW50c0FycmF5KTsKKyAgICAgICAgICAgIGlmICghYXR0 YWNobWVudHNBcnJheSkKKyAgICAgICAgICAgICAgICByZXR1cm4gU2tpcChyZWFkZXIsIGJ5dGVz UmVtYWluaW5nKTsKKyAgICAgICAgICAgIGZvciAoQ0ZJbmRleCBpID0gMCwgY291bnQgPSBDRkFy cmF5R2V0Q291bnQoYXR0YWNobWVudHNBcnJheSk7IGkgPCBjb3VudDsgKytpKSB7CisgICAgICAg ICAgICAgICAgQ0ZNdXRhYmxlRGljdGlvbmFyeVJlZiBhdHRhY2htZW50cyA9IGNoZWNrZWRfY2Zf Y2FzdDxDRk11dGFibGVEaWN0aW9uYXJ5UmVmPihDRkFycmF5R2V0VmFsdWVBdEluZGV4KGF0dGFj aG1lbnRzQXJyYXksIGkpKTsKKyAgICAgICAgICAgICAgICBDRkRpY3Rpb25hcnlTZXRWYWx1ZShh dHRhY2htZW50cywga0NNU2FtcGxlQXR0YWNobWVudEtleV9Ob3RTeW5jLCBrQ0ZCb29sZWFuVHJ1 ZSk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KIAogICAgICAgICBhdXRvIHRyYWNrSUQgPSB0 cmFjay50cmFja191aWQudmFsdWUoKTsKIAo=