214649 2020-07-22 12:12:15 -0700 updateRendering trace point should exclude SVG 2020-07-23 11:26:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 nham simon.fraser ggaren sabouhallawa simon.fraser webkit-bug-importer oldest_to_newest 1673922 0 nham 2020-07-22 12:12:15 -0700 After r259830, the updateRendering tracepoint doesn't work as expected since we are calling the tracepoint reentrantly (the root page's Page::updateRendering calls the SVG page's Page::updateRendering). We should either exclude the SVG page from this tracepoint or change the tracepoint pass an extra arg to kdebug_trace that can be used to properly pair the beginning and end of the tracepoint. 1674275 1 simon.fraser 2020-07-23 10:31:50 -0700 *** Bug 214691 has been marked as a duplicate of this bug. *** 1674276 2 405055 simon.fraser 2020-07-23 10:32:25 -0700 Created attachment 405055 Patch 1674278 3 405055 ggaren 2020-07-23 10:34:37 -0700 Comment on attachment 405055 Patch r=me 1674295 4 ews-feeder 2020-07-23 11:25:25 -0700 Committed r264778: <https://trac.webkit.org/changeset/264778> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405055. 1674296 5 webkit-bug-importer 2020-07-23 11:26:17 -0700 <rdar://problem/66002353> 405055 2020-07-23 10:32:25 -0700 2020-07-23 11:25:26 -0700 Patch bug-214649-20200723103224.patch text/plain 1555 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk5YzgwOGM3ZjZjNGQ2 MGViOTFhMTQ0OGNlNjg1OTViMTMzM2M3Ny4uMDgyZGVmYWFhZGM1NGJkMmQ4NThlYjJjNjBkYTI0 ZTRlN2M0ODRhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA3LTIzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIHVwZGF0ZVJlbmRl cmluZyB0cmFjZSBwb2ludCBzaG91bGQgZXhjbHVkZSBTVkcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDY0OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IGlzc3VlIHRoZSB0cmFjZSBwb2ludCBm b3IgU1ZHSW1hZ2UgUGFnZXMuCisKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UGFnZTo6dXBkYXRlUmVuZGVyaW5nKToKKwogMjAyMC0wNy0yMiAgQWxleCBDaHJp c3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFNhZmFyaSBkb2Vz IG5vdCBwcmVzZW50IENlcnRpZmljYXRlSW5mbyBmb3Igc2VydmljZS13b3JrZXIgc2VydmVkIGRv Y3VtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKaW5kZXggZGJiMzVlZTA4YmRmMTdlYjFkNDJiNGRhNDlm ODA5Zjk5NzNhMjUwNS4uMjA2OGRhNzBlN2RmMWMzZmUxYzkxOTFhY2Q1MDI1NmJjZGEyNDIyMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1BhZ2UuY3BwCkBAIC0xNDI0LDcgKzE0MjQsOSBAQCB2b2lkIFBhZ2U6OnVwZGF0 ZVJlbmRlcmluZygpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBUcmFjZVNjb3BlIHRy YWNlU2NvcGUoUmVuZGVyaW5nVXBkYXRlU3RhcnQsIFJlbmRlcmluZ1VwZGF0ZUVuZCk7CisgICAg Ym9vbCBpc1NWR0ltYWdlUGFnZSA9IGNocm9tZSgpLmNsaWVudCgpLmlzU1ZHSW1hZ2VDaHJvbWVD bGllbnQoKTsKKyAgICBpZiAoIWlzU1ZHSW1hZ2VQYWdlKQorICAgICAgICB0cmFjZVBvaW50KFJl bmRlcmluZ1VwZGF0ZVN0YXJ0KTsKIAogICAgIFNldEZvclNjb3BlPGJvb2w+IGNoYW5nZShtX2lu VXBkYXRlUmVuZGVyaW5nLCB0cnVlKTsKIApAQCAtMTQ5NCw2ICsxNDk2LDkgQEAgdm9pZCBQYWdl Ojp1cGRhdGVSZW5kZXJpbmcoKQogCiAgICAgbGF5b3V0SWZOZWVkZWQoKTsKICAgICBkb0FmdGVy VXBkYXRlUmVuZGVyaW5nKCk7CisKKyAgICBpZiAoIWlzU1ZHSW1hZ2VQYWdlKQorICAgICAgICB0 cmFjZVBvaW50KFJlbmRlcmluZ1VwZGF0ZUVuZCk7CiB9CiAKIHZvaWQgUGFnZTo6ZG9BZnRlclVw ZGF0ZVJlbmRlcmluZygpCg==