214641 2020-07-22 07:29:35 -0700 [32-bits] Fixing the return of doVMEntry into LowLevelInterpreter32_64.asm 2020-07-23 05:52:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ticaiolima ticaiolima ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1673810 0 ticaiolima 2020-07-22 07:29:35 -0700 ... 1673812 1 404921 ticaiolima 2020-07-22 07:36:40 -0700 Created attachment 404921 Patch 1673824 2 404921 mark.lam 2020-07-22 08:29:15 -0700 Comment on attachment 404921 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404921&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:331 > + move UndefinedTag, r1 > + move 0, r0 Can you just put a comment above this that says that this is in little endian order? That will make it easier if anyone tries to make big endian work, and need to grep for search for places to make needed changes. A comment is cheap and can be so helpful here. 1674173 3 405033 ticaiolima 2020-07-23 05:03:05 -0700 Created attachment 405033 Patch 1674175 4 405033 ticaiolima 2020-07-23 05:06:53 -0700 Comment on attachment 405033 Patch Thank you very much for the review. I also added another comment in another place that is "little-endian" specific. 1674184 5 ews-feeder 2020-07-23 05:51:56 -0700 Committed r264758: <https://trac.webkit.org/changeset/264758> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405033. 1674185 6 webkit-bug-importer 2020-07-23 05:52:18 -0700 <rdar://problem/65987760> 404921 2020-07-22 07:36:40 -0700 2020-07-23 05:03:01 -0700 Patch bug-214641-20200722113638.patch text/plain 1572 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0Njk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm YTQyMDMxYjc3Y2RkMGFlM2YzYzk0MGRkNGM2M2EwZmI3NWE1NGVjLi5jNjMwNzBhYzA4ODc3Nzgx YWQ2N2U0OWU4OWUxMzZiYjczNWE2MDZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNy0yMiAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgWzMyLWJpdHNdIEZpeGluZyB0aGUgcmV0dXJuIG9mIGRvVk1FbnRyeSBpbnRv IExvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDY0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkanVzdGluZyB0aGUgcmV0dXJuIG9mIGBkb1ZNRW50cnlg IGZvciAzMi1iaXRzIExMSW50IHRvIHByb3BlciBzZXQKKyAgICAgICAgYEVuY29kZWRKU1ZhbHVl YCByZXR1cm4gaW4gbGl0dGxlLWVuZGlhbiBhcmNoaXRlY3R1cmVzLiBJdCBpcyBleHBlY3RlZAor ICAgICAgICB0aGF0IHRhZyBpcyBzdG9yZWQgaW4gYHIxYCBhbmQgcGF5bG9hZCBpcyBzdG9yZWQg aW4gYHIwYC4KKworICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc206 CisKIDIwMjAtMDctMjEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg IFNpbXBsaWZ5IERpc2FsbG93U2NvcGUsIERpc2FsbG93R0MsIGFuZCBEaXNhbGxvd1ZNUmVlbnRy eSBpbXBsZW1lbnRhdGlvbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9s bGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtCmluZGV4IDY3Y2NmZDg0N2ZmYTkzYzZl ZjQzYzM5ZTFiYWY0YTQ1M2UwMDAyNjkuLjZiNGI2OWUzOWE0YTIyZjg2ODYyNTQ5ODAwMjk2NjMz NWFiMGJiYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZl bEludGVycHJldGVyMzJfNjQuYXNtCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9M b3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtCkBAIC0zMjcsOCArMzI3LDggQEAgbWFjcm8gZG9W TUVudHJ5KG1ha2VDYWxsKQogICAgIG1vdmUgdm0sIGEwCiAgICAgbW92ZSBwcm90b0NhbGxGcmFt ZSwgYTEKICAgICBjQ2FsbDIoX2xsaW50X2NoZWNrX3ZtX2VudHJ5X3Blcm1pc3Npb24pCi0gICAg bW92ZSBVbmRlZmluZWRUYWcsIHIwCi0gICAgbW92ZSAwLCByMQorICAgIG1vdmUgVW5kZWZpbmVk VGFnLCByMQorICAgIG1vdmUgMCwgcjAKIAogICAgIHN1YnAgY2ZyLCBDYWxsZWVSZWdpc3RlclNh dmVTaXplLCBzcAogICAgIHBvcENhbGxlZVNhdmVzKCkK 405033 2020-07-23 05:03:05 -0700 2020-07-23 05:51:56 -0700 Patch bug-214641-20200723090303.patch text/plain 2575 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0Njk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm YTQyMDMxYjc3Y2RkMGFlM2YzYzk0MGRkNGM2M2EwZmI3NWE1NGVjLi4xMjYxNDk4OTg0Y2NjNTM0 YzJjZjNiY2IwZjA2ZTNlNjZlNzgyYzU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wNy0yMyAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgWzMyLWJpdHNdIEZpeGluZyB0aGUgcmV0dXJuIG9mIGRvVk1FbnRyeSBpbnRv IExvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDY0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE1hcmsg TGFtLgorCisgICAgICAgIEFkanVzdGluZyB0aGUgcmV0dXJuIG9mIGBkb1ZNRW50cnlgIGZvciAz Mi1iaXRzIExMSW50IHRvIHByb3BlciBzZXQKKyAgICAgICAgYEVuY29kZWRKU1ZhbHVlYCByZXR1 cm4gaW4gbGl0dGxlLWVuZGlhbiBhcmNoaXRlY3R1cmVzLiBJdCBpcyBleHBlY3RlZAorICAgICAg ICB0aGF0IHRhZyBpcyBzdG9yZWQgaW4gYHIxYCBhbmQgcGF5bG9hZCBpcyBzdG9yZWQgaW4gYHIw YC4KKworICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtOgorICAgICAgICAq IGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc206CisKIDIwMjAtMDctMjEgIE1hcmsg TGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5IERpc2FsbG93U2Nv cGUsIERpc2FsbG93R0MsIGFuZCBEaXNhbGxvd1ZNUmVlbnRyeSBpbXBsZW1lbnRhdGlvbnMuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRl ci5hc20gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5h c20KaW5kZXggYmI4ZWZkNWQ2MThjMWMwNmFlNmJiMDQ1YzQ4NmNhZmE3ZGQ5OGNkNC4uNTFkM2M0 OWQyMzcwZmMyMjFlY2IyN2ExN2IwZjU2ZDRjOGFiYTZlZiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQpAQCAtMjE4Nyw3ICsy MTg3LDggQEAgb3AoY2hlY2twb2ludF9vc3JfZXhpdF9mcm9tX2lubGluZWRfY2FsbF90cmFtcG9s aW5lLCBtYWNybyAoKQogICAgICAgICAgICAgIyBHaXZlbiBfc2xvd19wYXRoX2NoZWNrcG9pbnRf b3NyX2V4aXRfZnJvbV9pbmxpbmVkX2NhbGwgaGFzCiAgICAgICAgICAgICAjIHBhcmFtZXRlcnMg YXMgQ2FsbEZyYW1lKiBhbmQgRW5jb2RlZEpTVmFsdWUsCiAgICAgICAgICAgICAjIHdlIG5lZWQg dG8gc3RvcmUgY2FsbCByZXN1bHQgb24gYTIsIGEzIGFuZCBjYWxsIGZyYW1lIG9uIGEwLAotICAg ICAgICAgICAgIyBsZWF2aW5nIGExIGFzIGR1bW15IHZhbHVlLgorICAgICAgICAgICAgIyBsZWF2 aW5nIGExIGFzIGR1bW15IHZhbHVlICh0aGlzIGNhbGxpbmcgY29udmVudGlvbiBpcyBjb25zaWRl cmVkIG9ubHkKKyAgICAgICAgICAgICMgZm9yIGxpdHRsZS1lbmRpYW4gYXJjaGl0ZWN0dXJlcyku CiAgICAgICAgICAgICBtb3ZlIHIxLCBhMwogICAgICAgICAgICAgbW92ZSByMCwgYTIKICAgICAg ICAgICAgIG1vdmUgY2ZyLCBhMApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xs aW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQppbmRleCA2N2NjZmQ4NDdmZmE5M2M2 ZWY0M2MzOWUxYmFmNGE0NTNlMDAwMjY5Li5kOTQxMTJiODFhOWM5MGY3ODM0MWE4MDVlZTMyMDQ1 YTVjMGUwNjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2 ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQv TG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQpAQCAtMzI3LDggKzMyNywxMCBAQCBtYWNybyBk b1ZNRW50cnkobWFrZUNhbGwpCiAgICAgbW92ZSB2bSwgYTAKICAgICBtb3ZlIHByb3RvQ2FsbEZy YW1lLCBhMQogICAgIGNDYWxsMihfbGxpbnRfY2hlY2tfdm1fZW50cnlfcGVybWlzc2lvbikKLSAg ICBtb3ZlIFVuZGVmaW5lZFRhZywgcjAKLSAgICBtb3ZlIDAsIHIxCisKKyAgICAjIFRhZyBpcyBz dG9yZWQgaW4gcjEgYW5kIHBheWxvYWQgaXMgc3RvcmVkIGluIHIwIGluIGxpdHRsZS1lbmRpYW4g YXJjaGl0ZWN0dXJlcy4KKyAgICBtb3ZlIFVuZGVmaW5lZFRhZywgcjEKKyAgICBtb3ZlIDAsIHIw CiAKICAgICBzdWJwIGNmciwgQ2FsbGVlUmVnaXN0ZXJTYXZlU2l6ZSwgc3AKICAgICBwb3BDYWxs ZWVTYXZlcygpCg==