214634 2020-07-22 03:12:11 -0700 REGRESSION: Fullscreen HTML5 video subtitles/captions are shown twice 2021-02-01 21:19:03 -0800 1 1 1 Unclassified WebKit Media Safari 13 iPhone / iPad iOS 13 RESOLVED FIXED InRadar P2 Normal --- 1 simonkawaji peng.liu6 cdumez changseok eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim jer.noble peng.liu6 philipj robert.erneborg sergio simon.fraser smorosow.dev webkit-bug-importer oldest_to_newest 1673783 0 simonkawaji 2020-07-22 03:12:11 -0700 When an HTML5 video is played with subtitles/captions in fullscreen, the previous subtitles will shown an additional time for a fraction of a second when the text is changed to the next one. The issue is a bit difficult to describe but you can take a look at the following examples to get a better understanding of the problem. * Two examples that have the issue: https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html https://codepen.io/JediLin/full/jpzgpv * How to recreate the bug: Try one of these links and fullscreen the video and enable subtitles. The bug will occur on fullscreen but not on windowed/in-page mode. I am using an 5th generation iPad with iOS version 13.6, Safari version 13.1 1674490 1 webkit-bug-importer 2020-07-23 17:43:28 -0700 <rdar://problem/66023355> 1674495 2 peng.liu6 2020-07-23 17:49:39 -0700 The issue is obvious with the first example video in my test. 1674510 3 simonkawaji 2020-07-23 18:17:25 -0700 I can add that the issue did not occur on iOS 13.3.1 but does occur on iOS 13.6. And in iOS 13.4, Safari was updated from 13.0 to 13.1 which included some webkit updates: https://webkit.org/blog/10247/new-webkit-features-in-safari-13-1/ 1694068 4 robert.erneborg 2020-10-02 06:24:33 -0700 (In reply to Peng Liu from comment #2) > The issue is obvious with the first example video in my test. We are still affected by this. Is it likely that this issue will get picked up anytime soon? 1721894 5 peng.liu6 2021-01-23 19:52:13 -0800 When I read the code, I noticed an issue that we set the "hidden" property of a text track representation layer to false before rendering the new subtitle. I will upload a patch to fix it. 1724392 6 418917 peng.liu6 2021-02-01 13:37:10 -0800 Created attachment 418917 Patch 1724479 7 418917 eric.carlson 2021-02-01 17:22:45 -0800 Comment on attachment 418917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418917&action=review > Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:302 > + m_needsGenerateTextTrackRepresentation = true; I know this isn't new to this change, but "m_needsToGenerateTextTrackRepresentation" would be a better name. 1724488 8 418947 peng.liu6 2021-02-01 17:52:12 -0800 Created attachment 418947 Revise the patch based on Eric's comment 1724489 9 418917 peng.liu6 2021-02-01 17:52:37 -0800 Comment on attachment 418917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418917&action=review >> Source/WebCore/html/shadow/MediaControlTextTrackContainerElement.cpp:302 >> + m_needsGenerateTextTrackRepresentation = true; > > I know this isn't new to this change, but "m_needsToGenerateTextTrackRepresentation" would be a better name. Agree! fixed. 1724523 10 ews-feeder 2021-02-01 21:18:59 -0800 Committed r272190: <https://trac.webkit.org/changeset/272190> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418947. 418917 2021-02-01 13:37:10 -0800 2021-02-01 17:22:45 -0800 Patch bug-214634-20210201133709.patch text/plain 2887 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTBiZjgzYzEyYmM4NDQ2 ODMxNjk4MjIwNzczZjVjNzNmNjYzZDlmYi4uZjdmMWQ5NzdlYmRhNjBjMDM2NGY1NDg1ZmVhNWI0 ZmM5MjVjZTBlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAyLTAxICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogRnVsbHNj cmVlbiBIVE1MNSB2aWRlbyBzdWJ0aXRsZXMvY2FwdGlvbnMgYXJlIHNob3duIHR3aWNlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ2MzQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlIG5lZWQg dG8gaGlkZSBhIHRleHQgdHJhY2sgcmVwcmVzZW50YXRpb24sIHdlIGNhbiBoaWRlIGl0IGRpcmVj dGx5LiBCdXQsIHdoZW4gd2UKKyAgICAgICAgbmVlZCB0byBzaG93KHNldCAiaGlkZGVuIiB0byBm YWxzZSkgYSB0ZXh0IHRyYWNrIHJlcHJlc2VudGF0aW9uLCB3ZSBoYXZlIHRvIHJlbmRlciBpdCBm aXJzdC4KKyAgICAgICAgT3RoZXJ3aXNlLCB0aGUgcHJldmlvdXNseSByZW5kZXJlZCBjb250ZW50 IHdpbGwgZmxhc2ggZm9yIGEgc2hvcnQgcGVyaW9kIG9mIHRpbWUuCisKKyAgICAgICAgQ292ZXJl ZCBieSBtYW51YWwgdGVzdC4KKworICAgICAgICAqIGh0bWwvc2hhZG93L01lZGlhQ29udHJvbFRl eHRUcmFja0NvbnRhaW5lckVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFDb250 cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6dXBkYXRlRGlzcGxheSk6CisgICAgICAgIChX ZWJDb3JlOjpNZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YWluZXJFbGVtZW50Ojp1cGRhdGVUZXh0 VHJhY2tSZXByZXNlbnRhdGlvbkltYWdlSWZOZWVkZWQpOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6dXBkYXRlVGV4dFRyYWNrUmVwcmVz ZW50YXRpb25JZk5lZWRlZCk6CisKIDIwMjEtMDItMDEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlA YXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBGaXggZWRpdGluZy9leGVj Q29tbWFuZC9wcmltaXRpdmUtdmFsdWUuaHRtbApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9zaGFkb3cvTWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YWluZXJF bGVtZW50LmNwcAppbmRleCAxMWFhNGM4MjY4MTRiOTlmMWMyOTkwNGI4MjA4MmExMDBiZjZhOTEw Li5jN2VhYjAwNjQ4MzYyY2FiNDFhNGU5ZTY4MmI0ZDhlYjE2ZDJkMDM2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YWluZXJF bGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xU ZXh0VHJhY2tDb250YWluZXJFbGVtZW50LmNwcApAQCAtMTgyLDcgKzE4Miw2IEBAIHZvaWQgTWVk aWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6dXBkYXRlRGlzcGxheSgpCiAKICAg ICB1cGRhdGVUZXh0VHJhY2tSZXByZXNlbnRhdGlvbklmTmVlZGVkKCk7CiAgICAgdXBkYXRlVGV4 dFRyYWNrU3R5bGUoKTsKLSAgICBtX25lZWRzR2VuZXJhdGVUZXh0VHJhY2tSZXByZXNlbnRhdGlv biA9IHRydWU7CiB9CiAKIHZvaWQgTWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVu dDo6dXBkYXRlVGV4dFRyYWNrUmVwcmVzZW50YXRpb25JbWFnZUlmTmVlZGVkKCkKQEAgLTE5NCw4 ICsxOTMsMTAgQEAgdm9pZCBNZWRpYUNvbnRyb2xUZXh0VHJhY2tDb250YWluZXJFbGVtZW50Ojp1 cGRhdGVUZXh0VHJhY2tSZXByZXNlbnRhdGlvbkltYWdlSWYKIAogICAgIC8vIFdlIHNob3VsZCBj YWxsIG1fdGV4dFRyYWNrUmVwcmVzZW50YXRpb24tPnVwZGF0ZSgpIHRvIHBhaW50IHRoZSBzdWJ0 cmVlIG9mCiAgICAgLy8gdGhlIFJlbmRlclRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQgYWZ0ZXIg dGhlIGxheW91dCBpcyBjbGVhbi4KLSAgICBpZiAobV90ZXh0VHJhY2tSZXByZXNlbnRhdGlvbikK KyAgICBpZiAobV90ZXh0VHJhY2tSZXByZXNlbnRhdGlvbikgewogICAgICAgICBtX3RleHRUcmFj a1JlcHJlc2VudGF0aW9uLT51cGRhdGUoKTsKKyAgICAgICAgbV90ZXh0VHJhY2tSZXByZXNlbnRh dGlvbi0+c2V0SGlkZGVuKGZhbHNlKTsKKyAgICB9CiB9CiAKIHZvaWQgTWVkaWFDb250cm9sVGV4 dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6cHJvY2Vzc0FjdGl2ZVZUVEN1ZShWVFRDdWUmIGN1ZSkK QEAgLTI5OCw3ICsyOTksNyBAQCB2b2lkIE1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVs ZW1lbnQ6OnVwZGF0ZVRleHRUcmFja1JlcHJlc2VudGF0aW9uSWZOZWVkZQogICAgICAgICBtX21l ZGlhRWxlbWVudC0+c2V0VGV4dFRyYWNrUmVwcmVzZW50YXRpb24obV90ZXh0VHJhY2tSZXByZXNl bnRhdGlvbi5nZXQoKSk7CiAgICAgfQogCi0gICAgbV90ZXh0VHJhY2tSZXByZXNlbnRhdGlvbi0+ c2V0SGlkZGVuKGZhbHNlKTsKKyAgICBtX25lZWRzR2VuZXJhdGVUZXh0VHJhY2tSZXByZXNlbnRh dGlvbiA9IHRydWU7CiB9CiAKIHZvaWQgTWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxl bWVudDo6Y2xlYXJUZXh0VHJhY2tSZXByZXNlbnRhdGlvbigpCg== 418947 2021-02-01 17:52:12 -0800 2021-02-01 21:19:01 -0800 Revise the patch based on Eric's comment bug-214634-20210201175211.patch text/plain 3694 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTBiZjgzYzEyYmM4NDQ2 ODMxNjk4MjIwNzczZjVjNzNmNjYzZDlmYi4uYTVkMmUzYjA3ZmIzMmQyNTA0NDZiNzZhOTg3MDMw Y2IzYjBkODAwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAyLTAxICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogRnVsbHNj cmVlbiBIVE1MNSB2aWRlbyBzdWJ0aXRsZXMvY2FwdGlvbnMgYXJlIHNob3duIHR3aWNlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ2MzQKKworICAg ICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgV2hlbiB3ZSBuZWVkIHRv IGhpZGUgYSB0ZXh0IHRyYWNrIHJlcHJlc2VudGF0aW9uLCB3ZSBjYW4gaGlkZSBpdCBkaXJlY3Rs eS4gQnV0LCB3aGVuIHdlCisgICAgICAgIG5lZWQgdG8gc2hvdyhzZXQgImhpZGRlbiIgdG8gZmFs c2UpIGEgdGV4dCB0cmFjayByZXByZXNlbnRhdGlvbiwgd2UgaGF2ZSB0byByZW5kZXIgaXQgZmly c3QuCisgICAgICAgIE90aGVyd2lzZSwgdGhlIHByZXZpb3VzbHkgcmVuZGVyZWQgY29udGVudCB3 aWxsIGZsYXNoIGZvciBhIHNob3J0IHBlcmlvZCBvZiB0aW1lLgorCisgICAgICAgIENvdmVyZWQg YnkgbWFudWFsIHRlc3QuCisKKyAgICAgICAgKiBodG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xUZXh0 VHJhY2tDb250YWluZXJFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhQ29udHJv bFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6OnVwZGF0ZURpc3BsYXkpOgorICAgICAgICAoV2Vi Q29yZTo6TWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6dXBkYXRlVGV4dFRy YWNrUmVwcmVzZW50YXRpb25JbWFnZUlmTmVlZGVkKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh Q29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6OnVwZGF0ZVRleHRUcmFja1JlcHJlc2Vu dGF0aW9uSWZOZWVkZWQpOgorCiAyMDIxLTAyLTAxICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFw cGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gRml4IGVkaXRpbmcvZXhlY0Nv bW1hbmQvcHJpbWl0aXZlLXZhbHVlLmh0bWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvc2hhZG93L01lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxl bWVudC5jcHAKaW5kZXggMTFhYTRjODI2ODE0Yjk5ZjFjMjk5MDRiODIwODJhMTAwYmY2YTkxMC4u ZDNjNGY5NDZmMjE5NTY0ZGFiMDlkMDY0ZjgyYjJkOGU2NDg5OTM5NiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxl bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sVGV4 dFRyYWNrQ29udGFpbmVyRWxlbWVudC5jcHAKQEAgLTE4MiwyMCArMTgyLDIxIEBAIHZvaWQgTWVk aWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6dXBkYXRlRGlzcGxheSgpCiAKICAg ICB1cGRhdGVUZXh0VHJhY2tSZXByZXNlbnRhdGlvbklmTmVlZGVkKCk7CiAgICAgdXBkYXRlVGV4 dFRyYWNrU3R5bGUoKTsKLSAgICBtX25lZWRzR2VuZXJhdGVUZXh0VHJhY2tSZXByZXNlbnRhdGlv biA9IHRydWU7CiB9CiAKIHZvaWQgTWVkaWFDb250cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVu dDo6dXBkYXRlVGV4dFRyYWNrUmVwcmVzZW50YXRpb25JbWFnZUlmTmVlZGVkKCkKIHsKLSAgICBp ZiAoIW1fbmVlZHNHZW5lcmF0ZVRleHRUcmFja1JlcHJlc2VudGF0aW9uKQorICAgIGlmICghbV9u ZWVkc1RvR2VuZXJhdGVUZXh0VHJhY2tSZXByZXNlbnRhdGlvbikKICAgICAgICAgcmV0dXJuOwog Ci0gICAgbV9uZWVkc0dlbmVyYXRlVGV4dFRyYWNrUmVwcmVzZW50YXRpb24gPSBmYWxzZTsKKyAg ICBtX25lZWRzVG9HZW5lcmF0ZVRleHRUcmFja1JlcHJlc2VudGF0aW9uID0gZmFsc2U7CiAKICAg ICAvLyBXZSBzaG91bGQgY2FsbCBtX3RleHRUcmFja1JlcHJlc2VudGF0aW9uLT51cGRhdGUoKSB0 byBwYWludCB0aGUgc3VidHJlZSBvZgogICAgIC8vIHRoZSBSZW5kZXJUZXh0VHJhY2tDb250YWlu ZXJFbGVtZW50IGFmdGVyIHRoZSBsYXlvdXQgaXMgY2xlYW4uCi0gICAgaWYgKG1fdGV4dFRyYWNr UmVwcmVzZW50YXRpb24pCisgICAgaWYgKG1fdGV4dFRyYWNrUmVwcmVzZW50YXRpb24pIHsKICAg ICAgICAgbV90ZXh0VHJhY2tSZXByZXNlbnRhdGlvbi0+dXBkYXRlKCk7CisgICAgICAgIG1fdGV4 dFRyYWNrUmVwcmVzZW50YXRpb24tPnNldEhpZGRlbihmYWxzZSk7CisgICAgfQogfQogCiB2b2lk IE1lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQ6OnByb2Nlc3NBY3RpdmVWVFRD dWUoVlRUQ3VlJiBjdWUpCkBAIC0yOTgsNyArMjk5LDcgQEAgdm9pZCBNZWRpYUNvbnRyb2xUZXh0 VHJhY2tDb250YWluZXJFbGVtZW50Ojp1cGRhdGVUZXh0VHJhY2tSZXByZXNlbnRhdGlvbklmTmVl ZGUKICAgICAgICAgbV9tZWRpYUVsZW1lbnQtPnNldFRleHRUcmFja1JlcHJlc2VudGF0aW9uKG1f dGV4dFRyYWNrUmVwcmVzZW50YXRpb24uZ2V0KCkpOwogICAgIH0KIAotICAgIG1fdGV4dFRyYWNr UmVwcmVzZW50YXRpb24tPnNldEhpZGRlbihmYWxzZSk7CisgICAgbV9uZWVkc1RvR2VuZXJhdGVU ZXh0VHJhY2tSZXByZXNlbnRhdGlvbiA9IHRydWU7CiB9CiAKIHZvaWQgTWVkaWFDb250cm9sVGV4 dFRyYWNrQ29udGFpbmVyRWxlbWVudDo6Y2xlYXJUZXh0VHJhY2tSZXByZXNlbnRhdGlvbigpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xUZXh0VHJh Y2tDb250YWluZXJFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNv bnRyb2xUZXh0VHJhY2tDb250YWluZXJFbGVtZW50LmgKaW5kZXggNTdlM2JlZmUyNzg4OTc2Yjhm OWFlNzllODIzNTU1MDAzMjYyZjEyOS4uY2UyNjYxNWYzZDA4YjRmYjEyNzllZTc5MDA4N2I3OGEw N2MwNzAwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250 cm9sVGV4dFRyYWNrQ29udGFpbmVyRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv c2hhZG93L01lZGlhQ29udHJvbFRleHRUcmFja0NvbnRhaW5lckVsZW1lbnQuaApAQCAtMTAyLDcg KzEwMiw3IEBAIHByaXZhdGU6CiAgICAgSW50UmVjdCBtX3ZpZGVvRGlzcGxheVNpemU7CiAgICAg aW50IG1fZm9udFNpemUgeyAwIH07CiAgICAgYm9vbCBtX2ZvbnRTaXplSXNJbXBvcnRhbnQgeyBm YWxzZSB9OwotICAgIGJvb2wgbV9uZWVkc0dlbmVyYXRlVGV4dFRyYWNrUmVwcmVzZW50YXRpb24g eyBmYWxzZSB9OworICAgIGJvb2wgbV9uZWVkc1RvR2VuZXJhdGVUZXh0VHJhY2tSZXByZXNlbnRh dGlvbiB7IGZhbHNlIH07CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==