214628 2020-07-22 00:24:00 -0700 Tapped DataDetected links present sub-menus from the wrong location. 2020-07-22 09:40:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton wenson_hsieh oldest_to_newest 1673760 0 megan_gardner 2020-07-22 00:24:00 -0700 Tapped DataDetected links present sub-menus from the wrong location. 1673766 1 404905 megan_gardner 2020-07-22 00:30:29 -0700 Created attachment 404905 Patch 1673767 2 megan_gardner 2020-07-22 00:30:59 -0700 <rdar://problem/64808642> 1673818 3 404905 wenson_hsieh 2020-07-22 07:54:01 -0700 Comment on attachment 404905 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404905&action=review > Source/WebKit/ChangeLog:12 > + Setting this bit ensures that all the necessary data is calculated and returned > + when a DataDetector link is tapped. Just curious — where is the logic that uses this linkIndicator information? 1673835 4 404905 megan_gardner 2020-07-22 09:07:22 -0700 Comment on attachment 404905 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404905&action=review >> Source/WebKit/ChangeLog:12 >> + when a DataDetector link is tapped. > > Just curious — where is the logic that uses this linkIndicator information? It's the bailout condition at the top of linkIndicatorPositionInformation in WebPageIOS, which in this case we do not want to bail out of, so that sourceRect = _positionInformation->linkIndicator.textBoundingRectInRootViewCoordinates gives good date when sending a source rect to DD. 1673837 5 ews-feeder 2020-07-22 09:09:57 -0700 Committed r264699: <https://trac.webkit.org/changeset/264699> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404905. 1673856 6 thorton 2020-07-22 09:40:27 -0700 Heh, this is a slightly heavyweight solution (because it involves needless snapshotting), but it will do the trick for now, until we split positionInformation up into more bite-sized chunks. 404905 2020-07-22 00:30:29 -0700 2020-07-22 09:09:57 -0700 Patch bug-214628-20200722003028.patch text/plain 2473 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NjUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhhZTM3MjI3YTUxMTE1MDg3 NTQ0OWUzNDRjMDMzNWNmMjJiOGUyYjcuLmQzMDViYjYzY2U5MTIwY2I5OGY3ZWE3YmEwZDBjYWZi YTI4OWI0ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDctMjIgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBUYXBwZWQgRGF0YURl dGVjdGVkIGxpbmtzIHByZXNlbnQgc3ViLW1lbnVzIGZyb20gdGhlIHdyb25nIGxvY2F0aW9uLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0NjI4Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NDgwODY0Mj4KKworICAgICAgICBXaGVuIGdldHRpbmcg dGhlIHBvc2l0aW9uSW5mb3JtYXRpb24gYXNzb2NpYXRlZCB3aXRoIHByZXNlbnRpbmcgRGF0YURl dGVjdG9ycyBVSQorICAgICAgICB3ZSB3ZXJlIG5vdCBpbmRpY2F0aW5nIHRoYXQgd2UgbmVlZCB0 aGUgbGlua0luZGljYXRvciBkYXRhLiBUaGlzIGNhdXNlZCB0aGUKKyAgICAgICAgcmVzdWx0aW5n IENHUmVjdCB0byBub3QgYmUgZmlsbGVkIG91dCwgYW5kIHdlIHdlcmUgcmV0dXJuaW5nIGEgemVy b2VkIG91dCBDR1JlY3QKKyAgICAgICAgdG8gdGhlIERhdGFEZXRlY3RvcnMgZnJhbWV3b3JrIGZv ciB0aGUgbG9jYXRpb24gdGhhdCBpdCBzaG91bGQgcHJlc2VudCB0aGUgc3ViTWVudSBmcm9tLgor ICAgICAgICBTZXR0aW5nIHRoaXMgYml0IGVuc3VyZXMgdGhhdCBhbGwgdGhlIG5lY2Vzc2FyeSBk YXRhIGlzIGNhbGN1bGF0ZWQgYW5kIHJldHVybmVkCisgICAgICAgIHdoZW4gYSBEYXRhRGV0ZWN0 b3IgbGluayBpcyB0YXBwZWQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L2lvcy9XZWJDaHJvbWVDbGll bnRJT1MubW06CisgICAgICAgIChXZWJLaXQ6OldlYkNocm9tZUNsaWVudDo6c2hvd0RhdGFEZXRl Y3RvcnNVSUZvckVsZW1lbnQpOgorCiAyMDIwLTA3LTIxICBNaWNoYWVsIENhdGFuemFybyAgPG1j YXRhbnphcm9AZ25vbWUub3JnPgogCiAgICAgICAgIFtHVEtdIFdlYktpdFNldHRpbmdzOmVuYWJs ZS1wcml2YXRlLWJyb3dzaW5nIG1pc3NpbmcgR19QQVJBTV9ERVBSRUNBVEVECmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvaW9zL1dlYkNocm9tZUNs aWVudElPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9pb3Mv V2ViQ2hyb21lQ2xpZW50SU9TLm1tCmluZGV4IDg5NjFmNWJmYjkwOGI0NjMxMDk3OWExZmE4OWQ4 MDZjMWI4YjRjODYuLjdkNTI1ZGZmOTU4ZDAzYTg1YWZmMTM5ZTc3MGQ4ZmFiMTEwZGYzYjEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9pb3MvV2Vi Q2hyb21lQ2xpZW50SU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3Jl U3VwcG9ydC9pb3MvV2ViQ2hyb21lQ2xpZW50SU9TLm1tCkBAIC0yMDMsNyArMjAzLDkgQEAgYm9v bCBXZWJDaHJvbWVDbGllbnQ6OnNob3dEYXRhRGV0ZWN0b3JzVUlGb3JFbGVtZW50KGNvbnN0IEVs ZW1lbnQmIGVsZW1lbnQsIGNvbnMKIAogICAgIC8vIEZJWE1FOiBJZGVhbGx5LCB3ZSB3b3VsZCBi ZSBhYmxlIHRvIGdlbmVyYXRlIEludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uIHdpdGhv dXQgcmUtaGl0LXRlc3RpbmcgdGhlIGVsZW1lbnQuCiAgICAgYXV0byYgbW91c2VFdmVudCA9IGRv d25jYXN0PE1vdXNlRXZlbnQ+KGV2ZW50KTsKLSAgICBhdXRvIHBvc2l0aW9uSW5mb3JtYXRpb24g PSBtX3BhZ2UucG9zaXRpb25JbmZvcm1hdGlvbihJbnRlcmFjdGlvbkluZm9ybWF0aW9uUmVxdWVz dCB7IHJvdW5kZWRJbnRQb2ludChtb3VzZUV2ZW50LmxvY2F0aW9uSW5Sb290Vmlld0Nvb3JkaW5h dGVzKCkpIH0pOworICAgIGF1dG8gcmVxdWVzdCA9IEludGVyYWN0aW9uSW5mb3JtYXRpb25SZXF1 ZXN0IHsgcm91bmRlZEludFBvaW50KG1vdXNlRXZlbnQubG9jYXRpb25JblJvb3RWaWV3Q29vcmRp bmF0ZXMoKSkgfTsKKyAgICByZXF1ZXN0LmluY2x1ZGVMaW5rSW5kaWNhdG9yID0gdHJ1ZTsKKyAg ICBhdXRvIHBvc2l0aW9uSW5mb3JtYXRpb24gPSBtX3BhZ2UucG9zaXRpb25JbmZvcm1hdGlvbihy ZXF1ZXN0KTsKICAgICBtX3BhZ2Uuc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpTaG93RGF0 YURldGVjdG9yc1VJRm9yUG9zaXRpb25JbmZvcm1hdGlvbihwb3NpdGlvbkluZm9ybWF0aW9uKSk7 CiAgICAgcmV0dXJuIHRydWU7CiB9Cg==