21462 2008-10-08 01:44:37 -0700 Overflow auto in div element shows obsolete scrollbars when content size is reduced 2014-10-17 06:51:37 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED DUPLICATE 71541 http://dev.itmill.com/raw-attachment/ticket/2138/safariscrollbug.html HasReduction P2 Normal --- 1 matti.tahvonen webkit-unassigned artur darin dtrebbien emacemac7 hyatt mstahv ssandela tonikitoo oldest_to_newest 94529 0 matti.tahvonen 2008-10-08 01:44:37 -0700 When content becomes small enough to fit into container, scrollbars are not removed. Reduced test case in URL field will show the case clearly (works in FF, IE, Opera. Bugs in Safari (both mac & win) and also in Chrome) 99452 1 artur 2008-11-20 04:08:45 -0800 Confirming the bug in latest nightly build r38492/windows. This has been bugging me also for some time. 102542 2 artur 2008-12-14 22:11:30 -0800 The problem seems to be that to RenderLayer::computeScrollDimensions uses clientHeight/clientWidth from the parent DIV to determine the amount of available space for the child DIV. ClientHeight/Width does not include the scrollbar sizes and thus it is wrongly determined that the child DIV will not fit inside the parent without scrollbars. I'm not sure if this should be fixed in computeScrollDimensions like done in the patch or if the scrollbars should be removed before calling computeScrollDimensions (called through RenderLayer::updateScrollInfoAfterLayout) 102544 3 26022 artur 2008-12-14 22:12:49 -0800 Created attachment 26022 Patch for taking existing scrollbars into account 102778 4 matti.tahvonen 2008-12-17 08:39:56 -0800 Hi! Somebody with decent powers, please confirm this bug. This bugzilla seems to be so full that it is impossible to get tickets handled without it. 104312 5 26409 artur 2009-01-04 03:55:28 -0800 Created attachment 26409 Updated patch including a webkit test Contains patch and a test case which fails with trunk version and succeeds when the patch is used. 104352 6 darin 2009-01-04 10:14:32 -0800 The patch needs a change log entry too. Please see http://webkit.org/coding/contributing.html for details. 104399 7 26424 artur 2009-01-04 22:37:14 -0800 Created attachment 26424 Patch + test case + changelog entry 107700 8 artur 2009-01-30 07:44:25 -0800 Bug report, test case, test for webkit, suggested patch. What more can one do to get a bug fixed? 120630 9 30184 eric 2009-05-11 05:31:04 -0700 Created attachment 30184 A (slightly) cleaned up version of the test case 120633 10 26424 eric 2009-05-11 05:34:13 -0700 Comment on attachment 26424 Patch + test case + changelog entry This patch uses tabs (which will cause the commit to fail. This patch also adds extra { } which violate the style guidelines: http://webkit.org/coding/coding-style.html I cleaned up the test case slightly to use the "blue means you need to look at the test case to understand the results; green means pass and red means fail" system. Otherwise, the patch looks sane to me. Hyatt really needs to weigh in here though. Ideally you'd update the patch to fix the style issues. Also I would probably have used // for the clientHeight/clientWidth comment and would have broken it into two lines. But I think /* is OK too, I'd have to check the style guidelines to be sure. 122057 11 eric 2009-05-19 22:03:07 -0700 Adding Hyatt for his comments on this patch. 122058 12 26424 eric 2009-05-19 22:04:15 -0700 Comment on attachment 26424 Patch + test case + changelog entry Great bug to fix. r- for the style issues. Added Hyatt to the CC list so he can also rubber-stamp. Please post a copy with fixed style. http://webkit.org/coding/coding-style.html 126176 13 matti.tahvonen 2009-06-16 02:27:32 -0700 Our "official workaround" for this bug in Vaadin (formerly IT Mill Toolkit) revealed an other scrollbar related issue. I filled a separate bug report for it: https://bugs.webkit.org/show_bug.cgi?id=26438 Some of you superusers could confirm that too. BTW. Still eagerly waiting for the fix to land in webkit. I was bit disappointed not to see this in safari 4. We could have removed a lot of dirty code from our product. 126210 14 31351 artur 2009-06-16 09:20:49 -0700 Created attachment 31351 Updated patch (coding style, against latest revision) 126912 15 31351 hyatt 2009-06-19 01:02:49 -0700 Comment on attachment 31351 Updated patch (coding style, against latest revision) This does not seem quite right to me. I think it will just cause other cases to be wrong. 174262 16 mstahv 2009-12-22 07:32:20 -0800 Hi! If the patch by Artur is not enough, what else can we do to help you to fix this issue? I have just spent one and a half day fighting with bugs and regressions which are either directly caused by this bug or its workarounds. So I'm really motivated to help fixing this issue. I'd much rather focus on developing new features. It would also enhance our products "feeling" a bit as we would get rid of some flickering caused by our workarounds. cheers, matti 599126 17 ssandela 2012-04-10 03:20:19 -0700 *** This bug has been marked as a duplicate of bug 71541 *** 26022 2008-12-14 22:12:49 -0800 2009-01-04 03:55:28 -0800 Patch for taking existing scrollbars into account scrollbar-21462.patch text/plain 790 artur SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHJldmlzaW9uIDM5MjkzKQorKysgV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMyLDYg KzEzMzIsMTQgQEAgdm9pZCBSZW5kZXJMYXllcjo6Y29tcHV0ZVNjcm9sbERpbWVuc2lvbgogICAg IAogICAgIG1fc2Nyb2xsT3JpZ2luWCA9IGx0ciA/IDAgOiBtX3Njcm9sbFdpZHRoIC0gY2xpZW50 V2lkdGg7CiAKKyAgICAvKiBjbGllbnRIZWlnaHQvY2xpZW50V2lkdGggZG9lcyBub3QgaW5jbHVk ZSBjdXJyZW50bHkgdmlzaWJsZSBzY3JvbGxiYXIgc2l6ZXMgYnV0IHRoaXMgYXJlYSBpcyB1c2Fi bGUgaWYgc2Nyb2xsYmFycyBhcmUgbm90IG5lZWRlZCAqLworICAgIGlmIChtX29iamVjdC0+aGFz QXV0b0hvcml6b250YWxTY3JvbGxiYXIoKSkgeworICAgICAgY2xpZW50SGVpZ2h0ICs9IGhvcml6 b250YWxTY3JvbGxiYXJIZWlnaHQoKTsKKyAgICB9CisgICAgaWYgKG1fb2JqZWN0LT5oYXNBdXRv VmVydGljYWxTY3JvbGxiYXIoKSkgeworICAgICAgY2xpZW50V2lkdGggKz0gdmVydGljYWxTY3Jv bGxiYXJXaWR0aCgpOworICAgIH0KKwogICAgIGlmIChuZWVkSEJhcikKICAgICAgICAgKm5lZWRI QmFyID0gcmlnaHRQb3MgPiBjbGllbnRXaWR0aDsKICAgICBpZiAobmVlZFZCYXIpCg== 26409 2009-01-04 03:55:28 -0800 2009-01-04 22:37:14 -0800 Updated patch including a webkit test patch-new text/plain 2078 artur SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHJldmlzaW9uIDM5NTc3KQorKysgV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMyLDYg KzEzMzIsMTQgQEAgdm9pZCBSZW5kZXJMYXllcjo6Y29tcHV0ZVNjcm9sbERpbWVuc2lvbgogICAg IAogICAgIG1fc2Nyb2xsT3JpZ2luWCA9IGx0ciA/IDAgOiBtX3Njcm9sbFdpZHRoIC0gY2xpZW50 V2lkdGg7CiAKKyAgICAvKiBjbGllbnRIZWlnaHQvY2xpZW50V2lkdGggZG9lcyBub3QgaW5jbHVk ZSBjdXJyZW50bHkgdmlzaWJsZSBzY3JvbGxiYXIgc2l6ZXMgYnV0IHRoaXMgYXJlYSBpcyB1c2Fi bGUgaWYgc2Nyb2xsYmFycyBhcmUgbm90IG5lZWRlZCAqLworICAgIGlmIChtX29iamVjdC0+aGFz QXV0b0hvcml6b250YWxTY3JvbGxiYXIoKSkgeworICAgICAgY2xpZW50SGVpZ2h0ICs9IGhvcml6 b250YWxTY3JvbGxiYXJIZWlnaHQoKTsKKyAgICB9CisgICAgaWYgKG1fb2JqZWN0LT5oYXNBdXRv VmVydGljYWxTY3JvbGxiYXIoKSkgeworICAgICAgY2xpZW50V2lkdGggKz0gdmVydGljYWxTY3Jv bGxiYXJXaWR0aCgpOworICAgIH0KKwogICAgIGlmIChuZWVkSEJhcikKICAgICAgICAgKm5lZWRI QmFyID0gcmlnaHRQb3MgPiBjbGllbnRXaWR0aDsKICAgICBpZiAobmVlZFZCYXIpCkluZGV4OiBM YXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhcnMtYWZ0ZXItcmVzaXplLmh0bWwKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvc2Nyb2xsYmFycy9zY3JvbGxiYXItYWZ0ZXItcmVzaXplLmh0 bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhci1hZnRl ci1yZXNpemUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzOCBAQAorPGhlYWQ+Cis8c2Ny aXB0PgorCitmdW5jdGlvbiBvbkxvYWQoKSB7CisgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgIH0K KworICAvLyBXZSBtdXN0IGRvIHRoaXMgdXNpbmcgYSB0aW1lciBiZWNhdXNlIHRoZSBzY3JvbGxi YXJzIG11c3QgYmUgdGhlcmUgd2hlbgorICAvLyB3ZSByZWR1Y2UgdGhlIHNpemUgb2YgdGhlIGlu bmVyIERJViAgICAKKyAgc2V0VGltZW91dChyZWR1Y2VJbm5lciwxKTsKK30KKworZnVuY3Rpb24g cmVkdWNlSW5uZXIoKSB7CisJdmFyIGlubmVyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImlu bmVyIik7CisJaW5uZXIuc3R5bGUuaGVpZ2h0PSIyMDBweCI7CisJaW5uZXIuc3R5bGUud2lkdGg9 IjIwMHB4IjsKKwkKKwkvLyBUaGVyZSBzaG91bGQgbm93IGJlIG5vIHNjcm9sbGJhcnMgaW4gIm91 dGVyIgorCisJaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworCQl3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworCX0KK30KKworPC9zY3JpcHQ+Cis8L2hl YWQ+Cis8Ym9keSBvbmxvYWQ9Im9uTG9hZCgpIj4KK1RoaXMgdGVzdCBlbnN1cmVzIHRoYXQgc2Ny b2xsYmFycyBhcmUgcmVtb3ZlZCB3aGVuIGEgRElWIGluc2lkZSBhbm90aGVyIERJVgoraXMgc2hy aW5rIHRvIGJlIHRoZSBleGFjdCBzaXplIG9mIHRoZSBvdXRlciBESVYuPGJyLz4KKzxici8+CitU aGUgcmVzdWx0IHNob3VsZCBiZSBhIHJlZCBzcXVhcmUgd2l0aCBubyBzY3JvbGxiYXJzIHZpc2li bGUuPC9icj4KKworPGRpdiBpZD0ib3V0ZXIiIHN0eWxlPSJoZWlnaHQ6IDIwMHB4OyB3aWR0aDog MjAwcHg7IGJhY2tncm91bmQ6IGdyZWVuOyBvdmVyZmxvdzogYXV0byI+Cis8ZGl2IGlkPSJpbm5l ciIgc3R5bGU9ImhlaWdodDogMzAwcHg7IHdpZHRoOiAzMDBweDsgYmFja2dyb3VuZDogcmVkOyI+ Cis8L2Rpdj4KKzwvZGl2PgorPC9ib2R5Pgo= 26424 2009-01-04 22:37:14 -0800 2009-06-16 09:20:49 -0700 Patch + test case + changelog entry scrollbar-issue-21462.patch text/plain 3097 artur SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzOTU5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDktMDEtMDQgIEFydHVyIFNpZ25lbGwgIDxhcnR1ci5zaWduZWxs QGFiby5maT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUZXN0OiBzY3JvbGxiYXJzL3Njcm9sbGJhci1hZnRlci1yZXNpemUuaHRtbAorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxh eWVyOjpjb21wdXRlU2Nyb2xsRGltZW5zaW9ucyk6CisKIDIwMDktMDEtMDQgIERhdmlkIEtpbHpl ciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCBpbnN0YWxsICouaWRsIGFu ZCAqLmluIGZpbGVzIGFzIHJlc291cmNlcwpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNw cAkocmV2aXNpb24gMzk1NzcpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEzMzIsNiArMTMzMiwxNCBAQCB2b2lkIFJlbmRlckxheWVyOjpj b21wdXRlU2Nyb2xsRGltZW5zaW9uCiAgICAgCiAgICAgbV9zY3JvbGxPcmlnaW5YID0gbHRyID8g MCA6IG1fc2Nyb2xsV2lkdGggLSBjbGllbnRXaWR0aDsKIAorICAgIC8qIGNsaWVudEhlaWdodC9j bGllbnRXaWR0aCBkb2VzIG5vdCBpbmNsdWRlIGN1cnJlbnRseSB2aXNpYmxlIHNjcm9sbGJhciBz aXplcyBidXQgdGhpcyBhcmVhIGlzIHVzYWJsZSBpZiBzY3JvbGxiYXJzIGFyZSBub3QgbmVlZGVk ICovCisgICAgaWYgKG1fb2JqZWN0LT5oYXNBdXRvSG9yaXpvbnRhbFNjcm9sbGJhcigpKSB7Cisg ICAgICBjbGllbnRIZWlnaHQgKz0gaG9yaXpvbnRhbFNjcm9sbGJhckhlaWdodCgpOworICAgIH0K KyAgICBpZiAobV9vYmplY3QtPmhhc0F1dG9WZXJ0aWNhbFNjcm9sbGJhcigpKSB7CisgICAgICBj bGllbnRXaWR0aCArPSB2ZXJ0aWNhbFNjcm9sbGJhcldpZHRoKCk7CisgICAgfQorCiAgICAgaWYg KG5lZWRIQmFyKQogICAgICAgICAqbmVlZEhCYXIgPSByaWdodFBvcyA+IGNsaWVudFdpZHRoOwog ICAgIGlmIChuZWVkVkJhcikKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5NTkxKQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsOSBAQAorMjAwOS0wMS0wNCAg QXJ0dXIgU2lnbmVsbCAgPGFydHVyLnNpZ25lbGxAYWJvLmZpPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc2Nyb2xsYmFycy9zY3JvbGxiYXItYWZ0 ZXItcmVzaXplLmh0bWw6IEFkZGVkLgorCiAyMDA5LTAxLTA0ICBTaW1vbiBGcmFzZXIgIDxzaW1v bi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aGUgZXhwZWN0ZWQgaW1hZ2UgdG8g YWNjb3VudCBmb3IgYSB0eXBvIGZpeCBkb25lIG9uIDIwMDgtMTItMjMuCkluZGV4OiBMYXlvdXRU ZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhci1hZnRlci1yZXNpemUuaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhci1hZnRlci1yZXNpemUuaHRtbAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL3Njcm9sbGJhcnMvc2Nyb2xsYmFyLWFmdGVyLXJlc2l6 ZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDM4IEBACis8aGVhZD4KKzxzY3JpcHQ+CisK K2Z1bmN0aW9uIG9uTG9hZCgpIHsKKyAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikg eworICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgfQorCisgIC8v IFdlIG11c3QgZG8gdGhpcyB1c2luZyBhIHRpbWVyIGJlY2F1c2UgdGhlIHNjcm9sbGJhcnMgbXVz dCBiZSB0aGVyZSB3aGVuCisgIC8vIHdlIHJlZHVjZSB0aGUgc2l6ZSBvZiB0aGUgaW5uZXIgRElW ICAgIAorICBzZXRUaW1lb3V0KHJlZHVjZUlubmVyLDEpOworfQorCitmdW5jdGlvbiByZWR1Y2VJ bm5lcigpIHsKKwl2YXIgaW5uZXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW5uZXIiKTsK Kwlpbm5lci5zdHlsZS5oZWlnaHQ9IjIwMHB4IjsKKwlpbm5lci5zdHlsZS53aWR0aD0iMjAwcHgi OworCQorCS8vIFRoZXJlIHNob3VsZCBub3cgYmUgbm8gc2Nyb2xsYmFycyBpbiAib3V0ZXIiCisK KwlpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisJCXdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisJfQorfQorCis8L3NjcmlwdD4KKzwvaGVhZD4KKzxi b2R5IG9ubG9hZD0ib25Mb2FkKCkiPgorVGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCBzY3JvbGxiYXJz IGFyZSByZW1vdmVkIHdoZW4gYSBESVYgaW5zaWRlIGFub3RoZXIgRElWCitpcyBzaHJpbmsgdG8g YmUgdGhlIGV4YWN0IHNpemUgb2YgdGhlIG91dGVyIERJVi48YnIvPgorPGJyLz4KK1RoZSByZXN1 bHQgc2hvdWxkIGJlIGEgcmVkIHNxdWFyZSB3aXRoIG5vIHNjcm9sbGJhcnMgdmlzaWJsZS48L2Jy PgorCis8ZGl2IGlkPSJvdXRlciIgc3R5bGU9ImhlaWdodDogMjAwcHg7IHdpZHRoOiAyMDBweDsg YmFja2dyb3VuZDogZ3JlZW47IG92ZXJmbG93OiBhdXRvIj4KKzxkaXYgaWQ9ImlubmVyIiBzdHls ZT0iaGVpZ2h0OiAzMDBweDsgd2lkdGg6IDMwMHB4OyBiYWNrZ3JvdW5kOiByZWQ7Ij4KKzwvZGl2 PgorPC9kaXY+Cis8L2JvZHk+Cg== 30184 2009-05-11 05:31:04 -0700 2009-05-11 05:31:04 -0700 A (slightly) cleaned up version of the test case test.html text/html 936 eric PGRpdj4KVGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCBzY3JvbGxiYXJzIGFyZSByZW1vdmVkIHdoZW4g YSBESVYgaW5zaWRlIGFub3RoZXIgRElWCmlzIHNocmluayB0byBiZSB0aGUgZXhhY3Qgc2l6ZSBv ZiB0aGUgb3V0ZXIgRElWLgo8L2Rpdj4KVGhlIHJlc3VsdCBzaG91bGQgYmUgYSBibHVlIHNxdWFy ZSB3aXRoIG5vIHNjcm9sbGJhcnMgdmlzaWJsZS4KCjxkaXYgaWQ9Im91dGVyIiBzdHlsZT0iaGVp Z2h0OiAxMDBweDsgd2lkdGg6IDEwMHB4OyBiYWNrZ3JvdW5kOiByZWQ7IG92ZXJmbG93OiBhdXRv Ij4KICAgIDxkaXYgaWQ9ImlubmVyIiBzdHlsZT0iaGVpZ2h0OiAyMDBweDsgd2lkdGg6IDIwMHB4 OyBiYWNrZ3JvdW5kOiBibHVlOyI+PC9kaXY+CjwvZGl2PgoKPHNjcmlwdD4KaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERv bmUoKTsKd2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkgewogICAgLy8gV2UgbXVzdCBkbyB0aGlz IHVzaW5nIGEgdGltZXIgYmVjYXVzZSB0aGUgc2Nyb2xsYmFycyBtdXN0IGJlIHRoZXJlIHdoZW4K ICAgIC8vIHdlIHJlZHVjZSB0aGUgc2l6ZSBvZiB0aGUgaW5uZXIgZGl2CiAgICBzZXRUaW1lb3V0 KHJlZHVjZUlubmVyLCAwKTsKfQoKZnVuY3Rpb24gcmVkdWNlSW5uZXIoKSB7CiAgICB2YXIgaW5u ZXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW5uZXIiKTsKICAgIGlubmVyLnN0eWxlLmhl aWdodCA9ICIxMDBweCI7CiAgICBpbm5lci5zdHlsZS53aWR0aCA9ICIxMDBweCI7CgogICAgLy8g VGhlcmUgc2hvdWxkIG5vdyBiZSBubyBzY3JvbGxiYXJzIGluICJvdXRlciIKICAgIGlmICh3aW5k b3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90 aWZ5RG9uZSgpOwp9Cgo8L3NjcmlwdD4K 31351 2009-06-16 09:20:49 -0700 2010-06-11 11:38:19 -0700 Updated patch (coding style, against latest revision) patch-21462-b.txt text/plain 3448 artur SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDQ0Njg5KQ0KKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp DQpAQCAtMSwzICsxLDE2IEBADQorMjAwOS0wNi0xNSAgQXJ0dXIgU2lnbmVsbCAgYXJ0dXIuc2ln bmVsbEBhYm8uZmkNCisNCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0K KyAgICAgICAgQnVnIDIxNDYyOiBPdmVyZmxvdyBhdXRvIGluIGRpdiBlbGVtZW50IHNob3dzIG9i c29sZXRlIHNjcm9sbGJhcnMgd2hlbg0KKyAgICAgICAgY29udGVudCBzaXplIGlzIHJlZHVjZWQN CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ2Mg0K Kw0KKyAgICAgICAgVGVzdDogc2Nyb2xsYmFycy9zY3JvbGxiYXItYWZ0ZXItcmVzaXplLmh0bWwN CisNCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoNCisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJMYXllcjo6Y29tcHV0ZVNjcm9sbERpbWVuc2lvbnMpOg0KKw0KIDIwMDktMDYt MTUgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPg0KIA0KICAgICAg ICAgUmV2aWV3ZWQgYnkgYW5kIGRvbmUgd2l0aCBUb3IgQXJuZSBWZXN0YsO4Lg0KSW5kZXg6IFdl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkocmV2aXNpb24gNDQ2ODkpDQorKysgV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtMTU4Miw2ICsxNTgy LDE1IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OmNvbXB1dGVTY3JvbGxEaW1lbnNpb24NCiAgICAgDQog ICAgIG1fc2Nyb2xsT3JpZ2luWCA9IGx0ciA/IDAgOiBtX3Njcm9sbFdpZHRoIC0gY2xpZW50V2lk dGg7DQogDQorICAgIC8vIGNsaWVudEhlaWdodC9jbGllbnRXaWR0aCBkb2VzIG5vdCBpbmNsdWRl IGN1cnJlbnRseSB2aXNpYmxlIHNjcm9sbGJhciANCisgICAgLy8gc2l6ZXMgYnV0IHRoaXMgYXJl YSBpcyB1c2FibGUgaWYgc2Nyb2xsYmFycyBhcmUgbm90IG5lZWRlZA0KKw0KKyAgICBpZiAoYm94 LT5oYXNBdXRvSG9yaXpvbnRhbFNjcm9sbGJhcigpKSANCisgICAgICAgIGNsaWVudEhlaWdodCAr PSBob3Jpem9udGFsU2Nyb2xsYmFySGVpZ2h0KCk7DQorDQorICAgIGlmIChib3gtPmhhc0F1dG9W ZXJ0aWNhbFNjcm9sbGJhcigpKSANCisgICAgICAgIGNsaWVudFdpZHRoICs9IHZlcnRpY2FsU2Ny b2xsYmFyV2lkdGgoKTsNCisNCiAgICAgaWYgKG5lZWRIQmFyKQ0KICAgICAgICAgKm5lZWRIQmFy ID0gcmlnaHRQb3MgPiBjbGllbnRXaWR0aDsNCiAgICAgaWYgKG5lZWRWQmFyKQ0KSW5kZXg6IExh eW91dFRlc3RzL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxv ZwkocmV2aXNpb24gNDQ2ODkpDQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpDQpAQCAtMSwzICsxLDEzIEBADQorMjAwOS0wNi0xNSAgQXJ0dXIgU2lnbmVsbCAgPHNldCBF TUFJTF9BRERSRVNTIGVudmlyb25tZW50IHZhcmlhYmxlPg0KKw0KKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuDQorDQorICAgICAgICBCdWcgMjE0NjI6IE92ZXJmbG93IGF1dG8g aW4gZGl2IGVsZW1lbnQgc2hvd3Mgb2Jzb2xldGUgc2Nyb2xsYmFycyB3aGVuDQorICAgICAgICBj b250ZW50IHNpemUgaXMgcmVkdWNlZA0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNDYyDQorDQorICAgICAgICAqIHNjcm9sbGJhcnMvc2Nyb2xsYmFy LWFmdGVyLXJlc2l6ZS5odG1sOiBBZGRlZC4NCisNCiAyMDA5LTA2LTE0ICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4NCiANCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4u DQpJbmRleDogTGF5b3V0VGVzdHMvc2Nyb2xsYmFycy9zY3JvbGxiYXItYWZ0ZXItcmVzaXplLmh0 bWwNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0NCi0tLSBMYXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Njcm9sbGJhci1hZnRl ci1yZXNpemUuaHRtbAkocmV2aXNpb24gMCkNCisrKyBMYXlvdXRUZXN0cy9zY3JvbGxiYXJzL3Nj cm9sbGJhci1hZnRlci1yZXNpemUuaHRtbAkocmV2aXNpb24gMCkNCkBAIC0wLDAgKzEsMzAgQEAN Cis8ZGl2Pg0KK1RoaXMgdGVzdCBlbnN1cmVzIHRoYXQgc2Nyb2xsYmFycyBhcmUgcmVtb3ZlZCB3 aGVuIGEgRElWIGluc2lkZSBhbm90aGVyIERJVg0KK2lzIHNocmluayB0byBiZSB0aGUgZXhhY3Qg c2l6ZSBvZiB0aGUgb3V0ZXIgRElWLg0KKzwvZGl2Pg0KK1RoZSByZXN1bHQgc2hvdWxkIGJlIGEg Ymx1ZSBzcXVhcmUgd2l0aCBubyBzY3JvbGxiYXJzIHZpc2libGUuDQorDQorPGRpdiBpZD0ib3V0 ZXIiIHN0eWxlPSJoZWlnaHQ6IDEwMHB4OyB3aWR0aDogMTAwcHg7IGJhY2tncm91bmQ6IHJlZDsg b3ZlcmZsb3c6IGF1dG8iPg0KKyAgICA8ZGl2IGlkPSJpbm5lciIgc3R5bGU9ImhlaWdodDogMjAw cHg7IHdpZHRoOiAyMDBweDsgYmFja2dyb3VuZDogYmx1ZTsiPjwvZGl2Pg0KKzwvZGl2Pg0KKw0K KzxzY3JpcHQ+DQoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikNCisgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOw0KK3dpbmRvdy5vbmxvYWQgPSBmdW5jdGlv bigpIHsNCisgICAgLy8gV2UgbXVzdCBkbyB0aGlzIHVzaW5nIGEgdGltZXIgYmVjYXVzZSB0aGUg c2Nyb2xsYmFycyBtdXN0IGJlIHRoZXJlIHdoZW4NCisgICAgLy8gd2UgcmVkdWNlIHRoZSBzaXpl IG9mIHRoZSBpbm5lciBkaXYNCisgICAgc2V0VGltZW91dChyZWR1Y2VJbm5lciwgMCk7DQorfQ0K Kw0KK2Z1bmN0aW9uIHJlZHVjZUlubmVyKCkgew0KKyAgICB2YXIgaW5uZXIgPSBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgiaW5uZXIiKTsNCisgICAgaW5uZXIuc3R5bGUuaGVpZ2h0ID0gIjEwMHB4 IjsNCisgICAgaW5uZXIuc3R5bGUud2lkdGggPSAiMTAwcHgiOw0KKw0KKyAgICAvLyBUaGVyZSBz aG91bGQgbm93IGJlIG5vIHNjcm9sbGJhcnMgaW4gIm91dGVyIg0KKyAgICBpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQ0KKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5 RG9uZSgpOw0KK30NCisNCis8L3NjcmlwdD4NCg==