214619 2020-07-21 15:53:17 -0700 Web Inspector: inspector/canvas/memory.html is failing on macOS Apple Silicon 2020-07-21 17:10:05 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg dino hi inspector-bugzilla-changes thorton webkit-bug-importer oldest_to_newest 1673650 0 bburg 2020-07-21 15:53:17 -0700 . 1673651 1 bburg 2020-07-21 15:53:34 -0700 <rdar://65747521> 1673655 2 404870 bburg 2020-07-21 16:03:35 -0700 Created attachment 404870 Patch 1673656 3 404870 hi 2020-07-21 16:07:09 -0700 Comment on attachment 404870 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404870&action=review r=me > LayoutTests/inspector/canvas/memory.html:59 > + InspectorTest.expectGreaterThan(event.target.memoryCost, isNaN(initialMemoryCost) ? 0 : initialMemoryCost, "Memory cost should increase upon initially resizing canvas."); NIT: this shouldn't be `NaN`, but I suppose it couldn't hurt to check 1673674 4 404870 bburg 2020-07-21 16:54:28 -0700 Comment on attachment 404870 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404870&action=review >> LayoutTests/inspector/canvas/memory.html:59 >> + InspectorTest.expectGreaterThan(event.target.memoryCost, isNaN(initialMemoryCost) ? 0 : initialMemoryCost, "Memory cost should increase upon initially resizing canvas."); > > NIT: this shouldn't be `NaN`, but I suppose it couldn't hurt to check It.. is. see expected results for the first test case. 1673683 5 ews-feeder 2020-07-21 17:10:04 -0700 Committed r264683: <https://trac.webkit.org/changeset/264683> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404870. 404870 2020-07-21 16:03:35 -0700 2020-07-21 17:10:05 -0700 Patch bug-214619-20200721160334.patch text/plain 2399 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NjE5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjIwYTZmZDg3MWVhMTY0NzE2N2Ri NmY2ZjQ1NmU2YTc0YjE2NGQ4OS4uOGRkZDAyNjI2NDZhZTNkZGJmNmYwYWI0NzQ2OWRiYjg2NTJj NmJlYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA3LTIxICBCcmlhbiBCdXJnICA8YmJ1 cmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGluc3BlY3Rvci9jYW52YXMv bWVtb3J5Lmh0bWwgaXMgZmFpbGluZyBvbiBtYWNPUyBBcHBsZSBTaWxpY29uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ2MTkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9jYW52YXMv bWVtb3J5LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBpbnNwZWN0b3IvY2FudmFzL21lbW9yeS5o dG1sOgorICAgICAgICBDYW52YXMgbWVtb3J5IGNvc3RzIGFyZSBub3QgdGhlIHNhbWUgYXMgb24g SW50ZWwgbWFjT1MuIENoYW5nZSB0aGUgdGVzdCB0bworICAgICAgICBzaW1wbHkgY2hlY2sgdGhh dCB0aGUgbWVtb3J5IGNvc3QgaW5jcmVhc2VzIGZyb20gemVyby1pc2ggdG8gbm90LXplcm8uCisK IDIwMjAtMDctMjAgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmluZywgc2tpcCBmbGFreSB0ZXN0IHdlYmdsLzIuMC4w L2NvbmZvcm1hbmNlMi9zdGF0ZS9nbC1vYmplY3QtZ2V0LWNhbGxzLmh0bWwuCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL21lbW9yeS1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL21lbW9yeS1leHBlY3RlZC50eHQKaW5kZXggNmM5NjA2 YjdiYTExYWMyMjkxMzA3ZGFlZGMxZGJmOGQ4NTM0Y2Q5Ny4uOWFhNTkxM2U4NDZkNTc1ZWRhNDRm YWNkNjk4ODI5NTAwYmQxZDUxOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nh bnZhcy9tZW1vcnktZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52 YXMvbWVtb3J5LWV4cGVjdGVkLnR4dApAQCAtNyw1ICs3LDUgQEAgTWVtb3J5IGNvc3Qgb2YgY2Fu dmFzIGlzIE5hTi4KIAogLS0gUnVubmluZyB0ZXN0IGNhc2U6IENhbnZhcy5tZW1vcnkuY2FudmFz TWVtb3J5Q2hhbmdlZAogQ2hhbmdlIHNpemUgb2YgY2FudmFzIHRvIDIwMHgyMDAuCi1NZW1vcnkg Y29zdCBvZiBjYW52YXMgdXBkYXRlZCB0byAxNjY0MDAuCitQQVNTOiBNZW1vcnkgY29zdCBzaG91 bGQgaW5jcmVhc2UgdXBvbiBpbml0aWFsbHkgcmVzaXppbmcgY2FudmFzLgogCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL21lbW9yeS5odG1sIGIvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2NhbnZhcy9tZW1vcnkuaHRtbAppbmRleCA0YmZkN2E2Y2VhYjUzZmM1ZDliOGU3 MTNiODUzZDI3NWUwMTczZTcxLi41MDhiODdkZjFlMmZiZDdjNWRkZWU4ZmVhODUxMzg3MDk2Yjc5 YjZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY2FudmFzL21lbW9yeS5odG1s CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jYW52YXMvbWVtb3J5Lmh0bWwKQEAgLTUzLDkg KzUzLDEwIEBAIGZ1bmN0aW9uIHRlc3QoKSB7CiAKICAgICAgICAgICAgIEluc3BlY3RvclRlc3Qu YXNzZXJ0KGNhbnZhc2VzLmxlbmd0aCA9PT0gMSwgIlRoZXJlIHNob3VsZCBvbmx5IGJlIG9uZSBj YW52YXMtMmQuIik7CiAKKyAgICAgICAgICAgIGxldCBpbml0aWFsTWVtb3J5Q29zdCA9IGNhbnZh c2VzWzBdLm1lbW9yeUNvc3Q7CiAgICAgICAgICAgICBjYW52YXNlc1swXS5hd2FpdEV2ZW50KFdJ LkNhbnZhcy5FdmVudC5NZW1vcnlDaGFuZ2VkKQogICAgICAgICAgICAgLnRoZW4oKGV2ZW50KSA9 PiB7Ci0gICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2coYE1lbW9yeSBjb3N0IG9mIGNh bnZhcyB1cGRhdGVkIHRvICR7ZXZlbnQudGFyZ2V0Lm1lbW9yeUNvc3R9LmApOworICAgICAgICAg ICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0R3JlYXRlclRoYW4oZXZlbnQudGFyZ2V0Lm1lbW9y eUNvc3QsIGlzTmFOKGluaXRpYWxNZW1vcnlDb3N0KSA/IDAgOiBpbml0aWFsTWVtb3J5Q29zdCwg Ik1lbW9yeSBjb3N0IHNob3VsZCBpbmNyZWFzZSB1cG9uIGluaXRpYWxseSByZXNpemluZyBjYW52 YXMuIik7CiAgICAgICAgICAgICB9KQogICAgICAgICAgICAgLnRoZW4ocmVzb2x2ZSwgcmVqZWN0 KTsKIAo=