214603 2020-07-21 11:06:39 -0700 llint_slow_path_get_private_name() should not be using PropertySlot::InternalMethodType::VMInquiry. 2020-07-21 14:12:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1673518 0 mark.lam 2020-07-21 11:06:39 -0700 VMInquiry means (1) the get operation should not call back into JS, (2) it should not throw any exceptions (except for OutOfMemoryError or StackOverflowError which can be thrown at any time), or have any side effects that is observable from JS code. In this case, llint_slow_path_get_private_name() is just implementating PrivateFieldGet (https://tc39.es/proposal-class-fields/#sec-privatefieldget) and has no need to use VMInquiry. 1673522 1 404839 mark.lam 2020-07-21 11:12:10 -0700 Created attachment 404839 proposed patch. 1673536 2 404841 mark.lam 2020-07-21 11:35:52 -0700 Created attachment 404841 proposed patch. 1673570 3 404841 ysuzuki 2020-07-21 12:27:07 -0700 Comment on attachment 404841 proposed patch. r=me 1673616 4 mark.lam 2020-07-21 14:11:24 -0700 Thanks for the review. Landed in r264679: <http://trac.webkit.org/r264679>. 1673617 5 webkit-bug-importer 2020-07-21 14:12:15 -0700 <rdar://problem/65902335> 404839 2020-07-21 11:12:10 -0700 2020-07-21 11:15:31 -0700 proposed patch. bug-214603.patch text/plain 3244 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjY0NjYzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBA CisyMDIwLTA3LTIxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBs bGludF9zbG93X3BhdGhfZ2V0X3ByaXZhdGVfbmFtZSgpIHNob3VsZCBub3QgYmUgdXNpbmcgUHJv cGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5cGU6OlZNSW5xdWlyeS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDYwMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFZNSW5xdWlyeSBtZWFucyAoMSkgdGhl IGdldCBvcGVyYXRpb24gc2hvdWxkIG5vdCBjYWxsIGJhY2sgaW50byBKUywgKDIpIGl0IHNob3Vs ZAorICAgICAgICBub3QgdGhyb3cgYW55IGV4Y2VwdGlvbnMgKGV4Y2VwdCBmb3IgT3V0T2ZNZW1v cnlFcnJvciBvciBTdGFja092ZXJmbG93RXJyb3Igd2hpY2gKKyAgICAgICAgY2FuIGJlIHRocm93 biBhdCBhbnkgdGltZSksIG9yIGhhdmUgYW55IHNpZGUgZWZmZWN0cyB0aGF0IGlzIG9ic2VydmFi bGUgZnJvbSBKUworICAgICAgICBjb2RlLiAgSW4gdGhpcyBjYXNlLCBsbGludF9zbG93X3BhdGhf Z2V0X3ByaXZhdGVfbmFtZSgpIGlzIGp1c3QgaW1wbGVtZW50YXRpbmcKKyAgICAgICAgUHJpdmF0 ZUZpZWxkR2V0IChodHRwczovL3RjMzkuZXMvcHJvcG9zYWwtY2xhc3MtZmllbGRzLyNzZWMtcHJp dmF0ZWZpZWxkZ2V0KSBhbmQKKyAgICAgICAgc2hvdWxkIGFjdHVhbGx5IGJlIHVzaW5nIFByb3Bl cnR5U2xvdDo6SW50ZXJuYWxNZXRob2RUeXBlOjpHZXRPd25Qcm9wZXJ0eQorICAgICAgICAoYWNj b3JkaW5nIHRvIGh0dHBzOi8vdGMzOS5lcy9wcm9wb3NhbC1jbGFzcy1maWVsZHMvI3NlYy1wcml2 YXRlZmllbGRmaW5kKS4KKworICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIHRoZSBhYm92ZSBjaGFu Z2UsIGFuZCBhbHNvIGFkZHMgYW4gYXNzZXJ0IGluIEpTT2JqZWN0OjpnZXRQcml2YXRlRmllbGQK KyAgICAgICAgdG8gZW5zdXJlIHRoYXQgbm8gb25lIGNhbGxzIGl0IGZvciBhIFZNSW5xdWlyeSBz aW5jZSBpdCBpcyBub3Qgc3VwcG9ydGVkLgorCisgICAgICAgICogbGxpbnQvTExJbnRTbG93UGF0 aHMuY3BwOgorICAgICAgICAoSlNDOjpMTEludDo6TExJTlRfU0xPV19QQVRIX0RFQ0wpOgorICAg ICAgICAqIHJ1bnRpbWUvSlNPYmplY3RJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkpTT2JqZWN0 OjpnZXRQcml2YXRlRmllbGQpOgorCiAyMDIwLTA3LTIxICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJv ICA8YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXcgbm9uLXVuaWZpZWQgc291 cmNlIGJ1aWxkIGZpeApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xv d1BhdGhzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJ bnRTbG93UGF0aHMuY3BwCShyZXZpc2lvbiAyNjQ2NjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvbGxpbnQvTExJbnRTbG93UGF0aHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDkzLDcgKzEw OTMsNyBAQCBMTElOVF9TTE9XX1BBVEhfREVDTChzbG93X3BhdGhfZ2V0X3ByaXZhCiAgICAgTExJ TlRfQ0hFQ0tfRVhDRVBUSU9OKCk7CiAgICAgQVNTRVJUKHByb3BlcnR5LmlzUHJpdmF0ZU5hbWUo KSk7CiAKLSAgICBQcm9wZXJ0eVNsb3Qgc2xvdChiYXNlVmFsdWUsIFByb3BlcnR5U2xvdDo6SW50 ZXJuYWxNZXRob2RUeXBlOjpWTUlucXVpcnkpOworICAgIFByb3BlcnR5U2xvdCBzbG90KGJhc2VW YWx1ZSwgUHJvcGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5cGU6OkdldE93blByb3BlcnR5KTsK ICAgICBhc09iamVjdChiYXNlVmFsdWUpLT5nZXRQcml2YXRlRmllbGQoZ2xvYmFsT2JqZWN0LCBw cm9wZXJ0eSwgc2xvdCk7CiAgICAgTExJTlRfQ0hFQ0tfRVhDRVBUSU9OKCk7CiAKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0SW5saW5lcy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0SW5saW5lcy5oCShyZXZp c2lvbiAyNjQ2NjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdElu bGluZXMuaAkod29ya2luZyBjb3B5KQpAQCAtMSw3ICsxLDcgQEAKIC8qCiAgKiAgQ29weXJpZ2h0 IChDKSAxOTk5LTIwMDEgSGFycmkgUG9ydGVuIChwb3J0ZW5Aa2RlLm9yZykKICAqICBDb3B5cmln aHQgKEMpIDIwMDEgUGV0ZXIgS2VsbHkgKHBta0Bwb3N0LmNvbSkKLSAqICBDb3B5cmlnaHQgKEMp IDIwMDMtMjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiAgQ29weXJpZ2h0 IChDKSAyMDAzLTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICogIENvcHly aWdodCAoQykgMjAwNyBFcmljIFNlaWRlbCAoZXJpY0B3ZWJraXQub3JnKQogICoKICAqICBUaGlz IGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29y CkBAIC02MDMsNiArNjAzLDcgQEAgaW5saW5lIGJvb2wgSlNPYmplY3Q6OmdldFByaXZhdGVGaWVs ZChKUwogewogICAgIFZNJiB2bSA9IGdldFZNKGdsb2JhbE9iamVjdCk7CiAgICAgYXV0byBzY29w ZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOworICAgIEFTU0VSVCghc2xvdC5pc1ZNSW5xdWly eSgpKTsKICAgICBpZiAoIUpTT2JqZWN0OjpnZXRQcml2YXRlRmllbGRTbG90KHRoaXMsIGdsb2Jh bE9iamVjdCwgcHJvcGVydHlOYW1lLCBzbG90KSkgewogICAgICAgICB0aHJvd0V4Y2VwdGlvbihn bG9iYWxPYmplY3QsIHNjb3BlLCBjcmVhdGVJbnZhbGlkUHJpdmF0ZU5hbWVFcnJvcihnbG9iYWxP YmplY3QpKTsKICAgICAgICAgUkVMRUFTRV9BTkRfUkVUVVJOKHNjb3BlLCBmYWxzZSk7Cg== 404841 2020-07-21 11:35:52 -0700 2020-07-21 12:27:07 -0700 proposed patch. bug-214603.patch text/plain 4261 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjY0NjY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBA CisyMDIwLTA3LTIxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBs bGludF9zbG93X3BhdGhfZ2V0X3ByaXZhdGVfbmFtZSgpIHNob3VsZCBub3QgYmUgdXNpbmcgUHJv cGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5cGU6OlZNSW5xdWlyeS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDYwMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFZNSW5xdWlyeSBtZWFucyAoMSkgdGhl IGdldCBvcGVyYXRpb24gc2hvdWxkIG5vdCBjYWxsIGJhY2sgaW50byBKUywgKDIpIGl0IHNob3Vs ZAorICAgICAgICBub3QgdGhyb3cgYW55IGV4Y2VwdGlvbnMgKGV4Y2VwdCBmb3IgT3V0T2ZNZW1v cnlFcnJvciBvciBTdGFja092ZXJmbG93RXJyb3Igd2hpY2gKKyAgICAgICAgY2FuIGJlIHRocm93 biBhdCBhbnkgdGltZSksIG9yIGhhdmUgYW55IHNpZGUgZWZmZWN0cyB0aGF0IGlzIG9ic2VydmFi bGUgZnJvbSBKUworICAgICAgICBjb2RlLiAgSW4gdGhpcyBjYXNlLCBsbGludF9zbG93X3BhdGhf Z2V0X3ByaXZhdGVfbmFtZSgpIGlzIGp1c3QgaW1wbGVtZW50YXRpbmcKKyAgICAgICAgUHJpdmF0 ZUZpZWxkR2V0IChodHRwczovL3RjMzkuZXMvcHJvcG9zYWwtY2xhc3MtZmllbGRzLyNzZWMtcHJp dmF0ZWZpZWxkZ2V0KSBhbmQKKyAgICAgICAgc2hvdWxkIGFjdHVhbGx5IGJlIHVzaW5nIFByb3Bl cnR5U2xvdDo6SW50ZXJuYWxNZXRob2RUeXBlOjpHZXRPd25Qcm9wZXJ0eQorICAgICAgICAoYWNj b3JkaW5nIHRvIGh0dHBzOi8vdGMzOS5lcy9wcm9wb3NhbC1jbGFzcy1maWVsZHMvI3NlYy1wcml2 YXRlZmllbGRmaW5kKS4KKworICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIHRoZSBhYm92ZSBjaGFu Z2UsIGFuZCBhbHNvIGFkZHMgYW4gYXNzZXJ0IGluIEpTT2JqZWN0OjpnZXRQcml2YXRlRmllbGQK KyAgICAgICAgdG8gZW5zdXJlIHRoYXQgbm8gb25lIGNhbGxzIGl0IGZvciBhIFZNSW5xdWlyeSBz aW5jZSBpdCBpcyBub3Qgc3VwcG9ydGVkLgorCisgICAgICAgIEFsc28gYWRkZWQgYSBQcm9wZXJ0 eVNsb3Q6OmlzVk1JbnF1aXJ5KCkgY29udmVuaWVuY2UgcXVlcnkgbWV0aG9kLgorCisgICAgICAg ICogbGxpbnQvTExJbnRTbG93UGF0aHMuY3BwOgorICAgICAgICAoSlNDOjpMTEludDo6TExJTlRf U0xPV19QQVRIX0RFQ0wpOgorICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3RJbmxpbmVzLmg6Cisg ICAgICAgIChKU0M6OkpTT2JqZWN0OjpnZXRQcml2YXRlRmllbGQpOgorICAgICAgICAqIHJ1bnRp bWUvUHJvcGVydHlTbG90Lmg6CisgICAgICAgIChKU0M6OlByb3BlcnR5U2xvdDo6aXNWTUlucXVp cnkgY29uc3QpOgorCiAyMDIwLTA3LTIxICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXcgbm9uLXVuaWZpZWQgc291cmNlIGJ1aWxk IGZpeApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRTbG93UGF0 aHMuY3BwCShyZXZpc2lvbiAyNjQ2NjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQv TExJbnRTbG93UGF0aHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDkzLDcgKzEwOTMsNyBAQCBM TElOVF9TTE9XX1BBVEhfREVDTChzbG93X3BhdGhfZ2V0X3ByaXZhCiAgICAgTExJTlRfQ0hFQ0tf RVhDRVBUSU9OKCk7CiAgICAgQVNTRVJUKHByb3BlcnR5LmlzUHJpdmF0ZU5hbWUoKSk7CiAKLSAg ICBQcm9wZXJ0eVNsb3Qgc2xvdChiYXNlVmFsdWUsIFByb3BlcnR5U2xvdDo6SW50ZXJuYWxNZXRo b2RUeXBlOjpWTUlucXVpcnkpOworICAgIFByb3BlcnR5U2xvdCBzbG90KGJhc2VWYWx1ZSwgUHJv cGVydHlTbG90OjpJbnRlcm5hbE1ldGhvZFR5cGU6OkdldE93blByb3BlcnR5KTsKICAgICBhc09i amVjdChiYXNlVmFsdWUpLT5nZXRQcml2YXRlRmllbGQoZ2xvYmFsT2JqZWN0LCBwcm9wZXJ0eSwg c2xvdCk7CiAgICAgTExJTlRfQ0hFQ0tfRVhDRVBUSU9OKCk7CiAKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0SW5saW5lcy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0SW5saW5lcy5oCShyZXZpc2lvbiAyNjQ2 NjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdElubGluZXMuaAko d29ya2luZyBjb3B5KQpAQCAtMSw3ICsxLDcgQEAKIC8qCiAgKiAgQ29weXJpZ2h0IChDKSAxOTk5 LTIwMDEgSGFycmkgUG9ydGVuIChwb3J0ZW5Aa2RlLm9yZykKICAqICBDb3B5cmlnaHQgKEMpIDIw MDEgUGV0ZXIgS2VsbHkgKHBta0Bwb3N0LmNvbSkKLSAqICBDb3B5cmlnaHQgKEMpIDIwMDMtMjAx OSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiAgQ29weXJpZ2h0IChDKSAyMDAz LTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICogIENvcHlyaWdodCAoQykg MjAwNyBFcmljIFNlaWRlbCAoZXJpY0B3ZWJraXQub3JnKQogICoKICAqICBUaGlzIGxpYnJhcnkg aXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCkBAIC02MDMs NiArNjAzLDcgQEAgaW5saW5lIGJvb2wgSlNPYmplY3Q6OmdldFByaXZhdGVGaWVsZChKUwogewog ICAgIFZNJiB2bSA9IGdldFZNKGdsb2JhbE9iamVjdCk7CiAgICAgYXV0byBzY29wZSA9IERFQ0xB UkVfVEhST1dfU0NPUEUodm0pOworICAgIEFTU0VSVCghc2xvdC5pc1ZNSW5xdWlyeSgpKTsKICAg ICBpZiAoIUpTT2JqZWN0OjpnZXRQcml2YXRlRmllbGRTbG90KHRoaXMsIGdsb2JhbE9iamVjdCwg cHJvcGVydHlOYW1lLCBzbG90KSkgewogICAgICAgICB0aHJvd0V4Y2VwdGlvbihnbG9iYWxPYmpl Y3QsIHNjb3BlLCBjcmVhdGVJbnZhbGlkUHJpdmF0ZU5hbWVFcnJvcihnbG9iYWxPYmplY3QpKTsK ICAgICAgICAgUkVMRUFTRV9BTkRfUkVUVVJOKHNjb3BlLCBmYWxzZSk7CkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9Qcm9wZXJ0eVNsb3QuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Qcm9wZXJ0eVNsb3QuaAkocmV2aXNpb24gMjY0NjYx KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJvcGVydHlTbG90LmgJKHdvcmtp bmcgY29weSkKQEAgLTEsNSArMSw1IEBACiAvKgotICogIENvcHlyaWdodCAoQykgMjAwNS0yMDE5 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5cmlnaHQgKEMpIDIwMDUt MjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogIFRoaXMgbGlicmFy eSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqICBt b2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1Ymxp YwpAQCAtMTM5LDYgKzEzOSw3IEBAIHB1YmxpYzoKICAgICBib29sIGlzVGFpbnRlZEJ5T3BhcXVl T2JqZWN0KCkgY29uc3QgeyByZXR1cm4gbV9pc1RhaW50ZWRCeU9wYXF1ZU9iamVjdDsgfQogCiAg ICAgSW50ZXJuYWxNZXRob2RUeXBlIGludGVybmFsTWV0aG9kVHlwZSgpIGNvbnN0IHsgcmV0dXJu IG1faW50ZXJuYWxNZXRob2RUeXBlOyB9CisgICAgYm9vbCBpc1ZNSW5xdWlyeSgpIGNvbnN0IHsg cmV0dXJuIG1faW50ZXJuYWxNZXRob2RUeXBlID09IEludGVybmFsTWV0aG9kVHlwZTo6Vk1JbnF1 aXJ5OyB9CiAKICAgICB2b2lkIGRpc2FibGVDYWNoaW5nKCkKICAgICB7Cg==