214596 2020-07-21 09:10:01 -0700 Debug build is failing after r264537 on Linux 2020-07-21 12:17:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ticaiolima ticaiolima darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1673457 0 ticaiolima 2020-07-21 09:10:01 -0700 Version of GCC is 8.3.0. The error is the following: ``` FAILED: Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f2e18ffc-15.cpp.o /usr/bin/ccache /usr/bin/c++ -DBUILDING_JSCONLY__ -DBUILDING_JavaScriptCore -DBUILDING_WITH_CMAKE=1 -DHAVE_CONFIG_H=1 -DJavaScriptCore_EXPORTS -DSTATICALLY_LINKED_WITH_WTF -IDerivedSources/ForwardingHeaders -I. -I../../Source/JavaScriptCore -I../../Source/JavaScriptCore/API -I../../Source/JavaScriptCore/assembler -I../../Source/JavaScriptCore/b3 -I../../Source/JavaScriptCore/b3/air -I../../Source/JavaScriptCore/bindings -I../../Source/JavaScriptCore/builtins -I../../Source/JavaScriptCore/bytecode -I../../Source/JavaScriptCore/bytecompiler -I../../Source/JavaScriptCore/dfg -I../../Source/JavaScriptCore/disassembler -I../../Source/JavaScriptCore/disassembler/ARM64 -I../../Source/JavaScriptCore/disassembler/udis86 -I../../Source/JavaScriptCore/domjit -I../../Source/JavaScriptCore/ftl -I../../Source/JavaScriptCore/heap -I../../Source/JavaScriptCore/debugger -I../../Source/JavaScriptCore/inspector -I../../Source/JavaScriptCore/inspector/agents -I../../Source/JavaScriptCore/inspector/augmentable -I../../Source/JavaScriptCore/inspector/remote -I../../Source/JavaScriptCore/interpreter -I../../Source/JavaScriptCore/jit -I../../Source/JavaScriptCore/llint -I../../Source/JavaScriptCore/parser -I../../Source/JavaScriptCore/profiler -I../../Source/JavaScriptCore/runtime -I../../Source/JavaScriptCore/tools -I../../Source/JavaScriptCore/wasm -I../../Source/JavaScriptCore/wasm/js -I../../Source/JavaScriptCore/yarr -IDerivedSources/JavaScriptCore -IDerivedSources/JavaScriptCore/inspector -IDerivedSources/JavaScriptCore/runtime -IDerivedSources/JavaScriptCore/yarr -fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-noexcept-type -Wno-psabi -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -fno-strict-aliasing -fno-exceptions -fno-rtti -gsplit-dwarf -g -fPIC -ffp-contract=off -std=c++17 -MD -MT Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f2e18ffc-15.cpp.o -MF Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f2e18ffc-15.cpp.o.d -o Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/__/__/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f2e18ffc-15.cpp.o -c DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f2e18ffc-15.cpp In file included from DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:32, from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:26, from ../../Source/JavaScriptCore/config.h:38, from ../../Source/JavaScriptCore/runtime/IntlLocaleConstructor.cpp:26, from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f2e18ffc-15.cpp:1: ../../Source/JavaScriptCore/runtime/IntlObject.cpp: In function ‘constexpr WTF::ASCIILiteral JSC::relevantExtensionKeyString(JSC::RelevantExtensionKey)’: DerivedSources/ForwardingHeaders/wtf/Assertions.h:354:34: error: call to non-‘constexpr’ function ‘void WTFReportAssertionFailure(const char*, int, const char*, const char*)’ WTFReportAssertionFailure(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, #assertion); \ ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/JavaScriptCore/runtime/IntlObject.cpp:657:5: note: in expansion of macro ‘ASSERT_UNDER_CONSTEXPR_CONTEXT’ ASSERT_UNDER_CONSTEXPR_CONTEXT(0); ``` 1673465 1 404824 ticaiolima 2020-07-21 09:18:46 -0700 Created attachment 404824 Patch 1673469 2 404824 darin 2020-07-21 09:29:34 -0700 Comment on attachment 404824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404824&action=review > Source/JavaScriptCore/runtime/IntlObject.cpp:-657 > - ASSERT_UNDER_CONSTEXPR_CONTEXT(0); Does ASSERT_UNDER_CONSTEXPR_CONTEXT work at all on this "Linux context"? 1673512 3 ticaiolima 2020-07-21 11:01:15 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 404824 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404824&action=review > > > Source/JavaScriptCore/runtime/IntlObject.cpp:-657 > > - ASSERT_UNDER_CONSTEXPR_CONTEXT(0); > > Does ASSERT_UNDER_CONSTEXPR_CONTEXT work at all on this "Linux context"? It seems that whenever the `assert` is falsy, it triggers compilation error due to call of `WTFReportAssertionFailure`. I spent sometime trying to understand why, but got no success yet. 1673516 4 404824 darin 2020-07-21 11:05:32 -0700 Comment on attachment 404824 Patch Yusuke suggested removing the ASSERT_UNDER_CONSTEXPR_CONTEXT entirely and not changing this from constexpr to inline. 1673524 5 404824 ysuzuki 2020-07-21 11:13:29 -0700 Comment on attachment 404824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404824&action=review >>> Source/JavaScriptCore/runtime/IntlObject.cpp:-657 >>> - ASSERT_UNDER_CONSTEXPR_CONTEXT(0); >> >> Does ASSERT_UNDER_CONSTEXPR_CONTEXT work at all on this "Linux context"? > > It seems that whenever the `assert` is falsy, it triggers compilation error due to call of `WTFReportAssertionFailure`. I spent sometime trying to understand why, but got no success yet. I think removing this assertion is better for now. GCC seems not handling switch's reachability correctly. 1673537 6 404842 ticaiolima 2020-07-21 11:37:00 -0700 Created attachment 404842 Patch 1673563 7 ews-feeder 2020-07-21 12:16:04 -0700 Committed r264671: <https://trac.webkit.org/changeset/264671> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404842. 1673564 8 webkit-bug-importer 2020-07-21 12:17:18 -0700 <rdar://problem/65896603> 404824 2020-07-21 09:18:46 -0700 2020-07-21 11:36:48 -0700 Patch bug-214596-20200721131845.patch text/plain 1886 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NTNjZThjZTQ0ZGRkYTc4M2MzOWZlNTlhOGU1NzVhYmVmMTJjMGU0Li5hYTQ0MDMyYjczMDRlZWYw YzZjYzM4MmVjODkyZDUyYmFiN2I5MmEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNy0yMSAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgRGVidWcgYnVpbGQgaXMgZmFpbGluZyBhZnRlciByMjY0NTM3IG9uIExpbnV4 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ1OTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUg Y29uc3RleHByIG1vZGlmaWVyIGZyb20gYHJlbGV2YW50RXh0ZW5zaW9uS2V5U3RyaW5nYCB0byBh dm9pZAorICAgICAgICBidWlsZCBmYWlsdXJlIG9uIExpbnV4IGJ1aWxkcy4KKworICAgICAgICAq IHJ1bnRpbWUvSW50bE9iamVjdC5jcHA6CisgICAgICAgIChKU0M6OnJlbGV2YW50RXh0ZW5zaW9u S2V5U3RyaW5nKToKKwogMjAyMC0wNy0yMSAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJl ekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3IG5vbi11bmlmaWVkIHNvdXJjZSBidWls ZCBmaXgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxPYmpl Y3QuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bE9iamVjdC5jcHAKaW5k ZXggY2U1MWQ4ODIyMzUzZDA4NWEyMGJhZWMyOWMzOTE2ZWM0YmViMzE2ZS4uZDNjYjRkYzNlZWNk ZTU2ZGU5Njc1YjlhYzg1ZjQzZDY2MDBiODYyZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSW50bE9iamVjdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSW50bE9iamVjdC5jcHAKQEAgLTY0NSw3ICs2NDUsNyBAQCBzdGF0aWMgdm9pZCB1 bmljb2RlRXh0ZW5zaW9uU3ViVGFncyhjb25zdCBTdHJpbmcmIGV4dGVuc2lvbiwgVmVjdG9yPFN0 cmluZz4mIHN1YgogICAgIHN1YnRhZ3MuYXBwZW5kKGV4dGVuc2lvbi5zdWJzdHJpbmcodmFsdWVT dGFydCwgZXh0ZW5zaW9uTGVuZ3RoIC0gdmFsdWVTdGFydCkpOwogfQogCi1jb25zdGV4cHIgQVND SUlMaXRlcmFsIHJlbGV2YW50RXh0ZW5zaW9uS2V5U3RyaW5nKFJlbGV2YW50RXh0ZW5zaW9uS2V5 IGtleSkKK2lubGluZSBBU0NJSUxpdGVyYWwgcmVsZXZhbnRFeHRlbnNpb25LZXlTdHJpbmcoUmVs ZXZhbnRFeHRlbnNpb25LZXkga2V5KQogewogICAgIHN3aXRjaCAoa2V5KSB7CiAjZGVmaW5lIEpT Q19SRVRVUk5fSU5UTF9SRUxFVkFOVF9FWFRFTlNJT05fS0VZUyhsb3dlck5hbWUsIGNhcGl0YWxp emVkTmFtZSkgXApAQCAtNjU0LDcgKzY1NCw3IEBAIGNvbnN0ZXhwciBBU0NJSUxpdGVyYWwgcmVs ZXZhbnRFeHRlbnNpb25LZXlTdHJpbmcoUmVsZXZhbnRFeHRlbnNpb25LZXkga2V5KQogICAgIEpT Q19JTlRMX1JFTEVWQU5UX0VYVEVOU0lPTl9LRVlTKEpTQ19SRVRVUk5fSU5UTF9SRUxFVkFOVF9F WFRFTlNJT05fS0VZUykKICN1bmRlZiBKU0NfUkVUVVJOX0lOVExfUkVMRVZBTlRfRVhURU5TSU9O X0tFWVMKICAgICB9Ci0gICAgQVNTRVJUX1VOREVSX0NPTlNURVhQUl9DT05URVhUKDApOworICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIHJldHVybiBBU0NJSUxpdGVyYWw6Om51bGwoKTsK IH0KIAo= 404842 2020-07-21 11:37:00 -0700 2020-07-21 12:16:05 -0700 Patch bug-214596-20200721153659.patch text/plain 1415 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NTNjZThjZTQ0ZGRkYTc4M2MzOWZlNTlhOGU1NzVhYmVmMTJjMGU0Li4zZjJiZjM1ZTcxZmZiNDcw ZWNjYTk0ODA0Mzc3ZGVjMDQyNTJkYmNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNy0yMSAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgRGVidWcgYnVpbGQgaXMgZmFpbGluZyBhZnRlciByMjY0NTM3IG9uIExpbnV4 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ1OTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmlu ZyBgQVNTRVJUX1VOREVSX0NPTlRFWFBSX0NPTlRFWFQoMClgIHRvIGF2b2lkIGNvbXBpbGF0aW9u CisgICAgICAgIGZhaWx1cmUgb2YgRGVidWcgYnVpbGRzIG9uIExpbnV4LgorCisgICAgICAgICog cnVudGltZS9JbnRsT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6cmVsZXZhbnRFeHRlbnNpb25L ZXlTdHJpbmcpOgorCiAyMDIwLTA3LTIxICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6 QGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXcgbm9uLXVuaWZpZWQgc291cmNlIGJ1aWxk IGZpeApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bE9iamVj dC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRsT2JqZWN0LmNwcAppbmRl eCBjZTUxZDg4MjIzNTNkMDg1YTIwYmFlYzI5YzM5MTZlYzRiZWIzMTZlLi5iMmQ1Y2I4NGM4MzJj NjJlNmM0NWYwZmNkNGY3ZmQ4ODQ4MDZhYmRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9JbnRsT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9JbnRsT2JqZWN0LmNwcApAQCAtNjU0LDcgKzY1NCw2IEBAIGNvbnN0ZXhwciBBU0NJ SUxpdGVyYWwgcmVsZXZhbnRFeHRlbnNpb25LZXlTdHJpbmcoUmVsZXZhbnRFeHRlbnNpb25LZXkg a2V5KQogICAgIEpTQ19JTlRMX1JFTEVWQU5UX0VYVEVOU0lPTl9LRVlTKEpTQ19SRVRVUk5fSU5U TF9SRUxFVkFOVF9FWFRFTlNJT05fS0VZUykKICN1bmRlZiBKU0NfUkVUVVJOX0lOVExfUkVMRVZB TlRfRVhURU5TSU9OX0tFWVMKICAgICB9Ci0gICAgQVNTRVJUX1VOREVSX0NPTlNURVhQUl9DT05U RVhUKDApOwogICAgIHJldHVybiBBU0NJSUxpdGVyYWw6Om51bGwoKTsKIH0KIAo=