214590 2020-07-21 05:40:16 -0700 [GTK][WPE] ITP: use the database store unconditionally 2020-07-22 03:47:57 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=213493 Gtk P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply katherine_cheney wilander youennf oldest_to_newest 1673419 0 cgarcia 2020-07-21 05:40:16 -0700 The memory store is now considered legacy. 1673422 1 404812 cgarcia 2020-07-21 05:43:26 -0700 Created attachment 404812 Patch 1673788 2 cgarcia 2020-07-22 03:47:57 -0700 Committed r264694: <https://trac.webkit.org/changeset/264694> 404812 2020-07-21 05:43:26 -0700 2020-07-21 08:40:24 -0700 Patch wk2-itp-database.diff text/plain 7182 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYTdiYjQ1YWYyYjNkLi42NDQzNTQwMDA0NDcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjAgQEAKKzIwMjAtMDctMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gSVRQOiB1c2UgdGhlIGRhdGFiYXNlIHN0b3Jl IHVuY29uZGl0aW9uYWxseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjE0NTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhlIG1lbW9yeSBzdG9yZSBpcyBub3cgY29uc2lkZXJlZCBsZWdhY3kuCisKKyAg ICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9DbGFzc2lmaWVyL1Jlc291cmNlTG9hZFN0YXRpc3RpY3NE YXRhYmFzZVN0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVzb3VyY2VMb2FkU3RhdGlzdGlj c0RhdGFiYXNlU3RvcmU6OlJlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0b3JlKTogVXNl CisgICAgICAgIEZpbGVTeXN0ZW06OnBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudCgpIHRvIGNyZWF0 ZSB0aGUgZGF0YWJhc2UgcGF0aC4KKyAgICAgICAgKFdlYktpdDo6UmVzb3VyY2VMb2FkU3RhdGlz dGljc0RhdGFiYXNlU3RvcmU6Om9wZW5JVFBEYXRhYmFzZSk6IEVuc3VyZSB0aGUgZGlyZWN0b3J5 IGV4aXN0cyBiZWZvcmUgdHJ5aW5nIHRvCisgICAgICAgIG9wZW4gdGhlIGRhdGFiYXNlLgorICAg ICAgICAqIFVJUHJvY2Vzcy9zb3VwL1dlYlByb2Nlc3NQb29sU291cC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxpemVOZXR3b3JrUHJvY2Vzcyk6 IEFsd2F5cyBlbmFibGUgdGhlIElUUCBkYXRhYmFlIGJ5IGRlZmF1bHQuCisKIDIwMjAtMDctMjEg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIEZp eCBJVFAgZGF0YSBzdW1tYXJ5IHdoZW4gdXNpbmcgdGhlIG1lbW9yeSBzdG9yZSBhbmQgYmxvY2tp bmcgYWxsIHRoaXJkLXBhcnR5IGNvb2tpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9y ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZpZXIvUmVzb3VyY2VM b2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwCmluZGV4IDYwNTIzNmFhNjU2NC4uMmQ5NmY4 MDBiZWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL0NsYXNzaWZp ZXIvUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvQ2xhc3NpZmllci9SZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0 YWJhc2VTdG9yZS5jcHAKQEAgLTI4Miw3ICsyODIsNyBAQCBIYXNoU2V0PFJlc291cmNlTG9hZFN0 YXRpc3RpY3NEYXRhYmFzZVN0b3JlKj4mIFJlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRhYmFzZVN0 bwogCiBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRGF0YWJhc2VTdG9yZTo6UmVzb3VyY2VMb2FkU3Rh dGlzdGljc0RhdGFiYXNlU3RvcmUoV2ViUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlJiBzdG9y ZSwgV29ya1F1ZXVlJiB3b3JrUXVldWUsIFNob3VsZEluY2x1ZGVMb2NhbGhvc3Qgc2hvdWxkSW5j bHVkZUxvY2FsaG9zdCwgY29uc3QgU3RyaW5nJiBzdG9yYWdlRGlyZWN0b3J5UGF0aCwgUEFMOjpT ZXNzaW9uSUQgc2Vzc2lvbklEKQogICAgIDogUmVzb3VyY2VMb2FkU3RhdGlzdGljc1N0b3JlKHN0 b3JlLCB3b3JrUXVldWUsIHNob3VsZEluY2x1ZGVMb2NhbGhvc3QpCi0gICAgLCBtX3N0b3JhZ2VE aXJlY3RvcnlQYXRoKHN0b3JhZ2VEaXJlY3RvcnlQYXRoICsgIi9vYnNlcnZhdGlvbnMuZGIiKQor ICAgICwgbV9zdG9yYWdlRGlyZWN0b3J5UGF0aChGaWxlU3lzdGVtOjpwYXRoQnlBcHBlbmRpbmdD b21wb25lbnQoc3RvcmFnZURpcmVjdG9yeVBhdGgsICJvYnNlcnZhdGlvbnMuZGIiX3MpKQogICAg ICwgbV9zZXNzaW9uSUQoc2Vzc2lvbklEKQogewogICAgIEFTU0VSVCghUnVuTG9vcDo6aXNNYWlu KCkpOwpAQCAtMzIwLDkgKzMyMCwxMyBAQCB2b2lkIFJlc291cmNlTG9hZFN0YXRpc3RpY3NEYXRh YmFzZVN0b3JlOjpjbG9zZSgpCiAKIHZvaWQgUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNl U3RvcmU6Om9wZW5JVFBEYXRhYmFzZSgpCiB7Ci0gICAgaWYgKCFGaWxlU3lzdGVtOjpmaWxlRXhp c3RzKG1fc3RvcmFnZURpcmVjdG9yeVBhdGgpKQorICAgIGlmICghRmlsZVN5c3RlbTo6ZmlsZUV4 aXN0cyhtX3N0b3JhZ2VEaXJlY3RvcnlQYXRoKSkgeworICAgICAgICBpZiAoIUZpbGVTeXN0ZW06 Om1ha2VBbGxEaXJlY3RvcmllcyhGaWxlU3lzdGVtOjpkaXJlY3RvcnlOYW1lKG1fc3RvcmFnZURp cmVjdG9yeVBhdGgpKSkgeworICAgICAgICAgICAgUkVMRUFTRV9MT0dfRVJST1IoTmV0d29yaywg IiVwIC0gUmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlU3RvcmU6Om9wZW4gZmFpbGVkLCBl cnJvciBtZXNzYWdlOiBGYWlsZWQgdG8gY3JlYXRlIGRpcmVjdG9yeSBkYXRhYmFzZSBwYXRoOiAl IiBQVUJMSUNfTE9HX1NUUklORywgdGhpcywgbV9zdG9yYWdlRGlyZWN0b3J5UGF0aC51dGY4KCku ZGF0YSgpKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQogICAgICAgICBtX2lzTmV3 UmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlRmlsZSA9IHRydWU7Ci0gICAgZWxzZQorICAg IH0gZWxzZQogICAgICAgICBtX2lzTmV3UmVzb3VyY2VMb2FkU3RhdGlzdGljc0RhdGFiYXNlRmls ZSA9IGZhbHNlOwogCiAgICAgaWYgKCFtX2RhdGFiYXNlLm9wZW4obV9zdG9yYWdlRGlyZWN0b3J5 UGF0aCkpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL3NvdXAvV2ViUHJv Y2Vzc1Bvb2xTb3VwLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL3NvdXAvV2ViUHJvY2Vz c1Bvb2xTb3VwLmNwcAppbmRleCBiNmU1NjZjMWU5ZjEuLmJmYmJmOTY2NGU0OCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mvc291cC9XZWJQcm9jZXNzUG9vbFNvdXAuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL3NvdXAvV2ViUHJvY2Vzc1Bvb2xTb3VwLmNwcApA QCAtNDYsNiArNDYsNyBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxpemVO ZXR3b3JrUHJvY2VzcyhOZXR3b3JrUHJvY2Vzc0NyZWF0aW9uUGFyYQogICAgIHBhcmFtZXRlcnMu aWdub3JlVExTRXJyb3JzID0gbV9pZ25vcmVUTFNFcnJvcnM7CiAgICAgcGFyYW1ldGVycy5sYW5n dWFnZXMgPSB1c2VyUHJlZmVycmVkTGFuZ3VhZ2VzKCk7CiAgICAgcGFyYW1ldGVycy5wcm94eVNl dHRpbmdzID0gbV9uZXR3b3JrUHJveHlTZXR0aW5nczsKKyAgICBwYXJhbWV0ZXJzLnNob3VsZEVu YWJsZUlUUERhdGFiYXNlID0gdHJ1ZTsKIH0KIAogdm9pZCBXZWJQcm9jZXNzUG9vbDo6c2V0SWdu b3JlVExTRXJyb3JzKGJvb2wgaWdub3JlVExTRXJyb3JzKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hh bmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDc4ZTdmNTdmNWQ5Ny4uMzYzMjA3ZDMwYTQ4 IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMjAtMDctMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gSVRQOiB1c2UgdGhlIGRhdGFiYXNlIHN0 b3JlIHVuY29uZGl0aW9uYWxseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE0NTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXBkYXRlIHRoZSB1bml0IHRlc3QgdG8gbW9uaXRvciB0aGUgZGF0YWJhc2Ug ZmlsZSBpbnN0ZWFkIG9mIHRoZSBvbGQgbG9nIGZpbGUuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdFdlYnNpdGVEYXRhLmNwcDoKKyAgICAgICAgKHRlc3RX ZWJzaXRlRGF0YUlUUCk6CisKIDIwMjAtMDctMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIEZpeCBJVFAgZGF0YSBzdW1tYXJ5IHdoZW4gdXNp bmcgdGhlIG1lbW9yeSBzdG9yZSBhbmQgYmxvY2tpbmcgYWxsIHRoaXJkLXBhcnR5IGNvb2tpZXMK ZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0V2Vi c2l0ZURhdGEuY3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3RX ZWJzaXRlRGF0YS5jcHAKaW5kZXggZGM0YjE3Y2Y4NjMxLi5hZTNmMjFmYjVhYTAgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0V2Vic2l0ZURhdGEu Y3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0V2Vic2l0 ZURhdGEuY3BwCkBAIC02NzMsMTAgKzY3MywxMCBAQCBzdGF0aWMgdm9pZCB0ZXN0V2Vic2l0ZURh dGFEZXZpY2VJZEhhc2hTYWx0KFdlYnNpdGVEYXRhVGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcgog c3RhdGljIHZvaWQgdGVzdFdlYnNpdGVEYXRhSVRQKFdlYnNpdGVEYXRhVGVzdCogdGVzdCwgZ2Nv bnN0cG9pbnRlcikKIHsKICAgICBjb25zdCBjaGFyKiBpdHBEaXJlY3RvcnkgPSB3ZWJraXRfd2Vi c2l0ZV9kYXRhX21hbmFnZXJfZ2V0X2l0cF9kaXJlY3RvcnkodGVzdC0+bV9tYW5hZ2VyKTsKLSAg ICBHVW5pcXVlUHRyPGNoYXI+IGl0cExvZ0ZpbGUoZ19idWlsZF9maWxlbmFtZShpdHBEaXJlY3Rv cnksICJmdWxsX2Jyb3dzaW5nX3Nlc3Npb25fcmVzb3VyY2VMb2cucGxpc3QiLCBudWxscHRyKSk7 CisgICAgR1VuaXF1ZVB0cjxjaGFyPiBpdHBEYXRhYmFzZUZpbGUoZ19idWlsZF9maWxlbmFtZShp dHBEaXJlY3RvcnksICJvYnNlcnZhdGlvbnMuZGIiLCBudWxscHRyKSk7CiAKICAgICAvLyBEZWxl dGUgYW55IHByZXZpb3VzIGRhdGEuCi0gICAgZ191bmxpbmsoaXRwTG9nRmlsZS5nZXQoKSk7Cisg ICAgZ191bmxpbmsoaXRwRGF0YWJhc2VGaWxlLmdldCgpKTsKICAgICBnX3JtZGlyKGl0cERpcmVj dG9yeSk7CiAKICAgICBnX2Fzc2VydF9mYWxzZSh3ZWJraXRfd2Vic2l0ZV9kYXRhX21hbmFnZXJf Z2V0X2l0cF9lbmFibGVkKHRlc3QtPm1fbWFuYWdlcikpOwpAQCAtNjg2LDE0ICs2ODYsMTcgQEAg c3RhdGljIHZvaWQgdGVzdFdlYnNpdGVEYXRhSVRQKFdlYnNpdGVEYXRhVGVzdCogdGVzdCwgZ2Nv bnN0cG9pbnRlcikKICAgICB3ZWJraXRfd2Vic2l0ZV9kYXRhX21hbmFnZXJfc2V0X2l0cF9lbmFi bGVkKHRlc3QtPm1fbWFuYWdlciwgVFJVRSk7CiAgICAgZ19hc3NlcnRfdHJ1ZSh3ZWJraXRfd2Vi c2l0ZV9kYXRhX21hbmFnZXJfZ2V0X2l0cF9lbmFibGVkKHRlc3QtPm1fbWFuYWdlcikpOwogICAg IGdfYXNzZXJ0X2ZhbHNlKGdfZmlsZV90ZXN0KGl0cERpcmVjdG9yeSwgR19GSUxFX1RFU1RfSVNf RElSKSk7Ci0gICAgZ19hc3NlcnRfZmFsc2UoZ19maWxlX3Rlc3QoaXRwTG9nRmlsZS5nZXQoKSwg R19GSUxFX1RFU1RfSVNfUkVHVUxBUikpOworICAgIGdfYXNzZXJ0X2ZhbHNlKGdfZmlsZV90ZXN0 KGl0cERhdGFiYXNlRmlsZS5nZXQoKSwgR19GSUxFX1RFU1RfSVNfUkVHVUxBUikpOwogCiAgICAg dGVzdC0+bG9hZFVSSShrU2VydmVyLT5nZXRVUklGb3JQYXRoKCIvZW1wdHkiKS5kYXRhKCkpOwog ICAgIHRlc3QtPndhaXRVbnRpbExvYWRGaW5pc2hlZCgpOwogCi0gICAgdGVzdC0+d2FpdFVudGls RmlsZUNoYW5nZWQoaXRwTG9nRmlsZS5nZXQoKSwgR19GSUxFX01PTklUT1JfRVZFTlRfQ1JFQVRF RCk7CisgICAgdGVzdC0+d2FpdFVudGlsRmlsZUNoYW5nZWQoaXRwRGF0YWJhc2VGaWxlLmdldCgp LCBHX0ZJTEVfTU9OSVRPUl9FVkVOVF9DUkVBVEVEKTsKICAgICBnX2Fzc2VydF90cnVlKGdfZmls ZV90ZXN0KGl0cERpcmVjdG9yeSwgR19GSUxFX1RFU1RfSVNfRElSKSk7Ci0gICAgZ19hc3NlcnRf dHJ1ZShnX2ZpbGVfdGVzdChpdHBMb2dGaWxlLmdldCgpLCBHX0ZJTEVfVEVTVF9JU19SRUdVTEFS KSk7CisgICAgZ19hc3NlcnRfdHJ1ZShnX2ZpbGVfdGVzdChpdHBEYXRhYmFzZUZpbGUuZ2V0KCks IEdfRklMRV9URVNUX0lTX1JFR1VMQVIpKTsKKworICAgIC8vIEdpdmUgc29tZSB0aW1lIGZvciB0 aGUgZGF0YWJhc2UgdG8gYmUgdXBkYXRlZC4KKyAgICB0ZXN0LT53YWl0KDAuNSk7CiAKICAgICBH TGlzdCogZGF0YUxpc3QgPSB0ZXN0LT5mZXRjaChXRUJLSVRfV0VCU0lURV9EQVRBX0lUUCk7CiAg ICAgZ19hc3NlcnRfbm9ubnVsbChkYXRhTGlzdCk7CkBAIC03MTMsNyArNzE2LDcgQEAgc3RhdGlj IHZvaWQgdGVzdFdlYnNpdGVEYXRhSVRQKFdlYnNpdGVEYXRhVGVzdCogdGVzdCwgZ2NvbnN0cG9p bnRlcikKICAgICAvLyBDbGVhciBhbGwuCiAgICAgc3RhdGljIGNvbnN0IFdlYktpdFdlYnNpdGVE YXRhVHlwZXMgY2FjaGVBbmRJVFAgPSBzdGF0aWNfY2FzdDxXZWJLaXRXZWJzaXRlRGF0YVR5cGVz PihXRUJLSVRfV0VCU0lURV9EQVRBX0lUUCB8IFdFQktJVF9XRUJTSVRFX0RBVEFfTUVNT1JZX0NB Q0hFIHwgV0VCS0lUX1dFQlNJVEVfREFUQV9ESVNLX0NBQ0hFKTsKICAgICB0ZXN0LT5jbGVhcihj YWNoZUFuZElUUCwgMCk7Ci0gICAgdGVzdC0+d2FpdFVudGlsRmlsZUNoYW5nZWQoaXRwTG9nRmls ZS5nZXQoKSwgR19GSUxFX01PTklUT1JfRVZFTlRfREVMRVRFRCk7CisgICAgdGVzdC0+d2FpdFVu dGlsRmlsZUNoYW5nZWQoaXRwRGF0YWJhc2VGaWxlLmdldCgpLCBHX0ZJTEVfTU9OSVRPUl9FVkVO VF9ERUxFVEVEKTsKIAogICAgIHdlYmtpdF93ZWJzaXRlX2RhdGFfbWFuYWdlcl9zZXRfaXRwX2Vu YWJsZWQodGVzdC0+bV9tYW5hZ2VyLCBGQUxTRSk7CiAgICAgZ19hc3NlcnRfZmFsc2Uod2Via2l0 X3dlYnNpdGVfZGF0YV9tYW5hZ2VyX2dldF9pdHBfZW5hYmxlZCh0ZXN0LT5tX21hbmFnZXIpKTsK