214569 2020-07-20 13:40:16 -0700 [WPE] WebPopupItem should always be forward declared as struct 2020-07-20 15:17:13 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez webkit-bug-importer oldest_to_newest 1673213 0 aperez 2020-07-20 13:40:16 -0700 ../Source/WebKit/UIProcess/API/wpe/WebKitWebViewClient.h:38:1: warning: class 'WebPopupItem' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags] class WebPopupItem; ^ ../Source/WebKit/UIProcess/WebPageProxy.h:357:8: note: previous use is here struct WebPopupItem; ^ 1673216 1 404754 aperez 2020-07-20 13:44:51 -0700 Created attachment 404754 Patch for landing 1673259 2 ews-feeder 2020-07-20 15:16:46 -0700 Committed r264623: <https://trac.webkit.org/changeset/264623> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404754. 1673260 3 webkit-bug-importer 2020-07-20 15:17:13 -0700 <rdar://problem/65850780> 404754 2020-07-20 13:44:51 -0700 2020-07-20 15:16:46 -0700 Patch for landing bug-214569-20200720234449.patch text/plain 1254 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGMxMDM3ZDU5ODliODY2Yjgy NGM2MjQxMWVmZDY5MmE3ODQwYjIxOGUuLmJjMzc5ZDhmZGQ3M2FlN2FmZGU1Mjg5YTFmZjI0NzFl Y2Q4Y2IwODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDctMjAgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBXZWJQ b3B1cEl0ZW0gc2hvdWxkIGFsd2F5cyBiZSBmb3J3YXJkIGRlY2xhcmVkIGFzIHN0cnVjdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0NTY5CisKKyAg ICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRl ZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvd3BlL1dlYktpdFdlYlZpZXdDbGllbnQuaDog Rm9yd2FyZC1kZWNsYXJlIFdlYlBvcHVwSXRlbSBhcyBhIHN0cnVjdC4KKwogMjAyMC0wNy0yMCAg QWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJF R1JFU1NJT04ocjI2MzU1MSkgTWFpbiB0aHJlYWQgb2Z0ZW4gaGFuZ3Mgd2hpbGUgc2F2aW5nIGNv b2tpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvV2ViS2l0 V2ViVmlld0NsaWVudC5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9XZWJLaXRX ZWJWaWV3Q2xpZW50LmgKaW5kZXggMzYzODFjYTMzM2FkNTE2YWJkMjQ5NjcyOWFiZjVjM2Y0ZGEx ZjA1Ni4uYzE1ZjVhOWEwZjYwNGJkNDdiYTRjZmM5NWEzNmY5NTRjMjBlYmVmMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9XZWJLaXRXZWJWaWV3Q2xpZW50LmgK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9XZWJLaXRXZWJWaWV3Q2xpZW50 LmgKQEAgLTM1LDcgKzM1LDcgQEAgY2xhc3MgSW50UmVjdDsKIG5hbWVzcGFjZSBXZWJLaXQgewog Y2xhc3MgRG93bmxvYWRQcm94eTsKIGNsYXNzIFdlYktpdFBvcHVwTWVudTsKLWNsYXNzIFdlYlBv cHVwSXRlbTsKK3N0cnVjdCBXZWJQb3B1cEl0ZW07CiBzdHJ1Y3QgVXNlck1lc3NhZ2U7CiB9CiAK