214566 2020-07-20 12:53:23 -0700 [GTK] GeoclueGeolocationProvider uses very low accuracy setting (city) as default geolocation API 2020-07-27 08:05:06 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 newton688 aperez aperez bugs-noreply cgarcia clopez pnormand oldest_to_newest 1673188 0 newton688 2020-07-20 12:53:23 -0700 When using the Epiphany browser in Linux with libwebkit2gtk (v2.28.3) and the geoclue2 library with a website like openstreetmap.org or maps.google.com the accuracy is very low at around 25km or "city" level. Geoclue ends up using only IP-based location, which is intended to give a city level of accuracy. According to the source code of Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp geoclue will only be instructed to provide greater accuracy with cell phone tower location, wifi, bluetooth beacons and even GPS if the enableHighAccuracy position option is enabled. Websites like Open Street Map or Google Maps do not use the enableHighAccuracy position options for simple location, which not very useful with only a city level of accuracy. They appear to assume that at least a street level of accuracy could be given without enabling a GPS on the device. The MDN reference on the HTML Geolocation API points out GPS as a differentiating factor for using enableHighAccuracy: https://developer.mozilla.org/en-US/docs/Web/API/PositionOptions/enableHighAccuracy In terms of geoclue, street level accuracy can be achieved without GPS using the presence of nearby cell phone towers, wifi endpoints and bluetooth low energy beacons. But, these require the street level setting. Otherwise, it's just the IP address based lookup. Changing GeoclueGeoLocationProvider.cpp to use GeoclueAccuracySteetLevel (6) as the default could be a more reasonable tradeoff of accuracy for performance and might give a better experience for Linux users. 1675200 1 405266 aperez 2020-07-27 04:49:42 -0700 Created attachment 405266 Patch 1675207 2 405266 cgarcia 2020-07-27 05:40:38 -0700 Comment on attachment 405266 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405266&action=review > Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp:244 > unsigned accuracy = m_isHighAccuracyEnabled ? 8 : 4; You have only changed the comment, I guess this should be: unsigned accuracy = m_isHighAccuracyEnabled ? 8 : 6; no? 1675210 3 aperez 2020-07-27 05:53:14 -0700 (In reply to Carlos Garcia Campos from comment #2) > Comment on attachment 405266 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405266&action=review > > > Source/WebKit/UIProcess/geoclue/GeoclueGeolocationProvider.cpp:244 > > unsigned accuracy = m_isHighAccuracyEnabled ? 8 : 4; > > You have only changed the comment, I guess this should be: > > unsigned accuracy = m_isHighAccuracyEnabled ? 8 : 6; > > no? Indeed, I'll post an updated patch 🤦️ 1675212 4 405268 aperez 2020-07-27 05:57:53 -0700 Created attachment 405268 Patch v2 1675240 5 ews-feeder 2020-07-27 08:05:05 -0700 Committed r264920: <https://trac.webkit.org/changeset/264920> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405268. 405266 2020-07-27 04:49:42 -0700 2020-07-27 05:57:48 -0700 Patch bug-214566-20200727144940.patch text/plain 2202 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUyYjRiYWRkMjU5NjEwN2Iw MzYxZDFiZDI2NzBkMjc5YjY0NTNmNzMuLmZjYmVhOTMyZDI2MGNiZTczZmFmMGM3ODc2ZjFlYzQ1 YzllYTY4MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDctMjcgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBHZW9j bHVlR2VvbG9jYXRpb25Qcm92aWRlciB1c2VzIHZlcnkgbG93IGFjY3VyYWN5IHNldHRpbmcgKGNp dHkpIGFzIGRlZmF1bHQgZ2VvbG9jYXRpb24gQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ1NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgICog VUlQcm9jZXNzL2dlb2NsdWUvR2VvY2x1ZUdlb2xvY2F0aW9uUHJvdmlkZXIuY3BwOgorICAgICAg ICAoV2ViS2l0OjpHZW9jbHVlR2VvbG9jYXRpb25Qcm92aWRlcjo6cmVxdWVzdEFjY3VyYWN5TGV2 ZWwpOiBVc2UKKyAgICAgICAgR2VvY2x1ZUFjY3VyYWN5U3RlZXRMZXZlbCB3aGVuIGhpZ2ggYWNj dXJhY3kgd2FzIG5vdCByZXF1ZXN0ZWQuCisKIDIwMjAtMDctMjcgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdW0dUS10gQWRkIEFQSSB0 byBzdXBwb3J0ICJQcml2YWN5IFJlcG9ydCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2dlb2NsdWUvR2VvY2x1ZUdlb2xvY2F0aW9uUHJvdmlkZXIuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvZ2VvY2x1ZS9HZW9jbHVlR2VvbG9jYXRpb25Qcm92aWRlci5jcHAKaW5k ZXggN2JhMzkzMzJiY2U2ZTI4ZjBmNGIyZjdhY2Y2MzZmODM1YzU0ZjQ4Ni4uNmRkMjFlYmZmZDE1 NDZhNGVlYjA4ZjU3ZmU5OTdiOTg2MGQ4YWYzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvZ2VvY2x1ZS9HZW9jbHVlR2VvbG9jYXRpb25Qcm92aWRlci5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvZ2VvY2x1ZS9HZW9jbHVlR2VvbG9jYXRpb25Qcm92aWRlci5j cHAKQEAgLTIzMiw3ICsyMzIsMTUgQEAgdm9pZCBHZW9jbHVlR2VvbG9jYXRpb25Qcm92aWRlcjo6 cmVxdWVzdEFjY3VyYWN5TGV2ZWwoKQogICAgIGlmICghbV9jbGllbnQpCiAgICAgICAgIHJldHVy bjsKIAotICAgIC8vIEdlb2NsdWVBY2N1cmFjeUxldmVsQ2l0eSA9IDQsIEdlb2NsdWVBY2N1cmFj eUxldmVsRXhhY3QgPSA4LgorICAgIC8vIEZyb20gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxNDU2NjoKKyAgICAvLworICAgIC8vICAgIldlYnNpdGVzIGxpa2UgT3Bl blN0cmVldE1hcCBvciBHb29nbGUgTWFwcyBkbyBub3QgdXNlIHRoZQorICAgIC8vICAgIGVuYWJs ZUhpZ2hBY2N1cmFjeSBwb3NpdGlvbiBvcHRpb25zIGZvciBzaW1wbGUgbG9jYXRpb24sIHdoaWNo CisgICAgLy8gICAgbm90IHZlcnkgdXNlZnVsIHdpdGggb25seSBhIGNpdHkgbGV2ZWwgb2YgYWNj dXJhY3kuIFRoZXkgYXBwZWFyCisgICAgLy8gICAgdG8gYXNzdW1lIHRoYXQgYXQgbGVhc3QgYSBz dHJlZXQgbGV2ZWwgb2YgYWNjdXJhY3kgY291bGQgYmUgZ2l2ZW4KKyAgICAvLyAgICB3aXRob3V0 IGVuYWJsaW5nIGEgR1BTIG9uIHRoZSBkZXZpY2UuIgorICAgIC8vCisgICAgLy8gR2VvY2x1ZUFj Y3VyYWN5TGV2ZWxTdHJlZXRMZXZlbCA9IDYsIEdlb2NsdWVBY2N1cmFjeUxldmVsRXhhY3QgPSA4 LgogICAgIHVuc2lnbmVkIGFjY3VyYWN5ID0gbV9pc0hpZ2hBY2N1cmFjeUVuYWJsZWQgPyA4IDog NDsKICAgICBnX2RidXNfcHJveHlfY2FsbChtX2NsaWVudC5nZXQoKSwgIm9yZy5mcmVlZGVza3Rv cC5EQnVzLlByb3BlcnRpZXMuU2V0IiwKICAgICAgICAgZ192YXJpYW50X25ldygiKHNzdikiLCAi b3JnLmZyZWVkZXNrdG9wLkdlb0NsdWUyLkNsaWVudCIsICJSZXF1ZXN0ZWRBY2N1cmFjeUxldmVs IiwgZ192YXJpYW50X25ld191aW50MzIoYWNjdXJhY3kpKSwK 405268 2020-07-27 05:57:53 -0700 2020-07-27 08:05:06 -0700 Patch v2 bug-214566-20200727155752.patch text/plain 2325 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0OTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUyYjRiYWRkMjU5NjEwN2Iw MzYxZDFiZDI2NzBkMjc5YjY0NTNmNzMuLmZjYmVhOTMyZDI2MGNiZTczZmFmMGM3ODc2ZjFlYzQ1 YzllYTY4MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDctMjcgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBHZW9j bHVlR2VvbG9jYXRpb25Qcm92aWRlciB1c2VzIHZlcnkgbG93IGFjY3VyYWN5IHNldHRpbmcgKGNp dHkpIGFzIGRlZmF1bHQgZ2VvbG9jYXRpb24gQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ1NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgICog VUlQcm9jZXNzL2dlb2NsdWUvR2VvY2x1ZUdlb2xvY2F0aW9uUHJvdmlkZXIuY3BwOgorICAgICAg ICAoV2ViS2l0OjpHZW9jbHVlR2VvbG9jYXRpb25Qcm92aWRlcjo6cmVxdWVzdEFjY3VyYWN5TGV2 ZWwpOiBVc2UKKyAgICAgICAgR2VvY2x1ZUFjY3VyYWN5U3RlZXRMZXZlbCB3aGVuIGhpZ2ggYWNj dXJhY3kgd2FzIG5vdCByZXF1ZXN0ZWQuCisKIDIwMjAtMDctMjcgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdW0dUS10gQWRkIEFQSSB0 byBzdXBwb3J0ICJQcml2YWN5IFJlcG9ydCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2dlb2NsdWUvR2VvY2x1ZUdlb2xvY2F0aW9uUHJvdmlkZXIuY3BwIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvZ2VvY2x1ZS9HZW9jbHVlR2VvbG9jYXRpb25Qcm92aWRlci5jcHAKaW5k ZXggN2JhMzkzMzJiY2U2ZTI4ZjBmNGIyZjdhY2Y2MzZmODM1YzU0ZjQ4Ni4uNDExMDU2ZDQzZWE3 NjRjNDJiY2UwNDAzZTZjNjlkZGI4YjI0YjA0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvZ2VvY2x1ZS9HZW9jbHVlR2VvbG9jYXRpb25Qcm92aWRlci5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvZ2VvY2x1ZS9HZW9jbHVlR2VvbG9jYXRpb25Qcm92aWRlci5j cHAKQEAgLTIzMiw4ICsyMzIsMTYgQEAgdm9pZCBHZW9jbHVlR2VvbG9jYXRpb25Qcm92aWRlcjo6 cmVxdWVzdEFjY3VyYWN5TGV2ZWwoKQogICAgIGlmICghbV9jbGllbnQpCiAgICAgICAgIHJldHVy bjsKIAotICAgIC8vIEdlb2NsdWVBY2N1cmFjeUxldmVsQ2l0eSA9IDQsIEdlb2NsdWVBY2N1cmFj eUxldmVsRXhhY3QgPSA4LgotICAgIHVuc2lnbmVkIGFjY3VyYWN5ID0gbV9pc0hpZ2hBY2N1cmFj eUVuYWJsZWQgPyA4IDogNDsKKyAgICAvLyBGcm9tIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTQ1NjY6CisgICAgLy8KKyAgICAvLyAgICJXZWJzaXRlcyBsaWtlIE9w ZW5TdHJlZXRNYXAgb3IgR29vZ2xlIE1hcHMgZG8gbm90IHVzZSB0aGUKKyAgICAvLyAgICBlbmFi bGVIaWdoQWNjdXJhY3kgcG9zaXRpb24gb3B0aW9ucyBmb3Igc2ltcGxlIGxvY2F0aW9uLCB3aGlj aAorICAgIC8vICAgIG5vdCB2ZXJ5IHVzZWZ1bCB3aXRoIG9ubHkgYSBjaXR5IGxldmVsIG9mIGFj Y3VyYWN5LiBUaGV5IGFwcGVhcgorICAgIC8vICAgIHRvIGFzc3VtZSB0aGF0IGF0IGxlYXN0IGEg c3RyZWV0IGxldmVsIG9mIGFjY3VyYWN5IGNvdWxkIGJlIGdpdmVuCisgICAgLy8gICAgd2l0aG91 dCBlbmFibGluZyBhIEdQUyBvbiB0aGUgZGV2aWNlLiIKKyAgICAvLworICAgIC8vIEdlb2NsdWVB Y2N1cmFjeUxldmVsU3RyZWV0TGV2ZWwgPSA2LCBHZW9jbHVlQWNjdXJhY3lMZXZlbEV4YWN0ID0g OC4KKyAgICB1bnNpZ25lZCBhY2N1cmFjeSA9IG1faXNIaWdoQWNjdXJhY3lFbmFibGVkID8gOCA6 IDY7CiAgICAgZ19kYnVzX3Byb3h5X2NhbGwobV9jbGllbnQuZ2V0KCksICJvcmcuZnJlZWRlc2t0 b3AuREJ1cy5Qcm9wZXJ0aWVzLlNldCIsCiAgICAgICAgIGdfdmFyaWFudF9uZXcoIihzc3YpIiwg Im9yZy5mcmVlZGVza3RvcC5HZW9DbHVlMi5DbGllbnQiLCAiUmVxdWVzdGVkQWNjdXJhY3lMZXZl bCIsIGdfdmFyaWFudF9uZXdfdWludDMyKGFjY3VyYWN5KSksCiAgICAgICAgIEdfREJVU19DQUxM X0ZMQUdTX05PTkUsIC0xLCBudWxscHRyLCBudWxscHRyLCBudWxscHRyKTsK