214560 2020-07-20 11:51:21 -0700 [Cocoa] MediaSampleAVFObjC::createImageSample depends on function argument evaluation order 2020-07-20 12:53:14 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=169811 InRadar P2 Normal --- 1 darin darin andersca eric.carlson ews-watchlist glenn jer.noble philipj pnormand sergio webkit-bug-importer oldest_to_newest 1673159 0 darin 2020-07-20 11:51:21 -0700 [Cocoa] MediaSampleAVFObjC::createImageSample depends on function argument evaluation order 1673160 1 404737 darin 2020-07-20 11:55:08 -0700 Created attachment 404737 Patch 1673163 2 darin 2020-07-20 11:57:20 -0700 *** Bug 214559 has been marked as a duplicate of this bug. *** 1673186 3 ews-feeder 2020-07-20 12:52:15 -0700 Committed r264610: <https://trac.webkit.org/changeset/264610> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404737. 1673187 4 webkit-bug-importer 2020-07-20 12:53:14 -0700 <rdar://problem/65842463> 404737 2020-07-20 11:55:08 -0700 2020-07-20 12:52:16 -0700 Patch bug-214560-20200720115507.patch text/plain 4964 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQ2NDAzZTgwYWRiODE3 ZjY0MGE1OTUxOTdkYWQxZTEyNWRkYzIyYi4uNWEzZjQ3MDUwZjc5ZmY4NGVmYmQ2ODM4OWQ2MTYx N2M3YzRkYTM5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA3LTIwICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIE1lZGlhU2FtcGxl QVZGT2JqQzo6Y3JlYXRlSW1hZ2VTYW1wbGUgZGVwZW5kcyBvbiBmdW5jdGlvbiBhcmd1bWVudCBl dmFsdWF0aW9uIG9yZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTQ1NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhU2FtcGxl QVZGT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6OmRlYWxsb2NhdGVWZWN0b3JCdWZmZXIpOiBS ZW5hbWVkIGZyb20gcmVsZWFzZVVpbnQ4VmVjdG9yLgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFT YW1wbGVBVkZPYmpDOjpjcmVhdGVJbWFnZVNhbXBsZSk6IFJlYXJyYW5nZWQgY29kZSBzbyB0aGF0 IHdlIGRvbid0IGNhbGwgYm90aAorICAgICAgICBkYXRhKCkgYW5kIHJlbGVhc2VCdWZmZXIoKSBv biB0aGUgc2FtZSB2ZWN0b3IgaW4gdGhlIHNhbWUgZnVuY3Rpb24gY2FsbDsgdGhhdCBpc24ndCBz YWZlIGJlY2F1c2UKKyAgICAgICAgdGhlIG9yZGVyIG9mIGFyZ3VtZW50IGV2YWx1YXRpb24gaXMg bm90IGd1YXJhbnRlZWQsIGFuZCBzbyBkYXRhKCkgY291bGQgYmUgY2FsbGVkIGFmdGVyIHRoZQor ICAgICAgICBidWZmZXIgaXMgcmVsZWFzZWQuIEFsc28gYWRkZWQgY29kZSB0byBkZWFsbG9jYXRl IHRoZSBidWZmZXIgaWYgQ1ZQaXhlbEJ1ZmZlckNyZWF0ZVdpdGhCeXRlcworICAgICAgICBmYWls cy4gVGhlIG9sZCBjb2RlIHdvdWxkIGhhdmUgbGVha2VkIGl0IGluIHRoYXQgY2FzZS4gQWxzbyBt YWRlIHNvbWUgc3R5bGUgdHdlYWtzIHRvIHVzZQorICAgICAgICBhZG9wdENGIG1vcmUgY29uc2lz dGVudGx5IHRvIGhhbmRsZSByZWZlcmVuY2UgY291bnRpbmcsIGFuZCBzbGlnaHRseSBvcHRpbWl6 ZWQgYSBsb29wIHRvCisgICAgICAgIG9ubHkgZ2V0IHRoZSBhcnJheSBjb3VudCBvbmNlLgorCiAy MDIwLTA3LTIwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1N0cmVhbWVyXSBBZGQgc3VwcG9ydCBmb3IgY2FudmFzIGNhcHR1cmVTdHJlYW0sIHRl c3RzIGZhaWxpbmcgc2luY2UgdGhleSB3ZXJlIGFkZGVkIGluIHIyMTM1OTgKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlh U2FtcGxlQVZGT2JqQy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91 bmRhdGlvbi9vYmpjL01lZGlhU2FtcGxlQVZGT2JqQy5tbQppbmRleCAxNzNmNTBlOTNkMzUxYWFj NmE4ZWU3YTZkYWQ5NDNjYmI3MTMwODQzLi4zMjViNTkwNTdkOGJkOWQ3MjcxODUyMWIyYTQ1NWNk NzUyNTIwN2YzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9h dmZvdW5kYXRpb24vb2JqYy9NZWRpYVNhbXBsZUFWRk9iakMubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFTYW1wbGVBVkZPYmpD Lm1tCkBAIC00MSw0MCArNDEsNDAgQEAgV1RGX0RFQ0xBUkVfQ0ZfVFlQRV9UUkFJVChDTVNhbXBs ZUJ1ZmZlcik7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotc3RhdGljIGlubGluZSB2b2lkIHJl bGVhc2VVaW50OFZlY3Rvcih2b2lkICphcnJheSwgY29uc3Qgdm9pZCopCitzdGF0aWMgdm9pZCBk ZWFsbG9jYXRlVmVjdG9yQnVmZmVyKHZvaWQqIGFycmF5LCBjb25zdCB2b2lkKikKIHsKICAgICBX VEY6OlZlY3Rvck1hbGxvYzo6ZnJlZShhcnJheSk7CiB9CiAKIFJlZlB0cjxNZWRpYVNhbXBsZUFW Rk9iakM+IE1lZGlhU2FtcGxlQVZGT2JqQzo6Y3JlYXRlSW1hZ2VTYW1wbGUoVmVjdG9yPHVpbnQ4 X3Q+JiYgYXJyYXksIHVuc2lnbmVkIHdpZHRoLCB1bnNpZ25lZCBoZWlnaHQpCiB7Ci0gICAgQ1ZQ aXhlbEJ1ZmZlclJlZiBwaXhlbEJ1ZmZlciA9IG51bGxwdHI7Ci0gICAgYXV0byBzdGF0dXMgPSBD VlBpeGVsQnVmZmVyQ3JlYXRlV2l0aEJ5dGVzKGtDRkFsbG9jYXRvckRlZmF1bHQsIHdpZHRoLCBo ZWlnaHQsIGtDVlBpeGVsRm9ybWF0VHlwZV8zMkJHUkEsIGFycmF5LmRhdGEoKSwgd2lkdGggKiA0 LCByZWxlYXNlVWludDhWZWN0b3IsIGFycmF5LnJlbGVhc2VCdWZmZXIoKS5sZWFrUHRyKCksIE5V TEwsICZwaXhlbEJ1ZmZlcik7Ci0gICAgYXV0byBpbWFnZUJ1ZmZlciA9IGFkb3B0Q0YocGl4ZWxC dWZmZXIpOwotCi0gICAgQVNTRVJUX1VOVVNFRChzdGF0dXMsICFzdGF0dXMpOwotICAgIGlmICgh aW1hZ2VCdWZmZXIpCisgICAgQ1ZQaXhlbEJ1ZmZlclJlZiBwaXhlbEJ1ZmZlclJhdyA9IG51bGxw dHI7CisgICAgYXV0byBkYXRhID0gYXJyYXkucmVsZWFzZUJ1ZmZlcigpLmxlYWtQdHIoKTsKKyAg ICBhdXRvIHN0YXR1cyA9IENWUGl4ZWxCdWZmZXJDcmVhdGVXaXRoQnl0ZXMoa0NGQWxsb2NhdG9y RGVmYXVsdCwgd2lkdGgsIGhlaWdodCwga0NWUGl4ZWxGb3JtYXRUeXBlXzMyQkdSQSwgZGF0YSwg d2lkdGggKiA0LCBkZWFsbG9jYXRlVmVjdG9yQnVmZmVyLCBkYXRhLCBudWxscHRyLCAmcGl4ZWxC dWZmZXJSYXcpOworICAgIGF1dG8gcGl4ZWxCdWZmZXIgPSBhZG9wdENGKHBpeGVsQnVmZmVyUmF3 KTsKKyAgICBpZiAoIXBpeGVsQnVmZmVyKSB7CisgICAgICAgIGRlYWxsb2NhdGVWZWN0b3JCdWZm ZXIoZGF0YSwgbnVsbHB0cik7CiAgICAgICAgIHJldHVybiBudWxscHRyOworICAgIH0KKyAgICBB U1NFUlRfVU5VU0VEKHN0YXR1cywgIXN0YXR1cyk7CiAKLSAgICBDTVZpZGVvRm9ybWF0RGVzY3Jp cHRpb25SZWYgZm9ybWF0RGVzY3JpcHRpb24gPSBudWxscHRyOwotICAgIHN0YXR1cyA9IENNVmlk ZW9Gb3JtYXREZXNjcmlwdGlvbkNyZWF0ZUZvckltYWdlQnVmZmVyKGtDRkFsbG9jYXRvckRlZmF1 bHQsIGltYWdlQnVmZmVyLmdldCgpLCAmZm9ybWF0RGVzY3JpcHRpb24pOworICAgIENNVmlkZW9G b3JtYXREZXNjcmlwdGlvblJlZiBmb3JtYXREZXNjcmlwdGlvblJhdyA9IG51bGxwdHI7CisgICAg c3RhdHVzID0gQ01WaWRlb0Zvcm1hdERlc2NyaXB0aW9uQ3JlYXRlRm9ySW1hZ2VCdWZmZXIoa0NG QWxsb2NhdG9yRGVmYXVsdCwgcGl4ZWxCdWZmZXIuZ2V0KCksICZmb3JtYXREZXNjcmlwdGlvblJh dyk7CiAgICAgQVNTRVJUKCFzdGF0dXMpOworICAgIGF1dG8gZm9ybWF0RGVzY3JpcHRpb24gPSBh ZG9wdENGKGZvcm1hdERlc2NyaXB0aW9uUmF3KTsKIAogICAgIENNU2FtcGxlVGltaW5nSW5mbyBz YW1wbGVUaW1pbmdJbmZvcm1hdGlvbiA9IHsga0NNVGltZUludmFsaWQsIGtDTVRpbWVJbnZhbGlk LCBrQ01UaW1lSW52YWxpZCB9OwotCi0gICAgQ01TYW1wbGVCdWZmZXJSZWYgc2FtcGxlQnVmZmVy OwotICAgIHN0YXR1cyA9IENNU2FtcGxlQnVmZmVyQ3JlYXRlUmVhZHlXaXRoSW1hZ2VCdWZmZXIo a0NGQWxsb2NhdG9yRGVmYXVsdCwgaW1hZ2VCdWZmZXIuZ2V0KCksIGZvcm1hdERlc2NyaXB0aW9u LCAmc2FtcGxlVGltaW5nSW5mb3JtYXRpb24sICZzYW1wbGVCdWZmZXIpOwotICAgIENGUmVsZWFz ZShmb3JtYXREZXNjcmlwdGlvbik7CisgICAgQ01TYW1wbGVCdWZmZXJSZWYgc2FtcGxlQnVmZmVy UmF3ID0gbnVsbHB0cjsKKyAgICBzdGF0dXMgPSBDTVNhbXBsZUJ1ZmZlckNyZWF0ZVJlYWR5V2l0 aEltYWdlQnVmZmVyKGtDRkFsbG9jYXRvckRlZmF1bHQsIHBpeGVsQnVmZmVyLmdldCgpLCBmb3Jt YXREZXNjcmlwdGlvbi5nZXQoKSwgJnNhbXBsZVRpbWluZ0luZm9ybWF0aW9uLCAmc2FtcGxlQnVm ZmVyUmF3KTsKICAgICBBU1NFUlQoIXN0YXR1cyk7CisgICAgYXV0byBzYW1wbGVCdWZmZXIgPSBh ZG9wdENGKHNhbXBsZUJ1ZmZlclJhdyk7CiAKLSAgICBhdXRvIHNhbXBsZSA9IGFkb3B0Q0Yoc2Ft cGxlQnVmZmVyKTsKLQotICAgIENGQXJyYXlSZWYgYXR0YWNobWVudHNBcnJheSA9IENNU2FtcGxl QnVmZmVyR2V0U2FtcGxlQXR0YWNobWVudHNBcnJheShzYW1wbGUuZ2V0KCksIHRydWUpOwotICAg IGZvciAoQ0ZJbmRleCBpID0gMDsgaSA8IENGQXJyYXlHZXRDb3VudChhdHRhY2htZW50c0FycmF5 KTsgKytpKSB7CisgICAgQ0ZBcnJheVJlZiBhdHRhY2htZW50c0FycmF5ID0gQ01TYW1wbGVCdWZm ZXJHZXRTYW1wbGVBdHRhY2htZW50c0FycmF5KHNhbXBsZUJ1ZmZlci5nZXQoKSwgdHJ1ZSk7Cisg ICAgZm9yIChDRkluZGV4IGkgPSAwLCBjb3VudCA9IENGQXJyYXlHZXRDb3VudChhdHRhY2htZW50 c0FycmF5KTsgaSA8IGNvdW50OyArK2kpIHsKICAgICAgICAgQ0ZNdXRhYmxlRGljdGlvbmFyeVJl ZiBhdHRhY2htZW50cyA9IGNoZWNrZWRfY2ZfY2FzdDxDRk11dGFibGVEaWN0aW9uYXJ5UmVmPihD RkFycmF5R2V0VmFsdWVBdEluZGV4KGF0dGFjaG1lbnRzQXJyYXksIGkpKTsKICAgICAgICAgQ0ZE aWN0aW9uYXJ5U2V0VmFsdWUoYXR0YWNobWVudHMsIGtDTVNhbXBsZUF0dGFjaG1lbnRLZXlfRGlz cGxheUltbWVkaWF0ZWx5LCBrQ0ZCb29sZWFuVHJ1ZSk7CiAgICAgfQotICAgIHJldHVybiBjcmVh dGUoc2FtcGxlLmdldCgpKTsKKyAgICByZXR1cm4gY3JlYXRlKHNhbXBsZUJ1ZmZlci5nZXQoKSk7 CiB9CiAKIE1lZGlhVGltZSBNZWRpYVNhbXBsZUFWRk9iakM6OnByZXNlbnRhdGlvblRpbWUoKSBj b25zdAo=