214554 2020-07-20 08:44:31 -0700 [GTK] WebKitSettings:enable-private-browsing missing G_PARAM_DEPRECATED 2020-07-21 07:00:57 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro berto bugs-noreply cgarcia ews-watchlist gustavo mcatanzaro oldest_to_newest 1673083 0 mcatanzaro 2020-07-20 08:44:31 -0700 WebKitSettings:enable-private-browsing is missing G_PARAM_DEPRECATED 1673084 1 404717 mcatanzaro 2020-07-20 08:45:40 -0700 Created attachment 404717 Patch 1673085 2 mcatanzaro 2020-07-20 08:46:12 -0700 Style checker won't like this, since the existing code doesn't follow WebKit code style, but I figure reindenting it to change one line is probably overkill. 1673086 3 ews-watchlist 2020-07-20 08:46:41 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1673385 4 404717 cgarcia 2020-07-20 23:58:06 -0700 Comment on attachment 404717 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404717&action=review > Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:957 > + readWriteConstructParamFlags | G_PARAM_DEPRECATED)); You need a cast here. This doesn't build. 1673423 5 mcatanzaro 2020-07-21 06:03:52 -0700 (In reply to Carlos Garcia Campos from comment #4) > You need a cast here. This doesn't build. That's what I thought, but I tried without just to see, and it built for me, so I didn't use it. Maybe the cast is no longer required with GCC 10. I tested again just now to be certain, and it really builds fine for me without the cast.... 1673425 6 404813 mcatanzaro 2020-07-21 06:06:57 -0700 Created attachment 404813 Patch for landing 1673437 7 ews-feeder 2020-07-21 07:00:56 -0700 Committed r264653: <https://trac.webkit.org/changeset/264653> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404813. 404717 2020-07-20 08:45:40 -0700 2020-07-21 06:06:55 -0700 Patch bug-214554-20200720104539.patch text/plain 1575 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU5NjJhZGY3NTAwYWYxM2Ey ZmRmOWY4YWEyOWZkMzhmZGFhMDkyNTguLmNlZjgwMmJmMGRkYmNlOTJkZGI2YWI3ODQ5ZWRiNGJl Nzk5MTE0OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDctMjAgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW0dUS10gV2ViS2l0 U2V0dGluZ3M6ZW5hYmxlLXByaXZhdGUtYnJvd3NpbmcgbWlzc2luZyBHX1BBUkFNX0RFUFJFQ0FU RUQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDU1 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9nbGliL1dlYktpdFNldHRpbmdzLmNwcDoKKyAgICAgICAgKHdlYmtpdF9zZXR0 aW5nc19jbGFzc19pbml0KToKKwogMjAyMC0wNy0xOCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1 ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNjQ1NjMu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRTZXR0 aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRTZXR0aW5n cy5jcHAKaW5kZXggNmY1MWM4NWM1ZTU0ZDBmZWY4NDI0MTMzZTBmMWE0ZTE5ODk3YmFmYy4uNGMz Yjg1ODhmMDY5MmUyNzI1MDc1MjUxYzgwOGM3YWQ5ODMxNjFjZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFNldHRpbmdzLmNwcApAQCAtOTU0LDcg Kzk1NCw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9zZXR0aW5nc19jbGFzc19pbml0KFdlYktpdFNl dHRpbmdzQ2xhc3MqIGtsYXNzKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXygiRW5hYmxlIHByaXZhdGUgYnJvd3NpbmciKSwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIldo ZXRoZXIgdG8gZW5hYmxlIHByaXZhdGUgYnJvd3NpbmciKSwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZBTFNFLAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVhZFdyaXRlQ29u c3RydWN0UGFyYW1GbGFncykpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcmVhZFdyaXRlQ29uc3RydWN0UGFyYW1GbGFncyB8IEdfUEFS QU1fREVQUkVDQVRFRCkpOwogI2VuZGlmCiAKICAgICAvKioK 404813 2020-07-21 06:06:57 -0700 2020-07-21 07:00:56 -0700 Patch for landing bug-214554-20200721080657.patch text/plain 1613 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU2ODUzZDllNTBhZjY0ZGU5 YTgyZGNmZDk1ZTI4ODMyYjBiMmQ0YjYuLjk3YTY3MGQ3OWYzZjExZmJjZWQzNmUxMjAxZTEzMmFm YmFkMDY3NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDctMjEgIE1pY2hhZWwg Q2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW0dUS10gV2ViS2l0 U2V0dGluZ3M6ZW5hYmxlLXByaXZhdGUtYnJvd3NpbmcgbWlzc2luZyBHX1BBUkFNX0RFUFJFQ0FU RUQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDU1 NAorCisgICAgICAgIFJldmlld2VkIGJ5IENhcmxvcyBHYXJjaWEgQ2FtcG9zLgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFNldHRpbmdzLmNwcDoKKyAgICAgICAgKHdlYmtp dF9zZXR0aW5nc19jbGFzc19pbml0KToKKwogMjAyMC0wNy0yMSAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUHJlcGFyZSB1bml0IHRl c3RzIGZvciBHVEs0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xp Yi9XZWJLaXRTZXR0aW5ncy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9X ZWJLaXRTZXR0aW5ncy5jcHAKaW5kZXggNmY1MWM4NWM1ZTU0ZDBmZWY4NDI0MTMzZTBmMWE0ZTE5 ODk3YmFmYy4uYjdmOWEwOWJjMTRiMjZkMDE1NDE3ODk5MWVmNGExYTI5M2I4OTFmOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0U2V0dGluZ3MuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFNldHRpbmdzLmNw cApAQCAtOTU0LDcgKzk1NCw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF9zZXR0aW5nc19jbGFzc19p bml0KFdlYktpdFNldHRpbmdzQ2xhc3MqIGtsYXNzKQogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXygiRW5hYmxlIHByaXZhdGUgYnJvd3Np bmciKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIF8oIldoZXRoZXIgdG8gZW5hYmxlIHByaXZhdGUgYnJvd3NpbmciKSwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEZBTFNFLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cmVhZFdyaXRlQ29uc3RydWN0UGFyYW1GbGFncykpOworICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8R1BhcmFtRmxhZ3M+ KHJlYWRXcml0ZUNvbnN0cnVjdFBhcmFtRmxhZ3MgfCBHX1BBUkFNX0RFUFJFQ0FURUQpKSk7CiAj ZW5kaWYKIAogICAgIC8qKgo=