214553 2020-07-20 08:17:18 -0700 [webkitpy] Build with arm64e when on Apple Internal 2020-07-20 11:12:54 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari 13 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ews-watchlist glenn thorton webkit-bug-importer oldest_to_newest 1673078 0 jbedard 2020-07-20 08:17:18 -0700 Apple Internal builds should consider the runtime architecture arm64, but should build with arm64e. 1673080 1 jbedard 2020-07-20 08:17:31 -0700 <rdar://problem/65745597> 1673081 2 404716 jbedard 2020-07-20 08:30:42 -0700 Created attachment 404716 Patch 1673094 3 404716 aakash_jain 2020-07-20 09:14:24 -0700 Comment on attachment 404716 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404716&action=review > Tools/Scripts/webkitpy/port/mac.py:79 > + architecture = 'arm64e' Might be a good idea to add a comment here about why are we doing this. Also it might be better to modify architecture() method to return the architecture accordingly, rather than hacking this function. > Tools/Scripts/webkitpy/port/mac.py:80 > + return ['ARCHS=i386'] if architecture == 'x86' else ['ARCHS={}'.format(architecture)] Can we convert this to multi-line if else for better readability? 1673103 4 404716 jbedard 2020-07-20 09:33:06 -0700 Comment on attachment 404716 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404716&action=review >> Tools/Scripts/webkitpy/port/mac.py:79 >> + architecture = 'arm64e' > > Might be a good idea to add a comment here about why are we doing this. > Also it might be better to modify architecture() method to return the architecture accordingly, rather than hacking this function. Modifying architecture() is the wrong thing to do, since we only want arm64e for build-time. The runtime architecture should still be thought of as arm64. 1673109 5 404722 jbedard 2020-07-20 09:48:00 -0700 Created attachment 404722 Patch 1673124 6 404722 thorton 2020-07-20 10:35:18 -0700 Comment on attachment 404722 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404722&action=review > Tools/Scripts/webkitpy/port/mac.py:78 > + # The Internal SDK should always prefer arm64e binaries to arm64 ones Weird double space between "binaries" and "to" 1673130 7 404726 jbedard 2020-07-20 10:44:42 -0700 Created attachment 404726 Patch for landing 1673143 8 ews-feeder 2020-07-20 11:12:53 -0700 Committed r264605: <https://trac.webkit.org/changeset/264605> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404726. 404716 2020-07-20 08:30:42 -0700 2020-07-20 09:47:58 -0700 Patch bug-214553-20200720083042.patch text/plain 1431 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDYwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA3LTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIEJ1aWxkIHdpdGggYXJtNjRlIHdoZW4gb24gQXBwbGUg SW50ZXJuYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxNDU1MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjU3NDU1OTc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Bv cnQvbWFjLnB5OgorICAgICAgICAoTWFjUG9ydC5fYnVpbGRfZHJpdmVyX2ZsYWdzKTogVXNlIGFy bTY0ZSBpbnN0ZWFkIG9mIGFybTY0IGZvciBJbnRlcm5hbCBidWlsZHMuCisKIDIwMjAtMDctMjAg IFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtGbGF0 cGFrIFNES10gVXBkYXRlIHRvIEZETyAxOS4wOC4xMiByZWxlYXNlCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9tYWMucHkJKHJldmlzaW9uIDI2NDYwMSkKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9tYWMucHkJKHdvcmtpbmcgY29weSkKQEAgLTc0LDcgKzc0LDEwIEBAIGNsYXNz IE1hY1BvcnQoRGFyd2luUG9ydCk6CiAgICAgICAgIHJldHVybiByZXN1bHQKIAogICAgIGRlZiBf YnVpbGRfZHJpdmVyX2ZsYWdzKHNlbGYpOgotICAgICAgICByZXR1cm4gWydBUkNIUz1pMzg2J10g aWYgc2VsZi5hcmNoaXRlY3R1cmUoKSA9PSAneDg2JyBlbHNlIFsnQVJDSFM9e30nLmZvcm1hdChz ZWxmLmFyY2hpdGVjdHVyZSgpKV0KKyAgICAgICAgYXJjaGl0ZWN0dXJlID0gc2VsZi5hcmNoaXRl Y3R1cmUoKQorICAgICAgICBpZiBhcmNoaXRlY3R1cmUgPT0gJ2FybTY0JyBhbmQgYXBwbGVfYWRk aXRpb25zKCk6CisgICAgICAgICAgICBhcmNoaXRlY3R1cmUgPSAnYXJtNjRlJworICAgICAgICBy ZXR1cm4gWydBUkNIUz1pMzg2J10gaWYgYXJjaGl0ZWN0dXJlID09ICd4ODYnIGVsc2UgWydBUkNI Uz17fScuZm9ybWF0KGFyY2hpdGVjdHVyZSldCiAKICAgICBkZWYgZGVmYXVsdF9iYXNlbGluZV9z ZWFyY2hfcGF0aChzZWxmLCAqKmt3YXJncyk6CiAgICAgICAgIHZlcnNpb25zX3RvX2ZhbGxiYWNr ID0gW10K 404722 2020-07-20 09:48:00 -0700 2020-07-20 10:44:39 -0700 Patch bug-214553-20200720094759.patch text/plain 1536 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDYwMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA3LTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIEJ1aWxkIHdpdGggYXJtNjRlIHdoZW4gb24gQXBwbGUg SW50ZXJuYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxNDU1MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjU3NDU1OTc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Bv cnQvbWFjLnB5OgorICAgICAgICAoTWFjUG9ydC5fYnVpbGRfZHJpdmVyX2ZsYWdzKTogVXNlIGFy bTY0ZSBpbnN0ZWFkIG9mIGFybTY0IGZvciBJbnRlcm5hbCBidWlsZHMuCisKIDIwMjAtMDctMjAg IFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtGbGF0 cGFrIFNES10gVXBkYXRlIHRvIEZETyAxOS4wOC4xMiByZWxlYXNlCkluZGV4OiBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9tYWMucHkJKHJldmlzaW9uIDI2NDYwMSkKKysrIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9tYWMucHkJKHdvcmtpbmcgY29weSkKQEAgLTc0LDcgKzc0LDEzIEBAIGNsYXNz IE1hY1BvcnQoRGFyd2luUG9ydCk6CiAgICAgICAgIHJldHVybiByZXN1bHQKIAogICAgIGRlZiBf YnVpbGRfZHJpdmVyX2ZsYWdzKHNlbGYpOgotICAgICAgICByZXR1cm4gWydBUkNIUz1pMzg2J10g aWYgc2VsZi5hcmNoaXRlY3R1cmUoKSA9PSAneDg2JyBlbHNlIFsnQVJDSFM9e30nLmZvcm1hdChz ZWxmLmFyY2hpdGVjdHVyZSgpKV0KKyAgICAgICAgYXJjaGl0ZWN0dXJlID0gc2VsZi5hcmNoaXRl Y3R1cmUoKQorICAgICAgICAjIFRoZSBJbnRlcm5hbCBTREsgc2hvdWxkIGFsd2F5cyBwcmVmZXIg YXJtNjRlIGJpbmFyaWVzICB0byBhcm02NCBvbmVzCisgICAgICAgIGlmIGFyY2hpdGVjdHVyZSA9 PSAnYXJtNjQnIGFuZCBhcHBsZV9hZGRpdGlvbnMoKToKKyAgICAgICAgICAgIGFyY2hpdGVjdHVy ZSA9ICdhcm02NGUnCisgICAgICAgIGlmIGFyY2hpdGVjdHVyZSA9PSAneDg2JzoKKyAgICAgICAg ICAgIHJldHVybiBbJ0FSQ0hTPWkzODYnXQorICAgICAgICByZXR1cm4gWydBUkNIUz17fScuZm9y bWF0KGFyY2hpdGVjdHVyZSldCiAKICAgICBkZWYgZGVmYXVsdF9iYXNlbGluZV9zZWFyY2hfcGF0 aChzZWxmLCAqKmt3YXJncyk6CiAgICAgICAgIHZlcnNpb25zX3RvX2ZhbGxiYWNrID0gW10K 404726 2020-07-20 10:44:42 -0700 2020-07-20 11:12:54 -0700 Patch for landing bug-214553-20200720104440.patch text/plain 1519 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDYwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA3LTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIEJ1aWxkIHdpdGggYXJtNjRlIHdoZW4gb24gQXBwbGUg SW50ZXJuYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxNDU1MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjU3NDU1OTc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9t YWMucHk6CisgICAgICAgIChNYWNQb3J0Ll9idWlsZF9kcml2ZXJfZmxhZ3MpOiBVc2UgYXJtNjRl IGluc3RlYWQgb2YgYXJtNjQgZm9yIEludGVybmFsIGJ1aWxkcy4KKwogMjAyMC0wNy0yMCAgQWxl eCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBs b2NrIGljb24gdG8gTWluaUJyb3dzZXIKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC9tYWMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5w eQkocmV2aXNpb24gMjY0NjA0KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5w eQkod29ya2luZyBjb3B5KQpAQCAtNzQsNyArNzQsMTMgQEAgY2xhc3MgTWFjUG9ydChEYXJ3aW5Q b3J0KToKICAgICAgICAgcmV0dXJuIHJlc3VsdAogCiAgICAgZGVmIF9idWlsZF9kcml2ZXJfZmxh Z3Moc2VsZik6Ci0gICAgICAgIHJldHVybiBbJ0FSQ0hTPWkzODYnXSBpZiBzZWxmLmFyY2hpdGVj dHVyZSgpID09ICd4ODYnIGVsc2UgWydBUkNIUz17fScuZm9ybWF0KHNlbGYuYXJjaGl0ZWN0dXJl KCkpXQorICAgICAgICBhcmNoaXRlY3R1cmUgPSBzZWxmLmFyY2hpdGVjdHVyZSgpCisgICAgICAg ICMgVGhlIEludGVybmFsIFNESyBzaG91bGQgYWx3YXlzIHByZWZlciBhcm02NGUgYmluYXJpZXMg dG8gYXJtNjQgb25lcworICAgICAgICBpZiBhcmNoaXRlY3R1cmUgPT0gJ2FybTY0JyBhbmQgYXBw bGVfYWRkaXRpb25zKCk6CisgICAgICAgICAgICBhcmNoaXRlY3R1cmUgPSAnYXJtNjRlJworICAg ICAgICBpZiBhcmNoaXRlY3R1cmUgPT0gJ3g4Nic6CisgICAgICAgICAgICByZXR1cm4gWydBUkNI Uz1pMzg2J10KKyAgICAgICAgcmV0dXJuIFsnQVJDSFM9e30nLmZvcm1hdChhcmNoaXRlY3R1cmUp XQogCiAgICAgZGVmIGRlZmF1bHRfYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZiwgKiprd2FyZ3Mp OgogICAgICAgICB2ZXJzaW9uc190b19mYWxsYmFjayA9IFtdCg==