214549 2020-07-20 04:31:06 -0700 Some classes have final destructors but are non-final 2020-07-20 06:42:13 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez achristensen cdumez cgarcia clopez darin webkit-bug-importer youennf oldest_to_newest 1673028 0 aperez 2020-07-20 04:31:06 -0700 ../Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.h:68:30: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class] ~WebSWServerConnection() final; ^ 1673029 1 aperez 2020-07-20 04:33:09 -0700 Also WebMessagePortChannelProvider: ../Source/WebKit/WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h:39:38: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class] ~WebMessagePortChannelProvider() final; ^ 1673030 2 404710 aperez 2020-07-20 04:37:45 -0700 Created attachment 404710 Patch 1673046 3 ews-feeder 2020-07-20 06:41:57 -0700 Committed r264598: <https://trac.webkit.org/changeset/264598> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404710. 1673047 4 webkit-bug-importer 2020-07-20 06:42:13 -0700 <rdar://problem/65822676> 404710 2020-07-20 04:37:45 -0700 2020-07-20 06:41:58 -0700 Patch bug-214549-20200720143743.patch text/plain 2553 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVkZDExZDcxZmUxNzY0NTJh NmEyMjJkMzA3ZjQ3ZThhYzYyMTExNmIuLjM3OWRkMzM4OGM1MmRkZmFlNmYyYjA0YmU2YTA0ZWVi YzBmNDYzN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDctMjAgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBTb21lIGNsYXNz ZXMgaGF2ZSBmaW5hbCBkZXN0cnVjdG9ycyBidXQgYXJlIG5vbi1maW5hbAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0NTQ5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4K KworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvV2ViU1dTZXJ2ZXJDb25u ZWN0aW9uLmg6IE1hcmsgV2ViU1dTZXJ2ZXJDb25uZWN0aW9uCisgICAgICAgIGNsYXNzIGFzIGZp bmFsLgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViTWVzc2FnZVBvcnRD aGFubmVsUHJvdmlkZXIuaDogRGl0dG8uCisKIDIwMjAtMDctMjAgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIHZhbGdyaW5kIGNsYWltcyB1bmlu aXRpYWxpemVkIG1lbW9yeSB3aGVuIG9wZW5pbmcgaW5zcGVjdG9yIChXZWJLaXQ6Okluc3BlY3Rv ckJyb3dzZXJBZ2VudDo6ZW5hYmxlKFdURjo6U3RyaW5nJikpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvV2ViU1dTZXJ2ZXJDb25uZWN0aW9u LmggYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1NlcnZpY2VXb3JrZXIvV2ViU1dTZXJ2 ZXJDb25uZWN0aW9uLmgKaW5kZXggYzgzMzcwMWMxODhiOGFlNDU2ZDRiM2QxMDc0MDU3ZDk2Njk4 MWRjNS4uMDUwODhhYmMzYzgzNDY4OGJlMjgwOTg2ODA2OWRjZmU3NjA4N2QwMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9TZXJ2aWNlV29ya2VyL1dlYlNXU2VydmVy Q29ubmVjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvU2VydmljZVdv cmtlci9XZWJTV1NlcnZlckNvbm5lY3Rpb24uaApAQCAtNjEsNyArNjEsNyBAQCBjbGFzcyBOZXR3 b3JrUHJvY2VzczsKIGNsYXNzIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjsKIGNsYXNzIFNlcnZpY2VX b3JrZXJGZXRjaFRhc2s7CiAKLWNsYXNzIFdlYlNXU2VydmVyQ29ubmVjdGlvbiA6IHB1YmxpYyBX ZWJDb3JlOjpTV1NlcnZlcjo6Q29ubmVjdGlvbiwgcHVibGljIElQQzo6TWVzc2FnZVNlbmRlciwg cHVibGljIElQQzo6TWVzc2FnZVJlY2VpdmVyIHsKK2NsYXNzIFdlYlNXU2VydmVyQ29ubmVjdGlv biBmaW5hbCA6IHB1YmxpYyBXZWJDb3JlOjpTV1NlcnZlcjo6Q29ubmVjdGlvbiwgcHVibGljIElQ Qzo6TWVzc2FnZVNlbmRlciwgcHVibGljIElQQzo6TWVzc2FnZVJlY2VpdmVyIHsKIHB1YmxpYzoK ICAgICBXZWJTV1NlcnZlckNvbm5lY3Rpb24oTmV0d29ya1Byb2Nlc3MmLCBXZWJDb3JlOjpTV1Nl cnZlciYsIElQQzo6Q29ubmVjdGlvbiYsIFdlYkNvcmU6OlByb2Nlc3NJZGVudGlmaWVyKTsKICAg ICBXZWJTV1NlcnZlckNvbm5lY3Rpb24oY29uc3QgV2ViU1dTZXJ2ZXJDb25uZWN0aW9uJikgPSBk ZWxldGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvV2ViTWVzc2FnZVBvcnRDaGFubmVsUHJvdmlkZXIuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJNZXNzYWdlUG9ydENoYW5uZWxQcm92aWRlci5oCmluZGV4 IGE2MDEzNmU5N2I1NDdiYjNlMjBiNDI0OWQ3MGRhN2MyN2RkMGFjZTQuLmIwZTg3MTNkMjYwZmY4 NDI1MmU3M2U3ZjNmODc1YjVlNjkxYTIyNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJNZXNzYWdlUG9ydENoYW5uZWxQcm92aWRlci5oCisr KyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJNZXNzYWdlUG9y dENoYW5uZWxQcm92aWRlci5oCkBAIC0yOSw3ICsyOSw3IEBACiAKIG5hbWVzcGFjZSBXZWJLaXQg ewogCi1jbGFzcyBXZWJNZXNzYWdlUG9ydENoYW5uZWxQcm92aWRlciA6IHB1YmxpYyBXZWJDb3Jl OjpNZXNzYWdlUG9ydENoYW5uZWxQcm92aWRlciB7CitjbGFzcyBXZWJNZXNzYWdlUG9ydENoYW5u ZWxQcm92aWRlciBmaW5hbCA6IHB1YmxpYyBXZWJDb3JlOjpNZXNzYWdlUG9ydENoYW5uZWxQcm92 aWRlciB7CiAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgc3RhdGlj IFdlYk1lc3NhZ2VQb3J0Q2hhbm5lbFByb3ZpZGVyJiBzaW5nbGV0b24oKTsK