214540 2020-07-19 19:23:35 -0700 Use forward template declarations for ColorComponents instead of including ColorComponents.h 2020-07-20 01:38:17 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii darin don.olmstead ross.kirsling sam webkit-bug-importer oldest_to_newest 1672977 0 fujii 2020-07-19 19:23:35 -0700 Use forward template declarations for ColorComponents instead of including ColorComponents.h r264289 isn't a right fix. (In reply to Darin Adler from bug #214204 comment #20) > I’m not sure moving the include to the header was the best fix. We might > have been able to just forward declare in the header and include only in the > files that were using that template. 1672978 1 404692 fujii 2020-07-19 19:29:57 -0700 Created attachment 404692 Patch 1672980 2 404692 darin 2020-07-19 19:34:10 -0700 Comment on attachment 404692 Patch Let's wait for EWS results. 1672991 3 fujii 2020-07-19 23:11:44 -0700 Yup. All EWS are green. And, I confirmed WinCairo non-unified builds using Clang is fine. 1672999 4 404692 fujii 2020-07-20 01:37:30 -0700 Comment on attachment 404692 Patch Clearing flags on attachment: 404692 Committed r264593: <https://trac.webkit.org/changeset/264593> 1673000 5 fujii 2020-07-20 01:37:33 -0700 All reviewed patches have been landed. Closing bug. 1673001 6 webkit-bug-importer 2020-07-20 01:38:17 -0700 <rdar://problem/65813423> 404692 2020-07-19 19:29:57 -0700 2020-07-20 01:37:30 -0700 Patch bug-214540-20200720112956.patch text/plain 1838 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGExYzAyMmUwNDNmY2Mx MTdmZjlhNjEyOWRiNDMwN2IyOTA5MGQ4ZC4uNmU2NTdjNjczODVkODhmY2UzYzUzODFkYjVhZWFh Yjk5YTY1M2U2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA3LTE5ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFVzZSBmb3J3 YXJkIHRlbXBsYXRlIGRlY2xhcmF0aW9ucyBmb3IgQ29sb3JDb21wb25lbnRzIGluc3RlYWQgb2Yg aW5jbHVkaW5nIENvbG9yQ29tcG9uZW50cy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ1NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0NvbG9yTWF0cml4Lmg6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3JUeXBlcy5oOgorCiAyMDIwLTA3LTE5ICBG dWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJldmVydGluZyByMjY0NTg4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvQ29sb3JNYXRyaXguaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0NvbG9yTWF0cml4LmgKaW5kZXggZTIzMTNmNDExOWFjNTIwN2JkZWRjMzMwOTg2ODdl MjkzNWM5MTY1Ny4uODJlOGQ0OGIwYjczMzMxYzI0ODQ0NWViYmUxZTUxNzRmYjM3ZThmMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29sb3JNYXRyaXguaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db2xvck1hdHJpeC5oCkBAIC0y NSwxMiArMjUsMTMgQEAKIAogI3ByYWdtYSBvbmNlCiAKLSNpbmNsdWRlICJDb2xvckNvbXBvbmVu dHMuaCIKICNpbmNsdWRlIDxtYXRoLmg+CiAjaW5jbHVkZSA8d3RmL01hdGhFeHRyYXMuaD4KIAog bmFtZXNwYWNlIFdlYkNvcmUgewogCit0ZW1wbGF0ZTx0eXBlbmFtZT4gc3RydWN0IENvbG9yQ29t cG9uZW50czsKKwogdGVtcGxhdGU8c2l6ZV90IENvbHVtbnMsIHNpemVfdCBSb3dzPgogY2xhc3Mg Q29sb3JNYXRyaXggewogcHVibGljOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvQ29sb3JUeXBlcy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvQ29sb3JUeXBlcy5oCmluZGV4IDkyNDIzZjIyMmY0NGFlZThlYmZkYTQ2MGVhMjA5ODQ5NmIw MzFmNDYuLmUzZDlhOTM1ZjIxZWFjNDlhMWZhZmRiN2RiY2RkOTY3YWIyN2FmOWMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yVHlwZXMuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db2xvclR5cGVzLmgKQEAgLTI1LDExICsy NSwxMSBAQAogCiAjcHJhZ21hIG9uY2UKIAotI2luY2x1ZGUgIkNvbG9yQ29tcG9uZW50cy5oIgog I2luY2x1ZGUgIkNvbG9yU3BhY2UuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCit0ZW1wbGF0 ZTx0eXBlbmFtZT4gc3RydWN0IENvbG9yQ29tcG9uZW50czsKIHRlbXBsYXRlPHR5cGVuYW1lPiBz dHJ1Y3QgQ29tcG9uZW50VHJhaXRzOwogCiB0ZW1wbGF0ZTw+IHN0cnVjdCBDb21wb25lbnRUcmFp dHM8dWludDhfdD4gewo=