214536 2020-07-19 08:06:27 -0700 cpp.py:3688: FutureWarning: Possible nested set at position 101 2020-07-19 12:07:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro darin ews-watchlist glenn jbedard mcatanzaro webkit-bug-importer oldest_to_newest 1672894 0 mcatanzaro 2020-07-19 08:06:27 -0700 $ check-webkit-style /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py:110: FutureWarning: Possible nested set at position 1 EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]') /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:3688: FutureWarning: Possible nested set at position 101 check_identifier_name_in_declaration(filename, line_number, line, file_state, error) /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:3688: FutureWarning: Possible nested set at position 73 check_identifier_name_in_declaration(filename, line_number, line, file_state, error) Total errors found: 0 in 5 files First warning is bug #214531. Let's fix the others here. Seems the warning was added in https://bugs.python.org/issue30349 and all we need to do is escape [ when used inside a set. That is, we have to change "[[" to "[\[". That was a little hard to figure out because the warning message points to the wrong line... the issue is on line 3780, not line 3688. 1672895 1 404670 mcatanzaro 2020-07-19 08:08:04 -0700 Created attachment 404670 Patch 1672896 2 mcatanzaro 2020-07-19 08:09:32 -0700 (BTW, the warning means this code will break in a future version of python if we do not add the escape. The escape will maintain current behavior going forward.) 1672936 3 ews-feeder 2020-07-19 12:06:27 -0700 Committed r264581: <https://trac.webkit.org/changeset/264581> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404670. 1672937 4 webkit-bug-importer 2020-07-19 12:07:15 -0700 <rdar://problem/65794323> 404670 2020-07-19 08:08:04 -0700 2020-07-19 12:06:28 -0700 Patch bug-214536-20200719100803.patch text/plain 1876 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NTc2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmUwZDg0OWJlZmFmOGJiZTUzZmI2ZmY3N2FhMDQ4OGE2 NTJhNzIyNC4uOTYzZWJiOTQ5M2MxOTcxZmE3YzI2NjQ4ZDdiNzhmYTVkZjNmMTQwZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIwLTA3LTE5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn PgorCisgICAgICAgIGNwcC5weTozNjg4OiBGdXR1cmVXYXJuaW5nOiBQb3NzaWJsZSBuZXN0ZWQg c2V0IGF0IHBvc2l0aW9uIDEwMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE0NTM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIHdhcm5pbmcgd2FzIGFkZGVkIGluIGh0dHBzOi8vYnVncy5weXRob24u b3JnL2lzc3VlMzAzNDkuIFdlIG5lZWQgdG8gZXNjYXBlIFsgd2hlbiB1c2VkCisgICAgICAgIGlu c2lkZSBhIHNldC4gVGhhdCBpcywgd2UgaGF2ZSB0byBjaGFuZ2UgIltbIiB0byAiW1xbIi4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAg ICAoY2hlY2tfaWRlbnRpZmllcl9uYW1lX2luX2RlY2xhcmF0aW9uKToKKwogMjAyMC0wNy0xNyAg U2FtIFdlaW5pZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGZpbmFsIHZl c3RpZ2F0ZXMgb2YgU2ltcGxlQ29sb3IKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9j aGVja2Vycy9jcHAucHkKaW5kZXggZjQ5ZjJiNjU3M2QzMDdlYmIyYTgzOWIzZjlhNjU4YjUxNGFm ZGM4Zi4uNDM2M2EwOTlhMDVlMzI3ZDlhOTU2ZmI0MGFmZmRmODI0Y2JkOWRmOSAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKQEAgLTM3NzcsNyArMzc3 Nyw3IEBAIGRlZiBjaGVja19pZGVudGlmaWVyX25hbWVfaW5fZGVjbGFyYXRpb24oZmlsZW5hbWUs IGxpbmVfbnVtYmVyLCBsaW5lLCBmaWxlX3N0YXRlCiAgICAgdHlwZV9yZWdleHAgPSByJ1x3KFtc d118XHMqWyomXVxzKnw6OikrJwogICAgIGlkZW50aWZpZXJfcmVnZXhwID0gcicoP1A8aWRlbnRp Zmllcj5bXHc6XSspJwogICAgIG1heWJlX2JpdGZpZWxkX3JlZ2V4cCA9IHInKDpccypcZCtccyop PycKLSAgICBjaGFyYWN0ZXJfYWZ0ZXJfaWRlbnRpZmllcl9yZWdleHAgPSByJyg/UDxjaGFyYWN0 ZXJfYWZ0ZXJfaWRlbnRpZmllcj5bWzsoKT0sXSkoPyE9KScKKyAgICBjaGFyYWN0ZXJfYWZ0ZXJf aWRlbnRpZmllcl9yZWdleHAgPSByJyg/UDxjaGFyYWN0ZXJfYWZ0ZXJfaWRlbnRpZmllcj5bXFs7 KCk9LF0pKD8hPSknCiAgICAgZGVjbGFyYXRpb25fd2l0aG91dF90eXBlX3JlZ2V4cCA9IHInXHMq JyArIGlkZW50aWZpZXJfcmVnZXhwICsgcidccyonICsgbWF5YmVfYml0ZmllbGRfcmVnZXhwICsg Y2hhcmFjdGVyX2FmdGVyX2lkZW50aWZpZXJfcmVnZXhwCiAgICAgZGVjbGFyYXRpb25fd2l0aF90 eXBlX3JlZ2V4cCA9IHInXHMqJyArIHR5cGVfcmVnZXhwICsgcidccycgKyBkZWNsYXJhdGlvbl93 aXRob3V0X3R5cGVfcmVnZXhwCiAgICAgY29uc3RydWN0b3JfcmVnZXhwID0gcidccyooW1x3X10q OjopKig/UDxwcmVfcGFydD5bXHdfXSspOjooP1A8cG9zdF9wYXJ0Pltcd19dKylbKF0nCg==