214535 2020-07-19 07:27:10 -0700 JSC build scripts should be quiet by default 2020-07-20 13:20:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1672889 0 mcatanzaro 2020-07-19 07:27:10 -0700 Some of our build scripts have started printing "Nothing changed" on successful operation. For example: [354/2150] Generating ../../DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h OffsetExtractor: Nothing changed. [481/2150] Generating ../../DerivedSources/JavaScriptCore/LLIntAssembly.h Offlineasm: Nothing changed. The build logs are nicer if, between 'cmake' and 'cmake install', we only print stuff when there is an actual problem that needs to be investigated. We achieved this long ago (bug #152382) and only a couple changes are needed to get there again. 1672891 1 404669 mcatanzaro 2020-07-19 07:31:58 -0700 Created attachment 404669 Patch 1673203 2 ews-feeder 2020-07-20 13:19:31 -0700 Committed r264616: <https://trac.webkit.org/changeset/264616> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404669. 1673204 3 webkit-bug-importer 2020-07-20 13:20:14 -0700 <rdar://problem/65844029> 404669 2020-07-19 07:31:58 -0700 2020-07-20 13:19:32 -0700 Patch bug-214535-20200719093157.patch text/plain 2719 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm MDllNzZhZTdhNTBmMDA5NWJiNTM4ZTQ2NDEyMGRjMDNiNDUwOGU4Li5jZDIwNDNmNmUyY2FmZDRj NDEzZGIxYjExNmZmOTcyOTFmYjQyMTQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNy0xOSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdu b21lLm9yZz4KKworICAgICAgICBKU0MgYnVpbGQgc2NyaXB0cyBzaG91bGQgYmUgcXVpZXQgYnkg ZGVmYXVsdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjE0NTM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAor ICAgICAgICBUaGVyZSdzIG5vIG5lZWQgZm9yIHRoZXNlIHNjcmlwdHMgdG8gcHJpbnQgIk5vdGhp bmcgY2hhbmdlZCIgd2hlbiB0aGV5IGRvbid0IGRvIGFueXRoaW5nLgorCisgICAgICAgICogb2Zm bGluZWFzbS9hc20ucmI6CisgICAgICAgICogb2ZmbGluZWFzbS9nZW5lcmF0ZV9vZmZzZXRfZXh0 cmFjdG9yLnJiOgorICAgICAgICAqIG9mZmxpbmVhc20vZ2VuZXJhdGVfc2V0dGluZ3NfZXh0cmFj dG9yLnJiOgorCiAyMDIwLTA3LTE5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25v bWUub3JnPgogCiAgICAgICAgIGNwcF9nZW5lcmF0b3IucHk6MTM0OiBTeW50YXhXYXJuaW5nOiAi aXMiIHdpdGggYSBsaXRlcmFsLiBEaWQgeW91IG1lYW4gIj09Ij8KZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2FzbS5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9vZmZsaW5lYXNtL2FzbS5yYgppbmRleCA3MTk5YzVmMDUzYWFlY2M3ZTVlYmMxMzNkNGQ3Yzgz OGRiNDM1Yjk0Li44Yzc3NzU0YmJjYmI3NThhMGVkNzY5OTYzMjhkZTQwYmNiMjk5OGI4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9hc20ucmIKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vYXNtLnJiCkBAIC0zNzUsNyArMzc1LDcgQEAg aWYgRmlsZVRlc3QuZXhpc3Q/IG91dHB1dEZsbm0KICAgICAgICAgfQogICAgIH0KICAgICBpZiBs YXN0TGluZSBhbmQgbGFzdExpbmUgPT0gaW5wdXRIYXNoCi0gICAgICAgICRzdGRlcnIucHV0cyAi T2ZmbGluZWFzbTogTm90aGluZyBjaGFuZ2VkLiIKKyAgICAgICAgIyBOb3RoaW5nIGNoYW5nZWQu CiAgICAgICAgIGV4aXQgMAogICAgIGVuZAogZW5kCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvb2ZmbGluZWFzbS9nZW5lcmF0ZV9vZmZzZXRfZXh0cmFjdG9yLnJiIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vZ2VuZXJhdGVfb2Zmc2V0X2V4dHJhY3Rvci5yYgpp bmRleCAyZDk3NTM1NGM3ZDU2ZmIyYzc1MmI5MTg3MDA4OGE1NWQ0OWMwM2YzLi5kNmQ5ZWY2MWY1 ZjE5YjBiYjlkOTE3MDNlYWE5MTUwNTNmZjhlNjVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvb2ZmbGluZWFzbS9nZW5lcmF0ZV9vZmZzZXRfZXh0cmFjdG9yLnJiCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2dlbmVyYXRlX29mZnNldF9leHRyYWN0b3Iu cmIKQEAgLTY1LDcgKzY1LDcgQEAgaWYgRmlsZVRlc3QuZXhpc3Q/IG91dHB1dEZsbm0KICAgICAg ICAgfCBpbnAgfAogICAgICAgICBmaXJzdExpbmUgPSBpbnAuZ2V0cwogICAgICAgICBpZiBmaXJz dExpbmUgYW5kIGZpcnN0TGluZS5jaG9tcCA9PSBpbnB1dEhhc2gKLSAgICAgICAgICAgICRzdGRl cnIucHV0cyAiT2Zmc2V0RXh0cmFjdG9yOiBOb3RoaW5nIGNoYW5nZWQuIgorICAgICAgICAgICAg IyBOb3RoaW5nIGNoYW5nZWQuCiAgICAgICAgICAgICBleGl0IDAKICAgICAgICAgZW5kCiAgICAg fQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vZ2VuZXJhdGVf c2V0dGluZ3NfZXh0cmFjdG9yLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v Z2VuZXJhdGVfc2V0dGluZ3NfZXh0cmFjdG9yLnJiCmluZGV4IDdmNGNkMTIwZTc2NzE2Njg3YmUz ZWU4ZWI0NjUyZjRiMGQwYzlhZjEuLjQ0OGI0NmU5NTUxNTk1NGRkMTE0Y2I1YmY0ZDRmYjk4MjY3 MDA1YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2dlbmVy YXRlX3NldHRpbmdzX2V4dHJhY3Rvci5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2Zm bGluZWFzbS9nZW5lcmF0ZV9zZXR0aW5nc19leHRyYWN0b3IucmIKQEAgLTQ5LDcgKzQ5LDcgQEAg aWYgRmlsZVRlc3QuZXhpc3Q/IG91dHB1dEZsbm0KICAgICAgICAgfCBpbnAgfAogICAgICAgICBm aXJzdExpbmUgPSBpbnAuZ2V0cwogICAgICAgICBpZiBmaXJzdExpbmUgYW5kIGZpcnN0TGluZS5j aG9tcCA9PSBpbnB1dEhhc2gKLSAgICAgICAgICAgICRzdGRlcnIucHV0cyAiU2V0dGluZ3NFeHRy YWN0b3I6IE5vdGhpbmcgY2hhbmdlZC4iCisgICAgICAgICAgICAjIE5vdGhpbmcgY2hhbmdlZC4K ICAgICAgICAgICAgIGV4aXQgMAogICAgICAgICBlbmQKICAgICB9Cg==