214531 2020-07-19 05:25:13 -0700 pep8.py:110: FutureWarning: Possible nested set at position 1 2020-07-24 17:23:14 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro darin ews-watchlist glenn jbedard mcatanzaro webkit-bug-importer oldest_to_newest 1672873 0 mcatanzaro 2020-07-19 05:25:13 -0700 Let's try to fix this python warning that occurs when running webkit-patch: $ webkit-patch upload /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py:110: FutureWarning: Possible nested set at position 1 EXTRANEOUS_WHITESPACE_REGEX = re.compile(r'[[({] | []}),;:]') Since we don't control the code, we should update to a newer version of pep8. It has been renamed to pycodestyle. I've tested this patch with python3. I think it should work with python2. Let's see if EWS likes it. 1672874 1 mcatanzaro 2020-07-19 05:30:52 -0700 BTW, maybe I'm doing something wrong, but this style checker seems unable to find obvious style errors in our python code even without any of my changes.... 1672875 2 404664 mcatanzaro 2020-07-19 05:31:23 -0700 Created attachment 404664 Patch 1672877 3 mcatanzaro 2020-07-19 06:10:18 -0700 Seems that works. Attaching an alternate patch to see if we can get away with removing pep8 and using pycodestyle also for python2. 1672878 4 404665 mcatanzaro 2020-07-19 06:12:27 -0700 Created attachment 404665 Patch 1672883 5 mcatanzaro 2020-07-19 06:54:43 -0700 *** Bug 209017 has been marked as a duplicate of this bug. *** 1672887 6 mcatanzaro 2020-07-19 07:03:06 -0700 (In reply to Michael Catanzaro from comment #1) > BTW, maybe I'm doing something wrong, but this style checker seems unable to > find obvious style errors in our python code even without any of my > changes.... Apparently I was looking for style rules that we suppress. It actually still works fine if I violate the right rules: $ check-webkit-style ERROR: Source/WebKit/Scripts/generate-message-receiver.py:41: missing whitespace around operator [pep8/E225] [5] ERROR: Source/WebKit/Scripts/generate-message-receiver.py:42: missing whitespace around operator [pep8/E225] [5] ERROR: Source/WebKit/Scripts/generate-message-receiver.py:45: missing whitespace after ',' [pep8/E231] [5] Total errors found: 3 in 3 files Seems good. 1672931 7 ews-feeder 2020-07-19 11:45:12 -0700 Committed r264579: <https://trac.webkit.org/changeset/264579> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404665. 1672932 8 webkit-bug-importer 2020-07-19 11:46:14 -0700 <rdar://problem/65793948> 1674917 9 jbedard 2020-07-24 16:51:00 -0700 Reopening to attach new patch. 1674918 10 405204 jbedard 2020-07-24 16:51:02 -0700 Created attachment 405204 Patch for landing 1674919 11 jbedard 2020-07-24 16:51:49 -0700 (In reply to Jonathan Bedard from comment #10) > Created attachment 405204 [details] > Patch for landing Pep8 was removed from the auto importer, we should remove it from the test as well. 1674925 12 ews-feeder 2020-07-24 17:12:43 -0700 Committed r264872: <https://trac.webkit.org/changeset/264872> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405204. 1674930 13 405204 mcatanzaro 2020-07-24 17:22:35 -0700 Comment on attachment 405204 Patch for landing Good catch! 404664 2020-07-19 05:31:23 -0700 2020-07-19 06:12:25 -0700 Patch bug-214531-20200719073122.patch text/plain 4664 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NTc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmUwZDg0OWJlZmFmOGJiZTUzZmI2ZmY3N2FhMDQ4OGE2 NTJhNzIyNC4uY2MyMTI0MmZiODAyNGZlNzFhMmZkZTk0MGJkNzQzMmFjNDY0YjdlYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIwLTA3LTE5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn PgorCisgICAgICAgIHBlcDgucHk6MTEwOiBGdXR1cmVXYXJuaW5nOiBQb3NzaWJsZSBuZXN0ZWQg c2V0IGF0IHBvc2l0aW9uIDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxNDUzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFVwZGF0ZSBmcm9tIHBlcDggdG8gcHljb2Rlc3R5bGUgaWYgdXNpbmcgcHl0aG9u My4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvcHl0aG9uLnB5 OgorICAgICAgICAoUHl0aG9uQ2hlY2tlci5jaGVjayk6CisgICAgICAgIChQeXRob25DaGVja2Vy Ll9jaGVja19weWNvZGVzdHlsZSk6CisgICAgICAgIChQeXRob25DaGVja2VyLl9jaGVja19weWNv ZGVzdHlsZS5fcHljb2Rlc3R5bGVfaGFuZGxlX2Vycm9yKToKKyAgICAgICAgKFB5dGhvbkNoZWNr ZXIuX2NoZWNrX3BlcDgpOiBEZWxldGVkLgorICAgICAgICAoUHl0aG9uQ2hlY2tlci5fY2hlY2tf cGVwOC5fcGVwOF9oYW5kbGVfZXJyb3IpOiBEZWxldGVkLgorICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weToKKyAgICAgICAgKEF1dG9pbnN0YWxsSW1wb3J0 SG9vay5maW5kX21vZHVsZSk6CisKIDIwMjAtMDctMTcgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBw bGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBmaW5hbCB2ZXN0aWdhdGVzIG9mIFNpbXBsZUNvbG9y CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL3B5dGhv bi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvcHl0aG9uLnB5Cmlu ZGV4IDE3Y2Q5OWQ1MDZlNTFmN2QyNDBiZWVlM2ZkOGYwM2UxYzU0YTc4ZTcuLjlmZjc0N2RiM2M4 YTZmOGQ2M2NjYzU4OTFiYmNlNzM3ZDQ4MzI0ZmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvcHl0aG9uLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvcHl0aG9uLnB5CkBAIC0zMCw4ICszMCwxMCBAQCBmcm9tIHdl YmtpdHB5LmNvbW1vbi5zeXN0ZW0uZmlsZXN5c3RlbSBpbXBvcnQgRmlsZVN5c3RlbQogZnJvbSB3 ZWJraXRweS5jb21tb24udW5pY29kZV9jb21wYXRpYmlsaXR5IGltcG9ydCBTdHJpbmdJTwogZnJv bSB3ZWJraXRweS5jb21tb24uc3lzdGVtLm91dHB1dGNhcHR1cmUgaW1wb3J0IE91dHB1dENhcHR1 cmVTY29wZQogZnJvbSB3ZWJraXRweS5jb21tb24ud2Via2l0X2ZpbmRlciBpbXBvcnQgV2ViS2l0 RmluZGVyCi1mcm9tIHdlYmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxlZCBpbXBvcnQgcGVw OAotCitpZiBzeXMudmVyc2lvbl9pbmZvIDwgKDMsIDApOgorICAgIGZyb20gd2Via2l0cHkudGhp cmRwYXJ0eS5hdXRvaW5zdGFsbGVkIGltcG9ydCBwZXA4IGFzIHB5Y29kZXN0eWxlCitlbHNlOgor ICAgIGZyb20gd2Via2l0cHkudGhpcmRwYXJ0eS5hdXRvaW5zdGFsbGVkIGltcG9ydCBweWNvZGVz dHlsZQogCiBjbGFzcyBQeXRob25DaGVja2VyKG9iamVjdCk6CiAgICAgIiIiUHJvY2Vzc2VzIHRl eHQgbGluZXMgZm9yIGNoZWNraW5nIHN0eWxlLiIiIgpAQCAtNDAsMzIgKzQyLDMyIEBAIGNsYXNz IFB5dGhvbkNoZWNrZXIob2JqZWN0KToKICAgICAgICAgc2VsZi5faGFuZGxlX3N0eWxlX2Vycm9y ID0gaGFuZGxlX3N0eWxlX2Vycm9yCiAKICAgICBkZWYgY2hlY2soc2VsZiwgbGluZXMpOgotICAg ICAgICBzZWxmLl9jaGVja19wZXA4KGxpbmVzKQorICAgICAgICBzZWxmLl9jaGVja19weWNvZGVz dHlsZShsaW5lcykKICAgICAgICAgIyBGSVhNRTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwNDEzMwogICAgICAgICAjIFB5bGludCBjYW4ndCBsaXZlIGhhcHBpbHkg aW4gcHl0aG9uIDIgYW5kIDMgd29ybGQsIHdlIG5lZWQgdG8gcGljayBvbmUKICAgICAgICAgaWYg c3lzLnZlcnNpb25faW5mbyA8ICgzLCAwKToKICAgICAgICAgICAgIHNlbGYuX2NoZWNrX3B5bGlu dChsaW5lcykKIAotICAgIGRlZiBfY2hlY2tfcGVwOChzZWxmLCBsaW5lcyk6Ci0gICAgICAgICMg SW5pdGlhbGl6ZSBwZXA4Lm9wdGlvbnMsIHdoaWNoIGlzIG5lY2Vzc2FyeSBmb3IKKyAgICBkZWYg X2NoZWNrX3B5Y29kZXN0eWxlKHNlbGYsIGxpbmVzKToKKyAgICAgICAgIyBJbml0aWFsaXplIHB5 Y29kZXN0eWxlLm9wdGlvbnMsIHdoaWNoIGlzIG5lY2Vzc2FyeSBmb3IKICAgICAgICAgIyBDaGVj a2VyLmNoZWNrX2FsbCgpIHRvIGV4ZWN1dGUuCi0gICAgICAgIHBlcDgucHJvY2Vzc19vcHRpb25z KGFyZ2xpc3Q9W3NlbGYuX2ZpbGVfcGF0aF0pCisgICAgICAgIHB5Y29kZXN0eWxlLnByb2Nlc3Nf b3B0aW9ucyhhcmdsaXN0PVtzZWxmLl9maWxlX3BhdGhdKQogCi0gICAgICAgIHBlcDhfY2hlY2tl ciA9IHBlcDguQ2hlY2tlcihzZWxmLl9maWxlX3BhdGgpCisgICAgICAgIHB5Y29kZXN0eWxlX2No ZWNrZXIgPSBweWNvZGVzdHlsZS5DaGVja2VyKHNlbGYuX2ZpbGVfcGF0aCkKIAotICAgICAgICBk ZWYgX3BlcDhfaGFuZGxlX2Vycm9yKGxpbmVfbnVtYmVyLCBvZmZzZXQsIHRleHQsIGNoZWNrKToK KyAgICAgICAgZGVmIF9weWNvZGVzdHlsZV9oYW5kbGVfZXJyb3IobGluZV9udW1iZXIsIG9mZnNl dCwgdGV4dCwgY2hlY2spOgogICAgICAgICAgICAgIyBGSVhNRTogSW5jb3Jwb3JhdGUgdGhlIGNo YXJhY3RlciBvZmZzZXQgaW50byB0aGUgZXJyb3Igb3V0cHV0LgogICAgICAgICAgICAgIyAgICAg ICAgVGhpcyB3aWxsIHJlcXVpcmUgdXBkYXRpbmcgdGhlIGVycm9yIGhhbmRsZXIgX19jYWxsX18K ICAgICAgICAgICAgICMgICAgICAgIHNpZ25hdHVyZSB0byBpbmNsdWRlIGFuIG9wdGlvbmFsICJv ZmZzZXQiIHBhcmFtZXRlci4KLSAgICAgICAgICAgIHBlcDhfY29kZSA9IHRleHRbOjRdCi0gICAg ICAgICAgICBwZXA4X21lc3NhZ2UgPSB0ZXh0WzU6XQorICAgICAgICAgICAgcHljb2Rlc3R5bGVf Y29kZSA9IHRleHRbOjRdCisgICAgICAgICAgICBweWNvZGVzdHlsZV9tZXNzYWdlID0gdGV4dFs1 Ol0KIAotICAgICAgICAgICAgY2F0ZWdvcnkgPSAicGVwOC8iICsgcGVwOF9jb2RlCisgICAgICAg ICAgICBjYXRlZ29yeSA9ICJwZXA4LyIgKyBweWNvZGVzdHlsZV9jb2RlCiAKLSAgICAgICAgICAg IHNlbGYuX2hhbmRsZV9zdHlsZV9lcnJvcihsaW5lX251bWJlciwgY2F0ZWdvcnksIDUsIHBlcDhf bWVzc2FnZSkKKyAgICAgICAgICAgIHNlbGYuX2hhbmRsZV9zdHlsZV9lcnJvcihsaW5lX251bWJl ciwgY2F0ZWdvcnksIDUsIHB5Y29kZXN0eWxlX21lc3NhZ2UpCiAKLSAgICAgICAgcGVwOF9jaGVj a2VyLnJlcG9ydF9lcnJvciA9IF9wZXA4X2hhbmRsZV9lcnJvcgotICAgICAgICBwZXA4X2Vycm9y cyA9IHBlcDhfY2hlY2tlci5jaGVja19hbGwoKQorICAgICAgICBweWNvZGVzdHlsZV9jaGVja2Vy LnJlcG9ydF9lcnJvciA9IF9weWNvZGVzdHlsZV9oYW5kbGVfZXJyb3IKKyAgICAgICAgcHljb2Rl c3R5bGVfZXJyb3JzID0gcHljb2Rlc3R5bGVfY2hlY2tlci5jaGVja19hbGwoKQogCiAgICAgZGVm IF9jaGVja19weWxpbnQoc2VsZiwgbGluZXMpOgogICAgICAgICBweWxpbnRlciA9IFB5bGludGVy KCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRf Xy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weQppbmRl eCBkZTY4NzQ3OTFkNzQxMDE5OWJlMDgyNTYwOTg1YTNiNTNlYTIxOTE1Li4zZmZhMzAwYmJiZTJk ZjI3ZDcwYjM0MGIxOWNkNjc1MDNkMjFiZDhjIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90aGlyZHBhcnR5L19faW5pdF9fLnB5CkBAIC05NCw3ICs5NCw3IEBAIGNsYXNzIEF1dG9pbnN0 YWxsSW1wb3J0SG9vayhvYmplY3QpOgogICAgICAgICAjIG9yZGVyIGZvciBhdXRvaW5zdGFsbF9l dmVyeXRoaW5nKCksIGJlbG93LCB0byB3b3JrIHByb3Blcmx5LgogICAgICAgICBpZiAnLm1lY2hh bml6ZScgaW4gZnVsbG5hbWU6CiAgICAgICAgICAgICBzZWxmLl9pbnN0YWxsX21lY2hhbml6ZSgp Ci0gICAgICAgIGVsaWYgJy5wZXA4JyBpbiBmdWxsbmFtZToKKyAgICAgICAgZWxpZiAnLnBlcDgn IGluIGZ1bGxuYW1lIGFuZCBzeXMudmVyc2lvbl9pbmZvIDwgKDMsIDApOgogICAgICAgICAgICAg c2VsZi5faW5zdGFsbF9wZXA4KCkKICAgICAgICAgZWxpZiAnLnB5Y29kZXN0eWxlJyBpbiBmdWxs bmFtZToKICAgICAgICAgICAgIHNlbGYuX2luc3RhbGxfcHljb2Rlc3R5bGUoKQo= 404665 2020-07-19 06:12:27 -0700 2020-07-24 17:23:14 -0700 Patch bug-214531-20200719081226.patch text/plain 5337 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NTc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmUwZDg0OWJlZmFmOGJiZTUzZmI2ZmY3N2FhMDQ4OGE2 NTJhNzIyNC4uNWVlZTFmOTNmYmFlY2JjZmYxMjgxOWJhMjNmOTMwYTdjNjkxMjM3NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIwLTA3LTE5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn PgorCisgICAgICAgIHBlcDgucHk6MTEwOiBGdXR1cmVXYXJuaW5nOiBQb3NzaWJsZSBuZXN0ZWQg c2V0IGF0IHBvc2l0aW9uIDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxNDUzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor ICAgICAgICAKKyAgICAgICAgVXBkYXRlIGZyb20gcGVwOCB0byBweWNvZGVzdHlsZS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvcHl0aG9uLnB5OgorICAgICAg ICAoUHl0aG9uQ2hlY2tlci5jaGVjayk6CisgICAgICAgIChQeXRob25DaGVja2VyLl9jaGVja19w eWNvZGVzdHlsZSk6CisgICAgICAgIChQeXRob25DaGVja2VyLl9jaGVja19weWNvZGVzdHlsZS5f cHljb2Rlc3R5bGVfaGFuZGxlX2Vycm9yKToKKyAgICAgICAgKFB5dGhvbkNoZWNrZXIuX2NoZWNr X3BlcDgpOiBEZWxldGVkLgorICAgICAgICAoUHl0aG9uQ2hlY2tlci5fY2hlY2tfcGVwOC5fcGVw OF9oYW5kbGVfZXJyb3IpOiBEZWxldGVkLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdGhp cmRwYXJ0eS9fX2luaXRfXy5weToKKyAgICAgICAgKEF1dG9pbnN0YWxsSW1wb3J0SG9vay5maW5k X21vZHVsZSk6CisgICAgICAgIChBdXRvaW5zdGFsbEltcG9ydEhvb2suX2luc3RhbGxfa2V5cmlu Zyk6CisgICAgICAgIChBdXRvaW5zdGFsbEltcG9ydEhvb2suX2luc3RhbGxfcGVwOCk6IERlbGV0 ZWQuCisKIDIwMjAtMDctMTcgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbW92ZSBmaW5hbCB2ZXN0aWdhdGVzIG9mIFNpbXBsZUNvbG9yCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL3B5dGhvbi5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvcHl0aG9uLnB5CmluZGV4IDE3Y2Q5OWQ1MDZl NTFmN2QyNDBiZWVlM2ZkOGYwM2UxYzU0YTc4ZTcuLmVjOWUwMjYzMDQ0YWM1M2VlMTZjZTkyNmE0 ZDZiYTQwMTg1NmE3NzMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvcHl0aG9uLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvcHl0aG9uLnB5CkBAIC0zMCw4ICszMCw3IEBAIGZyb20gd2Via2l0cHkuY29tbW9uLnN5 c3RlbS5maWxlc3lzdGVtIGltcG9ydCBGaWxlU3lzdGVtCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi51 bmljb2RlX2NvbXBhdGliaWxpdHkgaW1wb3J0IFN0cmluZ0lPCiBmcm9tIHdlYmtpdHB5LmNvbW1v bi5zeXN0ZW0ub3V0cHV0Y2FwdHVyZSBpbXBvcnQgT3V0cHV0Q2FwdHVyZVNjb3BlCiBmcm9tIHdl YmtpdHB5LmNvbW1vbi53ZWJraXRfZmluZGVyIGltcG9ydCBXZWJLaXRGaW5kZXIKLWZyb20gd2Vi a2l0cHkudGhpcmRwYXJ0eS5hdXRvaW5zdGFsbGVkIGltcG9ydCBwZXA4Ci0KK2Zyb20gd2Via2l0 cHkudGhpcmRwYXJ0eS5hdXRvaW5zdGFsbGVkIGltcG9ydCBweWNvZGVzdHlsZQogCiBjbGFzcyBQ eXRob25DaGVja2VyKG9iamVjdCk6CiAgICAgIiIiUHJvY2Vzc2VzIHRleHQgbGluZXMgZm9yIGNo ZWNraW5nIHN0eWxlLiIiIgpAQCAtNDAsMzIgKzM5LDMyIEBAIGNsYXNzIFB5dGhvbkNoZWNrZXIo b2JqZWN0KToKICAgICAgICAgc2VsZi5faGFuZGxlX3N0eWxlX2Vycm9yID0gaGFuZGxlX3N0eWxl X2Vycm9yCiAKICAgICBkZWYgY2hlY2soc2VsZiwgbGluZXMpOgotICAgICAgICBzZWxmLl9jaGVj a19wZXA4KGxpbmVzKQorICAgICAgICBzZWxmLl9jaGVja19weWNvZGVzdHlsZShsaW5lcykKICAg ICAgICAgIyBGSVhNRTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NDEzMwogICAgICAgICAjIFB5bGludCBjYW4ndCBsaXZlIGhhcHBpbHkgaW4gcHl0aG9uIDIgYW5k IDMgd29ybGQsIHdlIG5lZWQgdG8gcGljayBvbmUKICAgICAgICAgaWYgc3lzLnZlcnNpb25faW5m byA8ICgzLCAwKToKICAgICAgICAgICAgIHNlbGYuX2NoZWNrX3B5bGludChsaW5lcykKIAotICAg IGRlZiBfY2hlY2tfcGVwOChzZWxmLCBsaW5lcyk6Ci0gICAgICAgICMgSW5pdGlhbGl6ZSBwZXA4 Lm9wdGlvbnMsIHdoaWNoIGlzIG5lY2Vzc2FyeSBmb3IKKyAgICBkZWYgX2NoZWNrX3B5Y29kZXN0 eWxlKHNlbGYsIGxpbmVzKToKKyAgICAgICAgIyBJbml0aWFsaXplIHB5Y29kZXN0eWxlLm9wdGlv bnMsIHdoaWNoIGlzIG5lY2Vzc2FyeSBmb3IKICAgICAgICAgIyBDaGVja2VyLmNoZWNrX2FsbCgp IHRvIGV4ZWN1dGUuCi0gICAgICAgIHBlcDgucHJvY2Vzc19vcHRpb25zKGFyZ2xpc3Q9W3NlbGYu X2ZpbGVfcGF0aF0pCisgICAgICAgIHB5Y29kZXN0eWxlLnByb2Nlc3Nfb3B0aW9ucyhhcmdsaXN0 PVtzZWxmLl9maWxlX3BhdGhdKQogCi0gICAgICAgIHBlcDhfY2hlY2tlciA9IHBlcDguQ2hlY2tl cihzZWxmLl9maWxlX3BhdGgpCisgICAgICAgIHB5Y29kZXN0eWxlX2NoZWNrZXIgPSBweWNvZGVz dHlsZS5DaGVja2VyKHNlbGYuX2ZpbGVfcGF0aCkKIAotICAgICAgICBkZWYgX3BlcDhfaGFuZGxl X2Vycm9yKGxpbmVfbnVtYmVyLCBvZmZzZXQsIHRleHQsIGNoZWNrKToKKyAgICAgICAgZGVmIF9w eWNvZGVzdHlsZV9oYW5kbGVfZXJyb3IobGluZV9udW1iZXIsIG9mZnNldCwgdGV4dCwgY2hlY2sp OgogICAgICAgICAgICAgIyBGSVhNRTogSW5jb3Jwb3JhdGUgdGhlIGNoYXJhY3RlciBvZmZzZXQg aW50byB0aGUgZXJyb3Igb3V0cHV0LgogICAgICAgICAgICAgIyAgICAgICAgVGhpcyB3aWxsIHJl cXVpcmUgdXBkYXRpbmcgdGhlIGVycm9yIGhhbmRsZXIgX19jYWxsX18KICAgICAgICAgICAgICMg ICAgICAgIHNpZ25hdHVyZSB0byBpbmNsdWRlIGFuIG9wdGlvbmFsICJvZmZzZXQiIHBhcmFtZXRl ci4KLSAgICAgICAgICAgIHBlcDhfY29kZSA9IHRleHRbOjRdCi0gICAgICAgICAgICBwZXA4X21l c3NhZ2UgPSB0ZXh0WzU6XQorICAgICAgICAgICAgcHljb2Rlc3R5bGVfY29kZSA9IHRleHRbOjRd CisgICAgICAgICAgICBweWNvZGVzdHlsZV9tZXNzYWdlID0gdGV4dFs1Ol0KIAotICAgICAgICAg ICAgY2F0ZWdvcnkgPSAicGVwOC8iICsgcGVwOF9jb2RlCisgICAgICAgICAgICBjYXRlZ29yeSA9 ICJwZXA4LyIgKyBweWNvZGVzdHlsZV9jb2RlCiAKLSAgICAgICAgICAgIHNlbGYuX2hhbmRsZV9z dHlsZV9lcnJvcihsaW5lX251bWJlciwgY2F0ZWdvcnksIDUsIHBlcDhfbWVzc2FnZSkKKyAgICAg ICAgICAgIHNlbGYuX2hhbmRsZV9zdHlsZV9lcnJvcihsaW5lX251bWJlciwgY2F0ZWdvcnksIDUs IHB5Y29kZXN0eWxlX21lc3NhZ2UpCiAKLSAgICAgICAgcGVwOF9jaGVja2VyLnJlcG9ydF9lcnJv ciA9IF9wZXA4X2hhbmRsZV9lcnJvcgotICAgICAgICBwZXA4X2Vycm9ycyA9IHBlcDhfY2hlY2tl ci5jaGVja19hbGwoKQorICAgICAgICBweWNvZGVzdHlsZV9jaGVja2VyLnJlcG9ydF9lcnJvciA9 IF9weWNvZGVzdHlsZV9oYW5kbGVfZXJyb3IKKyAgICAgICAgcHljb2Rlc3R5bGVfZXJyb3JzID0g cHljb2Rlc3R5bGVfY2hlY2tlci5jaGVja19hbGwoKQogCiAgICAgZGVmIF9jaGVja19weWxpbnQo c2VsZiwgbGluZXMpOgogICAgICAgICBweWxpbnRlciA9IFB5bGludGVyKCkKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weQppbmRleCBkZTY4NzQ3OTFkNzQx MDE5OWJlMDgyNTYwOTg1YTNiNTNlYTIxOTE1Li5kZGQ0Y2QwMDQwMjc0ZDk4MzA1ZThjNzU4ZTEw YTRhNmVhY2FmNzEyIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFy dHkvX19pbml0X18ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5L19f aW5pdF9fLnB5CkBAIC05NCw4ICs5NCw2IEBAIGNsYXNzIEF1dG9pbnN0YWxsSW1wb3J0SG9vayhv YmplY3QpOgogICAgICAgICAjIG9yZGVyIGZvciBhdXRvaW5zdGFsbF9ldmVyeXRoaW5nKCksIGJl bG93LCB0byB3b3JrIHByb3Blcmx5LgogICAgICAgICBpZiAnLm1lY2hhbml6ZScgaW4gZnVsbG5h bWU6CiAgICAgICAgICAgICBzZWxmLl9pbnN0YWxsX21lY2hhbml6ZSgpCi0gICAgICAgIGVsaWYg Jy5wZXA4JyBpbiBmdWxsbmFtZToKLSAgICAgICAgICAgIHNlbGYuX2luc3RhbGxfcGVwOCgpCiAg ICAgICAgIGVsaWYgJy5weWNvZGVzdHlsZScgaW4gZnVsbG5hbWU6CiAgICAgICAgICAgICBzZWxm Ll9pbnN0YWxsX3B5Y29kZXN0eWxlKCkKICAgICAgICAgZWxpZiAnLnB5bGludCcgaW4gZnVsbG5h bWU6CkBAIC0xNTMsOSArMTUxLDYgQEAgY2xhc3MgQXV0b2luc3RhbGxJbXBvcnRIb29rKG9iamVj dCk6CiAgICAgICAgIHNlbGYuX2luc3RhbGwoImh0dHBzOi8vZmlsZXMucHl0aG9uaG9zdGVkLm9y Zy9wYWNrYWdlcy83ZC9hOS84YzZiZjYwNzEwNzgxY2UxM2E5OTg3YzBkZWJkYThhZGFiMzVlYjc5 YzZiNTUyNWY3ZmU1MjQwYjdhOGEva2V5cmluZy03LjMuMS50YXIuZ3oiLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAia2V5cmluZy03LjMuMS9rZXlyaW5nIikKIAotICAgIGRlZiBfaW5z dGFsbF9wZXA4KHNlbGYpOgotICAgICAgICBzZWxmLl9pbnN0YWxsKCJodHRwczovL2ZpbGVzLnB5 dGhvbmhvc3RlZC5vcmcvcGFja2FnZXMvMDEvYTAvNjRiYTE5NTE5ZGI0OWU0MDk0ZDgyNTk5NDEy YTk2NjBkZWU4YzI2YTdhZGRiYmIxYmYxNzkyN2NlZWZlL3BlcDgtMS43LjEudGFyLmd6IiwKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgInBlcDgtMS43LjEvcGVwOC5weSIpCiAgICAgZGVm IF9pbnN0YWxsX3B5Y29kZXN0eWxlKHNlbGYpOgogICAgICAgICBzZWxmLl9pbnN0YWxsKCJodHRw czovL2ZpbGVzLnB5dGhvbmhvc3RlZC5vcmcvcGFja2FnZXMvc291cmNlL3AvcHljb2Rlc3R5bGUv cHljb2Rlc3R5bGUtMi41LjAudGFyLmd6IiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg InB5Y29kZXN0eWxlLTIuNS4wL3B5Y29kZXN0eWxlLnB5IikK 405204 2020-07-24 16:51:02 -0700 2020-07-24 17:12:44 -0700 Patch for landing bug-214531-20200724165101.patch text/plain 1246 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDg3MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA3LTI0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBwZXA4LnB5OjExMDogRnV0dXJlV2FybmluZzogUG9zc2libGUgbmVzdGVk IHNldCBhdCBwb3NpdGlvbiAxIChGb2xsb3ctdXAgZml4KQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0NTMxCisKKyAgICAgICAgVW5yZXZpZXdlZCB0 ZXN0IGZpeC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRf X191bml0dGVzdC5weToKKyAgICAgICAgKFRoaXJkcGFydHlUZXN0LnRlc3RfaW1wb3J0cyk6IEF1 dG8taW1wb3J0IG9mIHBlcDggaGFzIGJlZW4gcmVtb3ZlZC4KKwogMjAyMC0wNy0yNCAgVGFkZXUg WmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBXS1N0cmluZ0dldE1heGlt dW1VVEY4Q1N0cmluZ1NpemUgc2hvdWxkIGNhc3QgYmVmb3JlIGFyaXRobWV0aWMKSW5kZXg6IFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfX191bml0dGVzdC5weQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3RoaXJkcGFydHkvX19pbml0X19fdW5p dHRlc3QucHkJKHJldmlzaW9uIDI2NDc3OSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhp cmRwYXJ0eS9fX2luaXRfX191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNDAsNCArNDAs MyBAQCBjbGFzcyBUaGlyZHBhcnR5VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIGlt cG9ydCB3ZWJraXRweS50aGlyZHBhcnR5LmF1dG9pbnN0YWxsZWQuY292ZXJhZ2UKICAgICAgICAg aW1wb3J0IHdlYmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxlZC5tZWNoYW5pemUKICAgICAg ICAgaW1wb3J0IHdlYmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxlZC5weWxpbnQKLSAgICAg ICAgaW1wb3J0IHdlYmtpdHB5LnRoaXJkcGFydHkuYXV0b2luc3RhbGxlZC5wZXA4Cg==