<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>214509</bug_id>
          
          <creation_ts>2020-07-17 16:26:03 -0700</creation_ts>
          <short_desc>[WebGL2] Fix validation of pixel unpack parameters</short_desc>
          <delta_ts>2020-07-17 18:39:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>209516</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kenneth Russell">kbr</reporter>
          <assigned_to name="Kenneth Russell">kbr</assigned_to>
          <cc>dino</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>graouts</cc>
    
    <cc>jdarpinian</cc>
    
    <cc>justin_fan</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1672713</commentid>
    <comment_count>0</comment_count>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-07-17 16:26:03 -0700</bug_when>
    <thetext>In Bug 209516 WebGL 2.0-specific validation was added to ANGLE for pixel unpack parameters. While upstreaming that fix in http://crbug.com/angleproject/4849 a small error was found which should be merged into WebKit as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1672714</commentid>
    <comment_count>1</comment_count>
      <attachid>404617</attachid>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-07-17 16:27:40 -0700</bug_when>
    <thetext>Created attachment 404617
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1672715</commentid>
    <comment_count>2</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2020-07-17 16:28:37 -0700</bug_when>
    <thetext>Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1672747</commentid>
    <comment_count>3</comment_count>
      <attachid>404617</attachid>
    <who name="Kenneth Russell">kbr</who>
    <bug_when>2020-07-17 17:24:31 -0700</bug_when>
    <thetext>Comment on attachment 404617
Patch

ANGLE patch has landed upstream. CQ&apos;ing again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1672757</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-07-17 18:38:05 -0700</bug_when>
    <thetext>Committed r264562: &lt;https://trac.webkit.org/changeset/264562&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404617.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1672758</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-07-17 18:39:14 -0700</bug_when>
    <thetext>&lt;rdar://problem/65753880&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>404617</attachid>
            <date>2020-07-17 16:27:40 -0700</date>
            <delta_ts>2020-07-17 18:38:06 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214509-20200717162739.patch</filename>
            <type>text/plain</type>
            <size>1747</size>
            <attacher name="Kenneth Russell">kbr</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0
eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k
ZXggMmZhYjBkMmE0ZGQ4YjY1MDgwMDdjNTA3Mjg3OTMxMjc1YTg2ZGM3My4uZTBlNDA2YWFmOTIx
ZDhjYWU4YWFmZDNkODNlZDkyMGJlMjkwNDYxMyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy
dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3LTE3ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAY2hy
b21pdW0ub3JnPgorCisgICAgICAgIFtXZWJHTDJdIEZpeCB2YWxpZGF0aW9uIG9mIHBpeGVsIHVu
cGFjayBwYXJhbWV0ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0yMTQ1MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBGaXggc21hbGwgZXJyb3IgZGlzY292ZXJlZCB3aGlsZSB1cHN0cmVhbWluZyB0aGUg
cHJldmlvdXMgZml4IHRvCisgICAgICAgIHRoZSBBTkdMRSBwcm9qZWN0LgorCisgICAgICAgICog
c3JjL2xpYkFOR0xFL3ZhbGlkYXRpb25FUzMuY3BwOgorICAgICAgICAoZ2w6OlZhbGlkYXRlRVMz
VGV4SW1hZ2VQYXJhbWV0ZXJzQmFzZSk6CisKIDIwMjAtMDctMTcgIEtlbm5ldGggUnVzc2VsbCAg
PGtickBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1dlYkdMMl0gUmVhZFBpeGVscyB1cGRhdGVz
CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvdmFsaWRh
dGlvbkVTMy5jcHAgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvdmFsaWRh
dGlvbkVTMy5jcHAKaW5kZXggOTRmM2Q1NDcxYWIxMWNhYzk5YjIzZmY1YjE2MzMwN2NlN2EwZmI2
OC4uOTI5MDYxZjdlZTJkNWY4NzgwOWRjN2FlNWI0MmQ5ZTZhODY1NTYyMiAxMDA2NDQKLS0tIGEv
U291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3ZhbGlkYXRpb25FUzMuY3BwCisr
KyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS92YWxpZGF0aW9uRVMzLmNw
cApAQCAtNjg4LDExICs2ODgsOSBAQCBib29sIFZhbGlkYXRlRVMzVGV4SW1hZ2VQYXJhbWV0ZXJz
QmFzZShjb25zdCBDb250ZXh0ICpjb250ZXh0LAogICAgICAgICAvLyAgICAgIEdMX1VOUEFDS19T
S0lQX1JPV1MgKyBoZWlnaHQgPiBEYXRhU3RvcmVIZWlnaHQKICAgICAgICAgLy8gICAgZXhjZXB0
IGZvciB0ZXhJbWFnZTNEIGlmIG5vIEdMX1BJWEVMX1VOUEFDS19CVUZGRVIgaXMKICAgICAgICAg
Ly8gICAgYm91bmQgYW5kIF9waXhlbHNfIGlzIG51bGwuCi0gICAgICAgIGlmICghcGl4ZWxVbnBh
Y2tCdWZmZXIgJiYgIXBpeGVscykKKyAgICAgICAgaWYgKCFwaXhlbFVucGFja0J1ZmZlciAmJiAh
cGl4ZWxzICYmICFpc1N1YkltYWdlKQogICAgICAgICB7CiAgICAgICAgICAgICAvLyBFeGNlcHRp
b24gY2FzZSBmb3IgdGV4SW1hZ2UyRCBvciB0ZXhJbWFnZTNELCBhYm92ZS4KLSAgICAgICAgICAg
IC8vIFRoZSB2YWxpZGF0aW9uIGFib3ZlIGVuc3VyZXMgbnVsbCBwaXhlbHMgaGF2ZSBiZWVuIHJl
amVjdGVkIGZvciB0ZXhTdWJJbWFnZS4KLSAgICAgICAgICAgIEFTU0VSVCghaXNTdWJJbWFnZSk7
CiAgICAgICAgIH0KICAgICAgICAgZWxzZQogICAgICAgICB7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>