214491 2020-07-17 12:00:18 -0700 REGRESSION(r264330): infinite loop in JSC stress tests using cloop 2020-07-21 11:55:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214289 InRadar P2 Normal --- 1 mcatanzaro mcatanzaro mcatanzaro saam webkit-bug-importer ysuzuki oldest_to_newest 1672576 0 mcatanzaro 2020-07-17 12:00:18 -0700 r264330 added an infinite loop that was supposed to be broken by the --returnEarlyFromInfiniteLoopsForFuzzing=true flag. However, it doesn't work when the tests are run with cloop. This has caused JSC stress tests to run forever only on x86_64 (with cloop enabled). Instead of skipping the tests on particular architectures, let's run the loops only if $vm.useJIT(), suggested by Yusuke. I think there is a problem with architecture detection for arm64, because the tests are still running fine on this architecture. 1672579 1 mcatanzaro 2020-07-17 12:16:06 -0700 (In reply to Michael Catanzaro from comment #0) > I think there is a problem with architecture detection for arm64, because > the tests are still running fine on this architecture. Seems I touched it last, in r261862. My changes look correct, though.... 1672586 2 404582 mcatanzaro 2020-07-17 12:44:56 -0700 Created attachment 404582 Patch 1672827 3 mcatanzaro 2020-07-18 12:17:13 -0700 Looks like I broke the test on jsc-armv7. No clue why, unless maybe this feature depends on a higher JIT tier than the baseline JIT...? I'm not sure what else could be going wrong. The solution would be to not remove the skip line, so if nobody else has a guess, that's what I'll do. 1672839 4 404582 ysuzuki 2020-07-18 17:10:29 -0700 Comment on attachment 404582 Patch r=me 1672892 5 mcatanzaro 2020-07-19 07:46:18 -0700 (In reply to Michael Catanzaro from comment #3) > Looks like I broke the test on jsc-armv7. No clue why, unless maybe this > feature depends on a higher JIT tier than the baseline JIT...? I'm not sure > what else could be going wrong. > > The solution would be to not remove the skip line, so if nobody else has a > guess, that's what I'll do. Yusuke, are you OK with that "solution?" (The current version of the patch breaks jsc-armv7, and that would avoid doing so... but it doesn't seem great.) 1673182 6 404582 saam 2020-07-20 12:43:24 -0700 Comment on attachment 404582 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404582&action=review > JSTests/stress/validate-does-gc-with-return-early-from-infinite-loop.js:3 > +if ($vm.useJIT()) { this looks wrong in combination of removing the above skip. I didn't implement it on 32-bit. 1673193 7 mcatanzaro 2020-07-20 13:04:01 -0700 So to confirm, this test should run only (a) on 64-bit platforms, and (b) only if JIT is enabled. Yes? In that case, my patch would be fine if I leave the Skip line unchanged, right? 1673371 8 saam 2020-07-20 21:32:38 -0700 (In reply to Michael Catanzaro from comment #7) > So to confirm, this test should run only (a) on 64-bit platforms, and (b) > only if JIT is enabled. Yes? In that case, my patch would be fine if I leave > the Skip line unchanged, right? Yes, I believe that is the way to go. 1673426 9 404814 mcatanzaro 2020-07-21 06:14:21 -0700 Created attachment 404814 Patch 1673547 10 ews-feeder 2020-07-21 11:54:30 -0700 Committed r264668: <https://trac.webkit.org/changeset/264668> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404814. 1673548 11 webkit-bug-importer 2020-07-21 11:55:17 -0700 <rdar://problem/65895487> 404582 2020-07-17 12:44:56 -0700 2020-07-21 06:14:19 -0700 Patch bug-214491-20200717144455.patch text/plain 1488 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NTI5CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE5Yzg1YjYyY2JjMWMwMTYwY2M3OTcxZjcyMzc2 YzM5NWM3NGY0ZDUuLjRiZGZhZmNjYjY0MDhkYmM0NTYzYTRhOGU1NWNkZjk4ZDVkNjY0YmEgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMjAtMDctMTcgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bn bm9tZS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjY0MzMwKTogaW5maW5pdGUgbG9vcCBp biBKU0Mgc3RyZXNzIHRlc3RzIHVzaW5nIGNsb29wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ0OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSdW4gdGhlIHRlc3Qgb25seSBpZiBKSVQgaXMgZW5hYmxl ZCwgcmVnYXJkbGVzcyBvZiBhcmNoaXRlY3R1cmUuCisKKyAgICAgICAgKiBzdHJlc3MvdmFsaWRh dGUtZG9lcy1nYy13aXRoLXJldHVybi1lYXJseS1mcm9tLWluZmluaXRlLWxvb3AuanM6CisgICAg ICAgICh2bS51c2VKSVQpOgorCiAyMDIwLTA3LTE3ICBYYW4gTG9wZXogIDx4YW5AaWdhbGlhLmNv bT4KIAogICAgICAgICBNYXRoLm1heCgpIGNhbiB5aWVsZCB0aGUgd3JvbmcgcmVzdWx0IGZvciBt YXgoMCwgLTApLgpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvdmFsaWRhdGUtZG9lcy1nYy13 aXRoLXJldHVybi1lYXJseS1mcm9tLWluZmluaXRlLWxvb3AuanMgYi9KU1Rlc3RzL3N0cmVzcy92 YWxpZGF0ZS1kb2VzLWdjLXdpdGgtcmV0dXJuLWVhcmx5LWZyb20taW5maW5pdGUtbG9vcC5qcwpp bmRleCAwNWVhYmZmZjhjMjE5NzExZDBiNWMwMjBjZmQ5NmQ3ODQ3MDQ0MTBhLi41ZWEwMjI2MmYz Yzc1ZDYwMWZkZjc2ZDBmZDQwM2YwOTNiYWRkN2NjIDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVz cy92YWxpZGF0ZS1kb2VzLWdjLXdpdGgtcmV0dXJuLWVhcmx5LWZyb20taW5maW5pdGUtbG9vcC5q cworKysgYi9KU1Rlc3RzL3N0cmVzcy92YWxpZGF0ZS1kb2VzLWdjLXdpdGgtcmV0dXJuLWVhcmx5 LWZyb20taW5maW5pdGUtbG9vcC5qcwpAQCAtMSw0ICsxLDUgQEAKLS8vQCBza2lwIGlmICRhcmNo aXRlY3R1cmUgIT0gImFybTY0IiBhbmQgJGFyY2hpdGVjdHVyZSAhPSAieDg2LTY0IgogLy9AIHJ1 bkRlZmF1bHQoIi0tcmV0dXJuRWFybHlGcm9tSW5maW5pdGVMb29wc0ZvckZ1enppbmc9dHJ1ZSIs ICItLWVhcmx5UmV0dXJuRnJvbUluZmluaXRlTG9vcHNMaW1pdD0xMDAwMDAwIiwgIi0tdXNlQ29u Y3VycmVudEpJVD1mYWxzZSIsICItLXZhbGlkYXRlRG9lc0dDPXRydWUiKQogCi13aGlsZSgxKXt9 IHdoaWxlKDEpe30KK2lmICgkdm0udXNlSklUKCkpIHsKKyAgICB3aGlsZSgxKXt9IHdoaWxlKDEp e30KK30K 404814 2020-07-21 06:14:21 -0700 2020-07-21 11:54:30 -0700 Patch bug-214491-20200721081420.patch text/plain 1452 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NjUxCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDQxMjE3YjI0MGVmMGFhZjAwOTVmMjBlYjAwNmMy MDQwNDliZmY1ZGMuLjViYzAzMDViNDM0YWM1Mjk4NjgwOTdmOWJmOGJjZDM1OGNlZTM4ZmIgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTUgQEAKKzIwMjAtMDctMjEgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bn bm9tZS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjY0MzMwKTogaW5maW5pdGUgbG9vcCBp biBKU0Mgc3RyZXNzIHRlc3RzIHVzaW5nIGNsb29wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ0OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSdW4gdGhlIHRlc3Qgb25seSBpZiBKSVQgaXMgZW5hYmxl ZC4KKworICAgICAgICAqIHN0cmVzcy92YWxpZGF0ZS1kb2VzLWdjLXdpdGgtcmV0dXJuLWVhcmx5 LWZyb20taW5maW5pdGUtbG9vcC5qczoKKyAgICAgICAgKHZtLnVzZUpJVCk6CisKIDIwMjAtMDct MjAgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbRUNNQS00 MDJdIEltcGxlbWVudCBJbnRsLkRpc3BsYXlOYW1lcwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJl c3MvdmFsaWRhdGUtZG9lcy1nYy13aXRoLXJldHVybi1lYXJseS1mcm9tLWluZmluaXRlLWxvb3Au anMgYi9KU1Rlc3RzL3N0cmVzcy92YWxpZGF0ZS1kb2VzLWdjLXdpdGgtcmV0dXJuLWVhcmx5LWZy b20taW5maW5pdGUtbG9vcC5qcwppbmRleCAwNWVhYmZmZjhjMjE5NzExZDBiNWMwMjBjZmQ5NmQ3 ODQ3MDQ0MTBhLi4xN2QxODZkZTQ2Y2ZiYmExYWNmYzUzMWZhMzdjYThmOTUyMWNmNmM1IDEwMDY0 NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy92YWxpZGF0ZS1kb2VzLWdjLXdpdGgtcmV0dXJuLWVhcmx5 LWZyb20taW5maW5pdGUtbG9vcC5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy92YWxpZGF0ZS1kb2Vz LWdjLXdpdGgtcmV0dXJuLWVhcmx5LWZyb20taW5maW5pdGUtbG9vcC5qcwpAQCAtMSw0ICsxLDYg QEAKIC8vQCBza2lwIGlmICRhcmNoaXRlY3R1cmUgIT0gImFybTY0IiBhbmQgJGFyY2hpdGVjdHVy ZSAhPSAieDg2LTY0IgogLy9AIHJ1bkRlZmF1bHQoIi0tcmV0dXJuRWFybHlGcm9tSW5maW5pdGVM b29wc0ZvckZ1enppbmc9dHJ1ZSIsICItLWVhcmx5UmV0dXJuRnJvbUluZmluaXRlTG9vcHNMaW1p dD0xMDAwMDAwIiwgIi0tdXNlQ29uY3VycmVudEpJVD1mYWxzZSIsICItLXZhbGlkYXRlRG9lc0dD PXRydWUiKQogCi13aGlsZSgxKXt9IHdoaWxlKDEpe30KK2lmICgkdm0udXNlSklUKCkpIHsKKyAg ICB3aGlsZSgxKXt9IHdoaWxlKDEpe30KK30K