214490 2020-07-17 11:48:39 -0700 [iOS] Crash under WebProcess::handleXPCEndpointMessages 2020-07-17 12:31:02 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham cdumez webkit-bug-importer oldest_to_newest 1672569 0 pvollan 2020-07-17 11:48:39 -0700 According to crash logs, it seems possible that the parent process XPC connection can be null. Add a null check, and also check that the connection XPC object really is an XPC connection object. 1672570 1 pvollan 2020-07-17 11:48:59 -0700 rdar://problem/65717136 1672571 2 404579 pvollan 2020-07-17 11:51:39 -0700 Created attachment 404579 Patch 1672572 3 404579 cdumez 2020-07-17 11:52:20 -0700 Comment on attachment 404579 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404579&action=review > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:177 > + if (xpc_get_type(connection) != XPC_TYPE_CONNECTION) I think this should be an assertion. 1672573 4 404580 pvollan 2020-07-17 11:57:23 -0700 Created attachment 404580 Patch 1672574 5 pvollan 2020-07-17 11:57:44 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 404579 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404579&action=review > > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:177 > > + if (xpc_get_type(connection) != XPC_TYPE_CONNECTION) > > I think this should be an assertion. Fixed. Thanks for reviewing! 1672575 6 404580 cdumez 2020-07-17 11:58:18 -0700 Comment on attachment 404580 Patch r=me 1672583 7 ews-feeder 2020-07-17 12:31:00 -0700 Committed r264529: <https://trac.webkit.org/changeset/264529> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404580. 404579 2020-07-17 11:51:39 -0700 2020-07-17 11:57:21 -0700 Patch bug-214490-20200717115139.patch text/plain 1648 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjQ1MjYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA3LTE3ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBDcmFzaCB1bmRlciBX ZWJQcm9jZXNzOjpoYW5kbGVYUENFbmRwb2ludE1lc3NhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ0OTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBY2NvcmRpbmcgdG8gY3Jhc2ggbG9ncywgaXQg c2VlbXMgcG9zc2libGUgdGhhdCB0aGUgcGFyZW50IHByb2Nlc3MgWFBDIGNvbm5lY3Rpb24gY2Fu IGJlIG51bGwuIEFkZCBhIG51bGwgY2hlY2ssCisgICAgICAgIGFuZCBhbHNvIGNoZWNrIHRoYXQg dGhlIGNvbm5lY3Rpb24gWFBDIG9iamVjdCByZWFsbHkgaXMgYW4gWFBDIGNvbm5lY3Rpb24gb2Jq ZWN0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgc2luY2UgSSBoYXZlIG5vdCBiZWVuIGFibGUg dG8gcmVwcm9kdWNlIHRoaXMgaXNzdWUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dl YlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6aGFuZGxlWFBD RW5kcG9pbnRNZXNzYWdlcyBjb25zdCk6CisKIDIwMjAtMDctMTcgIERhdmlkIEtpbHplciAgPGRk a2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBbSVBDIGhhcmRlbmluZ10gQWRkIG51bGxwdHIg Y2hlY2tzIHRvIFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtU3RhcnRXaW5kb3dE cmFnKCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29j b2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlBy b2Nlc3NDb2NvYS5tbQkocmV2aXNpb24gMjY0NTA4KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtMTcxLDYgKzE3 MSwxMiBAQCB2b2lkIFdlYlByb2Nlc3M6OmhhbmRsZVhQQ0VuZHBvaW50TWVzc2FnCiAKICAgICBh dXRvIGNvbm5lY3Rpb24gPSBwYXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT54cGNDb25uZWN0aW9u KCk7CiAKKyAgICBpZiAoIWNvbm5lY3Rpb24pCisgICAgICAgIHJldHVybjsKKworICAgIGlmICh4 cGNfZ2V0X3R5cGUoY29ubmVjdGlvbikgIT0gWFBDX1RZUEVfQ09OTkVDVElPTikKKyAgICAgICAg cmV0dXJuOworCiAgICAgeHBjX2Nvbm5lY3Rpb25fc3VzcGVuZChjb25uZWN0aW9uKTsKIAogICAg IHhwY19jb25uZWN0aW9uX3NldF90YXJnZXRfcXVldWUoY29ubmVjdGlvbiwgZGlzcGF0Y2hfZ2V0 X2dsb2JhbF9xdWV1ZShESVNQQVRDSF9RVUVVRV9QUklPUklUWV9ERUZBVUxULCAwKSk7Cg== 404580 2020-07-17 11:57:23 -0700 2020-07-17 12:31:01 -0700 Patch bug-214490-20200717115722.patch text/plain 1643 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjQ1MjYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA3LTE3ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBDcmFzaCB1bmRlciBX ZWJQcm9jZXNzOjpoYW5kbGVYUENFbmRwb2ludE1lc3NhZ2VzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ0OTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBY2NvcmRpbmcgdG8gY3Jhc2ggbG9ncywgaXQg c2VlbXMgcG9zc2libGUgdGhhdCB0aGUgcGFyZW50IHByb2Nlc3MgWFBDIGNvbm5lY3Rpb24gY2Fu IGJlIG51bGwuIEFkZCBhIG51bGwgY2hlY2ssCisgICAgICAgIGFuZCBhbHNvIGNoZWNrIHRoYXQg dGhlIGNvbm5lY3Rpb24gWFBDIG9iamVjdCByZWFsbHkgaXMgYW4gWFBDIGNvbm5lY3Rpb24gb2Jq ZWN0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgc2luY2UgSSBoYXZlIG5vdCBiZWVuIGFibGUg dG8gcmVwcm9kdWNlIHRoaXMgaXNzdWUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dl YlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6aGFuZGxlWFBD RW5kcG9pbnRNZXNzYWdlcyBjb25zdCk6CisKIDIwMjAtMDctMTcgIERhdmlkIEtpbHplciAgPGRk a2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBbSVBDIGhhcmRlbmluZ10gQWRkIG51bGxwdHIg Y2hlY2tzIHRvIFdlYktpdDo6V2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtU3RhcnRXaW5kb3dE cmFnKCkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29j b2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlBy b2Nlc3NDb2NvYS5tbQkocmV2aXNpb24gMjY0NTA4KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtMTcxLDYgKzE3 MSwxMSBAQCB2b2lkIFdlYlByb2Nlc3M6OmhhbmRsZVhQQ0VuZHBvaW50TWVzc2FnCiAKICAgICBh dXRvIGNvbm5lY3Rpb24gPSBwYXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT54cGNDb25uZWN0aW9u KCk7CiAKKyAgICBpZiAoIWNvbm5lY3Rpb24pCisgICAgICAgIHJldHVybjsKKworICAgIFJFTEVB U0VfQVNTRVJUKHhwY19nZXRfdHlwZShjb25uZWN0aW9uKSA9PSBYUENfVFlQRV9DT05ORUNUSU9O KTsKKwogICAgIHhwY19jb25uZWN0aW9uX3N1c3BlbmQoY29ubmVjdGlvbik7CiAKICAgICB4cGNf Y29ubmVjdGlvbl9zZXRfdGFyZ2V0X3F1ZXVlKGNvbm5lY3Rpb24sIGRpc3BhdGNoX2dldF9nbG9i YWxfcXVldWUoRElTUEFUQ0hfUVVFVUVfUFJJT1JJVFlfREVGQVVMVCwgMCkpOwo=