214486 2020-07-17 10:56:16 -0700 [webkitpy] Simulators should opt out of emulation 2020-07-17 11:32:06 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari 13 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap dewei_zhu ews-watchlist glenn ryanhaddad slewis webkit-bug-importer oldest_to_newest 1672546 0 jbedard 2020-07-17 10:56:16 -0700 In general, it's never correct to run an emulated simulator. This is particularly relevant for watchOS, since x86_64 != i386, so watchOS simulators will run with the emulation logic intended for Rosetta. 1672547 1 jbedard 2020-07-17 10:56:40 -0700 <rdar://problem/65644439> 1672550 2 404574 jbedard 2020-07-17 11:00:02 -0700 Created attachment 404574 Patch 1672560 3 ews-feeder 2020-07-17 11:32:05 -0700 Committed r264523: <https://trac.webkit.org/changeset/264523> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404574. 404574 2020-07-17 11:00:02 -0700 2020-07-17 11:32:06 -0700 Patch bug-214486-20200717110001.patch text/plain 2969 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDUyMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTA3LTE3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIFNpbXVsYXRvcnMgc2hvdWxkIG9wdCBvdXQgb2YgZW11 bGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTQ0ODYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY1NjQ0NDM5PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0 L3NlcnZlcl9wcm9jZXNzLnB5OgorICAgICAgICAoU2VydmVyUHJvY2Vzcy5fX2luaXRfXyk6IENh bGxlciBtYXkgcmVxdWVzdCB0aGF0IGVtdWxhdGlvbiBiZSBkaXNhYmxlZC4KKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3BvcnQvc2ltdWxhdG9yX3Byb2Nlc3MucHk6CisgICAgICAgIChTaW11 bGF0b3JQcm9jZXNzLl9faW5pdF9fKTogRGlzYWJsZSBlbXVsYXRpb24uCisKIDIwMjAtMDctMTcg IFRydWl0dCBTYXZlbGwgIDx0c2F2ZWxsQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LCByZXZlcnRpbmcgcjI2NDQ3Ny4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9z ZXJ2ZXJfcHJvY2Vzcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvc2VydmVyX3Byb2Nlc3MucHkJKHJldmlzaW9uIDI2NDUwOCkKKysrIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQkod29ya2luZyBjb3B5KQpAQCAtNjEsMTIg KzYxLDEyIEBAIGNsYXNzIFNlcnZlclByb2Nlc3Mob2JqZWN0KToKICAgICBpbmRlZmluaXRlbHku IFRoZSBjbGFzcyBhbHNvIGhhbmRsZXMgdHJhbnNwYXJlbnRseSByZXN0YXJ0aW5nIHByb2Nlc3Nl cwogICAgIGFzIG5lY2Vzc2FyeSB0byBrZWVwIGlzc3VpbmcgY29tbWFuZHMuIiIiCiAKLSAgICBk ZWYgX19pbml0X18oc2VsZiwgcG9ydF9vYmosIG5hbWUsIGNtZCwgZW52PU5vbmUsIHVuaXZlcnNh bF9uZXdsaW5lcz1GYWxzZSwgdHJlYXRfbm9fZGF0YV9hc19jcmFzaD1GYWxzZSwgdGFyZ2V0X2hv c3Q9Tm9uZSwgY3Jhc2hfbWVzc2FnZT1Ob25lKToKKyAgICBkZWYgX19pbml0X18oc2VsZiwgcG9y dF9vYmosIG5hbWUsIGNtZCwgZW52PU5vbmUsIHVuaXZlcnNhbF9uZXdsaW5lcz1GYWxzZSwgdHJl YXRfbm9fZGF0YV9hc19jcmFzaD1GYWxzZSwgdGFyZ2V0X2hvc3Q9Tm9uZSwgY3Jhc2hfbWVzc2Fn ZT1Ob25lLCBhbGxvd19lbXVsYXRpb249VHJ1ZSk6CiAgICAgICAgIHNlbGYuX3BvcnQgPSBwb3J0 X29iagogICAgICAgICBzZWxmLl9uYW1lID0gbmFtZSAgIyBTaG91bGQgYmUgdGhlIGNvbW1hbmQg bmFtZSAoZS5nLiBEdW1wUmVuZGVyVHJlZSwgSW1hZ2VEaWZmKQogCiAgICAgICAgIHBsYXRmb3Jt ID0gc2VsZi5fcG9ydC5ob3N0LnBsYXRmb3JtCi0gICAgICAgIGlmIHBsYXRmb3JtLmlzX21hYygp IGFuZCBwbGF0Zm9ybS5hcmNoaXRlY3R1cmUoKSAhPSBzZWxmLl9wb3J0LmFyY2hpdGVjdHVyZSgp OgorICAgICAgICBpZiBhbGxvd19lbXVsYXRpb24gYW5kIHBsYXRmb3JtLmlzX21hYygpIGFuZCBw bGF0Zm9ybS5hcmNoaXRlY3R1cmUoKSAhPSBzZWxmLl9wb3J0LmFyY2hpdGVjdHVyZSgpOgogICAg ICAgICAgICAgc2VsZi5fY21kID0gWycvdXNyL2Jpbi9hcmNoJywgJy17fScuZm9ybWF0KHNlbGYu X3BvcnQuYXJjaGl0ZWN0dXJlKCkpXSArIGNtZAogICAgICAgICBlbHNlOgogICAgICAgICAgICAg c2VsZi5fY21kID0gY21kCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2ltdWxh dG9yX3Byb2Nlc3MucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L3NpbXVsYXRvcl9wcm9jZXNzLnB5CShyZXZpc2lvbiAyNjQ1MDgpCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvc2ltdWxhdG9yX3Byb2Nlc3MucHkJKHdvcmtpbmcgY29weSkKQEAgLTc5 LDcgKzc5LDcgQEAgY2xhc3MgU2ltdWxhdG9yUHJvY2VzcyhTZXJ2ZXJQcm9jZXNzKToKIAogICAg IGRlZiBfX2luaXRfXyhzZWxmLCBwb3J0X29iaiwgbmFtZSwgY21kLCBlbnY9Tm9uZSwgdW5pdmVy c2FsX25ld2xpbmVzPUZhbHNlLCB0cmVhdF9ub19kYXRhX2FzX2NyYXNoPUZhbHNlLCB0YXJnZXRf aG9zdD1Ob25lLCBjcmFzaF9tZXNzYWdlPU5vbmUpOgogICAgICAgICBlbnZbJ1BPUlQnXSA9IHN0 cih0YXJnZXRfaG9zdC5saXN0ZW5pbmdfcG9ydCgpKSAgIyBUaGUgdGFyZ2V0X2hvc3Qgc2hvdWxk IGJlIGEgZGV2aWNlLgotICAgICAgICBzdXBlcihTaW11bGF0b3JQcm9jZXNzLCBzZWxmKS5fX2lu aXRfXyhwb3J0X29iaiwgbmFtZSwgY21kLCBlbnYsIHVuaXZlcnNhbF9uZXdsaW5lcywgdHJlYXRf bm9fZGF0YV9hc19jcmFzaCwgdGFyZ2V0X2hvc3QsIGNyYXNoX21lc3NhZ2UpCisgICAgICAgIHN1 cGVyKFNpbXVsYXRvclByb2Nlc3MsIHNlbGYpLl9faW5pdF9fKHBvcnRfb2JqLCBuYW1lLCBjbWQs IGVudiwgdW5pdmVyc2FsX25ld2xpbmVzLCB0cmVhdF9ub19kYXRhX2FzX2NyYXNoLCB0YXJnZXRf aG9zdCwgY3Jhc2hfbWVzc2FnZSwgYWxsb3dfZW11bGF0aW9uPUZhbHNlKQogCiAgICAgICAgIHNl bGYuX2J1bmRsZV9pZCA9IHBvcnRfb2JqLmFwcF9pZGVudGlmaWVyX2Zyb21fYnVuZGxlKGNtZFsw XSkKIAo=