214445 2020-07-17 00:03:20 -0700 Add a addition point for extra user media sandbox extensions 2020-07-17 11:24:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton aestes andersca eric.carlson ews-watchlist glenn jer.noble philipj pvollan sam sergio webkit-bug-importer wenson_hsieh youennf oldest_to_newest 1672411 0 thorton 2020-07-17 00:03:20 -0700 Add a addition point for extra user media sandbox extensions 1672412 1 404540 thorton 2020-07-17 00:03:53 -0700 Created attachment 404540 Patch 1672413 2 thorton 2020-07-17 00:03:55 -0700 <rdar://problem/65148262> 1672499 3 404540 sam 2020-07-17 09:00:43 -0700 Comment on attachment 404540 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404540&action=review > Source/WebKit/UIProcess/UserMediaProcessManager.cpp:111 > + if (needsAppleCameraSandboxExtension) { > extensionCount++; > +#if HAVE(ADDITIONAL_APPLE_CAMERA_SERVICE) > + extensionCount++; > +#endif > + } I wonder if all this nonsense can be removed if we just modernized the Handle and HandleArray code. I would bet (though don't really remember) it stems from a time pre-move-only types, and now could probably be a lot more sane. 1672503 4 andersca 2020-07-17 09:08:30 -0700 (In reply to Sam Weinig from comment #3) > I wonder if all this nonsense can be removed if we just modernized the > Handle and HandleArray code. I would bet (though don't really remember) it > stems from a time pre-move-only types, and now could probably be a lot more > sane. Yup. 1672544 5 404540 thorton 2020-07-17 10:52:51 -0700 Comment on attachment 404540 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404540&action=review >> Source/WebKit/UIProcess/UserMediaProcessManager.cpp:111 >> + } > > I wonder if all this nonsense can be removed if we just modernized the Handle and HandleArray code. I would bet (though don't really remember) it stems from a time pre-move-only types, and now could probably be a lot more sane. Heh, I wondered (and complained to others!) about why it was written like this; that makes sense. Not to be fixed in this patch, though. 1672557 6 ews-feeder 2020-07-17 11:24:49 -0700 Committed r264521: <https://trac.webkit.org/changeset/264521> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404540. 404540 2020-07-17 00:03:53 -0700 2020-07-17 11:24:50 -0700 Patch bug-214445-20200717000352.patch text/plain 4312 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQyYjk2NTY3MDQzYTIzOWUw YTAxZTIwMzNhMWM0YjE1MjA0OWM3MTcuLjlmNWFjNTBiNzk4MzVjN2NjNTU0ZGMzNmM0ZTg0YTM1 YTIxNTM2YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDctMTcgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgYWRkaXRpb24g cG9pbnQgZm9yIGV4dHJhIHVzZXIgbWVkaWEgc2FuZGJveCBleHRlbnNpb25zCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQ0NDUKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzY1MTQ4MjYyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1VzZXJNZWRpYVByb2Nlc3NNYW5hZ2VyLmNwcDoK KyAgICAgICAgKFdlYktpdDo6VXNlck1lZGlhUHJvY2Vzc01hbmFnZXI6OndpbGxDcmVhdGVNZWRp YVN0cmVhbSk6CisgICAgICAgIChXZWJLaXQ6OlVzZXJNZWRpYVByb2Nlc3NNYW5hZ2VyOjpyZXZv a2VTYW5kYm94RXh0ZW5zaW9uc0lmTmVlZGVkKToKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvbS5h cHBsZS5XZWJQcm9jZXNzLnNiLmluOgorCiAyMDIwLTA3LTE2ICBNZWdhbiBHYXJkbmVyICA8bWVn YW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAgU2VsZWN0aW9uIGlzIG5vdCBhbHdheXMg Y2xlYXJpbmcgd2hlbiB0YXBwaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvVXNlck1lZGlhUHJvY2Vzc01hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv VXNlck1lZGlhUHJvY2Vzc01hbmFnZXIuY3BwCmluZGV4IDk2NWRkYWY3Nzk5NzcxMjUyZjJhNmM3 NzdiMGU3ZTczYmViYzFmZTkuLjI3YjEyM2JiZjk5OTBlNGQ2MWRiMmNiMzcxN2M2YjQ4YWU0ZWNh ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1VzZXJNZWRpYVByb2Nlc3NN YW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Vc2VyTWVkaWFQcm9jZXNz TWFuYWdlci5jcHAKQEAgLTMxLDYgKzMxLDEwIEBACiAjaW5jbHVkZSA8d3RmL05ldmVyRGVzdHJv eWVkLmg+CiAjaW5jbHVkZSA8d3RmL1RyYW5zbGF0ZWRQcm9jZXNzLmg+CiAKKyNpZiBFTkFCTEUo U0FOREJPWF9FWFRFTlNJT05TKSAmJiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQorI2luY2x1ZGUg PFdlYktpdEFkZGl0aW9ucy9Vc2VyTWVkaWFQcm9jZXNzTWFuYWdlckFkZGl0aW9ucy5jcHA+Cisj ZW5kaWYKKwogbmFtZXNwYWNlIFdlYktpdCB7CiAKICNpZiBFTkFCTEUoU0FOREJPWF9FWFRFTlNJ T05TKQpAQCAtOTksOCArMTAzLDEyIEBAIGJvb2wgVXNlck1lZGlhUHJvY2Vzc01hbmFnZXI6Ondp bGxDcmVhdGVNZWRpYVN0cmVhbShVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hCiAgICAgICAg IGV4dGVuc2lvbkNvdW50Kys7CiAKICAgICBib29sIG5lZWRzQXBwbGVDYW1lcmFTYW5kYm94RXh0 ZW5zaW9uID0gbmVlZHNWaWRlb1NhbmRib3hFeHRlbnNpb24gJiYgbmVlZHNBcHBsZUNhbWVyYVNl cnZpY2UoKTsKLSAgICBpZiAobmVlZHNBcHBsZUNhbWVyYVNhbmRib3hFeHRlbnNpb24pCisgICAg aWYgKG5lZWRzQXBwbGVDYW1lcmFTYW5kYm94RXh0ZW5zaW9uKSB7CiAgICAgICAgIGV4dGVuc2lv bkNvdW50Kys7CisjaWYgSEFWRShBRERJVElPTkFMX0FQUExFX0NBTUVSQV9TRVJWSUNFKQorICAg ICAgICBleHRlbnNpb25Db3VudCsrOworI2VuZGlmCisgICAgfQogCiAgICAgaWYgKGV4dGVuc2lv bkNvdW50KSB7CiAgICAgICAgIFNhbmRib3hFeHRlbnNpb246OkhhbmRsZUFycmF5IGhhbmRsZXM7 CkBAIC0xMTYsOCArMTI0LDE0IEBAIGJvb2wgVXNlck1lZGlhUHJvY2Vzc01hbmFnZXI6OndpbGxD cmVhdGVNZWRpYVN0cmVhbShVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hCiAgICAgICAgICAg ICBpZiAobmVlZHNWaWRlb1NhbmRib3hFeHRlbnNpb24gJiYgU2FuZGJveEV4dGVuc2lvbjo6Y3Jl YXRlSGFuZGxlRm9yR2VuZXJpY0V4dGVuc2lvbih2aWRlb0V4dGVuc2lvblBhdGgsIGhhbmRsZXNb LS1leHRlbnNpb25Db3VudF0pKQogICAgICAgICAgICAgICAgIGlkcy51bmNoZWNrZWRBcHBlbmQo dmlkZW9FeHRlbnNpb25QYXRoKTsKIAotICAgICAgICAgICAgaWYgKG5lZWRzQXBwbGVDYW1lcmFT YW5kYm94RXh0ZW5zaW9uICYmIFNhbmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZUZvck1hY2hM b29rdXAoYXBwbGVDYW1lcmFTZXJ2aWNlUGF0aCwgV1RGOjpudWxsb3B0LCBoYW5kbGVzWy0tZXh0 ZW5zaW9uQ291bnRdKSkKLSAgICAgICAgICAgICAgICBpZHMudW5jaGVja2VkQXBwZW5kKGFwcGxl Q2FtZXJhU2VydmljZVBhdGgpOworICAgICAgICAgICAgaWYgKG5lZWRzQXBwbGVDYW1lcmFTYW5k Ym94RXh0ZW5zaW9uKSB7CisgICAgICAgICAgICAgICAgaWYgKFNhbmRib3hFeHRlbnNpb246OmNy ZWF0ZUhhbmRsZUZvck1hY2hMb29rdXAoYXBwbGVDYW1lcmFTZXJ2aWNlUGF0aCwgV1RGOjpudWxs b3B0LCBoYW5kbGVzWy0tZXh0ZW5zaW9uQ291bnRdKSkKKyAgICAgICAgICAgICAgICAgICAgaWRz LnVuY2hlY2tlZEFwcGVuZChhcHBsZUNhbWVyYVNlcnZpY2VQYXRoKTsKKyNpZiBIQVZFKEFERElU SU9OQUxfQVBQTEVfQ0FNRVJBX1NFUlZJQ0UpCisgICAgICAgICAgICAgICAgaWYgKFNhbmRib3hF eHRlbnNpb246OmNyZWF0ZUhhbmRsZUZvck1hY2hMb29rdXAoYWRkaXRpb25hbEFwcGxlQ2FtZXJh U2VydmljZVBhdGgsIFdURjo6bnVsbG9wdCwgaGFuZGxlc1stLWV4dGVuc2lvbkNvdW50XSkpCisg ICAgICAgICAgICAgICAgICAgIGlkcy51bmNoZWNrZWRBcHBlbmQoYWRkaXRpb25hbEFwcGxlQ2Ft ZXJhU2VydmljZVBhdGgpOworI2VuZGlmCisgICAgICAgICAgICB9CiAKICAgICAgICAgICAgIGlm IChpZHMuc2l6ZSgpICE9IGhhbmRsZXMuc2l6ZSgpKSB7CiAgICAgICAgICAgICAgICAgV1RGTG9n QWx3YXlzKCJDb3VsZCBub3QgY3JlYXRlIGEgcmVxdWlyZWQgc2FuZGJveCBleHRlbnNpb24sIGNh cHR1cmUgd2lsbCBmYWlsISIpOwpAQCAtMTczLDggKzE4NywxMiBAQCB2b2lkIFVzZXJNZWRpYVBy b2Nlc3NNYW5hZ2VyOjpyZXZva2VTYW5kYm94RXh0ZW5zaW9uc0lmTmVlZGVkKFdlYlByb2Nlc3NQ cm94eSYgcAogICAgIH0KICAgICBpZiAoIWhhc1ZpZGVvQ2FwdHVyZSAmJiBwcm9jZXNzLmhhc1Zp ZGVvQ2FwdHVyZUV4dGVuc2lvbigpKSB7CiAgICAgICAgIHBhcmFtcy5hcHBlbmQodmlkZW9FeHRl bnNpb25QYXRoKTsKLSAgICAgICAgaWYgKG5lZWRzQXBwbGVDYW1lcmFTZXJ2aWNlKCkpCisgICAg ICAgIGlmIChuZWVkc0FwcGxlQ2FtZXJhU2VydmljZSgpKSB7CiAgICAgICAgICAgICBwYXJhbXMu YXBwZW5kKGFwcGxlQ2FtZXJhU2VydmljZVBhdGgpOworI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9T REspICYmIEhBVkUoQURESVRJT05BTF9BUFBMRV9DQU1FUkFfU0VSVklDRSkKKyAgICAgICAgICAg IHBhcmFtcy5hcHBlbmQoYWRkaXRpb25hbEFwcGxlQ2FtZXJhU2VydmljZVBhdGgpOworI2VuZGlm CisgICAgICAgIH0KICAgICAgICAgcHJvY2Vzcy5yZXZva2VWaWRlb0NhcHR1cmVFeHRlbnNpb24o KTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBw bGUuV2ViUHJvY2Vzcy5zYi5pbiBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUu V2ViUHJvY2Vzcy5zYi5pbgppbmRleCA0MGY0MTVjYTU0OGM5Mzk4ZDA1NGZlMWQ2OWEzMDM0YjI5 MjUxNjk4Li43NmI2NTEzMWU1YTg0MTJhYzdlZDRlNDRiOWFhZGIzNjllYTJjY2ExIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4K KysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmlu CkBAIC0xMTY5LDMgKzExNjksNyBAQAogICAgICAgICAoYWxsb3cgc3lzY2FsbC11bml4IChzeXNj YWxsLW51bWJlciBTWVNfb2JqY19icF9hc3Npc3RfY2ZnX25wKSkpCiAjZW5kaWYKICkKKworI2lm IFVTRShBUFBMRV9JTlRFUk5BTF9TREspCisjaW5jbHVkZSA8V2ViS2l0QWRkaXRpb25zL1dlYkNv bnRlbnRTYW5kYm94QWRkaXRpb25zTWFjLnNiPgorI2VuZGlmCg==