214433 2020-07-16 16:32:58 -0700 [iOS 14] Some PassKit SPI is now API 2020-07-17 08:54:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214420 https://bugs.webkit.org/show_bug.cgi?id=214431 https://bugs.webkit.org/show_bug.cgi?id=214432 https://bugs.webkit.org/show_bug.cgi?id=214476 https://bugs.webkit.org/show_bug.cgi?id=214479 InRadar P2 Normal --- 1 jbedard jbedard darin webkit-bug-importer oldest_to_newest 1672292 0 jbedard 2020-07-16 16:32:58 -0700 There is some PassKit SPI that is API in iOS 14. 1672294 1 webkit-bug-importer 2020-07-16 16:34:27 -0700 <rdar://problem/65695889> 1672297 2 404495 jbedard 2020-07-16 16:44:25 -0700 Created attachment 404495 Patch 1672298 3 404495 darin 2020-07-16 16:47:05 -0700 Comment on attachment 404495 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404495&action=review > Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:330 > +#ifndef __PKPAYMENTMERCHANTSESSION_H__ This is not the ideal way to resolve this. Long term we would want to remove this block entirely. Doing it this way means we could end up keeping this forever. 1672310 4 jbedard 2020-07-16 17:18:28 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 404495 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404495&action=review > > > Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h:330 > > +#ifndef __PKPAYMENTMERCHANTSESSION_H__ > > This is not the ideal way to resolve this. Long term we would want to remove > this block entirely. Doing it this way means we could end up keeping this > forever. I agree, I only went with it because it will be temporary once we stop building iOS 13. The other option would be to have version checks for both iOS and watchOS, which seemed worse to me. 1672313 5 darin 2020-07-16 17:26:51 -0700 Adding both version checks is what would let us remove this eventually. Otherwise we will keep it forever and not remember why it’s there. 1672385 6 404531 jbedard 2020-07-16 20:48:05 -0700 Created attachment 404531 Patch 1672402 7 404537 jbedard 2020-07-16 22:27:15 -0700 Created attachment 404537 Patch 1672473 8 ews-feeder 2020-07-17 07:09:08 -0700 Committed r264506: <https://trac.webkit.org/changeset/264506> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404537. 404495 2020-07-16 16:44:25 -0700 2020-07-16 20:48:03 -0700 Patch bug-214433-20200716164424.patch text/plain 1525 jbedard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjY0NDg1KQorKysgU291cmNlL1dlYkNv cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA3 LTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9T IDE0XSBTb21lIFBhc3NLaXQgU1BJIGlzIG5vdyBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDQzMworICAgICAgICA8cmRhcjovL3Byb2JsZW0v NjU2OTU4ODk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwYWwvc3BpL2NvY29hL1Bhc3NLaXRTUEkuaDoKKwogMjAyMC0wNy0xNiAgRXJpYyBDYXJs c29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgQVZSb3V0ZVBpY2tl clZpZXcgd2hlbiBhdmFpbGFibGUgZm9yIGNob29zaW5nIEFpclBsYXkgZGV2aWNlcwpJbmRleDog U291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY29jb2EvUGFzc0tpdFNQSS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NvY29hL1Bhc3NLaXRTUEkuaAkocmV2aXNp b24gMjY0NDgxKQorKysgU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY29jb2EvUGFzc0tpdFNQ SS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMjcsMTAgKzMyNywxNCBAQCB0eXBlZGVmIE5TX0VOVU0o TlNJbnRlZ2VyLCBQS1BheW1lbnRTZXR1CiBAcHJvcGVydHkgKG5vbmF0b21pYywgc3Ryb25nKSBO U0FycmF5IDxQS1BheW1lbnRTZXR1cEZlYXR1cmUgKj4gKnBheW1lbnRTZXR1cEZlYXR1cmVzOwog QGVuZAogCisjaWZuZGVmIF9fUEtQQVlNRU5UTUVSQ0hBTlRTRVNTSU9OX0hfXworCiBAaW50ZXJm YWNlIFBLUGF5bWVudE1lcmNoYW50U2Vzc2lvbiA6IE5TT2JqZWN0IDxOU1NlY3VyZUNvZGluZywg TlNDb3B5aW5nPgogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoRGljdGlvbmFyeTooTlNEaWN0aW9u YXJ5ICopZGljdGlvbmFyeTsKIEBlbmQKIAorI2VuZGlmCisKIEBpbnRlcmZhY2UgUEtQYXltZW50 QXV0aG9yaXphdGlvblZpZXdDb250cm9sbGVyICgpCiArICh2b2lkKXBheW1lbnRTZXJ2aWNlc01l cmNoYW50VVJMOih2b2lkKF4pKE5TVVJMICptZXJjaGFudFVSTCwgTlNFcnJvciAqZXJyb3IpKWNv bXBsZXRpb247CiArICh2b2lkKXBheW1lbnRTZXJ2aWNlc01lcmNoYW50VVJMRm9yQVBJVHlwZToo UEtQYXltZW50UmVxdWVzdEFQSVR5cGUpQVBJVHlwZSBjb21wbGV0aW9uOih2b2lkKF4pKE5TVVJM ICptZXJjaGFudFVSTCwgTlNFcnJvciAqZXJyb3IpKWNvbXBsZXRpb247Cg== 404531 2020-07-16 20:48:05 -0700 2020-07-16 22:27:14 -0700 Patch bug-214433-20200716204804.patch text/plain 1613 jbedard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjY0NDg4KQorKysgU291cmNlL1dlYkNv cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA3 LTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9T IDE0XSBTb21lIFBhc3NLaXQgU1BJIGlzIG5vdyBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDQzMworICAgICAgICA8cmRhcjovL3Byb2JsZW0v NjU2OTU4ODk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAg KiBwYWwvc3BpL2NvY29hL1Bhc3NLaXRTUEkuaDoKKwogMjAyMC0wNy0xNiAgRnVqaWkgSGlyb25v cmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBbV1RGXSBSZW1vdmUgdGhl IHVubmVjZXNzYXJ5IGlubmVyIGNsYXNzIERlZmF1bHRIYXNoPFQ+OjpIYXNoCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jb2NvYS9QYXNzS2l0U1BJLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY29jb2EvUGFzc0tpdFNQSS5oCShyZXZpc2lvbiAy NjQ0ODgpCisrKyBTb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jb2NvYS9QYXNzS2l0U1BJLmgJ KHdvcmtpbmcgY29weSkKQEAgLTMyNywxMCArMzI3LDE0IEBAIHR5cGVkZWYgTlNfRU5VTShOU0lu dGVnZXIsIFBLUGF5bWVudFNldHUKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzdHJvbmcpIE5TQXJy YXkgPFBLUGF5bWVudFNldHVwRmVhdHVyZSAqPiAqcGF5bWVudFNldHVwRmVhdHVyZXM7CiBAZW5k CiAKKyNpZiAoUExBVEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJF RCA8IDE0MDAwMCkgfHwgKFBMQVRGT1JNKFdBVENIT1MpICYmIF9fV0FUQ0hfT1NfVkVSU0lPTl9N SU5fUkVRVUlSRUQgPCA3MDAwMCkKKwogQGludGVyZmFjZSBQS1BheW1lbnRNZXJjaGFudFNlc3Np b24gOiBOU09iamVjdCA8TlNTZWN1cmVDb2RpbmcsIE5TQ29weWluZz4KIC0gKGluc3RhbmNldHlw ZSlpbml0V2l0aERpY3Rpb25hcnk6KE5TRGljdGlvbmFyeSAqKWRpY3Rpb25hcnk7CiBAZW5kCiAK KyNlbmRpZgorCiBAaW50ZXJmYWNlIFBLUGF5bWVudEF1dGhvcml6YXRpb25WaWV3Q29udHJvbGxl ciAoKQogKyAodm9pZClwYXltZW50U2VydmljZXNNZXJjaGFudFVSTDoodm9pZCheKShOU1VSTCAq bWVyY2hhbnRVUkwsIE5TRXJyb3IgKmVycm9yKSljb21wbGV0aW9uOwogKyAodm9pZClwYXltZW50 U2VydmljZXNNZXJjaGFudFVSTEZvckFQSVR5cGU6KFBLUGF5bWVudFJlcXVlc3RBUElUeXBlKUFQ SVR5cGUgY29tcGxldGlvbjoodm9pZCheKShOU1VSTCAqbWVyY2hhbnRVUkwsIE5TRXJyb3IgKmVy cm9yKSljb21wbGV0aW9uOwo= 404537 2020-07-16 22:27:15 -0700 2020-07-17 07:09:08 -0700 Patch bug-214433-20200716222714.patch text/plain 1645 jbedard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjY0NDk2KQorKysgU291cmNlL1dlYkNv cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA3 LTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9T IDE0XSBTb21lIFBhc3NLaXQgU1BJIGlzIG5vdyBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDQzMworICAgICAgICA8cmRhcjovL3Byb2JsZW0v NjU2OTU4ODk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAg KiBwYWwvc3BpL2NvY29hL1Bhc3NLaXRTUEkuaDoKKwogMjAyMC0wNy0xNiAgRXJpYyBDYXJsc29u ICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgQVZSb3V0ZVBpY2tlclZp ZXcgd2hlbiBhdmFpbGFibGUgZm9yIGNob29zaW5nIEFpclBsYXkgZGV2aWNlcwpJbmRleDogU291 cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY29jb2EvUGFzc0tpdFNQSS5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NvY29hL1Bhc3NLaXRTUEkuaAkocmV2aXNpb24g MjY0NDk2KQorKysgU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY29jb2EvUGFzc0tpdFNQSS5o CSh3b3JraW5nIGNvcHkpCkBAIC0zMjcsMTAgKzMyNywxNiBAQCB0eXBlZGVmIE5TX0VOVU0oTlNJ bnRlZ2VyLCBQS1BheW1lbnRTZXR1CiBAcHJvcGVydHkgKG5vbmF0b21pYywgc3Ryb25nKSBOU0Fy cmF5IDxQS1BheW1lbnRTZXR1cEZlYXR1cmUgKj4gKnBheW1lbnRTZXR1cEZlYXR1cmVzOwogQGVu ZAogCisjaWYgUExBVEZPUk0oTUFDKSBcCisgICAgfHwgKFBMQVRGT1JNKElPUykgJiYgX19JUEhP TkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxNDAwMDApIFwKKyAgICB8fCAoUExBVEZPUk0o V0FUQ0hPUykgJiYgX19XQVRDSF9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDcwMDAwKQorCiBA aW50ZXJmYWNlIFBLUGF5bWVudE1lcmNoYW50U2Vzc2lvbiA6IE5TT2JqZWN0IDxOU1NlY3VyZUNv ZGluZywgTlNDb3B5aW5nPgogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoRGljdGlvbmFyeTooTlNE aWN0aW9uYXJ5ICopZGljdGlvbmFyeTsKIEBlbmQKIAorI2VuZGlmCisKIEBpbnRlcmZhY2UgUEtQ YXltZW50QXV0aG9yaXphdGlvblZpZXdDb250cm9sbGVyICgpCiArICh2b2lkKXBheW1lbnRTZXJ2 aWNlc01lcmNoYW50VVJMOih2b2lkKF4pKE5TVVJMICptZXJjaGFudFVSTCwgTlNFcnJvciAqZXJy b3IpKWNvbXBsZXRpb247CiArICh2b2lkKXBheW1lbnRTZXJ2aWNlc01lcmNoYW50VVJMRm9yQVBJ VHlwZTooUEtQYXltZW50UmVxdWVzdEFQSVR5cGUpQVBJVHlwZSBjb21wbGV0aW9uOih2b2lkKF4p KE5TVVJMICptZXJjaGFudFVSTCwgTlNFcnJvciAqZXJyb3IpKWNvbXBsZXRpb247Cg==