214427 2020-07-16 15:13:07 -0700 XPC connection should be suspended before setting target queue 2020-07-16 18:01:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan benjamin bfulgham cdumez cmarcelo darin ews-watchlist webkit-bug-importer oldest_to_newest 1672264 0 pvollan 2020-07-16 15:13:07 -0700 An active XPC connection should be suspended before setting a new target queue. 1672267 1 404487 pvollan 2020-07-16 15:24:26 -0700 Created attachment 404487 Patch 1672299 2 404487 darin 2020-07-16 16:47:37 -0700 Comment on attachment 404487 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404487&action=review > Source/WTF/ChangeLog:3 > + XPC connection should be suspended before setting target queue Why? 1672303 3 pvollan 2020-07-16 17:01:39 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 404487 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404487&action=review > > > Source/WTF/ChangeLog:3 > > + XPC connection should be suspended before setting target queue > > Why? According to logs, it is an error to set the target queue while the connection is active. I will update the change log. Thanks for reviewing! 1672305 4 404498 pvollan 2020-07-16 17:13:14 -0700 Created attachment 404498 Patch 1672329 5 ews-feeder 2020-07-16 18:00:50 -0700 Committed r264489: <https://trac.webkit.org/changeset/264489> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404498. 1672331 6 webkit-bug-importer 2020-07-16 18:01:17 -0700 <rdar://problem/65699751> 404487 2020-07-16 15:24:26 -0700 2020-07-16 16:47:37 -0700 Patch bug-214427-20200716152425.patch text/plain 3139 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjQ0ODEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA3LTE2ICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBYUEMgY29ubmVjdGlvbiBzaG91bGQgYmUgc3Vz cGVuZGVkIGJlZm9yZSBzZXR0aW5nIHRhcmdldCBxdWV1ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0NDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVjbGFyZSBmdW5jdGlvbiB0byBzdXNwZW5kIFhQ QyBjb25uZWN0aW9uLgorCisgICAgICAgICogd3RmL3NwaS9kYXJ3aW4vWFBDU1BJLmg6CisKIDIw MjAtMDctMTYgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAg IFtCaWcgU3VyXSBEZS1kdXBsaWNhdGUgU1BJCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9zcGkvZGFy d2luL1hQQ1NQSS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3NwaS9kYXJ3aW4vWFBD U1BJLmgJKHJldmlzaW9uIDI2NDQ4MSkKKysrIFNvdXJjZS9XVEYvd3RmL3NwaS9kYXJ3aW4vWFBD U1BJLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyNyw2ICsxMjcsNyBAQCB4cGNfY29ubmVjdGlvbl90 IHhwY19jb25uZWN0aW9uX2NyZWF0ZV9mCiB4cGNfY29ubmVjdGlvbl90IHhwY19jb25uZWN0aW9u X2NyZWF0ZV9tYWNoX3NlcnZpY2UoY29uc3QgY2hhciogbmFtZSwgZGlzcGF0Y2hfcXVldWVfdCwg dWludDY0X3QgZmxhZ3MpOwogcGlkX3QgeHBjX2Nvbm5lY3Rpb25fZ2V0X3BpZCh4cGNfY29ubmVj dGlvbl90KTsKIHZvaWQgeHBjX2Nvbm5lY3Rpb25fcmVzdW1lKHhwY19jb25uZWN0aW9uX3QpOwor dm9pZCB4cGNfY29ubmVjdGlvbl9zdXNwZW5kKHhwY19jb25uZWN0aW9uX3QpOwogdm9pZCB4cGNf Y29ubmVjdGlvbl9zZW5kX21lc3NhZ2UoeHBjX2Nvbm5lY3Rpb25fdCwgeHBjX29iamVjdF90KTsK IHZvaWQgeHBjX2Nvbm5lY3Rpb25fc2VuZF9tZXNzYWdlX3dpdGhfcmVwbHkoeHBjX2Nvbm5lY3Rp b25fdCwgeHBjX29iamVjdF90LCBkaXNwYXRjaF9xdWV1ZV90LCB4cGNfaGFuZGxlcl90KTsKIHZv aWQgeHBjX2Nvbm5lY3Rpb25fc2V0X2V2ZW50X2hhbmRsZXIoeHBjX2Nvbm5lY3Rpb25fdCwgeHBj X2hhbmRsZXJfdCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkocmV2aXNpb24gMjY0NDgxKQorKysgU291cmNlL1dl YktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAyMC0wNy0x NiAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgWFBDIGNv bm5lY3Rpb24gc2hvdWxkIGJlIHN1c3BlbmRlZCBiZWZvcmUgc2V0dGluZyB0YXJnZXQgcXVldWUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDQyNwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFuIGFjdGl2 ZSBYUEMgY29ubmVjdGlvbiBzaG91bGQgYmUgc3VzcGVuZGVkIGJlZm9yZSBzZXR0aW5nIGEgbmV3 IHRhcmdldCBxdWV1ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHNpbmNlIHRoZXJlIHNob3Vs ZCBiZSBubyBiZWhhdmlvciBjaGFuZ2UgaW50cm9kdWNlZCBieSB0aGlzIHBhdGNoLgorCisgICAg ICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW06CisgICAgICAgIChXZWJL aXQ6OldlYlByb2Nlc3M6OmhhbmRsZVhQQ0VuZHBvaW50TWVzc2FnZXMgY29uc3QpOgorCiAyMDIw LTA3LTE2ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAg ICAgU2VsZWN0aW9uIGlzIG5vdCBhbHdheXMgY2xlYXJpbmcgd2hlbiB0YXBwaW5nLgpJbmRleDog U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1t CShyZXZpc2lvbiAyNjQ0ODEpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2Vi UHJvY2Vzc0NvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNzEsNiArMTcxLDggQEAgdm9pZCBX ZWJQcm9jZXNzOjpoYW5kbGVYUENFbmRwb2ludE1lc3NhZwogCiAgICAgYXV0byBjb25uZWN0aW9u ID0gcGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+eHBjQ29ubmVjdGlvbigpOwogCisgICAgeHBj X2Nvbm5lY3Rpb25fc3VzcGVuZChjb25uZWN0aW9uKTsKKwogICAgIHhwY19jb25uZWN0aW9uX3Nl dF90YXJnZXRfcXVldWUoY29ubmVjdGlvbiwgZGlzcGF0Y2hfZ2V0X2dsb2JhbF9xdWV1ZShESVNQ QVRDSF9RVUVVRV9QUklPUklUWV9ERUZBVUxULCAwKSk7CiAgICAgeHBjX2Nvbm5lY3Rpb25fc2V0 X2V2ZW50X2hhbmRsZXIoY29ubmVjdGlvbiwgXih4cGNfb2JqZWN0X3QgZXZlbnQpIHsKICAgICAg ICAgaWYgKHhwY19nZXRfdHlwZShldmVudCkgIT0gWFBDX1RZUEVfRElDVElPTkFSWSkKQEAgLTE4 Niw2ICsxODgsOCBAQCB2b2lkIFdlYlByb2Nlc3M6OmhhbmRsZVhQQ0VuZHBvaW50TWVzc2FnCiAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICB9KTsKKworICAgIHhwY19jb25uZWN0 aW9uX3Jlc3VtZShjb25uZWN0aW9uKTsKIH0KIAogdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUlu aXRpYWxpemVXZWJQcm9jZXNzKFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmIHBhcmFtZXRl cnMpCg== 404498 2020-07-16 17:13:14 -0700 2020-07-16 18:00:51 -0700 Patch bug-214427-20200716171313.patch text/plain 3200 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjQ0ODIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA3LTE2ICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBYUEMgY29ubmVjdGlvbiBzaG91bGQgYmUgc3Vz cGVuZGVkIGJlZm9yZSBzZXR0aW5nIHRhcmdldCBxdWV1ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0NDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCisKKyAgICAgICAgRGVjbGFyZSBmdW5jdGlvbiB0byBzdXNwZW5kIFhQQyBj b25uZWN0aW9uLgorCisgICAgICAgICogd3RmL3NwaS9kYXJ3aW4vWFBDU1BJLmg6CisKIDIwMjAt MDctMTYgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAg VXNlIEFWUm91dGVQaWNrZXJWaWV3IHdoZW4gYXZhaWxhYmxlIGZvciBjaG9vc2luZyBBaXJQbGF5 IGRldmljZXMKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL3NwaS9kYXJ3aW4vWFBDU1BJLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dURi93dGYvc3BpL2Rhcndpbi9YUENTUEkuaAkocmV2aXNpb24gMjY0 NDgyKQorKysgU291cmNlL1dURi93dGYvc3BpL2Rhcndpbi9YUENTUEkuaAkod29ya2luZyBjb3B5 KQpAQCAtMTI3LDYgKzEyNyw3IEBAIHhwY19jb25uZWN0aW9uX3QgeHBjX2Nvbm5lY3Rpb25fY3Jl YXRlX2YKIHhwY19jb25uZWN0aW9uX3QgeHBjX2Nvbm5lY3Rpb25fY3JlYXRlX21hY2hfc2Vydmlj ZShjb25zdCBjaGFyKiBuYW1lLCBkaXNwYXRjaF9xdWV1ZV90LCB1aW50NjRfdCBmbGFncyk7CiBw aWRfdCB4cGNfY29ubmVjdGlvbl9nZXRfcGlkKHhwY19jb25uZWN0aW9uX3QpOwogdm9pZCB4cGNf Y29ubmVjdGlvbl9yZXN1bWUoeHBjX2Nvbm5lY3Rpb25fdCk7Cit2b2lkIHhwY19jb25uZWN0aW9u X3N1c3BlbmQoeHBjX2Nvbm5lY3Rpb25fdCk7CiB2b2lkIHhwY19jb25uZWN0aW9uX3NlbmRfbWVz c2FnZSh4cGNfY29ubmVjdGlvbl90LCB4cGNfb2JqZWN0X3QpOwogdm9pZCB4cGNfY29ubmVjdGlv bl9zZW5kX21lc3NhZ2Vfd2l0aF9yZXBseSh4cGNfY29ubmVjdGlvbl90LCB4cGNfb2JqZWN0X3Qs IGRpc3BhdGNoX3F1ZXVlX3QsIHhwY19oYW5kbGVyX3QpOwogdm9pZCB4cGNfY29ubmVjdGlvbl9z ZXRfZXZlbnRfaGFuZGxlcih4cGNfY29ubmVjdGlvbl90LCB4cGNfaGFuZGxlcl90KTsKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjQ0ODIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA3LTE2ICBQZXIgQXJuZSBWb2xsYW4g IDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBYUEMgY29ubmVjdGlvbiBzaG91bGQgYmUg c3VzcGVuZGVkIGJlZm9yZSBzZXR0aW5nIHRhcmdldCBxdWV1ZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0NDI3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvIHN5c3RlbSBsb2dzLCBhbiBh Y3RpdmUgWFBDIGNvbm5lY3Rpb24gc2hvdWxkIGJlIHN1c3BlbmRlZCBiZWZvcmUgc2V0dGluZyBh IG5ldyB0YXJnZXQgcXVldWUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaW5jZSB0aGVyZSBz aG91bGQgYmUgbm8gYmVoYXZpb3IgY2hhbmdlIGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaC4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tOgorICAgICAgICAo V2ViS2l0OjpXZWJQcm9jZXNzOjpoYW5kbGVYUENFbmRwb2ludE1lc3NhZ2VzIGNvbnN0KToKKwog MjAyMC0wNy0xNiAgTWVnYW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFNlbGVjdGlvbiBpcyBub3QgYWx3YXlzIGNsZWFyaW5nIHdoZW4gdGFwcGluZy4KSW5k ZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2Nv YS5tbQkocmV2aXNpb24gMjY0NDgyKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29h L1dlYlByb2Nlc3NDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtMTcxLDYgKzE3MSw4IEBAIHZv aWQgV2ViUHJvY2Vzczo6aGFuZGxlWFBDRW5kcG9pbnRNZXNzYWcKIAogICAgIGF1dG8gY29ubmVj dGlvbiA9IHBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnhwY0Nvbm5lY3Rpb24oKTsKIAorICAg IHhwY19jb25uZWN0aW9uX3N1c3BlbmQoY29ubmVjdGlvbik7CisKICAgICB4cGNfY29ubmVjdGlv bl9zZXRfdGFyZ2V0X3F1ZXVlKGNvbm5lY3Rpb24sIGRpc3BhdGNoX2dldF9nbG9iYWxfcXVldWUo RElTUEFUQ0hfUVVFVUVfUFJJT1JJVFlfREVGQVVMVCwgMCkpOwogICAgIHhwY19jb25uZWN0aW9u X3NldF9ldmVudF9oYW5kbGVyKGNvbm5lY3Rpb24sIF4oeHBjX29iamVjdF90IGV2ZW50KSB7CiAg ICAgICAgIGlmICh4cGNfZ2V0X3R5cGUoZXZlbnQpICE9IFhQQ19UWVBFX0RJQ1RJT05BUlkpCkBA IC0xODYsNiArMTg4LDggQEAgdm9pZCBXZWJQcm9jZXNzOjpoYW5kbGVYUENFbmRwb2ludE1lc3Nh ZwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgfSk7CisKKyAgICB4cGNfY29u bmVjdGlvbl9yZXN1bWUoY29ubmVjdGlvbik7CiB9CiAKIHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZv cm1Jbml0aWFsaXplV2ViUHJvY2VzcyhXZWJQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiBwYXJh bWV0ZXJzKQo=