214419 2020-07-16 12:41:08 -0700 Remove (entirely unused) hat switch dpad support in HIDGamepad 2020-07-16 13:35:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson aestes webkit-bug-importer oldest_to_newest 1672211 0 beidson 2020-07-16 12:41:08 -0700 Remove (entirely unused) hat switch dpad support in HIDGamepad Turns out these simply don't exist in the wild. 1672213 1 404475 beidson 2020-07-16 12:44:17 -0700 Created attachment 404475 Patch 1672227 2 ews-feeder 2020-07-16 13:34:02 -0700 Committed r264475: <https://trac.webkit.org/changeset/264475> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404475. 1672228 3 webkit-bug-importer 2020-07-16 13:35:22 -0700 <rdar://problem/65686398> 404475 2020-07-16 12:44:17 -0700 2020-07-16 13:34:02 -0700 Patch bug-214419-20200716124417.patch text/plain 7095 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjNlMzNmZTViMDE5MjBj YzBhNTQyYjZlNzNmYjUzNzgyYjEwYTA2MC4uN2FiMzRhOTAwYzRmNDA2OTQ2ZTgxMjNjNGUwMTA3 ZTMwNDRjMTdhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA3LTE2ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgKGVudGlyZWx5 IHVudXNlZCkgaGF0IHN3aXRjaCBkcGFkIHN1cHBvcnQgaW4gSElER2FtZXBhZC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDQxOQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm5zIG91dCB0aGVzZSBk ZXZpY2VzIHNpbXBseSBkb24ndCBleGlzdCBpbiB0aGUgd2lsZC4KKworICAgICAgICAqIHBsYXRm b3JtL2dhbWVwYWQvbWFjL0hJREdhbWVwYWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SElER2Ft ZXBhZDo6aW5pdEVsZW1lbnRzKToKKyAgICAgICAgKFdlYkNvcmU6OkhJREdhbWVwYWQ6OmluaXRF bGVtZW50c0Zyb21BcnJheSk6CisgICAgICAgIChXZWJDb3JlOjpISURHYW1lcGFkOjp2YWx1ZUNo YW5nZWQpOgorICAgICAgICAoV2ViQ29yZTo6SElER2FtZXBhZDo6bWF5YmVBZGREUGFkKTogRGVs ZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OmZpbGxJbkJ1dHRvblZhbHVlcyk6IERlbGV0ZWQuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9nYW1lcGFkL21hYy9ISURHYW1lcGFkLmg6CisgICAgICAgIChX ZWJDb3JlOjpISURHYW1lcGFkRWxlbWVudDo6aXNBeGlzIGNvbnN0KToKKyAgICAgICAgKFdlYkNv cmU6OkhJREdhbWVwYWRFbGVtZW50Ojppc0RQYWQgY29uc3QpOiBEZWxldGVkLgorICAgICAgICAo V2ViQ29yZTo6SElER2FtZXBhZERQYWQ6OkhJREdhbWVwYWREUGFkKTogRGVsZXRlZC4KKyAgICAg ICAgKFdlYkNvcmU6OkhJREdhbWVwYWREUGFkOjpub3JtYWxpemVkVmFsdWUpOiBEZWxldGVkLgor CiAyMDIwLTA3LTE1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCBhdHR0ZW1wdCB0byBmaXggYnVpbGQgYWZ0ZXIgcjI2NDM4OS4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dhbWVwYWQvbWFjL0hJREdhbWVwYWQuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2FtZXBhZC9tYWMvSElER2FtZXBhZC5jcHAKaW5kZXgg NGY1ZDkwZTU2NmUyNzIxMTdiNTUzZWNlOTIxMWQ0NzlkZGQwNDg3Yy4uYjhmMWYzYTc5MjU5NzM4 YjNhNDNkYmM4M2RlNGQwOTI2NDU5OWZlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ2FtZXBhZC9tYWMvSElER2FtZXBhZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ2FtZXBhZC9tYWMvSElER2FtZXBhZC5jcHAKQEAgLTgwLDE1ICs4MCwxNCBAQCB2b2lk IEhJREdhbWVwYWQ6OmluaXRFbGVtZW50cygpCiAgICAgICAgIHJldHVybiBhLT5wcmlvcml0eSA8 IGItPnByaW9yaXR5OwogICAgIH0pOwogCisgICAgTE9HKEdhbWVwYWQsICJISURHYW1lcGFkIGlu aXRpYWxpemVkIHdpdGggJXp1IGJ1dHRvbnMgYW5kICV6dSBheGVzIiwgbV9idXR0b25zLnNpemUo KSwgbV9heGVzLnNpemUoKSk7CisKICAgICBtX2F4aXNWYWx1ZXMucmVzaXplKG1fYXhlcy5zaXpl KCkpOwotICAgIG1fYnV0dG9uVmFsdWVzLnJlc2l6ZShtX2J1dHRvbnMuc2l6ZSgpICsgKG1fZFBh ZHMuc2l6ZSgpICogNCkpOworICAgIG1fYnV0dG9uVmFsdWVzLnJlc2l6ZShtX2J1dHRvbnMuc2l6 ZSgpKTsKIAogICAgIGZvciAoYXV0byYgYnV0dG9uIDogbV9idXR0b25zKQogICAgICAgICBnZXRD dXJyZW50VmFsdWVGb3JFbGVtZW50KGJ1dHRvbi5nZXQoKSk7CiAKLSAgICBmb3IgKGF1dG8mIGRQ YWQgOiBtX2RQYWRzKQotICAgICAgICBnZXRDdXJyZW50VmFsdWVGb3JFbGVtZW50KGRQYWQuZ2V0 KCkpOwotCiAgICAgZm9yIChhdXRvJiBheGlzIDogbV9heGVzKQogICAgICAgICBnZXRDdXJyZW50 VmFsdWVGb3JFbGVtZW50KGF4aXMuZ2V0KCkpOwogfQpAQCAtMTEyLDggKzExMSw2IEBAIHZvaWQg SElER2FtZXBhZDo6aW5pdEVsZW1lbnRzRnJvbUFycmF5KENGQXJyYXlSZWYgZWxlbWVudHMpCiAg ICAgICAgIGlmICgodHlwZSA9PSBrSU9ISURFbGVtZW50VHlwZUlucHV0X01pc2MgfHwgdHlwZSA9 PSBrSU9ISURFbGVtZW50VHlwZUlucHV0X0J1dHRvbikpIHsKICAgICAgICAgICAgIGlmIChtYXli ZUFkZEJ1dHRvbihlbGVtZW50KSkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAg ICAgIGlmIChtYXliZUFkZERQYWQoZWxlbWVudCkpCi0gICAgICAgICAgICAgICAgY29udGludWU7 CiAgICAgICAgIH0KIAogICAgICAgICBpZiAoKHR5cGUgPT0ga0lPSElERWxlbWVudFR5cGVJbnB1 dF9NaXNjIHx8IHR5cGUgPT0ga0lPSElERWxlbWVudFR5cGVJbnB1dF9BeGlzKSAmJiBtYXliZUFk ZEF4aXMoZWxlbWVudCkpCkBAIC0xNTAsMjcgKzE0Nyw2IEBAIGJvb2wgSElER2FtZXBhZDo6bWF5 YmVBZGRCdXR0b24oSU9ISURFbGVtZW50UmVmIGVsZW1lbnQpCiAgICAgcmV0dXJuIHRydWU7CiB9 CiAKLWJvb2wgSElER2FtZXBhZDo6bWF5YmVBZGREUGFkKElPSElERWxlbWVudFJlZiBlbGVtZW50 KQotewotICAgIHVpbnQzMl90IHVzYWdlUGFnZSA9IElPSElERWxlbWVudEdldFVzYWdlUGFnZShl bGVtZW50KTsKLSAgICBpZiAodXNhZ2VQYWdlICE9IGtISURQYWdlX0dlbmVyaWNEZXNrdG9wKQot ICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAgICB1aW50MzJfdCB1c2FnZSA9IElPSElERWxlbWVu dEdldFVzYWdlKGVsZW1lbnQpOwotICAgIGlmICghdXNhZ2UgfHwgdXNhZ2UgIT0ga0hJRFVzYWdl X0dEX0hhdHN3aXRjaCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgQ0ZJbmRleCBtaW4g PSBJT0hJREVsZW1lbnRHZXRMb2dpY2FsTWluKGVsZW1lbnQpOwotICAgIENGSW5kZXggbWF4ID0g SU9ISURFbGVtZW50R2V0TG9naWNhbE1heChlbGVtZW50KTsKLQotICAgIG1fZFBhZHMuYXBwZW5k KG1ha2VVbmlxdWVSZWY8SElER2FtZXBhZERQYWQ+KG1pbiwgbWF4LCBlbGVtZW50KSk7Ci0KLSAg ICBJT0hJREVsZW1lbnRDb29raWUgY29va2llID0gSU9ISURFbGVtZW50R2V0Q29va2llKGVsZW1l bnQpOwotICAgIG1fZWxlbWVudE1hcC5zZXQoY29va2llLCAmbV9kUGFkcy5sYXN0KCkuZ2V0KCkp OwotCi0gICAgcmV0dXJuIHRydWU7Ci19Ci0KIGJvb2wgSElER2FtZXBhZDo6bWF5YmVBZGRBeGlz KElPSElERWxlbWVudFJlZiBlbGVtZW50KQogewogICAgIHVpbnQzMl90IHVzYWdlUGFnZSA9IElP SElERWxlbWVudEdldFVzYWdlUGFnZShlbGVtZW50KTsKQEAgLTE5MywzOCArMTY5LDYgQEAgYm9v bCBISURHYW1lcGFkOjptYXliZUFkZEF4aXMoSU9ISURFbGVtZW50UmVmIGVsZW1lbnQpCiAgICAg cmV0dXJuIHRydWU7CiB9CiAKLXN0YXRpYyB2b2lkIGZpbGxJbkJ1dHRvblZhbHVlcyhpbnQgdmFs dWUsIGRvdWJsZSYgYnV0dG9uMCwgZG91YmxlJiBidXR0b24xLCBkb3VibGUmIGJ1dHRvbjIsIGRv dWJsZSYgYnV0dG9uMykKLXsKLSAgICAvLyBTdGFuZGFyZCBEUGFkcyBoYXZlIDggcG9zc2libGUg cG9zaXRpb24gdmFsdWVzLCBtb3ZpbmcgYXJvdW5kIGEgY2lyY2xlOgotICAgIC8vIDAgLSBVcAot ICAgIC8vIDEgLSBVcCArIHJpZ2h0Ci0gICAgLy8gMiAtIFJpZ2h0Ci0gICAgLy8gMyAtIERvd24g KyByaWdodAotICAgIC8vIDQgLSBEb3duCi0gICAgLy8gNSAtIERvd24gKyBsZWZ0Ci0gICAgLy8g NiAtIExlZnQKLSAgICAvLyA3IC0gVXAgYW5kIExlZnQKLSAgICAvLyBUaGVzZSA4IHBvc2l0aW9u cyBhcmUgbWFwcGVkIG9uIHRvIDQgYnV0dG9uIHBvc2l0aW9uczoKLSAgICAvLyAwIC0gVXAKLSAg ICAvLyAxIC0gRG93bgotICAgIC8vIDIgLSBMZWZ0Ci0gICAgLy8gMyAtIFJpZ2h0Ci0KLSAgICBp ZiAodmFsdWUgPCAwIHx8IHZhbHVlID4gNykgewotICAgICAgICAvLyBIYW5kbGUgYW4gaW52YWxp ZCBpbnB1dCB2YWx1ZSB0aGF0IHdlIGRvbid0IGtub3cgaG93IHRvIGludGVycHJldC4KLSAgICAg ICAgYnV0dG9uMCA9IDAuMDsKLSAgICAgICAgYnV0dG9uMSA9IDAuMDsKLSAgICAgICAgYnV0dG9u MiA9IDAuMDsKLSAgICAgICAgYnV0dG9uMyA9IDAuMDsKLSAgICAgICAgcmV0dXJuOwotICAgIH0K LQotICAgIGJ1dHRvbjAgPSB2YWx1ZSA8IDIgfHwgdmFsdWUgPT0gNyA/IDEuMCA6IDAuMDsKLSAg ICBidXR0b24xID0gdmFsdWUgPiAyICYmIHZhbHVlIDwgNiA/IDEuMCA6IDAuMDsKLSAgICBidXR0 b24yID0gdmFsdWUgPiA0ID8gMS4wIDogMC4wOwotICAgIGJ1dHRvbjMgPSB2YWx1ZSA+IDAgJiYg dmFsdWUgPCA0ID8gMS4wIDogMC4wOwotfQotCiBISURJbnB1dFR5cGUgSElER2FtZXBhZDo6dmFs dWVDaGFuZ2VkKElPSElEVmFsdWVSZWYgdmFsdWUpCiB7CiAgICAgSU9ISURFbGVtZW50Q29va2ll IGNvb2tpZSA9IElPSElERWxlbWVudEdldENvb2tpZShJT0hJRFZhbHVlR2V0RWxlbWVudCh2YWx1 ZSkpOwpAQCAtMjUwLDE5ICsxOTQsNiBAQCBISURJbnB1dFR5cGUgSElER2FtZXBhZDo6dmFsdWVD aGFuZ2VkKElPSElEVmFsdWVSZWYgdmFsdWUpCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAg ICAgICAgICB9CiAgICAgICAgIH0KLSAgICB9IGVsc2UgaWYgKGVsZW1lbnQtPmlzRFBhZCgpKSB7 Ci0gICAgICAgIGludCBpbnRWYWx1ZSA9IElPSElEVmFsdWVHZXRJbnRlZ2VyVmFsdWUodmFsdWUp IC0gZWxlbWVudC0+bWluOwotICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbV9kUGFk cy5zaXplKCk7ICsraSkgewotICAgICAgICAgICAgaWYgKCZtX2RQYWRzW2ldLmdldCgpICE9IGVs ZW1lbnQpCi0gICAgICAgICAgICAgICAgY29udGludWU7Ci0KLSAgICAgICAgICAgIC8vIEVhY2gg RFBhZCByZXByZXNlbnRzIDQgYnV0dG9uIHZhbHVlcyB3aGljaCBhcmUgdGFja2VkIG9uIHRvIHRo ZSBlbmQgb2YgdGhlIHZhbHVlcyBmcm9tIG5vbi1EUGFkIGJ1dHRvbnMuCi0gICAgICAgICAgICB1 bnNpZ25lZCBmaXJzdEJ1dHRvblZhbHVlID0gbV9idXR0b25zLnNpemUoKSArIGkgKiA0OwotCi0g ICAgICAgICAgICBBU1NFUlQobV9idXR0b25WYWx1ZXMuc2l6ZSgpID4gZmlyc3RCdXR0b25WYWx1 ZSArIDMpOwotCi0gICAgICAgICAgICBmaWxsSW5CdXR0b25WYWx1ZXMoaW50VmFsdWUsIG1fYnV0 dG9uVmFsdWVzW2ZpcnN0QnV0dG9uVmFsdWVdLCBtX2J1dHRvblZhbHVlc1tmaXJzdEJ1dHRvblZh bHVlICsgMV0sIG1fYnV0dG9uVmFsdWVzW2ZpcnN0QnV0dG9uVmFsdWUgKyAyXSwgbV9idXR0b25W YWx1ZXNbZmlyc3RCdXR0b25WYWx1ZSArIDNdKTsKLSAgICAgICAgfQogICAgIH0gZWxzZQogICAg ICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ2FtZXBhZC9tYWMvSElER2FtZXBhZC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ2FtZXBhZC9tYWMvSElER2FtZXBhZC5oCmluZGV4IDE2NDFmNDA1MmYzMWY0NGE3NmU4NzZj MGM4ODliMDBiNzExOWQxMTMuLjgzODkzOGI0MmJkYWYzMDRkYzFhNGFjYTE5NzA4OGY0OGJhOGVi YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dhbWVwYWQvbWFjL0hJREdh bWVwYWQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9nYW1lcGFkL21hYy9ISURHYW1l cGFkLmgKQEAgLTU2LDcgKzU2LDYgQEAgc3RydWN0IEhJREdhbWVwYWRFbGVtZW50IHsKIAogICAg IHZpcnR1YWwgYm9vbCBpc0J1dHRvbigpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdmly dHVhbCBib29sIGlzQXhpcygpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Ci0gICAgdmlydHVhbCBi b29sIGlzRFBhZCgpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CiAKICAgICB2aXJ0dWFsIGRvdWJs ZSBub3JtYWxpemVkVmFsdWUoKSA9IDA7CiB9OwpAQCAtOTQsMTcgKzkzLDYgQEAgc3RydWN0IEhJ REdhbWVwYWRBeGlzIDogSElER2FtZXBhZEVsZW1lbnQgewogICAgIH0KIH07CiAKLXN0cnVjdCBI SURHYW1lcGFkRFBhZCA6IEhJREdhbWVwYWRFbGVtZW50IHsKLSAgICBISURHYW1lcGFkRFBhZChk b3VibGUgbWluLCBkb3VibGUgbWF4LCBJT0hJREVsZW1lbnRSZWYgZWxlbWVudCkKLSAgICAgICAg OiBISURHYW1lcGFkRWxlbWVudChtaW4sIG1heCwgZWxlbWVudCkKLSAgICB7Ci0gICAgfQotCi0g ICAgYm9vbCBpc0RQYWQoKSBjb25zdCBmaW5hbCB7IHJldHVybiB0cnVlOyB9Ci0KLSAgICB2aXJ0 dWFsIGRvdWJsZSBub3JtYWxpemVkVmFsdWUoKSB7IFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVE KCk7IH0KLX07Ci0KIGVudW0gY2xhc3MgSElESW5wdXRUeXBlIHsKICAgICBCdXR0b25QcmVzcywK ICAgICBOb3RBQnV0dG9uUHJlc3MsCkBAIC0xMjgsNyArMTE2LDYgQEAgcHJpdmF0ZToKICAgICB2 b2lkIGluaXRFbGVtZW50c0Zyb21BcnJheShDRkFycmF5UmVmKTsKIAogICAgIGJvb2wgbWF5YmVB ZGRCdXR0b24oSU9ISURFbGVtZW50UmVmKTsKLSAgICBib29sIG1heWJlQWRkRFBhZChJT0hJREVs ZW1lbnRSZWYpOwogICAgIGJvb2wgbWF5YmVBZGRBeGlzKElPSElERWxlbWVudFJlZik7CiAKICAg ICB2b2lkIGdldEN1cnJlbnRWYWx1ZUZvckVsZW1lbnQoY29uc3QgSElER2FtZXBhZEVsZW1lbnQm KTsKQEAgLTEzOSw3ICsxMjYsNiBAQCBwcml2YXRlOgogCiAgICAgVmVjdG9yPFVuaXF1ZVJlZjxI SURHYW1lcGFkQnV0dG9uPj4gbV9idXR0b25zOwogICAgIFZlY3RvcjxVbmlxdWVSZWY8SElER2Ft ZXBhZEF4aXM+PiBtX2F4ZXM7Ci0gICAgVmVjdG9yPFVuaXF1ZVJlZjxISURHYW1lcGFkRFBhZD4+ IG1fZFBhZHM7CiAgICAgVmVjdG9yPGRvdWJsZT4gbV9idXR0b25WYWx1ZXM7CiAgICAgVmVjdG9y PGRvdWJsZT4gbV9heGlzVmFsdWVzOwogfTsK