214416 2020-07-16 11:27:08 -0700 Make DocumentParser.ParserState an enum class 2020-07-16 23:40:17 -0700 1 1 1 Unclassified WebKit New Bugs Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis cdumez darin esprehn+autocc ews-watchlist kangil.han webkit-bug-importer oldest_to_newest 1672194 0 rbuis 2020-07-16 11:27:08 -0700 Make DocumentParser.ParserState an enum class since it is more readable. 1672196 1 404468 rbuis 2020-07-16 11:28:12 -0700 Created attachment 404468 Patch 1672240 2 404468 darin 2020-07-16 14:22:17 -0700 Comment on attachment 404468 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404468&action=review > Source/WebCore/dom/DocumentParser.h:70 > + bool isStopped() const { return m_state >= ParserState::Stopped; } Very sneaky that this one is different from the other three. I wonder if some of the callers who are checking isStopped() actually should be checking !isParsing() instead. 1672409 3 ews-feeder 2020-07-16 23:39:13 -0700 Committed r264501: <https://trac.webkit.org/changeset/264501> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404468. 1672410 4 webkit-bug-importer 2020-07-16 23:40:17 -0700 <rdar://problem/65710633> 404468 2020-07-16 11:28:12 -0700 2020-07-16 23:39:13 -0700 Patch bug-214416-20200716192811.patch text/plain 3960 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGRhMGE3NWJlYThiMmNl MmE2ZDQzYjQ4ODkxM2FkNDUyZThmNDhjMi4uYWRlNGRmZmYxZWI0NzYxY2UxMDc2ZTgyYjFiNjg2 NjQzOGQ3MDRmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA3LTE2ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTWFrZSBEb2N1bWVudFBhcnNlci5Q YXJzZXJTdGF0ZSBhbiBlbnVtIGNsYXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTQ0MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNYWtlIERvY3VtZW50UGFyc2VyLlBhcnNlclN0YXRlIGFuIGVudW0g Y2xhc3Mgc2luY2UgaXQgaXMgbW9yZSByZWFkYWJsZS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVu dFBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudFBhcnNlcjo6RG9jdW1lbnRQ YXJzZXIpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRQYXJzZXI6OnN0YXJ0UGFyc2luZyk6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudFBhcnNlcjo6cHJlcGFyZVRvU3RvcFBhcnNpbmcp OgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRQYXJzZXI6OnN0b3BQYXJzaW5nKToKKyAgICAg ICAgKFdlYkNvcmU6OkRvY3VtZW50UGFyc2VyOjpkZXRhY2gpOgorICAgICAgICAqIGRvbS9Eb2N1 bWVudFBhcnNlci5oOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnRQYXJzZXI6OmlzUGFyc2lu ZyBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudFBhcnNlcjo6aXNTdG9wcGluZyBj b25zdCk6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudFBhcnNlcjo6aXNTdG9wcGVkIGNvbnN0 KToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50UGFyc2VyOjppc0RldGFjaGVkIGNvbnN0KToK KyAgICAgICAgKCk6IERlbGV0ZWQuCisKIDIwMjAtMDctMTYgIEFuZHJlcyBHb256YWxleiAgPGFu ZHJlc2dfMjJAYXBwbGUuY29tPgogCiAgICAgICAgIFt3ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3Jh cHBlciBkb0FYQXR0cmlidXRlZFN0cmluZ0ZvclRleHRNYXJrZXJSYW5nZV1uZWVkcyB0byBhdXRv cmVsZWFzZSB0aGUgcmV0dXJuIHZhbHVlIGZyb20gdGhlIG1haW4gdGhyZWFkLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50UGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudFBhcnNlci5jcHAKaW5kZXggMzE2YzQyYzMzZmUyNGQxZWZiM2YwMTJiNDdj YmI1ZTcyN2UwOThmYS4uNzYyZDljMDBjZjlhMmY1YzQyYThhMzQ4YTc2YTU3NzhmMGIzZmNiNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50UGFyc2VyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRQYXJzZXIuY3BwCkBAIC0zMiw3ICszMiw3IEBACiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAKIERvY3VtZW50UGFyc2VyOjpEb2N1bWVudFBhcnNlcihEb2N1 bWVudCYgZG9jdW1lbnQpCi0gICAgOiBtX3N0YXRlKFBhcnNpbmdTdGF0ZSkKKyAgICA6IG1fc3Rh dGUoUGFyc2VyU3RhdGU6OlBhcnNpbmcpCiAgICAgLCBtX2RvY3VtZW50V2FzTG9hZGVkQXNQYXJ0 T2ZOYXZpZ2F0aW9uKGZhbHNlKQogICAgICwgbV9kb2N1bWVudChtYWtlV2Vha1B0cihkb2N1bWVu dCkpCiB7CkBAIC00OCwyMyArNDgsMjMgQEAgRG9jdW1lbnRQYXJzZXI6On5Eb2N1bWVudFBhcnNl cigpCiAKIHZvaWQgRG9jdW1lbnRQYXJzZXI6OnN0YXJ0UGFyc2luZygpCiB7Ci0gICAgbV9zdGF0 ZSA9IFBhcnNpbmdTdGF0ZTsKKyAgICBtX3N0YXRlID0gUGFyc2VyU3RhdGU6OlBhcnNpbmc7CiB9 CiAKIHZvaWQgRG9jdW1lbnRQYXJzZXI6OnByZXBhcmVUb1N0b3BQYXJzaW5nKCkKIHsKLSAgICBB U1NFUlQobV9zdGF0ZSA9PSBQYXJzaW5nU3RhdGUpOwotICAgIG1fc3RhdGUgPSBTdG9wcGluZ1N0 YXRlOworICAgIEFTU0VSVChtX3N0YXRlID09IFBhcnNlclN0YXRlOjpQYXJzaW5nKTsKKyAgICBt X3N0YXRlID0gUGFyc2VyU3RhdGU6OlN0b3BwaW5nOwogfQogCiB2b2lkIERvY3VtZW50UGFyc2Vy OjpzdG9wUGFyc2luZygpCiB7Ci0gICAgbV9zdGF0ZSA9IFN0b3BwZWRTdGF0ZTsKKyAgICBtX3N0 YXRlID0gUGFyc2VyU3RhdGU6OlN0b3BwZWQ7CiB9CiAKIHZvaWQgRG9jdW1lbnRQYXJzZXI6OmRl dGFjaCgpCiB7Ci0gICAgbV9zdGF0ZSA9IERldGFjaGVkU3RhdGU7CisgICAgbV9zdGF0ZSA9IFBh cnNlclN0YXRlOjpEZXRhY2hlZDsKICAgICBtX2RvY3VtZW50ID0gbnVsbHB0cjsKIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50UGFyc2VyLmggYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnRQYXJzZXIuaAppbmRleCBlOGEyMTZlNDc3YWM2ZjYwNDQ3MTI5MTk5 ZWVmMjZkODU1YTIwZDU2Li45Y2JlOTJhMzI3ZmQyNTJlOGVlMDMyNDk5M2Q3NTI0MmFlNWY1MGM3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRQYXJzZXIuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRQYXJzZXIuaApAQCAtNjUsMTAgKzY1LDEwIEBAIHB1 YmxpYzoKICAgICAvLyBkb2N1bWVudCgpIHdpbGwgcmV0dXJuIDAgYWZ0ZXIgZGV0YWNoKCkgaXMg Y2FsbGVkLgogICAgIERvY3VtZW50KiBkb2N1bWVudCgpIGNvbnN0IHsgQVNTRVJUKG1fZG9jdW1l bnQpOyByZXR1cm4gbV9kb2N1bWVudC5nZXQoKTsgfQogCi0gICAgYm9vbCBpc1BhcnNpbmcoKSBj b25zdCB7IHJldHVybiBtX3N0YXRlID09IFBhcnNpbmdTdGF0ZTsgfQotICAgIGJvb2wgaXNTdG9w cGluZygpIGNvbnN0IHsgcmV0dXJuIG1fc3RhdGUgPT0gU3RvcHBpbmdTdGF0ZTsgfQotICAgIGJv b2wgaXNTdG9wcGVkKCkgY29uc3QgeyByZXR1cm4gbV9zdGF0ZSA+PSBTdG9wcGVkU3RhdGU7IH0K LSAgICBib29sIGlzRGV0YWNoZWQoKSBjb25zdCB7IHJldHVybiBtX3N0YXRlID09IERldGFjaGVk U3RhdGU7IH0KKyAgICBib29sIGlzUGFyc2luZygpIGNvbnN0IHsgcmV0dXJuIG1fc3RhdGUgPT0g UGFyc2VyU3RhdGU6OlBhcnNpbmc7IH0KKyAgICBib29sIGlzU3RvcHBpbmcoKSBjb25zdCB7IHJl dHVybiBtX3N0YXRlID09IFBhcnNlclN0YXRlOjpTdG9wcGluZzsgfQorICAgIGJvb2wgaXNTdG9w cGVkKCkgY29uc3QgeyByZXR1cm4gbV9zdGF0ZSA+PSBQYXJzZXJTdGF0ZTo6U3RvcHBlZDsgfQor ICAgIGJvb2wgaXNEZXRhY2hlZCgpIGNvbnN0IHsgcmV0dXJuIG1fc3RhdGUgPT0gUGFyc2VyU3Rh dGU6OkRldGFjaGVkOyB9CiAKICAgICAvLyBGSVhNRTogSXMgdGhpcyBuZWNlc3Nhcnk/IERvZXMg WE1MRG9jdW1lbnRQYXJzZXJMaWJ4bWwyIHJlYWxseSBuZWVkIHRvIHNldCB0aGlzPwogICAgIHZp cnR1YWwgdm9pZCBzdGFydFBhcnNpbmcoKTsKQEAgLTEwNCwxMSArMTA0LDExIEBAIHByb3RlY3Rl ZDoKICAgICBleHBsaWNpdCBEb2N1bWVudFBhcnNlcihEb2N1bWVudCYpOwogCiBwcml2YXRlOgot ICAgIGVudW0gUGFyc2VyU3RhdGUgewotICAgICAgICBQYXJzaW5nU3RhdGUsCi0gICAgICAgIFN0 b3BwaW5nU3RhdGUsCi0gICAgICAgIFN0b3BwZWRTdGF0ZSwKLSAgICAgICAgRGV0YWNoZWRTdGF0 ZQorICAgIGVudW0gY2xhc3MgUGFyc2VyU3RhdGUgOiB1aW50OF90IHsKKyAgICAgICAgUGFyc2lu ZywKKyAgICAgICAgU3RvcHBpbmcsCisgICAgICAgIFN0b3BwZWQsCisgICAgICAgIERldGFjaGVk CiAgICAgfTsKICAgICBQYXJzZXJTdGF0ZSBtX3N0YXRlOwogICAgIGJvb2wgbV9kb2N1bWVudFdh c0xvYWRlZEFzUGFydE9mTmF2aWdhdGlvbjsK