214383 2020-07-15 16:38:32 -0700 [WinCairo][CURL] NetworkProcess consumes CPU resource greedily. 2021-08-02 13:47:46 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228095 InRadar P2 Normal --- 1 takashi.komori webkit-unassigned basuke chris.reid don.olmstead fujii stephan.szabo takashi.komori webkit-bug-importer oldest_to_newest 1671984 0 takashi.komori 2020-07-15 16:38:32 -0700 When MiniBrowser for wincairo accesses a sites, it sometimes consumes CPU greedily. How to reproduce. 1) Access http://news.yahoo.co.jp/ with MiniBrowser for wincairo. 2) Reload the page. 3) Check task-manager, you will see NetworkProcess consumes much CPU resource. 1672062 1 takashi.komori 2020-07-16 00:12:19 -0700 The cause of this issue is that CurlRequestSchduler::workerThread doesn't stop/sleep at ::select. When WebKit gets response headers the CurlRequest makes the curl_easy_handle PAUSED. We do not have to check paused handles by ::select but they are watched. And if a handle is ready for read/write ::select goes through without any wait. This makes worker thread busy loop. The root cause is NetworkDataTaskCurl::invokeDidReceiveResponse() doesn't handle PolicyAction::Ignore properly, and active jobs in CurlRequestSceduler aren't removed until timeout. So we have to call invalidateAndCancel() when policy action is Ignore. 1672067 2 404427 takashi.komori 2020-07-16 00:35:23 -0700 Created attachment 404427 Patch 1672295 3 ews-feeder 2020-07-16 16:35:26 -0700 Committed r264485: <https://trac.webkit.org/changeset/264485> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404427. 1672296 4 webkit-bug-importer 2020-07-16 16:36:18 -0700 <rdar://problem/65695976> 404427 2020-07-16 00:35:23 -0700 2020-07-16 16:35:27 -0700 Patch bug-214383-20200716163523.patch text/plain 1718 takashi.komori U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYzMGRjNDU4NTcyNDllN2Ew MjNmZDZhZGQyZjI0MGU2OWIzODI5MDcuLjQ5ODIzZGY0OGFhYTQxYmRiNDkzZjlkYWUzOTQ5Yzcw ZTNlOWZiZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDctMTYgIFRha2FzaGkg S29tb3JpICA8VGFrYXNoaS5Lb21vcmlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXVtD VVJMXSBOZXR3b3JrUHJvY2VzcyBjb25zdW1lcyBDUFUgcmVzb3VyY2UgZ3JlZWRpbHkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDM4MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBQb2xpY3lBY3Rp b246Oklnbm9yZSBoYW5kbGluZyByb3V0aW5lIGluIE5ldHdvcmtEYXRhVGFza0N1cmw6Omludm9r ZURpZFJlY2VpdmVSZXNwb25zZSgpCisgICAgICAgIElmIHdlIGRvbid0IGNhbmNlbCB0aGUgaWdu b3JlZCByZXF1ZXN0cyB0aGUgd29ya2VyIHRocmVhZCBmb3IgY3VybCBzY2hlZHVsZXIgZ29lcyBi dXN5LWxvb3BpbmcgYmVjYXVzZSB0aGUgZmRzIG9mIHRoZSByZXF1ZXN0cyBjb250aW51ZSB0byBi ZSBtb25pdG9yZWQuCisKKyAgICAgICAgTm8gdGVzdHMgbmVlZGVkIGFzIGV4aXN0aW5nIHRlc3Rz IGNvdmVyIHRoaXMgY2hhbmdlLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY3VybC9OZXR3 b3JrRGF0YVRhc2tDdXJsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFUYXNrQ3Vy bDo6aW52b2tlRGlkUmVjZWl2ZVJlc3BvbnNlKToKKwogMjAyMC0wNy0xMyAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBtb3JlIGxvZ2dpbmcgZm9yIG5hdmln YXRpb24gcG9saWN5IGRlY2lzaW9ucyBvbiBVSVByb2Nlc3Mgc2lkZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jdXJsL05ldHdvcmtEYXRhVGFza0N1cmwuY3BwIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jdXJsL05ldHdvcmtEYXRhVGFza0N1cmwuY3Bw CmluZGV4IGI3ZTcwZTgxYWRlODZjNWQxOTRiMjViNjg1OTA1NmI0M2IwZjljZjQuLjI3ZjhlZjU0 ZTU2MWQ2YzNlODEyZjhkNGRjNGNjMTMzNjM0ZmI0ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvTmV0d29ya1Byb2Nlc3MvY3VybC9OZXR3b3JrRGF0YVRhc2tDdXJsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2N1cmwvTmV0d29ya0RhdGFUYXNrQ3VybC5jcHAKQEAg LTIzNiw2ICsyMzYsNyBAQCB2b2lkIE5ldHdvcmtEYXRhVGFza0N1cmw6Omludm9rZURpZFJlY2Vp dmVSZXNwb25zZSgpCiAgICAgICAgICAgICAgICAgbV9jdXJsUmVxdWVzdC0+Y29tcGxldGVEaWRS ZWNlaXZlUmVzcG9uc2UoKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFBvbGlj eUFjdGlvbjo6SWdub3JlOgorICAgICAgICAgICAgaW52YWxpZGF0ZUFuZENhbmNlbCgpOwogICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICBub3RJbXBsZW1l bnRlZCgpOwo=