214372 2020-07-15 13:22:09 -0700 [ews] clicking submit for EWS analysis button for patches on closed bug should display error 2020-07-15 14:42:45 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210803 InRadar P2 Normal --- 1 aakash_jain aakash_jain ap beidson jbedard webkit-bug-importer oldest_to_newest 1671896 0 aakash_jain 2020-07-15 13:22:09 -0700 Clicking 'submit for EWS analysis' button for patches on closed bug should display error, and such patches shouldn't be sent to EWS (buildbot). This is because the first thing our Buildbot builders do is to validate-patch, which will skip the patch if the corresponding bug is closed. Therefore sending the patch to Buildbot is useless, and might be confusing for users. It's better to display an error that the patch is not being sent to EWS since the corresponding bug is already closed. 1671903 1 404384 aakash_jain 2020-07-15 13:27:24 -0700 Created attachment 404384 Patch 1671906 2 aakash_jain 2020-07-15 13:28:30 -0700 Tested in https://ews.webkit-uat.org/status-bubble/404379 (feel free to click the button to check the new behavior) 1671934 3 ews-feeder 2020-07-15 14:18:06 -0700 Committed r264421: <https://trac.webkit.org/changeset/264421> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404384. 1671935 4 webkit-bug-importer 2020-07-15 14:19:18 -0700 <rdar://problem/65626564> 1671949 5 aakash_jain 2020-07-15 14:42:45 -0700 > Committed r264421: <https://trac.webkit.org/changeset/264421> Deployed it on the server. 404384 2020-07-15 13:27:24 -0700 2020-07-15 14:18:07 -0700 Patch bug-214372-20200715162722.patch text/plain 6577 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDQxNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDIwLTA3LTE1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBjbGlja2luZyBzdWJtaXQgZm9yIEVXUyBhbmFseXNpcyBidXR0 b24gZm9yIHBhdGNoZXMgb24gY2xvc2VkIGJ1ZyBzaG91bGQgZGlzcGxheSBlcnJvcgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0MzcyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVnemlsbGEucHk6CisgICAgICAgIChCdWd6aWxsYS5f Z2V0X2J1Z19qc29uKTogTWV0aG9kIHRvIGdldCBidWcganNvbi4KKyAgICAgICAgKEJ1Z3ppbGxh LmlzX2J1Z19jbG9zZWQpOiBNZXRob2QgdG8gY2hlY2sgaWYgYnVnIGlzIGNsb3NlZC4KKyAgICAg ICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb25maWcucHk6CisgICAgICAgICog QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvZmV0Y2hlci5weToKKyAgICAgICAgKEJ1Z3pp bGxhUGF0Y2hGZXRjaGVyLnNlbmRfcGF0Y2hlc190b19idWlsZGJvdCk6CisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3Mvdmlld3Mvc3VibWl0dG9ld3MucHk6CisgICAgICAg IChTdWJtaXRUb0VXUy5wb3N0KTogRGlzcGxheSBlcnJvciBtZXNzYWdlIG9uIHN1Ym1pdCBmb3Ig RVdTIGFuYWx5c2lzIGJ1dHRvbiBjbGljayBmb3IgY2xvc2VkIGJ1Z3MuCisKIDIwMjAtMDctMTUg IEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFtydW4tamF2 YXNjcmlwdGNvcmUtdGVzdHNdIG5hdGl2ZUFyY2hpdGVjdHVyZSBzaG91bGQgbmV2ZXIgYmUgYXJt NjRlCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb25maWcucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWFwcC9ld3MvY29uZmln LnB5CShyZXZpc2lvbiAyNjQ0MTYpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBw L2V3cy9jb25maWcucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDMgKzQ0LDQgQEAgRVJSX05PTl9F WElTVElOR19QQVRDSCA9IC0zCiBFUlJfSU5WQUxJRF9QQVRDSF9JRCA9IC00CiBFUlJfT0JTT0xF VEVfUEFUQ0ggPSAtNQogRVJSX1VOQUJMRV9UT19GRVRDSF9QQVRDSCA9IC02CitFUlJfQlVHX0NM T1NFRCA9IC03CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9mZXRj aGVyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdz L2ZldGNoZXIucHkJKHJldmlzaW9uIDI2NDQxNikKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1hcHAvZXdzL2ZldGNoZXIucHkJKHdvcmtpbmcgY29weSkKQEAgLTI4LDcgKzI4LDcgQEAg aW1wb3J0IHRpbWUKIAogZnJvbSBld3MuY29tbW9uLmJ1Z3ppbGxhIGltcG9ydCBCdWd6aWxsYQog ZnJvbSBld3MuY29tbW9uLmJ1aWxkYm90IGltcG9ydCBCdWlsZGJvdAotZnJvbSBld3MuY29uZmln IGltcG9ydCBFUlJfT0JTT0xFVEVfUEFUQ0gsIEVSUl9VTkFCTEVfVE9fRkVUQ0hfUEFUQ0gKK2Zy b20gZXdzLmNvbmZpZyBpbXBvcnQgRVJSX0JVR19DTE9TRUQsIEVSUl9PQlNPTEVURV9QQVRDSCwg RVJSX1VOQUJMRV9UT19GRVRDSF9QQVRDSAogZnJvbSBld3MubW9kZWxzLnBhdGNoIGltcG9ydCBQ YXRjaAogZnJvbSBld3Mudmlld3Muc3RhdHVzYnViYmxlIGltcG9ydCBTdGF0dXNCdWJibGUKIApA QCAtODksMTEgKzg5LDE2IEBAIGNsYXNzIEJ1Z3ppbGxhUGF0Y2hGZXRjaGVyKCk6CiAgICAgICAg ICAgICAgICAgICAgIHJldHVybiBFUlJfVU5BQkxFX1RPX0ZFVENIX1BBVENICiAgICAgICAgICAg ICAgICAgY29udGludWUKICAgICAgICAgICAgIGlmIGJ6X3BhdGNoLmdldCgnaXNfb2Jzb2xldGUn KToKLSAgICAgICAgICAgICAgICBfbG9nLndhcm4oJ1BhdGNoIGlzIG9ic29sZXRlLCBza2lwcGlu ZycpCisgICAgICAgICAgICAgICAgX2xvZy53YXJuKCdQYXRjaCB7fSBpcyBvYnNvbGV0ZSwgc2tp cHBpbmcnLmZvcm1hdChwYXRjaF9pZCkpCiAgICAgICAgICAgICAgICAgUGF0Y2guc2V0X29ic29s ZXRlKHBhdGNoX2lkKQogICAgICAgICAgICAgICAgIGlmIGxlbihwYXRjaGVzX3RvX3NlbmQpID09 IDE6CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBFUlJfT0JTT0xFVEVfUEFUQ0gKICAgICAg ICAgICAgICAgICBjb250aW51ZQorICAgICAgICAgICAgaWYgQnVnemlsbGEuaXNfYnVnX2Nsb3Nl ZChiel9wYXRjaFsnYnVnX2lkJ10pID09IDE6CisgICAgICAgICAgICAgICAgX2xvZy53YXJuKCdC dWcge30gZm9yIHBhdGNoIHt9IGlzIGFscmVhZHkgY2xvc2VkLCBza2lwcGluZycuZm9ybWF0KGJ6 X3BhdGNoWydidWdfaWQnXSwgcGF0Y2hfaWQpKQorICAgICAgICAgICAgICAgIGlmIGxlbihwYXRj aGVzX3RvX3NlbmQpID09IDE6CisgICAgICAgICAgICAgICAgICAgIHJldHVybiBFUlJfQlVHX0NM T1NFRAorICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgICAgICBpZiBub3Qgc2VuZF90 b19jb21taXRfcXVldWUgYW5kIFBhdGNoLmlzX3BhdGNoX3NlbnRfdG9fYnVpbGRib3QocGF0Y2hf aWQpOgogICAgICAgICAgICAgICAgIF9sb2cuZXJyb3IoJ1BhdGNoIHt9IGlzIGFscmVhZHkgc2Vu dCB0byBidWlsZGJvdC4nLmZvcm1hdChwYXRjaF9pZCkpCiAgICAgICAgICAgICAgICAgY29udGlu dWUKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi9idWd6 aWxsYS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3 cy9jb21tb24vYnVnemlsbGEucHkJKHJldmlzaW9uIDI2NDQxNikKKysrIFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi9idWd6aWxsYS5weQkod29ya2luZyBjb3B5KQpA QCAtMzksNiArMzksOSBAQCBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiAKIAog Y2xhc3MgQnVnemlsbGEoKToKKyAgICBidWdfb3Blbl9zdGF0dXNlcyA9IFsnVU5DT05GSVJNRUQn LCAnTkVXJywgJ0FTU0lHTkVEJywgJ1JFT1BFTkVEJ10KKyAgICBidWdfY2xvc2VkX3N0YXR1c2Vz ID0gWydSRVNPTFZFRCcsICdWRVJJRklFRCcsICdDTE9TRUQnXQorCiAgICAgQGNsYXNzbWV0aG9k CiAgICAgZGVmIHJldHJpZXZlX2F0dGFjaG1lbnQoY2xzLCBhdHRhY2htZW50X2lkKToKICAgICAg ICAgYXR0YWNobWVudF9qc29uID0gQnVnemlsbGEuX2ZldGNoX2F0dGFjaG1lbnRfanNvbihhdHRh Y2htZW50X2lkKQpAQCAtOTAsNiArOTMsMjQgQEAgY2xhc3MgQnVnemlsbGEoKToKICAgICAgICAg cmV0dXJuIGF0dGFjaG1lbnRfanNvbi5nZXQoc3RyKGF0dGFjaG1lbnRfaWQpKQogCiAgICAgQGNs YXNzbWV0aG9kCisgICAgZGVmIF9nZXRfYnVnX2pzb24oY2xzLCBidWdfaWQpOgorICAgICAgICBp ZiBub3QgdXRpbC5pc192YWxpZF9pZChidWdfaWQpOgorICAgICAgICAgICAgX2xvZy53YXJuKCdJ bnZhbGlkIGJ1ZyBpZDoge30nLmZvcm1hdChidWdfaWQpKQorICAgICAgICAgICAgcmV0dXJuIFtd CisKKyAgICAgICAgYnVnX3VybCA9ICd7fXJlc3QvYnVnL3t9Jy5mb3JtYXQoY29uZmlnLkJVR19T RVJWRVJfVVJMLCBidWdfaWQpCisgICAgICAgIGFwaV9rZXkgPSBvcy5nZXRlbnYoJ0JVR1pJTExB X0FQSV9LRVknLCBOb25lKQorICAgICAgICBpZiBhcGlfa2V5OgorICAgICAgICAgICAgYnVnX3Vy bCArPSAnP2FwaV9rZXk9e30nLmZvcm1hdChhcGlfa2V5KQorICAgICAgICBidWcgPSB1dGlsLmZl dGNoX2RhdGFfZnJvbV91cmwoYnVnX3VybCkKKyAgICAgICAgaWYgbm90IGJ1ZzoKKyAgICAgICAg ICAgIHJldHVybiBOb25lCisgICAgICAgIGJ1Z3NfanNvbiA9IGJ1Zy5qc29uKCkuZ2V0KCdidWdz JykKKyAgICAgICAgaWYgbm90IGJ1Z3NfanNvbiBvciBsZW4oYnVnc19qc29uKSA9PSAwOgorICAg ICAgICAgICAgcmV0dXJuIE5vbmUKKyAgICAgICAgcmV0dXJuIGJ1Z3NfanNvblswXQorCisgICAg QGNsYXNzbWV0aG9kCiAgICAgZGVmIF9nZXRfY29tbWl0X3F1ZXVlX3BhdGNoZXNfZnJvbV9idWco Y2xzLCBidWdfaWQpOgogICAgICAgICBpZiBub3QgdXRpbC5pc192YWxpZF9pZChidWdfaWQpOgog ICAgICAgICAgICAgX2xvZy53YXJuKCdJbnZhbGlkIGJ1ZyBpZDogInt9IicuZm9ybWF0KGJ1Z19p ZCkpCkBAIC0xNDQsNiArMTY1LDE3IEBAIGNsYXNzIEJ1Z3ppbGxhKCk6CiAgICAgICAgICAgICBp ZHNfZm9yX2NvbW1pdF9xdWV1ZS5leHRlbmQoY2xzLl9nZXRfY29tbWl0X3F1ZXVlX3BhdGNoZXNf ZnJvbV9idWcoYnVnX2lkKSkKICAgICAgICAgcmV0dXJuIGlkc19mb3JfY29tbWl0X3F1ZXVlCiAK KyAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgaXNfYnVnX2Nsb3NlZChjbHMsIGJ1Z19pZCk6Cisg ICAgICAgIGJ1Z19qc29uID0gY2xzLl9nZXRfYnVnX2pzb24oYnVnX2lkKQorICAgICAgICBpZiBu b3QgYnVnX2pzb24gb3Igbm90IGJ1Z19qc29uLmdldCgnc3RhdHVzJyk6CisgICAgICAgICAgICBf bG9nLndhcm4oJ1VuYWJsZSB0byBmZXRjaCBidWcge30uJy5mb3JtYXQoYnVnX2lkKSkKKyAgICAg ICAgICAgIHJldHVybiAtMQorCisgICAgICAgIGlmIGJ1Z19qc29uLmdldCgnc3RhdHVzJykgaW4g Y2xzLmJ1Z19jbG9zZWRfc3RhdHVzZXM6CisgICAgICAgICAgICByZXR1cm4gMQorICAgICAgICBy ZXR1cm4gMAorCiAKIGNsYXNzIEJ1Z3ppbGxhQmVhdXRpZnVsU291cCgpOgogICAgICMgRklYTUU6 IERlcHJlY2F0ZSB0aGlzIGNsYXNzIHdoZW4gaHR0cHM6Ly9idWd6aWxsYS5tb3ppbGxhLm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTUwODUzMSBpcyBmaXhlZC4KSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N1Ym1pdHRvZXdzLnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL3ZpZXdzL3N1Ym1pdHRvZXdzLnB5CShy ZXZpc2lvbiAyNjQ0MTYpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy92 aWV3cy9zdWJtaXR0b2V3cy5weQkod29ya2luZyBjb3B5KQpAQCAtMzAsNyArMzAsNyBAQCBmcm9t IGRqYW5nby5zaG9ydGN1dHMgaW1wb3J0IHJlZGlyZWN0LCByCiBmcm9tIGRqYW5nby52aWV3cyBp bXBvcnQgVmlldwogZnJvbSBkamFuZ28udmlld3MuZGVjb3JhdG9ycy5jbGlja2phY2tpbmcgaW1w b3J0IHhmcmFtZV9vcHRpb25zX2V4ZW1wdAogCi1mcm9tIGV3cy5jb25maWcgaW1wb3J0IEVSUl9P QlNPTEVURV9QQVRDSCwgRVJSX1VOQUJMRV9UT19GRVRDSF9QQVRDSAorZnJvbSBld3MuY29uZmln IGltcG9ydCBFUlJfQlVHX0NMT1NFRCwgRVJSX09CU09MRVRFX1BBVENILCBFUlJfVU5BQkxFX1RP X0ZFVENIX1BBVENICiBmcm9tIGV3cy5mZXRjaGVyIGltcG9ydCBCdWd6aWxsYVBhdGNoRmV0Y2hl cgogZnJvbSBld3MubW9kZWxzLnBhdGNoIGltcG9ydCBQYXRjaAogCkBAIC02MSw2ICs2MSw4IEBA IGNsYXNzIFN1Ym1pdFRvRVdTKFZpZXcpOgogICAgICAgICAgICAgcmV0dXJuIEh0dHBSZXNwb25z ZSgnRVdTIGlzIHVuYWJsZSB0byBhY2Nlc3MgcGF0Y2gge30uIFBsZWFzZSBlbnN1cmUgdGhhdCB0 aGlzIHBhdGNoIGlzIHB1YmxpY2x5IGFjY2Vzc2libGUgb3IgaGFzIHI/IHNldC4nLmZvcm1hdChw YXRjaF9pZCkpCiAgICAgICAgIGlmIHJjID09IEVSUl9PQlNPTEVURV9QQVRDSDoKICAgICAgICAg ICAgIHJldHVybiBIdHRwUmVzcG9uc2UoJ1BhdGNoIHt9IGlzIG9ic29sZXRlLCBub3Qgc3VibWl0 dGluZyB0byBFV1MuJy5mb3JtYXQocGF0Y2hfaWQpKQorICAgICAgICBpZiByYyA9PSBFUlJfQlVH X0NMT1NFRDoKKyAgICAgICAgICAgIHJldHVybiBIdHRwUmVzcG9uc2UoJ0J1ZyBmb3IgcGF0Y2gg e30gaXMgY2xvc2VkLCBub3Qgc3VibWl0dGluZyB0byBFV1MuJy5mb3JtYXQocGF0Y2hfaWQpKQog CiAgICAgICAgIGlmIHJlcXVlc3QuUE9TVC5nZXQoJ25leHRfYWN0aW9uJykgPT0gJ3JldHVybl90 b19idWJibGVzJzoKICAgICAgICAgICAgIHJldHVybiByZWRpcmVjdCgnL3N0YXR1cy1idWJibGUv e30nLmZvcm1hdChwYXRjaF9pZCkpCg==