214369 2020-07-15 12:07:13 -0700 [run-javascriptcore-tests] nativeArchitecture should never be arm64e 2020-07-15 14:00:21 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari 13 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard ryanhaddad saam thorton webkit-bug-importer oldest_to_newest 1671855 0 jbedard 2020-07-15 12:07:13 -0700 For internal builds, architecture should be arm64e by default, but native architecture should be arm64. 1671856 1 jbedard 2020-07-15 12:08:38 -0700 <rdar://problem/65364995> 1671858 2 404371 jbedard 2020-07-15 12:12:54 -0700 Created attachment 404371 Patch 1671885 3 ews-feeder 2020-07-15 13:03:22 -0700 Committed r264416: <https://trac.webkit.org/changeset/264416> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404371. 1671888 4 saam 2020-07-15 13:05:50 -0700 (In reply to Jonathan Bedard from comment #0) > For internal builds, architecture should be arm64e by default, but native > architecture should be arm64. What’s the distinction for? These function names make it difficult to see what it’s used for and why your fix is needed. 1671889 5 thorton 2020-07-15 13:07:00 -0700 (Agreed, I think we need better names or comments about why this is so wacky) 1671924 6 jbedard 2020-07-15 14:00:21 -0700 (In reply to Saam Barati from comment #4) > (In reply to Jonathan Bedard from comment #0) > > For internal builds, architecture should be arm64e by default, but native > > architecture should be arm64. > > What’s the distinction for? These function names make it difficult to see > what it’s used for and why your fix is needed. 'architecture' means 'the architecture the user intends to build or test with' while 'native architecture' means 'the architecture that a machine will use to run code' Renaming probably isn't practical (since architecture is used in code not checked into WebKit), so comments are probably the way to go. 404371 2020-07-15 12:12:54 -0700 2020-07-15 13:03:23 -0700 Patch bug-214369-20200715121253.patch text/plain 1638 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDQwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIwLTA3LTE1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzXSBuYXRpdmVBcmNoaXRlY3R1 cmUgc2hvdWxkIG5ldmVyIGJlIGFybTY0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjE0MzY5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NTM2NDk5 NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWluZU5hdGl2ZUFyY2hpdGVjdHVy ZSk6CisgICAgICAgIChkZXRlcm1pbmVBcmNoaXRlY3R1cmUpOgorCiAyMDIwLTA3LTE1ICBSeWFu IEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIEZsYWt5IEFQSSBUZXN0 OiBUZXN0V2ViS2l0QVBJLlNsZWVwRGlzYWJsZXIuTmF2aWdhdGVCYWNrCkluZGV4OiBUb29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRk aXJzLnBtCShyZXZpc2lvbiAyNjQ0MDQpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0J KHdvcmtpbmcgY29weSkKQEAgLTM3MiwxMyArMzcyLDYgQEAgc3ViIGRldGVybWluZU5hdGl2ZUFy Y2hpdGVjdHVyZSg7JCQpCiAgICAgICAgICRvdXRwdXQgPSAiYXJtNjQiOwogICAgIH0KIAotICAg IGlmIChpc0FwcGxlQ29jb2FXZWJLaXQoKSAmJiAkb3V0cHV0IGVxICJhcm02NCIpIHsKLSAgICAg ICAgZGV0ZXJtaW5lWGNvZGVTREsoKTsKLSAgICAgICAgaWYgKCR4Y29kZVNESyBlcSAibWFjb3N4 LmludGVybmFsIikgewotICAgICAgICAgICAgJG91dHB1dCA9ICJhcm02NGUiOwotICAgICAgICB9 Ci0gICAgfQotCiAgICAgJG91dHB1dCA9ICJhcm0iIGlmICRvdXRwdXQgZXEgImFybXY3bCI7CiAg ICAgJG5hdGl2ZUFyY2hpdGVjdHVyZU1hcHsiJHRhcmdldDokcG9ydCJ9ID0gJG91dHB1dDsKIH0K QEAgLTM4OSw2ICszODIsMTIgQEAgc3ViIGRldGVybWluZUFyY2hpdGVjdHVyZQogCiAgICAgZGV0 ZXJtaW5lQmFzZVByb2R1Y3REaXIoKTsKICAgICAkYXJjaGl0ZWN0dXJlID0gbmF0aXZlQXJjaGl0 ZWN0dXJlKCk7CisgICAgaWYgKGlzQXBwbGVDb2NvYVdlYktpdCgpICYmICRhcmNoaXRlY3R1cmUg ZXEgImFybTY0IikgeworICAgICAgICBkZXRlcm1pbmVYY29kZVNESygpOworICAgICAgICBpZiAo JHhjb2RlU0RLIGVxICJtYWNvc3guaW50ZXJuYWwiKSB7CisgICAgICAgICAgICAkYXJjaGl0ZWN0 dXJlID0gImFybTY0ZSI7CisgICAgICAgIH0KKyAgICB9CiAKICAgICBpZiAoaXNBcHBsZUNvY29h V2ViS2l0KCkpIHsKICAgICAgICAgZGV0ZXJtaW5lWGNvZGVTREsoKTsK