214368 2020-07-15 11:55:08 -0700 Improve navigation policy decision release logging to help better diagnose issues 2020-07-15 12:39:13 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson ggaren webkit-bug-importer oldest_to_newest 1671849 0 cdumez 2020-07-15 11:55:08 -0700 Improve navigation policy decision release logging to help better diagnose issues. 1671851 1 404370 cdumez 2020-07-15 11:59:54 -0700 Created attachment 404370 Patch 1671872 2 ews-feeder 2020-07-15 12:38:05 -0700 Committed r264414: <https://trac.webkit.org/changeset/264414> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404370. 1671873 3 webkit-bug-importer 2020-07-15 12:39:13 -0700 <rdar://problem/65621261> 404370 2020-07-15 11:59:54 -0700 2020-07-15 12:38:05 -0700 Patch bug-214368-20200715115953.patch text/plain 7363 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NDAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYyMDJlYzg0OWZkMDlkYzQ4 NDNjOTFiNDdiM2E4NDIwYjA0OTVlNDAuLmU1NmZlZmRhOTE1NjA1ZjgxY2Q4ZjViYzc0ZWM0MzRm YWU2NWNkNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDctMTUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBJbXByb3ZlIG5hdmlnYXRpb24gcG9s aWN5IGRlY2lzaW9uIHJlbGVhc2UgbG9nZ2luZyB0byBoZWxwIGJldHRlciBkaWFnbm9zZSBpc3N1 ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDM2 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6 ZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbik6CisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYkZyYW1lTG9hZGVyQ2xpZW50OjpkaXNwYXRjaERlY2lkZVBvbGljeUZvck5hdmlnYXRpb25B Y3Rpb24pOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViUGFnZTo6ZGlkUmVjZWl2ZVBvbGljeURlY2lzaW9uKToKKwogMjAyMC0w Ny0xNSAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbU09VUF0g QXJ0aWZpY2lhbCBkZWxheSB0byBXZWJTb2NrZXQgY29ubmVjdGlvbiB0byBtaXRpZ2F0ZSBwb3J0 IHNjYW5uaW5nIGF0dGFja3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw CmluZGV4IGEzYmE5YTFkMDBlMGMyZWRiMzVmNjA4NmIxY2ZmYWJmOTkxOGYxYzQuLjQzNTViYzEz ZTdlNjBlZjJmNjQ5MjA2OTZjM2ZiNDM1YjA4NDkyNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNTE2Myw4ICs1MTYzLDEwIEBAIHZvaWQgV2ViUGFnZVBy b3h5OjpkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKFJlZjxXZWJQcm9jZXNzUHJveHk+ JiYgcHJvY2VzCiAgICAgbmF2aWdhdGlvbi0+c2V0RGVzdGluYXRpb25GcmFtZVNlY3VyaXR5T3Jp Z2luKGZyYW1lSW5mby5zZWN1cml0eU9yaWdpbik7CiAKICNpZiBFTkFCTEUoQ09OVEVOVF9GSUxU RVJJTkcpCi0gICAgaWYgKGZyYW1lLmRpZEhhbmRsZUNvbnRlbnRGaWx0ZXJVbmJsb2NrTmF2aWdh dGlvbihyZXF1ZXN0KSkKKyAgICBpZiAoZnJhbWUuZGlkSGFuZGxlQ29udGVudEZpbHRlclVuYmxv Y2tOYXZpZ2F0aW9uKHJlcXVlc3QpKSB7CisgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SX0lGX0FM TE9XRUQoUHJvY2VzcywgIklnbm9yaW5nIHJlcXVlc3QgdG8gbG9hZCB0aGlzIG1haW4gcmVzb3Vy Y2UgYmVjYXVzZSBpdCB3YXMgaGFuZGxlZCBieSBjb250ZW50IGZpbHRlciIpOwogICAgICAgICBy ZXR1cm4gcmVjZWl2ZWRQb2xpY3lEZWNpc2lvbihQb2xpY3lBY3Rpb246Oklnbm9yZSwgbV9uYXZp Z2F0aW9uU3RhdGUtPm5hdmlnYXRpb24obmF2aWdhdGlvbklEKSwgbnVsbHB0ciwgV1RGTW92ZShz ZW5kZXIpKTsKKyAgICB9CiAjZW5kaWYKIAogICAgIFNob3VsZEV4cGVjdFNhZmVCcm93c2luZ1Jl c3VsdCBzaG91bGRFeHBlY3RTYWZlQnJvd3NpbmdSZXN1bHQgPSBTaG91bGRFeHBlY3RTYWZlQnJv d3NpbmdSZXN1bHQ6OlllczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCmluZGV4IGQ1 MTE2OGFiNjk4YzFmNTA3NDc3MmVkMTA4OWU5MDc5ZDg1NmFjOTAuLmI1NjU3MWJhYmI4ZWJkODk5 N2E4MWZlOWUzYTZjYjUxZTUzMTkwN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAKKysrIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNw cApAQCAtOTAxLDYgKzkwMSw3IEBAIHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNo RGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbihjb25zdCBOYXZpZ2F0CiB7CiAgICAgYXV0 byogd2ViUGFnZSA9IG1fZnJhbWUtPnBhZ2UoKTsKICAgICBpZiAoIXdlYlBhZ2UpIHsKKyAgICAg ICAgV0VCRlJBTUVMT0FERVJDTElFTlRfUkVMRUFTRV9MT0dfRVJST1IoTmV0d29yaywgImRpc3Bh dGNoRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbjogaWdub3JpbmcgYmVjYXVzZSB0aGVy ZSdzIG5vIHdlYiBwYWdlIik7CiAgICAgICAgIGZ1bmN0aW9uKFBvbGljeUFjdGlvbjo6SWdub3Jl LCByZXF1ZXN0SWRlbnRpZmllcik7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC05MDksNiAr OTEwLDcgQEAgdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lG b3JOYXZpZ2F0aW9uQWN0aW9uKGNvbnN0IE5hdmlnYXQKIAogICAgIC8vIEFsd2F5cyBpZ25vcmUg cmVxdWVzdHMgd2l0aCBlbXB0eSBVUkxzLiAKICAgICBpZiAocmVxdWVzdC5pc0VtcHR5KCkpIHsK KyAgICAgICAgV0VCRlJBTUVMT0FERVJDTElFTlRfUkVMRUFTRV9MT0dfRVJST1IoTmV0d29yaywg ImRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbjogaWdub3JpbmcgYmVjYXVz ZSByZXF1ZXN0IGlzIGVtcHR5Iik7CiAgICAgICAgIGZ1bmN0aW9uKFBvbGljeUFjdGlvbjo6SWdu b3JlLCByZXF1ZXN0SWRlbnRpZmllcik7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC05MjAs NiArOTIyLDcgQEAgdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6ZGlzcGF0Y2hEZWNpZGVQb2xp Y3lGb3JOYXZpZ2F0aW9uQWN0aW9uKGNvbnN0IE5hdmlnYXQKICAgICAvLyBOb3RpZnkgdGhlIGJ1 bmRsZSBjbGllbnQuCiAgICAgV0tCdW5kbGVQYWdlUG9saWN5QWN0aW9uIHBvbGljeSA9IHdlYlBh Z2UtPmluamVjdGVkQnVuZGxlUG9saWN5Q2xpZW50KCkuZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlv bkFjdGlvbih3ZWJQYWdlLCBtX2ZyYW1lLnB0cigpLCBhY3Rpb24ucHRyKCksIHJlcXVlc3QsIHVz ZXJEYXRhKTsKICAgICBpZiAocG9saWN5ID09IFdLQnVuZGxlUGFnZVBvbGljeUFjdGlvblVzZSkg eworICAgICAgICBXRUJGUkFNRUxPQURFUkNMSUVOVF9SRUxFQVNFX0xPRyhOZXR3b3JrLCAiZGlz cGF0Y2hEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uOiBJbmplY3RlZCBCdW5kbGUgcmVz cG9uZGVkIHdpdGggUG9saWN5QWN0aW9uOjpVc2UiKTsKICAgICAgICAgZnVuY3Rpb24oUG9saWN5 QWN0aW9uOjpVc2UsIHJlcXVlc3RJZGVudGlmaWVyKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K QEAgLTk5NSwxNyArOTk4LDIxIEBAIHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpc3BhdGNo RGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbihjb25zdCBOYXZpZ2F0CiAgICAgICAgIFBv bGljeURlY2lzaW9uIHBvbGljeURlY2lzaW9uOwogCiAgICAgICAgIGlmICghd2ViUGFnZS0+c2Vu ZFN5bmMoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6RGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFj dGlvblN5bmMobV9mcmFtZS0+ZnJhbWVJRCgpLCBtX2ZyYW1lLT5pc01haW5GcmFtZSgpLCBtX2Zy YW1lLT5pbmZvKCksIHJlcXVlc3RJZGVudGlmaWVyLCBkb2N1bWVudExvYWRlci0+bmF2aWdhdGlv bklEKCksIG5hdmlnYXRpb25BY3Rpb25EYXRhLCBvcmlnaW5hdGluZ0ZyYW1lSW5mb0RhdGEsIG9y aWdpbmF0aW5nUGFnZUlELCBuYXZpZ2F0aW9uQWN0aW9uLnJlc291cmNlUmVxdWVzdCgpLCByZXF1 ZXN0LCBJUEM6OkZvcm1EYXRhUmVmZXJlbmNlIHsgcmVxdWVzdC5odHRwQm9keSgpIH0sIHJlZGly ZWN0UmVzcG9uc2UsIFVzZXJEYXRhKFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLnRyYW5zZm9ybU9i amVjdHNUb0hhbmRsZXModXNlckRhdGEuZ2V0KCkpLmdldCgpKSksIE1lc3NhZ2VzOjpXZWJQYWdl UHJveHk6OkRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb25TeW5jOjpSZXBseShwb2xpY3lE ZWNpc2lvbikpKSB7CisgICAgICAgICAgICBXRUJGUkFNRUxPQURFUkNMSUVOVF9SRUxFQVNFX0xP R19FUlJPUihOZXR3b3JrLCAiZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9u OiBpZ25vcmluZyBiZWNhdXNlIG9mIGZhaWxpbmcgdG8gc2VuZCBzeW5jIElQQyIpOwogICAgICAg ICAgICAgbV9mcmFtZS0+ZGlkUmVjZWl2ZVBvbGljeURlY2lzaW9uKGxpc3RlbmVySUQsIFBvbGlj eURlY2lzaW9uIHsgcmVxdWVzdElkZW50aWZpZXIsIFdURjo6bnVsbG9wdCwgUG9saWN5QWN0aW9u OjpJZ25vcmUsIDAsIHsgfSwgeyB9IH0pOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9 CiAKKyAgICAgICAgV0VCRlJBTUVMT0FERVJDTElFTlRfUkVMRUFTRV9MT0coTmV0d29yaywgImRp c3BhdGNoRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbjogR290IHBvbGljeUFjdGlvbiAl dSBmcm9tIHN5bmMgSVBDIiwgKHVuc2lnbmVkKXBvbGljeURlY2lzaW9uLnBvbGljeUFjdGlvbik7 CiAgICAgICAgIG1fZnJhbWUtPmRpZFJlY2VpdmVQb2xpY3lEZWNpc2lvbihsaXN0ZW5lcklELCBQ b2xpY3lEZWNpc2lvbiB7IHBvbGljeURlY2lzaW9uLmlkZW50aWZpZXIsIHBvbGljeURlY2lzaW9u LmlzTmF2aWdhdGluZ1RvQXBwQm91bmREb21haW4sIHBvbGljeURlY2lzaW9uLnBvbGljeUFjdGlv biwgMCwgcG9saWN5RGVjaXNpb24uZG93bmxvYWRJRCwgeyB9fSk7CiAgICAgICAgIHJldHVybjsK ICAgICB9CiAKICAgICBBU1NFUlQocG9saWN5RGVjaXNpb25Nb2RlID09IFBvbGljeURlY2lzaW9u TW9kZTo6QXN5bmNocm9ub3VzKTsKLSAgICBpZiAoIXdlYlBhZ2UtPnNlbmQoTWVzc2FnZXM6Oldl YlBhZ2VQcm94eTo6RGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbkFzeW5jKG1fZnJhbWUt PmZyYW1lSUQoKSwgbV9mcmFtZS0+aW5mbygpLCByZXF1ZXN0SWRlbnRpZmllciwgZG9jdW1lbnRM b2FkZXItPm5hdmlnYXRpb25JRCgpLCBuYXZpZ2F0aW9uQWN0aW9uRGF0YSwgb3JpZ2luYXRpbmdG cmFtZUluZm9EYXRhLCBvcmlnaW5hdGluZ1BhZ2VJRCwgbmF2aWdhdGlvbkFjdGlvbi5yZXNvdXJj ZVJlcXVlc3QoKSwgcmVxdWVzdCwgSVBDOjpGb3JtRGF0YVJlZmVyZW5jZSB7IHJlcXVlc3QuaHR0 cEJvZHkoKSB9LCByZWRpcmVjdFJlc3BvbnNlLCBVc2VyRGF0YShXZWJQcm9jZXNzOjpzaW5nbGV0 b24oKS50cmFuc2Zvcm1PYmplY3RzVG9IYW5kbGVzKHVzZXJEYXRhLmdldCgpKS5nZXQoKSksIGxp c3RlbmVySUQpKSkKKyAgICBpZiAoIXdlYlBhZ2UtPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94 eTo6RGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbkFzeW5jKG1fZnJhbWUtPmZyYW1lSUQo KSwgbV9mcmFtZS0+aW5mbygpLCByZXF1ZXN0SWRlbnRpZmllciwgZG9jdW1lbnRMb2FkZXItPm5h dmlnYXRpb25JRCgpLCBuYXZpZ2F0aW9uQWN0aW9uRGF0YSwgb3JpZ2luYXRpbmdGcmFtZUluZm9E YXRhLCBvcmlnaW5hdGluZ1BhZ2VJRCwgbmF2aWdhdGlvbkFjdGlvbi5yZXNvdXJjZVJlcXVlc3Qo KSwgcmVxdWVzdCwgSVBDOjpGb3JtRGF0YVJlZmVyZW5jZSB7IHJlcXVlc3QuaHR0cEJvZHkoKSB9 LCByZWRpcmVjdFJlc3BvbnNlLCBVc2VyRGF0YShXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS50cmFu c2Zvcm1PYmplY3RzVG9IYW5kbGVzKHVzZXJEYXRhLmdldCgpKS5nZXQoKSksIGxpc3RlbmVySUQp KSkgeworICAgICAgICBXRUJGUkFNRUxPQURFUkNMSUVOVF9SRUxFQVNFX0xPR19FUlJPUihOZXR3 b3JrLCAiZGlzcGF0Y2hEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uOiBpZ25vcmluZyBi ZWNhdXNlIG9mIGZhaWxpbmcgdG8gc2VuZCBhc3luYyBJUEMiKTsKICAgICAgICAgbV9mcmFtZS0+ ZGlkUmVjZWl2ZVBvbGljeURlY2lzaW9uKGxpc3RlbmVySUQsIFBvbGljeURlY2lzaW9uIHsgcmVx dWVzdElkZW50aWZpZXIsIFdURjo6bnVsbG9wdCwgUG9saWN5QWN0aW9uOjpJZ25vcmUsIDAsIHsg fSwgeyB9IH0pOworICAgIH0KIH0KIAogdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6Y2FuY2Vs UG9saWN5Q2hlY2soKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBh Z2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcAppbmRleCA0N2NkZWE3ZWRlMTk4MDU3OGRjNjk5YzlmYzdiNGNiNzQ4OTA3YWNhLi5mYzcy NDk4ZjQ3MjQyZTZmNzg0NGRmMzNkMjU0NTk4YzM3NjkzMzFiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtMzI5MSw2ICszMjkxLDggQEAgdm9p ZCBXZWJQYWdlOjpzZXRMYXllckhvc3RpbmdNb2RlKExheWVySG9zdGluZ01vZGUgbGF5ZXJIb3N0 aW5nTW9kZSkKIHZvaWQgV2ViUGFnZTo6ZGlkUmVjZWl2ZVBvbGljeURlY2lzaW9uKEZyYW1lSWRl bnRpZmllciBmcmFtZUlELCB1aW50NjRfdCBsaXN0ZW5lcklELCBQb2xpY3lEZWNpc2lvbiYmIHBv bGljeURlY2lzaW9uKQogewogICAgIFdlYkZyYW1lKiBmcmFtZSA9IFdlYlByb2Nlc3M6OnNpbmds ZXRvbigpLndlYkZyYW1lKGZyYW1lSUQpOworICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoTG9h ZGluZywgImRpZFJlY2VpdmVQb2xpY3lEZWNpc2lvbjogcG9saWN5QWN0aW9uOiAldSAtIGZyYW1l SUQ6ICVsbHUgLSB3ZWJGcmFtZTogJXAgLSBtYWluRnJhbWU6ICVkIiwgKHVuc2lnbmVkKXBvbGlj eURlY2lzaW9uLnBvbGljeUFjdGlvbiwgZnJhbWVJRC50b1VJbnQ2NCgpLCBmcmFtZSwgZnJhbWUg PyBmcmFtZS0+aXNNYWluRnJhbWUoKSA6IDApOworCiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAg cmV0dXJuOwogCg==