214355 2020-07-15 08:24:05 -0700 [ews-app] Add timeout to network requests 2020-11-16 11:36:01 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218994 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1671744 0 aakash_jain 2020-07-15 08:24:05 -0700 Sometimes network requests can get stuck or take very long time. on ews-app it can introduce delays in patch submissions from EWS django app to Buildbot. We should add an explicit timeout to network requests, so that the network request is timely terminated and retried in subsequent iteration of ews-app appropriately. 1671746 1 404343 aakash_jain 2020-07-15 08:27:48 -0700 Created attachment 404343 Patch 1671747 2 aakash_jain 2020-07-15 08:28:56 -0700 As per https://requests.readthedocs.io/en/master/user/quickstart/#timeouts: "Nearly all production code should use this parameter in nearly all requests. Failure to do so can cause your program to hang indefinitely" 1671752 3 aakash_jain 2020-07-15 08:39:44 -0700 In the past, I noticed few times ews-app getting stuck and not submitting patches to Buildbot for long time (even though the status-bubbles and /results kept working fine), restarting ews-app helped at those times. I believe I finally got to the bottom of the issue. 1671765 4 ews-feeder 2020-07-15 09:24:27 -0700 Committed r264399: <https://trac.webkit.org/changeset/264399> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404343. 1671767 5 webkit-bug-importer 2020-07-15 09:25:13 -0700 <rdar://problem/65609376> 404343 2020-07-15 08:27:48 -0700 2020-07-15 09:24:28 -0700 Patch bug-214355-20200715112747.patch text/plain 1620 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDM5OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA3LTE1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWFwcF0gQWRkIHRpbWVvdXQgdG8gbmV0d29yayByZXF1ZXN0cwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0MzU1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNs YXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vdXRpbC5weToKKyAgICAgICAgKGZldGNoX2Rh dGFfZnJvbV91cmwpOiBBZGQgdGllbW91dCBhcyByZWNvbW1lbmRlZCBpbiBodHRwczovL3JlcXVl c3RzLnJlYWR0aGVkb2NzLmlvL2VuL21hc3Rlci91c2VyL3F1aWNrc3RhcnQvI3RpbWVvdXRzCisK IDIwMjAtMDctMTUgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIE1ha2UgZXdzIGRqYW5nbyBhcHAgcm9idXN0IGFnYWluc3QgbmV0d29yayBpc3N1ZXMKSW5k ZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi91dGlsLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi91 dGlsLnB5CShyZXZpc2lvbiAyNjQzOTgpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YXBwL2V3cy9jb21tb24vdXRpbC5weQkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLSMg Q29weXJpZ2h0IChDKSAyMDE4LTIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgor IyBDb3B5cmlnaHQgKEMpIDIwMTgtMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMs IHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQg dGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTMwLDcgKzMwLDcgQEAgZGVmIGZldGNo X2RhdGFfZnJvbV91cmwodXJsKToKICAgICBfbG9nLmRlYnVnKCdGZXRjaGluZzoge30nLmZvcm1h dCh1cmwpKQogICAgIHJlc3BvbnNlID0gTm9uZQogICAgIHRyeToKLSAgICAgICAgcmVzcG9uc2Ug PSByZXF1ZXN0cy5nZXQodXJsKQorICAgICAgICByZXNwb25zZSA9IHJlcXVlc3RzLmdldCh1cmws IHRpbWVvdXQ9MTApCiAgICAgZXhjZXB0IEV4Y2VwdGlvbiBhcyBlOgogICAgICAgICBpZiByZXNw b25zZToKICAgICAgICAgICAgIF9sb2cuZXJyb3IoJ0ZhaWxlZCB0byBhY2Nlc3Mge3VybH0gd2l0 aCBzdGF0dXMgY29kZSB7c3RhdHVzX2NvZGV9LicuZm9ybWF0KHVybD11cmwsIHN0YXR1c19jb2Rl PXJlc3BvbnNlLnN0YXR1c19jb2RlKSkK