214351 2020-07-15 07:16:52 -0700 Make ews django app robust against network issues 2020-07-15 07:52:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1671729 0 aakash_jain 2020-07-15 07:16:52 -0700 Make ews django app robust against buildbot downtime. When ews django app starts, it fetches builder_name_to_id_mapping from Buildbot server. It fetches it only once. If Buildbot server was down at that moment or there was any network issue, that mapping isn't fetched. This mapping is used to decide which patches to send to Commit-Queue (by fetching list of pending_and_inprogress_builds on commit-queue). Although failure to fetch this mapping doesn't cause any functionality issue, since the logic is able to work without this mapping as well, it becomes little inefficient and logs have error messages like: "Invalid builder: Commit-Queue". We should re-fetch this mapping when required to make ews django app more robust against Buildbot downtime or network issues. 1671730 1 404340 aakash_jain 2020-07-15 07:20:30 -0700 Created attachment 404340 Patch 1671735 2 ews-feeder 2020-07-15 07:51:40 -0700 Committed r264398: <https://trac.webkit.org/changeset/264398> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404340. 1671736 3 webkit-bug-importer 2020-07-15 07:52:15 -0700 <rdar://problem/65605376> 404340 2020-07-15 07:20:30 -0700 2020-07-15 07:51:40 -0700 Patch bug-214351-20200715102029.patch text/plain 1816 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDM5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA3LTE1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBNYWtlIGV3cyBkamFuZ28gYXBwIHJvYnVzdCBhZ2FpbnN0IG5ldHdvcmsg aXNzdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTQzNTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi9idWlsZGJvdC5weToKKyAgICAg ICAgKEJ1aWxkYm90LmZldGNoX3BlbmRpbmdfYW5kX2lucHJvZ3Jlc3NfYnVpbGRzKTogUmUtZmV0 Y2ggYnVpbGRlcl9uYW1lX3RvX2lkX21hcHBpbmcgaWYgcmVxdWlyZWQuCisKIDIwMjAtMDctMTUg IEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFt3ZWJraXRw eV0gU3VwcG9ydCBSb3NldHRhIHRlc3RpbmcKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2V3cy1hcHAvZXdzL2NvbW1vbi9idWlsZGJvdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWls ZFNsYXZlU3VwcG9ydC9ld3MtYXBwL2V3cy9jb21tb24vYnVpbGRib3QucHkJKHJldmlzaW9uIDI2 NDM5NikKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1hcHAvZXdzL2NvbW1vbi9idWls ZGJvdC5weQkod29ya2luZyBjb3B5KQpAQCAtMTE3LDggKzExNywxMiBAQCBjbGFzcyBCdWlsZGJv dCgpOgogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBmZXRjaF9wZW5kaW5nX2FuZF9pbnByb2dy ZXNzX2J1aWxkcyhjbHMsIGJ1aWxkZXJfZnVsbF9uYW1lKToKICAgICAgICAgYnVpbGRlcmlkID0g QnVpbGRib3QuYnVpbGRlcl9uYW1lX3RvX2lkX21hcHBpbmcuZ2V0KGJ1aWxkZXJfZnVsbF9uYW1l KQorICAgICAgICBpZiBub3QgQnVpbGRib3QuYnVpbGRlcl9uYW1lX3RvX2lkX21hcHBpbmc6Cisg ICAgICAgICAgICBfbG9nLndhcm4oJ01pc3NpbmcgYnVpbGRlcl9uYW1lX3RvX2lkX21hcHBpbmcs IHJlZmV0Y2hpbmcgaXQgZnJvbSB7fScuZm9ybWF0KGNvbmZpZy5CVUlMREJPVF9TRVJWRVJfSE9T VCkpCisgICAgICAgICAgICBjbHMudXBkYXRlX2J1aWxkZXJfbmFtZV90b19pZF9tYXBwaW5nKCkK KwogICAgICAgICBpZiBub3QgYnVpbGRlcmlkOgotICAgICAgICAgICAgX2xvZy5lcnJvcignSW52 YWxpZCBidWlsZGVyOiB7fScuZm9ybWF0KGJ1aWxkZXJfZnVsbF9uYW1lKSkKKyAgICAgICAgICAg IF9sb2cuZXJyb3IoJ0ludmFsaWQgYnVpbGRlcjoge30uIE51bWJlciBvZiBidWlsZGVyczoge30n LmZvcm1hdChidWlsZGVyX2Z1bGxfbmFtZSwgbGVuKGNscy5idWlsZGVyX25hbWVfdG9faWRfbWFw cGluZykpKQogICAgICAgICAgICAgcmV0dXJuIHt9CiAgICAgICAgIHVybCA9ICdodHRwczovL3t9 L2FwaS92Mi9idWlsZGVycy97fS9idWlsZHJlcXVlc3RzP2NvbXBsZXRlPWZhbHNlJnByb3BlcnR5 PSonLmZvcm1hdChjb25maWcuQlVJTERCT1RfU0VSVkVSX0hPU1QsIGJ1aWxkZXJpZCkKICAgICAg ICAgYnVpbGRlcnNfZGF0YSA9IHV0aWwuZmV0Y2hfZGF0YV9mcm9tX3VybCh1cmwpCg==