214346 2020-07-15 04:37:14 -0700 ASAN builds of WebKit should not freeze when an EXC_RESOURCE is delivered 2020-07-16 02:12:15 -0700 1 1 1 Unclassified WebKit Platform Other Unspecified macOS 10.15 RESOLVED FIXED InRadar P2 Normal --- 1 tuomas.webkit webkit-unassigned mark.lam webkit-bug-importer oldest_to_newest 1671700 0 tuomas.webkit 2020-07-15 04:37:14 -0700 When a process instrumented with AddressSanitizer receives an EXC_RESOURCE, it is frozen for several minutes. 1671704 1 404332 tuomas.webkit 2020-07-15 05:06:40 -0700 Created attachment 404332 proposed patch 1671732 2 404332 mark.lam 2020-07-15 07:37:17 -0700 Comment on attachment 404332 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=404332&action=review r=me with fix. > Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:153 > + // EXC_RESOURCE on ASAN builds freezes the process for several minutes: rdar://65027596 > + if (char *disableFreezingOnExcResource = getenv("DISABLE_FREEZING_ON_EXC_RESOURCE")) { > + if (!strcasecmp(disableFreezingOnExcResource, "yes") || !strcasecmp(disableFreezingOnExcResource, "true") || !strcasecmp(disableFreezingOnExcResource, "1")) { > + int val = 1; > + int rc = sysctlbyname("debug.toggle_address_reuse", nullptr, 0, &val, sizeof(val)); > + if (rc < 0) > + WTFLogAlways("failed to set debug.toggle_address_reuse: %d\n", rc); > + else > + WTFLogAlways("debug.toggle_address_reuse is now 1.\n"); > + } > + } Can you guard this with #if ASAN_ENABLED? We don't need this for any other builds, right? 1671757 3 tuomas.webkit 2020-07-15 09:02:35 -0700 Ok, will do. I was thinking other sanitizers might be affected, but looking quickly at an UBSAN build, there are no giant mappings there, so limiting it to ASAN makes sense. 1672073 4 404429 tuomas.webkit 2020-07-16 01:22:18 -0700 Created attachment 404429 proposed patch wraps the code in #if ASAN_ENABLED as requested 1672075 5 ews-feeder 2020-07-16 02:11:35 -0700 Committed r264450: <https://trac.webkit.org/changeset/264450> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404429. 1672076 6 webkit-bug-importer 2020-07-16 02:12:15 -0700 <rdar://problem/65653827> 404332 2020-07-15 05:06:40 -0700 2020-07-16 01:22:18 -0700 proposed patch webkit_214346.patch text/plain 3187 tuomas.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNGYyZTFkZjc0YTVjLi4wOTMyYTU1NjUxYTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjUgQEAKKzIwMjAtMDctMTUgIFR1b21hcyBLYXJra2FpbmVuICA8dHVvbWFzLndlYmtpdEBh cHBsZS5jb20+CisKKyAgICAgICAgQVNBTiBidWlsZHMgb2YgV2ViS2l0IHNob3VsZCBub3QgZnJl ZXplIHdoZW4gYW4gRVhDX1JFU09VUkNFIGlzIGRlbGl2ZXJlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0MzQ2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB0aGUgV2ViQ29udGVudCBwcm9jZXNz IGFsbG9jYXRlcyAxMDAwIE1CIG9mIG1lbW9yeSBvciBzdGFydHMgMzIKKyAgICAgICAgdGhyZWFk cywgaXQgcmVjZWl2ZXMgYW4gRVhDX1JFU09VUkNFLiBUaGlzIHJlcXVpcmVzIGl0ZXJhdGluZyBh bGwgdGhlCisgICAgICAgIG1hcHBpbmdzIG9mIHRoZSBwcm9jZXNzLiBGb3IgdGhlIGNhc2Ugb2Yg YSBwcm9jZXNzIGluc3RydW1lbnRlZCB3aXRoCisgICAgICAgIEFkZHJlc3NTYW5pdGl6ZXIsIHRo ZSBtYXBwaW5ncyB0b3RhbCAyMCB0ZXJhYnl0ZXMsIGFuZCBjYXVzZSB0aGUKKyAgICAgICAgcHJv Y2VzcyB0byAiZnJlZXplIiBmb3Igc2V2ZXJhbCBtaW51dGVzLiAKKworICAgICAgICBTZXR0aW5n IHRoZSBzeXNjdGwgZGVidWcudG9nZ2xlX2FkZHJlc3NfcmV1c2UgdG8gMSBjYXVzZXMgdGhlCisg ICAgICAgIEVYQ19SRVNPVVJDRSBtZWNoYW5pc20gdG8gc2tpcCBpdGVyYXRpb24gb2YgYWxsIHRo ZSBtYXBwaW5ncy4gCisKKyAgICAgICAgV2l0aCB0aGlzIHBhdGNoLCBzZXR0aW5nIHRoZSBlbnZp cm9ubWVudCB2YXJpYWJsZSAKKyAgICAgICAgRElTQUJMRV9GUkVFWklOR19PTl9FWENfUkVTT1VS Q0Ugd2lsbCBzZXQgdGhlIHN5c2N0bCBtZW50aW9uZWQgYWJvdmUKKyAgICAgICAgZm9yIFdlYkNv bnRlbnQgYW5kIE5ldHdvcmtpbmcgcHJvY2Vzc2VzLgorCisgICAgICAgICogU2hhcmVkL0VudHJ5 UG9pbnRVdGlsaXRpZXMvQ29jb2EvWFBDU2VydmljZS9YUENTZXJ2aWNlTWFpbi5tbToKKwogMjAy MC0wNy0xNCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAg W2lPU10gQWRkIG1pc3NpbmcgbWVzc2FnZXMgdG8gbWVzc2FnZSBmaWx0ZXIgaW4gV2ViQ29udGVu dCBzYW5kYm94CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRp bGl0aWVzL0NvY29hL1hQQ1NlcnZpY2UvWFBDU2VydmljZU1haW4ubW0gYi9Tb3VyY2UvV2ViS2l0 L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL1hQQ1NlcnZpY2UvWFBDU2VydmljZU1h aW4ubW0KaW5kZXggMmE2NDMwZTBlNzEzLi43M2Q4NjRmYmUwMjAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvWFBDU2VydmljZS9YUENT ZXJ2aWNlTWFpbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0 aWVzL0NvY29hL1hQQ1NlcnZpY2UvWFBDU2VydmljZU1haW4ubW0KQEAgLTMwLDYgKzMwLDcgQEAK ICNpbXBvcnQgPENvcmVGb3VuZGF0aW9uL0NvcmVGb3VuZGF0aW9uLmg+CiAjaW1wb3J0IDxwYWwv c3BpL2NmL0NGVXRpbGl0aWVzU1BJLmg+CiAjaW1wb3J0IDxwYWwvc3BpL2NvY29hL0xhdW5jaFNl cnZpY2VzU1BJLmg+CisjaW1wb3J0IDxzeXMvc3lzY3RsLmg+CiAjaW1wb3J0IDx3dGYvT1NPYmpl Y3RQdHIuaD4KICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KICNpbXBvcnQgPHd0Zi9zcGkvZGFy d2luL1hQQ1NQSS5oPgpAQCAtMTM5LDYgKzE0MCwxNyBAQCBpbnQgWFBDU2VydmljZU1haW4oaW50 IGFyZ2MsIGNvbnN0IGNoYXIqKiBhcmd2KQogCiAgICAgaWYgKGJvb3RzdHJhcCkgewogI2lmIFBM QVRGT1JNKE1BQykKKyAgICAgICAgLy8gRVhDX1JFU09VUkNFIG9uIEFTQU4gYnVpbGRzIGZyZWV6 ZXMgdGhlIHByb2Nlc3MgZm9yIHNldmVyYWwgbWludXRlczogcmRhcjovLzY1MDI3NTk2CisgICAg ICAgIGlmIChjaGFyICpkaXNhYmxlRnJlZXppbmdPbkV4Y1Jlc291cmNlID0gZ2V0ZW52KCJESVNB QkxFX0ZSRUVaSU5HX09OX0VYQ19SRVNPVVJDRSIpKSB7CisgICAgICAgICAgICBpZiAoIXN0cmNh c2VjbXAoZGlzYWJsZUZyZWV6aW5nT25FeGNSZXNvdXJjZSwgInllcyIpIHx8ICFzdHJjYXNlY21w KGRpc2FibGVGcmVlemluZ09uRXhjUmVzb3VyY2UsICJ0cnVlIikgfHwgIXN0cmNhc2VjbXAoZGlz YWJsZUZyZWV6aW5nT25FeGNSZXNvdXJjZSwgIjEiKSkgeworICAgICAgICAgICAgICAgIGludCB2 YWwgPSAxOworICAgICAgICAgICAgICAgIGludCByYyA9IHN5c2N0bGJ5bmFtZSgiZGVidWcudG9n Z2xlX2FkZHJlc3NfcmV1c2UiLCBudWxscHRyLCAwLCAmdmFsLCBzaXplb2YodmFsKSk7CisgICAg ICAgICAgICAgICAgaWYgKHJjIDwgMCkKKyAgICAgICAgICAgICAgICAgICAgV1RGTG9nQWx3YXlz KCJmYWlsZWQgdG8gc2V0IGRlYnVnLnRvZ2dsZV9hZGRyZXNzX3JldXNlOiAlZFxuIiwgcmMpOwor ICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgV1RGTG9nQWx3YXlzKCJk ZWJ1Zy50b2dnbGVfYWRkcmVzc19yZXVzZSBpcyBub3cgMS5cbiIpOworICAgICAgICAgICAgfQor ICAgICAgICB9CiAgICAgICAgIFN0cmluZyB3ZWJLaXRCdW5kbGVWZXJzaW9uID0geHBjX2RpY3Rp b25hcnlfZ2V0X3N0cmluZyhib290c3RyYXAuZ2V0KCksICJXZWJLaXRCdW5kbGVWZXJzaW9uIik7 CiAgICAgICAgIFN0cmluZyBleHBlY3RlZEJ1bmRsZVZlcnNpb24gPSBbTlNCdW5kbGUgYnVuZGxl V2l0aElkZW50aWZpZXI6QCJjb20uYXBwbGUuV2ViS2l0Il0uaW5mb0RpY3Rpb25hcnlbKF9fYnJp ZGdlIE5TU3RyaW5nICopa0NGQnVuZGxlVmVyc2lvbktleV07CiAgICAgICAgIGlmICghd2ViS2l0 QnVuZGxlVmVyc2lvbi5pc051bGwoKSAmJiAhZXhwZWN0ZWRCdW5kbGVWZXJzaW9uLmlzTnVsbCgp ICYmIHdlYktpdEJ1bmRsZVZlcnNpb24gIT0gZXhwZWN0ZWRCdW5kbGVWZXJzaW9uKSB7Cg== 404429 2020-07-16 01:22:18 -0700 2020-07-16 02:11:35 -0700 proposed patch webkit_214346_b.patch text/plain 3207 tuomas.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNGYyZTFkZjc0YTVjLi4wOTMyYTU1NjUxYTYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjUgQEAKKzIwMjAtMDctMTUgIFR1b21hcyBLYXJra2FpbmVuICA8dHVvbWFzLndlYmtpdEBh cHBsZS5jb20+CisKKyAgICAgICAgQVNBTiBidWlsZHMgb2YgV2ViS2l0IHNob3VsZCBub3QgZnJl ZXplIHdoZW4gYW4gRVhDX1JFU09VUkNFIGlzIGRlbGl2ZXJlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0MzQ2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTWFyayBMYW0uCisKKyAgICAgICAgV2hlbiB0aGUgV2ViQ29udGVudCBwcm9jZXNzIGFsbG9j YXRlcyAxMDAwIE1CIG9mIG1lbW9yeSBvciBzdGFydHMgMzIKKyAgICAgICAgdGhyZWFkcywgaXQg cmVjZWl2ZXMgYW4gRVhDX1JFU09VUkNFLiBUaGlzIHJlcXVpcmVzIGl0ZXJhdGluZyBhbGwgdGhl CisgICAgICAgIG1hcHBpbmdzIG9mIHRoZSBwcm9jZXNzLiBGb3IgdGhlIGNhc2Ugb2YgYSBwcm9j ZXNzIGluc3RydW1lbnRlZCB3aXRoCisgICAgICAgIEFkZHJlc3NTYW5pdGl6ZXIsIHRoZSBtYXBw aW5ncyB0b3RhbCAyMCB0ZXJhYnl0ZXMsIGFuZCBjYXVzZSB0aGUKKyAgICAgICAgcHJvY2VzcyB0 byAiZnJlZXplIiBmb3Igc2V2ZXJhbCBtaW51dGVzLiAKKworICAgICAgICBTZXR0aW5nIHRoZSBz eXNjdGwgZGVidWcudG9nZ2xlX2FkZHJlc3NfcmV1c2UgdG8gMSBjYXVzZXMgdGhlCisgICAgICAg IEVYQ19SRVNPVVJDRSBtZWNoYW5pc20gdG8gc2tpcCBpdGVyYXRpb24gb2YgYWxsIHRoZSBtYXBw aW5ncy4gCisKKyAgICAgICAgV2l0aCB0aGlzIHBhdGNoLCBzZXR0aW5nIHRoZSBlbnZpcm9ubWVu dCB2YXJpYWJsZSAKKyAgICAgICAgRElTQUJMRV9GUkVFWklOR19PTl9FWENfUkVTT1VSQ0Ugd2ls bCBzZXQgdGhlIHN5c2N0bCBtZW50aW9uZWQgYWJvdmUKKyAgICAgICAgZm9yIFdlYkNvbnRlbnQg YW5kIE5ldHdvcmtpbmcgcHJvY2Vzc2VzLgorCisgICAgICAgICogU2hhcmVkL0VudHJ5UG9pbnRV dGlsaXRpZXMvQ29jb2EvWFBDU2VydmljZS9YUENTZXJ2aWNlTWFpbi5tbToKKwogMjAyMC0wNy0x NCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g QWRkIG1pc3NpbmcgbWVzc2FnZXMgdG8gbWVzc2FnZSBmaWx0ZXIgaW4gV2ViQ29udGVudCBzYW5k Ym94CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVz L0NvY29hL1hQQ1NlcnZpY2UvWFBDU2VydmljZU1haW4ubW0gYi9Tb3VyY2UvV2ViS2l0L1NoYXJl ZC9FbnRyeVBvaW50VXRpbGl0aWVzL0NvY29hL1hQQ1NlcnZpY2UvWFBDU2VydmljZU1haW4ubW0K aW5kZXggMmE2NDMwZTBlNzEzLi41YTIyZjVlYjI5ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvU2hhcmVkL0VudHJ5UG9pbnRVdGlsaXRpZXMvQ29jb2EvWFBDU2VydmljZS9YUENTZXJ2aWNl TWFpbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9FbnRyeVBvaW50VXRpbGl0aWVzL0Nv Y29hL1hQQ1NlcnZpY2UvWFBDU2VydmljZU1haW4ubW0KQEAgLTMwLDYgKzMwLDcgQEAKICNpbXBv cnQgPENvcmVGb3VuZGF0aW9uL0NvcmVGb3VuZGF0aW9uLmg+CiAjaW1wb3J0IDxwYWwvc3BpL2Nm L0NGVXRpbGl0aWVzU1BJLmg+CiAjaW1wb3J0IDxwYWwvc3BpL2NvY29hL0xhdW5jaFNlcnZpY2Vz U1BJLmg+CisjaW1wb3J0IDxzeXMvc3lzY3RsLmg+CiAjaW1wb3J0IDx3dGYvT1NPYmplY3RQdHIu aD4KICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KICNpbXBvcnQgPHd0Zi9zcGkvZGFyd2luL1hQ Q1NQSS5oPgpAQCAtMTM5LDYgKzE0MCwxOSBAQCBpbnQgWFBDU2VydmljZU1haW4oaW50IGFyZ2Ms IGNvbnN0IGNoYXIqKiBhcmd2KQogCiAgICAgaWYgKGJvb3RzdHJhcCkgewogI2lmIFBMQVRGT1JN KE1BQykKKyNpZiBBU0FOX0VOQUJMRUQKKyAgICAgICAgLy8gRVhDX1JFU09VUkNFIG9uIEFTQU4g YnVpbGRzIGZyZWV6ZXMgdGhlIHByb2Nlc3MgZm9yIHNldmVyYWwgbWludXRlczogcmRhcjovLzY1 MDI3NTk2CisgICAgICAgIGlmIChjaGFyICpkaXNhYmxlRnJlZXppbmdPbkV4Y1Jlc291cmNlID0g Z2V0ZW52KCJESVNBQkxFX0ZSRUVaSU5HX09OX0VYQ19SRVNPVVJDRSIpKSB7CisgICAgICAgICAg ICBpZiAoIXN0cmNhc2VjbXAoZGlzYWJsZUZyZWV6aW5nT25FeGNSZXNvdXJjZSwgInllcyIpIHx8 ICFzdHJjYXNlY21wKGRpc2FibGVGcmVlemluZ09uRXhjUmVzb3VyY2UsICJ0cnVlIikgfHwgIXN0 cmNhc2VjbXAoZGlzYWJsZUZyZWV6aW5nT25FeGNSZXNvdXJjZSwgIjEiKSkgeworICAgICAgICAg ICAgICAgIGludCB2YWwgPSAxOworICAgICAgICAgICAgICAgIGludCByYyA9IHN5c2N0bGJ5bmFt ZSgiZGVidWcudG9nZ2xlX2FkZHJlc3NfcmV1c2UiLCBudWxscHRyLCAwLCAmdmFsLCBzaXplb2Yo dmFsKSk7CisgICAgICAgICAgICAgICAgaWYgKHJjIDwgMCkKKyAgICAgICAgICAgICAgICAgICAg V1RGTG9nQWx3YXlzKCJmYWlsZWQgdG8gc2V0IGRlYnVnLnRvZ2dsZV9hZGRyZXNzX3JldXNlOiAl ZFxuIiwgcmMpOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgV1RG TG9nQWx3YXlzKCJkZWJ1Zy50b2dnbGVfYWRkcmVzc19yZXVzZSBpcyBub3cgMS5cbiIpOworICAg ICAgICAgICAgfQorICAgICAgICB9CisjZW5kaWYKICAgICAgICAgU3RyaW5nIHdlYktpdEJ1bmRs ZVZlcnNpb24gPSB4cGNfZGljdGlvbmFyeV9nZXRfc3RyaW5nKGJvb3RzdHJhcC5nZXQoKSwgIldl YktpdEJ1bmRsZVZlcnNpb24iKTsKICAgICAgICAgU3RyaW5nIGV4cGVjdGVkQnVuZGxlVmVyc2lv biA9IFtOU0J1bmRsZSBidW5kbGVXaXRoSWRlbnRpZmllcjpAImNvbS5hcHBsZS5XZWJLaXQiXS5p bmZvRGljdGlvbmFyeVsoX19icmlkZ2UgTlNTdHJpbmcgKilrQ0ZCdW5kbGVWZXJzaW9uS2V5XTsK ICAgICAgICAgaWYgKCF3ZWJLaXRCdW5kbGVWZXJzaW9uLmlzTnVsbCgpICYmICFleHBlY3RlZEJ1 bmRsZVZlcnNpb24uaXNOdWxsKCkgJiYgd2ViS2l0QnVuZGxlVmVyc2lvbiAhPSBleHBlY3RlZEJ1 bmRsZVZlcnNpb24pIHsK