<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>214338</bug_id>
          
          <creation_ts>2020-07-14 20:16:02 -0700</creation_ts>
          <short_desc>Add some missing boilerplate to help fix build on macOS Big Sur</short_desc>
          <delta_ts>2020-07-15 16:19:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saagar Jha">saagar</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>benjamin</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>darin</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1671638</commentid>
    <comment_count>0</comment_count>
    <who name="Saagar Jha">saagar</who>
    <bug_when>2020-07-14 20:16:02 -0700</bug_when>
    <thetext>Add some missing boilerplate to help fix build on macOS Big Sur</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671643</commentid>
    <comment_count>1</comment_count>
      <attachid>404316</attachid>
    <who name="Saagar Jha">saagar</who>
    <bug_when>2020-07-14 20:18:56 -0700</bug_when>
    <thetext>Created attachment 404316
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671782</commentid>
    <comment_count>2</comment_count>
      <attachid>404316</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-07-15 10:12:32 -0700</bug_when>
    <thetext>Comment on attachment 404316
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404316&amp;action=review

This is OK, but not entirely correct.

&gt; Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h:37
&gt; +@property (nonatomic, setter=_setUsesMetricsAppearance:) BOOL _usesMetricsAppearance;

No way for you to know this, but this should be:

    - (BOOL)_usesMetricsAppearance;

Could declare it as a property, harmless but not quite right, and there is definitely no setter.

&gt; Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:38
&gt; ++ (instancetype)_imageWithSystemSymbolName:(NSString *)systemSymbolName;

No way for you to know this, but the return type should not be (instancetype). It should be like this instead:

    + (nullable NSImage *)_imageWithSystemSymbolName:(NSString *)name;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671786</commentid>
    <comment_count>3</comment_count>
    <who name="Saagar Jha">saagar</who>
    <bug_when>2020-07-15 10:21:19 -0700</bug_when>
    <thetext>Yeah, I&apos;m just guessing these from looking at AppKit&apos;s symbol table, so they might differ from the actual internal header. -[NSAppearance _setUsesMetricsAppearance:] does exist on my system and sets the same ivar that -[NSAppearance _usesMetricsAppearance] accesses, and it isn&apos;t packed into a bitfield like many IPI flags are, so I figured that its setter might be exposed as SPI. I&apos;ll fix that and the nullability annotation and put up another patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671797</commentid>
    <comment_count>4</comment_count>
      <attachid>404356</attachid>
    <who name="Saagar Jha">saagar</who>
    <bug_when>2020-07-15 10:36:12 -0700</bug_when>
    <thetext>Created attachment 404356
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671808</commentid>
    <comment_count>5</comment_count>
      <attachid>404356</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-07-15 11:04:22 -0700</bug_when>
    <thetext>Comment on attachment 404356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404356&amp;action=review

Needs a tweak, but otherwise looks good.

&gt; Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h:37
&gt; +- (BOOL)_usesMetricsAppearance;

This should only be declared in #if !USE(APPLE_INTERNAL_SDK), otherwise it will probably break an internal build because it&apos;s already declared.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671814</commentid>
    <comment_count>6</comment_count>
      <attachid>404356</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-07-15 11:13:27 -0700</bug_when>
    <thetext>Comment on attachment 404356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404356&amp;action=review

&gt;&gt; Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h:37
&gt;&gt; +- (BOOL)_usesMetricsAppearance;
&gt; 
&gt; This should only be declared in #if !USE(APPLE_INTERNAL_SDK), otherwise it will probably break an internal build because it&apos;s already declared.

Oh, good point! How did I miss that?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671821</commentid>
    <comment_count>7</comment_count>
    <who name="Saagar Jha">saagar</who>
    <bug_when>2020-07-15 11:22:55 -0700</bug_when>
    <thetext>I thought that this should work as long as it matches the previous instance, like other declarations? If not I&apos;d be happy to wrap that in a #if !USE(APPLE_INTERNAL_SDK)–should I do that for the NSImage SPI as well?

(Also, is there a way to get webkit-patch upload to use staged changes for a patch? Until now I&apos;ve been stashing all my work, reapplying it, deleting all of my additional changes that aren&apos;t in this patch, and then reapplying again after running the script to get back to how it was before…)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671829</commentid>
    <comment_count>8</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-07-15 11:24:43 -0700</bug_when>
    <thetext>You&apos;ve actually already done it for the NSImage SPI.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671830</commentid>
    <comment_count>9</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2020-07-15 11:27:17 -0700</bug_when>
    <thetext>(In reply to Saagar Jha from comment #7)
&gt; I thought that this should work as long as it matches the previous instance,
&gt; like other declarations?

Sadly, no, Objective-C class extensions don’t work that way.

&gt; (Also, is there a way to get webkit-patch upload to use staged changes for a
&gt; patch? Until now I&apos;ve been stashing all my work, reapplying it, deleting all
&gt; of my additional changes that aren&apos;t in this patch, and then reapplying
&gt; again after running the script to get back to how it was before…)

I use separate branches for separate patches, not sure what this means in terms of the answer to your question.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671832</commentid>
    <comment_count>10</comment_count>
      <attachid>404363</attachid>
    <who name="Saagar Jha">saagar</who>
    <bug_when>2020-07-15 11:30:05 -0700</bug_when>
    <thetext>Created attachment 404363
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671845</commentid>
    <comment_count>11</comment_count>
    <who name="Saagar Jha">saagar</who>
    <bug_when>2020-07-15 11:38:47 -0700</bug_when>
    <thetext>(In reply to Alex Christensen from comment #8)
&gt; You&apos;ve actually already done it for the NSImage SPI.

Ha, so I have. Added it to NSAppearance as well.

(In reply to Darin Adler from comment #9)
&gt; Sadly, no, Objective-C class extensions don’t work that way.

Sad :(

 
&gt; I use separate branches for separate patches, not sure what this means in
&gt; terms of the answer to your question.

I have additional changes locally to that upstream probably doesn&apos;t want, like commenting out non-building code that I could&apos;t come up with fixes for. Usually I keep things like that permanently unstaged and upload only the changes that are relevant by staging and committing them. As webkit-patch doesn&apos;t seem to actually make commits I wasn&apos;t sure how to get it to understand the staging area–although if it just doesn&apos;t do this I can keep stashing as I was before. (I should note that I am using Git to work with the repository, not Subversion, so this might be a strange thing to try to do.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671854</commentid>
    <comment_count>12</comment_count>
      <attachid>404363</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-07-15 12:05:22 -0700</bug_when>
    <thetext>Comment on attachment 404363
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404363&amp;action=review

&gt; Source/WebCore/PAL/pal/spi/mac/NSImageSPI.h:38
&gt; ++ (nullable NSImage *)_imageWithSystemSymbolName:(NSString *)name;

It looks like you need to remove nullable here.  Adding a nullability specifier to an ObjC header makes it require nullability specifiers for all of them.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671859</commentid>
    <comment_count>13</comment_count>
      <attachid>404372</attachid>
    <who name="Saagar Jha">saagar</who>
    <bug_when>2020-07-15 12:13:12 -0700</bug_when>
    <thetext>Created attachment 404372
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671863</commentid>
    <comment_count>14</comment_count>
      <attachid>404372</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2020-07-15 12:19:56 -0700</bug_when>
    <thetext>Comment on attachment 404372
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404372&amp;action=review

&gt; Source/WebCore/PAL/pal/spi/mac/NSAppearanceSPI.h:36
&gt;  - (void)_drawInRect:(NSRect)rect context:(CGContextRef)context options:(NSDictionary *)options;

This will break our internal build.  This needs to be here for APPLE_INTERNAL_SDK and not.  _usesMetricsAppearance only needs to be there for not APPLE_INTERNAL_SDK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671865</commentid>
    <comment_count>15</comment_count>
      <attachid>404374</attachid>
    <who name="Saagar Jha">saagar</who>
    <bug_when>2020-07-15 12:24:08 -0700</bug_when>
    <thetext>Created attachment 404374
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671866</commentid>
    <comment_count>16</comment_count>
    <who name="Saagar Jha">saagar</who>
    <bug_when>2020-07-15 12:25:03 -0700</bug_when>
    <thetext>Stopped trying to be clever; here&apos;s a new patch. Also I found out that webkit-upload has a -g argument and you can use that to just give it a commit to upload, so no need to stash anymore.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671963</commentid>
    <comment_count>17</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-07-15 15:15:00 -0700</bug_when>
    <thetext>Committed r264428: &lt;https://trac.webkit.org/changeset/264428&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404374.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671964</commentid>
    <comment_count>18</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-07-15 15:15:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/65629661&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1671981</commentid>
    <comment_count>19</comment_count>
    <who name="Saagar Jha">saagar</who>
    <bug_when>2020-07-15 16:19:15 -0700</bug_when>
    <thetext>Thanks for your patience in reviewing this, Darin and Alex!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>404316</attachid>
            <date>2020-07-14 20:18:56 -0700</date>
            <delta_ts>2020-07-15 10:36:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214338-20200714201855.patch</filename>
            <type>text/plain</type>
            <size>3189</size>
            <attacher name="Saagar Jha">saagar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0Mzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDViYTMyOTRiMDRkNjM0YTRlNmIyOTVl
ZDJkZTIyOTg4NzcwZDRiNjEuLjYyMjdhZDQzM2Y3MDEyNTY2YjY4YjgyYWFkMDFkZTVlNWU3ZjJh
YzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDctMTQgIFNhYWdhciBKaGEgIDxzYWFnYXJA
c2FhZ2FyamhhLmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGJvaWxlcnBsYXRlIHRv
IGhlbHAgZml4IGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtSGF2ZS5oOiBBZGQgSEFWRV9M
QVJHRV9DT05UUk9MX1NJWkUgYW5kIGVuYWJsZSBpdCBvbiBCaWcgU3VyLgorCiAyMDIwLTA3LTE0
ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAg
UkVHUkVTU0lPTihyMjYyMzQxKSBVUkw6OmNyZWF0ZUNGVVJMIHNob3VsZCBwcm9kdWNlIGEgQ0ZV
UkwgdGhhdCB1c2VzIFVURi04IHRvIGRlY29kZSBpdHMgcGVyY2VudC1lbmNvZGVkIHNlcXVlbmNl
cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJD
b3JlL1BBTC9DaGFuZ2VMb2cKaW5kZXggY2JhOTE0ZTFlMzhkYjNkY2M4NjEyNjdmOWE1MDg2ZTVk
MjBhZDRlYS4uNjY5ZjUxZjAzZTNmM2RkOTdkNjI5OGMyMzU4NDI2Mzg3ZjViMDg5YiAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9Q
QUwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDctMTQgIFNhYWdhciBKaGEgIDxz
YWFnYXJAc2FhZ2FyamhhLmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGJvaWxlcnBs
YXRlIHRvIGhlbHAgZml4IGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDMzOAorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFsL3NwaS9tYWMvTlNBcHBlYXJhbmNl
U1BJLmg6IEFkZCBOU0FwcGVhcmFuY2UuX3VzZXNNZXRyaWNzQXBwZWFyYW5jZXMgdG8gdGhlIFNQ
SSBoZWFkZXIuCisgICAgICAgICogcGFsL3NwaS9tYWMvTlNJbWFnZVNQSS5oOiBBZGQgLVtOU0lt
YWdlIF9pbWFnZVdpdGhTeXN0ZW1TeW1ib2xOYW1lOl0gdG8gdGhlIFNQSSBoZWFkZXIuCisKIDIw
MjAtMDctMTIgIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBCdWlsZGlu
ZyBDRk5ldHdvcmtTUEkgd2l0aCB0aGUgbWFjT1MgQmlnIFN1ciBwdWJsaWMgU0RLIGZhaWxzCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaCBiL1NvdXJjZS9XVEYvd3Rm
L1BsYXRmb3JtSGF2ZS5oCmluZGV4IGU0N2E3NDVjNmNkODdjYzQwYTg4OGIwYWVlYjQ3NTMzNGRi
N2MxNWEuLmNhNzVjNDIxNTY3N2QwZGU2NzU5ZTU2ZmNmM2EzNDVlYjNmNjUzOGEgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1Bs
YXRmb3JtSGF2ZS5oCkBAIC01OTAsNiArNTkwLDEwIEBACiAjZGVmaW5lIEhBVkVfQUxURVJOQVRF
X0lDT05TIDEKICNlbmRpZgogCisjaWYgKFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJT
SU9OX01JTl9SRVFVSVJFRCA+PSAxMDE2MDApCisjZGVmaW5lIEhBVkVfTEFSR0VfQ09OVFJPTF9T
SVpFIDEKKyNlbmRpZgorCiAjaWYgKFBMQVRGT1JNKElPUykgJiYgX19JUEhPTkVfT1NfVkVSU0lP
Tl9NSU5fUkVRVUlSRUQgPj0gMTQwMDAwKQogI2RlZmluZSBIQVZFX1VJQ09OVEVYVE1FTlVfTE9D
QVRJT04gMQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9t
YWMvTlNBcHBlYXJhbmNlU1BJLmggYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNB
cHBlYXJhbmNlU1BJLmgKaW5kZXggN2RiNjk3MDAwNzE3NjMxMzk5MTdlMDA5YTI5N2IxZDJlYWVi
MzVhOS4uZjc4ZTM5MmQ1MTg3NjA4NWMyNzA4NzU2MDExYWU1ZDVmZGVlY2QxYiAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TQXBwZWFyYW5jZVNQSS5oCisrKyBi
L1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0FwcGVhcmFuY2VTUEkuaApAQCAtMzQs
NiArMzQsNyBAQAogQGludGVyZmFjZSBOU0FwcGVhcmFuY2UgKCkKIAogLSAodm9pZClfZHJhd0lu
UmVjdDooTlNSZWN0KXJlY3QgY29udGV4dDooQ0dDb250ZXh0UmVmKWNvbnRleHQgb3B0aW9uczoo
TlNEaWN0aW9uYXJ5ICopb3B0aW9uczsKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3Nl
dFVzZXNNZXRyaWNzQXBwZWFyYW5jZTopIEJPT0wgX3VzZXNNZXRyaWNzQXBwZWFyYW5jZTsKIAog
QGVuZAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNJbWFn
ZVNQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TSW1hZ2VTUEkuaAppbmRl
eCA1NDdjMTNiZWQyOTJhODQ4NjFiZGQzZTRmM2EwNjNjZDE0YTc0Mzc1Li4xOTEwNWY1YTJhY2Vh
ZWEzZTJmZTZmZTQ1OWZlNTVkMmYwMGNiNWUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Q
QUwvcGFsL3NwaS9tYWMvTlNJbWFnZVNQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwv
c3BpL21hYy9OU0ltYWdlU1BJLmgKQEAgLTM1LDYgKzM1LDcgQEAKIAogQGludGVyZmFjZSBOU0lt
YWdlICgpCiAtICh2b2lkKWxvY2tGb2N1c1dpdGhSZWN0OihOU1JlY3QpcmVjdCBjb250ZXh0OihO
U0dyYXBoaWNzQ29udGV4dCAqKWNvbnRleHQgaGludHM6KE5TRGljdGlvbmFyeSAqKWhpbnRzIGZs
aXBwZWQ6KEJPT0wpZmxpcHBlZDsKKysgKGluc3RhbmNldHlwZSlfaW1hZ2VXaXRoU3lzdGVtU3lt
Ym9sTmFtZTooTlNTdHJpbmcgKilzeXN0ZW1TeW1ib2xOYW1lOwogQGVuZAogCiAjZW5kaWYK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>404356</attachid>
            <date>2020-07-15 10:36:12 -0700</date>
            <delta_ts>2020-07-15 11:30:03 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214338-20200715103612.patch</filename>
            <type>text/plain</type>
            <size>3066</size>
            <attacher name="Saagar Jha">saagar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM0ZTg2Y2M2ZGMyM2UxNjQ0M2U3ZjM1
OTlkZDIzOWE5NWFlYWM1NjMuLjQ5MzVjMWNjNzZkZmE2NTdiYzA5Y2I4ODRlMmYxMzFmN2RkYzNi
MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDctMTUgIFNhYWdhciBKaGEgIDxzYWFnYXJA
c2FhZ2FyamhhLmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGJvaWxlcnBsYXRlIHRv
IGhlbHAgZml4IGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtSGF2ZS5oOiBBZGQgSEFWRV9M
QVJHRV9DT05UUk9MX1NJWkUgYW5kIGVuYWJsZSBpdCBvbiBCaWcgU3VyLgorCiAyMDIwLTA3LTE1
ICBKaW0gTWFzb24gIDxqbWFzb25AaWJpbnguY29tPgogCiAgICAgICAgIFtXVEZdIEZpeCBQYWNr
ZWRBbGlnbmVkUHRyIGZvciBYODZfNjQgY2Fub25pY2FsIGFkZHJlc3NlcwpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VM
b2cKaW5kZXggNThjZDUwYjc1NTFjMzk2NWVlNWI3Mjc0OWI0YTJiODJhMTVlN2VjOS4uYmEyMWMw
ZmYxNmVmMDM2N2NjMWYxM2EwYzM0OTg0MTI0NzY0OWMyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvUEFML0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMjAtMDctMTUgIFNhYWdhciBKaGEgIDxzYWFnYXJAc2FhZ2Fyamhh
LmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGJvaWxlcnBsYXRlIHRvIGhlbHAgZml4
IGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIxNDMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgICogcGFsL3NwaS9tYWMvTlNBcHBlYXJhbmNlU1BJLmg6IEFkZCAtW05T
QXBwZWFyYW5jZSBfdXNlc01ldHJpY3NBcHBlYXJhbmNlXSB0byB0aGUgU1BJIGhlYWRlci4KKyAg
ICAgICAgKiBwYWwvc3BpL21hYy9OU0ltYWdlU1BJLmg6IEFkZCArW05TSW1hZ2UgX2ltYWdlV2l0
aFN5c3RlbVN5bWJvbE5hbWU6XSB0byB0aGUgU1BJIGhlYWRlci4KKwogMjAyMC0wNy0xNSAgQnJh
ZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVzb2x2ZSByYWNlIGJl
dHdlZW4gSU9ISURNYW5hZ2VyIGFuZCBHYW1lQ29udHJvbGxlciBmcmFtZXdvcmsuCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRm
b3JtSGF2ZS5oCmluZGV4IDIwYTBhODhhZjJiZDkxZDUwN2UwNDVjY2JlNWE3MDlkMjVlZGRjMmEu
LjNhYzNkNzI0YjY2Y2U1N2IxNTJmZjNlZGEwMGRiNTk4NTE3MTlkYWQgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3Jt
SGF2ZS5oCkBAIC01OTQsNiArNTk0LDEwIEBACiAjZGVmaW5lIEhBVkVfQUxURVJOQVRFX0lDT05T
IDEKICNlbmRpZgogCisjaWYgKFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01J
Tl9SRVFVSVJFRCA+PSAxMDE2MDApCisjZGVmaW5lIEhBVkVfTEFSR0VfQ09OVFJPTF9TSVpFIDEK
KyNlbmRpZgorCiAjaWYgKFBMQVRGT1JNKElPUykgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5f
UkVRVUlSRUQgPj0gMTQwMDAwKQogI2RlZmluZSBIQVZFX1VJQ09OVEVYVE1FTlVfTE9DQVRJT04g
MQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNB
cHBlYXJhbmNlU1BJLmggYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNBcHBlYXJh
bmNlU1BJLmgKaW5kZXggN2RiNjk3MDAwNzE3NjMxMzk5MTdlMDA5YTI5N2IxZDJlYWViMzVhOS4u
NzMxNTRkMzQ2ZmIxOGFkYjRjMTQyYzU1MjRiM2Q1ZTUxM2JkZmRjYiAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TQXBwZWFyYW5jZVNQSS5oCisrKyBiL1NvdXJj
ZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0FwcGVhcmFuY2VTUEkuaApAQCAtMzQsNiArMzQs
NyBAQAogQGludGVyZmFjZSBOU0FwcGVhcmFuY2UgKCkKIAogLSAodm9pZClfZHJhd0luUmVjdDoo
TlNSZWN0KXJlY3QgY29udGV4dDooQ0dDb250ZXh0UmVmKWNvbnRleHQgb3B0aW9uczooTlNEaWN0
aW9uYXJ5ICopb3B0aW9uczsKKy0gKEJPT0wpX3VzZXNNZXRyaWNzQXBwZWFyYW5jZTsKIAogQGVu
ZAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNJbWFnZVNQ
SS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TSW1hZ2VTUEkuaAppbmRleCA1
NDdjMTNiZWQyOTJhODQ4NjFiZGQzZTRmM2EwNjNjZDE0YTc0Mzc1Li44MTM5NDFkNGI5OThmMmQ2
ZTkwYjc0NDM5MzkwYjYyNjhkZjg0NDE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwv
cGFsL3NwaS9tYWMvTlNJbWFnZVNQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3Bp
L21hYy9OU0ltYWdlU1BJLmgKQEAgLTM1LDYgKzM1LDcgQEAKIAogQGludGVyZmFjZSBOU0ltYWdl
ICgpCiAtICh2b2lkKWxvY2tGb2N1c1dpdGhSZWN0OihOU1JlY3QpcmVjdCBjb250ZXh0OihOU0dy
YXBoaWNzQ29udGV4dCAqKWNvbnRleHQgaGludHM6KE5TRGljdGlvbmFyeSAqKWhpbnRzIGZsaXBw
ZWQ6KEJPT0wpZmxpcHBlZDsKKysgKG51bGxhYmxlIE5TSW1hZ2UgKilfaW1hZ2VXaXRoU3lzdGVt
U3ltYm9sTmFtZTooTlNTdHJpbmcgKiluYW1lOwogQGVuZAogCiAjZW5kaWYK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>404363</attachid>
            <date>2020-07-15 11:30:05 -0700</date>
            <delta_ts>2020-07-15 12:13:10 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214338-20200715113004.patch</filename>
            <type>text/plain</type>
            <size>3195</size>
            <attacher name="Saagar Jha">saagar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM0ZTg2Y2M2ZGMyM2UxNjQ0M2U3ZjM1
OTlkZDIzOWE5NWFlYWM1NjMuLjQ5MzVjMWNjNzZkZmE2NTdiYzA5Y2I4ODRlMmYxMzFmN2RkYzNi
MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDctMTUgIFNhYWdhciBKaGEgIDxzYWFnYXJA
c2FhZ2FyamhhLmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGJvaWxlcnBsYXRlIHRv
IGhlbHAgZml4IGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtSGF2ZS5oOiBBZGQgSEFWRV9M
QVJHRV9DT05UUk9MX1NJWkUgYW5kIGVuYWJsZSBpdCBvbiBCaWcgU3VyLgorCiAyMDIwLTA3LTE1
ICBKaW0gTWFzb24gIDxqbWFzb25AaWJpbnguY29tPgogCiAgICAgICAgIFtXVEZdIEZpeCBQYWNr
ZWRBbGlnbmVkUHRyIGZvciBYODZfNjQgY2Fub25pY2FsIGFkZHJlc3NlcwpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VM
b2cKaW5kZXggMTQwN2Q2YjkyMGI1ZDQ5MmJlZDFmYjk1ODBmODAyMGYyMTc5MWY1ZC4uMjc2M2E4
OGEyOGZiZTM3M2NhZmNmZmUzMTI1ZWM0MWM3ZjRkYjJkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvUEFML0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMjAtMDctMTUgIFNhYWdhciBKaGEgIDxzYWFnYXJAc2FhZ2Fyamhh
LmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGJvaWxlcnBsYXRlIHRvIGhlbHAgZml4
IGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIxNDMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgICogcGFsL3NwaS9tYWMvTlNBcHBlYXJhbmNlU1BJLmg6IEFkZCAtW05T
QXBwZWFyYW5jZSBfdXNlc01ldHJpY3NBcHBlYXJhbmNlXSB0byB0aGUgU1BJIGhlYWRlci4KKyAg
ICAgICAgKiBwYWwvc3BpL21hYy9OU0ltYWdlU1BJLmg6IEFkZCArW05TSW1hZ2UgX2ltYWdlV2l0
aFN5c3RlbVN5bWJvbE5hbWU6XSB0byB0aGUgU1BJIGhlYWRlci4KKwogMjAyMC0wNy0xNSAgQnJh
ZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHNvbWUgYnVpbGQg
Y29uZmlndXJhdGlvbnMgYWZ0ZXIgcjI2NDM4OQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv
UGxhdGZvcm1IYXZlLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaAppbmRleCAyMGEw
YTg4YWYyYmQ5MWQ1MDdlMDQ1Y2NiZTVhNzA5ZDI1ZWRkYzJhLi4zYWMzZDcyNGI2NmNlNTdiMTUy
ZmYzZWRhMDBkYjU5ODUxNzE5ZGFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y
bUhhdmUuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaApAQCAtNTk0LDYgKzU5
NCwxMCBAQAogI2RlZmluZSBIQVZFX0FMVEVSTkFURV9JQ09OUyAxCiAjZW5kaWYKIAorI2lmIChQ
TEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxNjAw
KQorI2RlZmluZSBIQVZFX0xBUkdFX0NPTlRST0xfU0laRSAxCisjZW5kaWYKKwogI2lmIChQTEFU
Rk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDE0MDAwMCkK
ICNkZWZpbmUgSEFWRV9VSUNPTlRFWFRNRU5VX0xPQ0FUSU9OIDEKICNlbmRpZgpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TQXBwZWFyYW5jZVNQSS5oIGIvU291
cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TQXBwZWFyYW5jZVNQSS5oCmluZGV4IDdkYjY5
NzAwMDcxNzYzMTM5OTE3ZTAwOWEyOTdiMWQyZWFlYjM1YTkuLjg4N2ViYWQ4OTZhNjc3M2FhNjgw
NTYwMGVlZGQ3MWJmNzhjNjU1ZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwv
c3BpL21hYy9OU0FwcGVhcmFuY2VTUEkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3Nw
aS9tYWMvTlNBcHBlYXJhbmNlU1BJLmgKQEAgLTI5LDEyICsyOSwxNCBAQAogCiAjaWYgVVNFKEFQ
UExFX0lOVEVSTkFMX1NESykKICNpbXBvcnQgPEFwcEtpdC9OU0FwcGVhcmFuY2VfUHJpdmF0ZS5o
PgotI2VuZGlmCisjZWxzZQogCiBAaW50ZXJmYWNlIE5TQXBwZWFyYW5jZSAoKQogCiAtICh2b2lk
KV9kcmF3SW5SZWN0OihOU1JlY3QpcmVjdCBjb250ZXh0OihDR0NvbnRleHRSZWYpY29udGV4dCBv
cHRpb25zOihOU0RpY3Rpb25hcnkgKilvcHRpb25zOworLSAoQk9PTClfdXNlc01ldHJpY3NBcHBl
YXJhbmNlOwogCiBAZW5kCisjZW5kaWYgLy8gVVNFKEFQUExFX0lOVEVSTkFMX1NESykKIAogI2Vu
ZGlmIC8vIFVTRShBUFBLSVQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3Nw
aS9tYWMvTlNJbWFnZVNQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TSW1h
Z2VTUEkuaAppbmRleCA1NDdjMTNiZWQyOTJhODQ4NjFiZGQzZTRmM2EwNjNjZDE0YTc0Mzc1Li44
MTM5NDFkNGI5OThmMmQ2ZTkwYjc0NDM5MzkwYjYyNjhkZjg0NDE4IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNJbWFnZVNQSS5oCisrKyBiL1NvdXJjZS9XZWJD
b3JlL1BBTC9wYWwvc3BpL21hYy9OU0ltYWdlU1BJLmgKQEAgLTM1LDYgKzM1LDcgQEAKIAogQGlu
dGVyZmFjZSBOU0ltYWdlICgpCiAtICh2b2lkKWxvY2tGb2N1c1dpdGhSZWN0OihOU1JlY3QpcmVj
dCBjb250ZXh0OihOU0dyYXBoaWNzQ29udGV4dCAqKWNvbnRleHQgaGludHM6KE5TRGljdGlvbmFy
eSAqKWhpbnRzIGZsaXBwZWQ6KEJPT0wpZmxpcHBlZDsKKysgKG51bGxhYmxlIE5TSW1hZ2UgKilf
aW1hZ2VXaXRoU3lzdGVtU3ltYm9sTmFtZTooTlNTdHJpbmcgKiluYW1lOwogQGVuZAogCiAjZW5k
aWYK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>404372</attachid>
            <date>2020-07-15 12:13:12 -0700</date>
            <delta_ts>2020-07-15 12:24:06 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214338-20200715121311.patch</filename>
            <type>text/plain</type>
            <size>3210</size>
            <attacher name="Saagar Jha">saagar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM0ZTg2Y2M2ZGMyM2UxNjQ0M2U3ZjM1
OTlkZDIzOWE5NWFlYWM1NjMuLjQ5MzVjMWNjNzZkZmE2NTdiYzA5Y2I4ODRlMmYxMzFmN2RkYzNi
MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDctMTUgIFNhYWdhciBKaGEgIDxzYWFnYXJA
c2FhZ2FyamhhLmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGJvaWxlcnBsYXRlIHRv
IGhlbHAgZml4IGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtSGF2ZS5oOiBBZGQgSEFWRV9M
QVJHRV9DT05UUk9MX1NJWkUgYW5kIGVuYWJsZSBpdCBvbiBCaWcgU3VyLgorCiAyMDIwLTA3LTE1
ICBKaW0gTWFzb24gIDxqbWFzb25AaWJpbnguY29tPgogCiAgICAgICAgIFtXVEZdIEZpeCBQYWNr
ZWRBbGlnbmVkUHRyIGZvciBYODZfNjQgY2Fub25pY2FsIGFkZHJlc3NlcwpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VM
b2cKaW5kZXggZTY4OTE2ZTRkMjg2N2U4M2Y2YWYxNzM1MTAzNmYyZjczOGVlNTc0MC4uNjBlMzc4
NjZlOWRkNjJiMzg5ZDdkZDA3ZDY1ZjhhMWRmMTcwNTJmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvUEFML0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMjAtMDctMTUgIFNhYWdhciBKaGEgIDxzYWFnYXJAc2FhZ2Fyamhh
LmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGJvaWxlcnBsYXRlIHRvIGhlbHAgZml4
IGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIxNDMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgICogcGFsL3NwaS9tYWMvTlNBcHBlYXJhbmNlU1BJLmg6IEFkZCAtW05T
QXBwZWFyYW5jZSBfdXNlc01ldHJpY3NBcHBlYXJhbmNlXSB0byB0aGUgU1BJIGhlYWRlci4KKyAg
ICAgICAgKiBwYWwvc3BpL21hYy9OU0ltYWdlU1BJLmg6IEFkZCArW05TSW1hZ2UgX2ltYWdlV2l0
aFN5c3RlbVN5bWJvbE5hbWU6XSB0byB0aGUgU1BJIGhlYWRlci4KKwogMjAyMC0wNy0xNSAgUm9i
IEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEJ1aWxkaW5nIEFjY2Vzc2liaWxp
dHlTdXBwb3J0U1BJIHdpdGggdGhlIG1hY09TIEJpZyBTdXIgcHVibGljIFNESyBmYWlscwpkaWZm
IC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmggYi9Tb3VyY2UvV1RGL3d0Zi9Q
bGF0Zm9ybUhhdmUuaAppbmRleCAyMGEwYTg4YWYyYmQ5MWQ1MDdlMDQ1Y2NiZTVhNzA5ZDI1ZWRk
YzJhLi4zYWMzZDcyNGI2NmNlNTdiMTUyZmYzZWRhMDBkYjU5ODUxNzE5ZGFkIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0
Zm9ybUhhdmUuaApAQCAtNTk0LDYgKzU5NCwxMCBAQAogI2RlZmluZSBIQVZFX0FMVEVSTkFURV9J
Q09OUyAxCiAjZW5kaWYKIAorI2lmIChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lP
Tl9NSU5fUkVRVUlSRUQgPj0gMTAxNjAwKQorI2RlZmluZSBIQVZFX0xBUkdFX0NPTlRST0xfU0la
RSAxCisjZW5kaWYKKwogI2lmIChQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZFUlNJT05f
TUlOX1JFUVVJUkVEID49IDE0MDAwMCkKICNkZWZpbmUgSEFWRV9VSUNPTlRFWFRNRU5VX0xPQ0FU
SU9OIDEKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFj
L05TQXBwZWFyYW5jZVNQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TQXBw
ZWFyYW5jZVNQSS5oCmluZGV4IDdkYjY5NzAwMDcxNzYzMTM5OTE3ZTAwOWEyOTdiMWQyZWFlYjM1
YTkuLjg4N2ViYWQ4OTZhNjc3M2FhNjgwNTYwMGVlZGQ3MWJmNzhjNjU1ZDggMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0FwcGVhcmFuY2VTUEkuaAorKysgYi9T
b3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNBcHBlYXJhbmNlU1BJLmgKQEAgLTI5LDEy
ICsyOSwxNCBAQAogCiAjaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKICNpbXBvcnQgPEFwcEtp
dC9OU0FwcGVhcmFuY2VfUHJpdmF0ZS5oPgotI2VuZGlmCisjZWxzZQogCiBAaW50ZXJmYWNlIE5T
QXBwZWFyYW5jZSAoKQogCiAtICh2b2lkKV9kcmF3SW5SZWN0OihOU1JlY3QpcmVjdCBjb250ZXh0
OihDR0NvbnRleHRSZWYpY29udGV4dCBvcHRpb25zOihOU0RpY3Rpb25hcnkgKilvcHRpb25zOwor
LSAoQk9PTClfdXNlc01ldHJpY3NBcHBlYXJhbmNlOwogCiBAZW5kCisjZW5kaWYgLy8gVVNFKEFQ
UExFX0lOVEVSTkFMX1NESykKIAogI2VuZGlmIC8vIFVTRShBUFBLSVQpCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNJbWFnZVNQSS5oIGIvU291cmNlL1dlYkNv
cmUvUEFML3BhbC9zcGkvbWFjL05TSW1hZ2VTUEkuaAppbmRleCA1NDdjMTNiZWQyOTJhODQ4NjFi
ZGQzZTRmM2EwNjNjZDE0YTc0Mzc1Li43Y2Y4ZDIzNGNmNmEzOWI4NzA4YmY1YzQwNTQ5YjdhNTAy
OGQ3MGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNJbWFn
ZVNQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0ltYWdlU1BJLmgK
QEAgLTM1LDYgKzM1LDcgQEAKIAogQGludGVyZmFjZSBOU0ltYWdlICgpCiAtICh2b2lkKWxvY2tG
b2N1c1dpdGhSZWN0OihOU1JlY3QpcmVjdCBjb250ZXh0OihOU0dyYXBoaWNzQ29udGV4dCAqKWNv
bnRleHQgaGludHM6KE5TRGljdGlvbmFyeSAqKWhpbnRzIGZsaXBwZWQ6KEJPT0wpZmxpcHBlZDsK
KysgKE5TSW1hZ2UgKilfaW1hZ2VXaXRoU3lzdGVtU3ltYm9sTmFtZTooTlNTdHJpbmcgKiluYW1l
OwogQGVuZAogCiAjZW5kaWYK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>404374</attachid>
            <date>2020-07-15 12:24:08 -0700</date>
            <delta_ts>2020-07-15 15:15:01 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-214338-20200715122408.patch</filename>
            <type>text/plain</type>
            <size>3099</size>
            <attacher name="Saagar Jha">saagar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM0ZTg2Y2M2ZGMyM2UxNjQ0M2U3ZjM1
OTlkZDIzOWE5NWFlYWM1NjMuLjQ5MzVjMWNjNzZkZmE2NTdiYzA5Y2I4ODRlMmYxMzFmN2RkYzNi
MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDctMTUgIFNhYWdhciBKaGEgIDxzYWFnYXJA
c2FhZ2FyamhhLmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGJvaWxlcnBsYXRlIHRv
IGhlbHAgZml4IGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtSGF2ZS5oOiBBZGQgSEFWRV9M
QVJHRV9DT05UUk9MX1NJWkUgYW5kIGVuYWJsZSBpdCBvbiBCaWcgU3VyLgorCiAyMDIwLTA3LTE1
ICBKaW0gTWFzb24gIDxqbWFzb25AaWJpbnguY29tPgogCiAgICAgICAgIFtXVEZdIEZpeCBQYWNr
ZWRBbGlnbmVkUHRyIGZvciBYODZfNjQgY2Fub25pY2FsIGFkZHJlc3NlcwpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VM
b2cKaW5kZXggZTY4OTE2ZTRkMjg2N2U4M2Y2YWYxNzM1MTAzNmYyZjczOGVlNTc0MC4uNjBlMzc4
NjZlOWRkNjJiMzg5ZDdkZDA3ZDY1ZjhhMWRmMTcwNTJmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvUEFML0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMjAtMDctMTUgIFNhYWdhciBKaGEgIDxzYWFnYXJAc2FhZ2Fyamhh
LmNvbT4KKworICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGJvaWxlcnBsYXRlIHRvIGhlbHAgZml4
IGJ1aWxkIG9uIG1hY09TIEJpZyBTdXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTIxNDMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgICogcGFsL3NwaS9tYWMvTlNBcHBlYXJhbmNlU1BJLmg6IEFkZCAtW05T
QXBwZWFyYW5jZSBfdXNlc01ldHJpY3NBcHBlYXJhbmNlXSB0byB0aGUgU1BJIGhlYWRlci4KKyAg
ICAgICAgKiBwYWwvc3BpL21hYy9OU0ltYWdlU1BJLmg6IEFkZCArW05TSW1hZ2UgX2ltYWdlV2l0
aFN5c3RlbVN5bWJvbE5hbWU6XSB0byB0aGUgU1BJIGhlYWRlci4KKwogMjAyMC0wNy0xNSAgUm9i
IEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEJ1aWxkaW5nIEFjY2Vzc2liaWxp
dHlTdXBwb3J0U1BJIHdpdGggdGhlIG1hY09TIEJpZyBTdXIgcHVibGljIFNESyBmYWlscwpkaWZm
IC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmggYi9Tb3VyY2UvV1RGL3d0Zi9Q
bGF0Zm9ybUhhdmUuaAppbmRleCAyMGEwYTg4YWYyYmQ5MWQ1MDdlMDQ1Y2NiZTVhNzA5ZDI1ZWRk
YzJhLi4zYWMzZDcyNGI2NmNlNTdiMTUyZmYzZWRhMDBkYjU5ODUxNzE5ZGFkIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUhhdmUuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0
Zm9ybUhhdmUuaApAQCAtNTk0LDYgKzU5NCwxMCBAQAogI2RlZmluZSBIQVZFX0FMVEVSTkFURV9J
Q09OUyAxCiAjZW5kaWYKIAorI2lmIChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lP
Tl9NSU5fUkVRVUlSRUQgPj0gMTAxNjAwKQorI2RlZmluZSBIQVZFX0xBUkdFX0NPTlRST0xfU0la
RSAxCisjZW5kaWYKKwogI2lmIChQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZFUlNJT05f
TUlOX1JFUVVJUkVEID49IDE0MDAwMCkKICNkZWZpbmUgSEFWRV9VSUNPTlRFWFRNRU5VX0xPQ0FU
SU9OIDEKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFj
L05TQXBwZWFyYW5jZVNQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvbWFjL05TQXBw
ZWFyYW5jZVNQSS5oCmluZGV4IDdkYjY5NzAwMDcxNzYzMTM5OTE3ZTAwOWEyOTdiMWQyZWFlYjM1
YTkuLmRlZmFkNDNkODViYjE2ZjQ4ZmM3MjI3ODVlNWY0NGI5NTllYzNiZjkgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0FwcGVhcmFuY2VTUEkuaAorKysgYi9T
b3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNBcHBlYXJhbmNlU1BJLmgKQEAgLTM0LDYg
KzM0LDkgQEAKIEBpbnRlcmZhY2UgTlNBcHBlYXJhbmNlICgpCiAKIC0gKHZvaWQpX2RyYXdJblJl
Y3Q6KE5TUmVjdClyZWN0IGNvbnRleHQ6KENHQ29udGV4dFJlZiljb250ZXh0IG9wdGlvbnM6KE5T
RGljdGlvbmFyeSAqKW9wdGlvbnM7CisjaWYgIVVTRShBUFBMRV9JTlRFUk5BTF9TREspCistIChC
T09MKV91c2VzTWV0cmljc0FwcGVhcmFuY2U7CisjZW5kaWYKIAogQGVuZAogCmRpZmYgLS1naXQg
YS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNJbWFnZVNQSS5oIGIvU291cmNlL1dl
YkNvcmUvUEFML3BhbC9zcGkvbWFjL05TSW1hZ2VTUEkuaAppbmRleCA1NDdjMTNiZWQyOTJhODQ4
NjFiZGQzZTRmM2EwNjNjZDE0YTc0Mzc1Li43Y2Y4ZDIzNGNmNmEzOWI4NzA4YmY1YzQwNTQ5Yjdh
NTAyOGQ3MGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNJ
bWFnZVNQSS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0ltYWdlU1BJ
LmgKQEAgLTM1LDYgKzM1LDcgQEAKIAogQGludGVyZmFjZSBOU0ltYWdlICgpCiAtICh2b2lkKWxv
Y2tGb2N1c1dpdGhSZWN0OihOU1JlY3QpcmVjdCBjb250ZXh0OihOU0dyYXBoaWNzQ29udGV4dCAq
KWNvbnRleHQgaGludHM6KE5TRGljdGlvbmFyeSAqKWhpbnRzIGZsaXBwZWQ6KEJPT0wpZmxpcHBl
ZDsKKysgKE5TSW1hZ2UgKilfaW1hZ2VXaXRoU3lzdGVtU3ltYm9sTmFtZTooTlNTdHJpbmcgKilu
YW1lOwogQGVuZAogCiAjZW5kaWYK
</data>

          </attachment>
      

    </bug>

</bugzilla>