214329 2020-07-14 16:08:15 -0700 REGRESSION (r264101): Sharing a link attaches an image instead of the URL 2020-07-14 17:20:26 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh bdakin dino graouts hi megan_gardner thorton webkit-bug-importer oldest_to_newest 1671572 0 wenson_hsieh 2020-07-14 16:08:15 -0700 <rdar://problem/65513607> 1671579 1 404301 wenson_hsieh 2020-07-14 16:23:53 -0700 Created attachment 404301 Patch 1671585 2 thorton 2020-07-14 16:35:17 -0700 Might be even better to use some WTF thing, but this is fine as a quick fix 1671588 3 wenson_hsieh 2020-07-14 16:37:59 -0700 (In reply to Tim Horton from comment #2) > Might be even better to use some WTF thing, but this is fine as a quick fix That’s true! I could make this something like URL(element.imageURL).protocolIs(“data"); 1671591 4 wenson_hsieh 2020-07-14 16:38:39 -0700 (In reply to Tim Horton from comment #2) > Might be even better to use some WTF thing, but this is fine as a quick fix That’s true! I could make this something like URL(element.imageURL).protocolIsData(); 1671592 5 404301 hi 2020-07-14 16:39:56 -0700 Comment on attachment 404301 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404301&action=review r=me > Source/WebKit/ChangeLog:10 > + r264101 added logic that attempts to share an activated (i.e. long-pressed) element as an image, if the image > + URL for the element is equal to "data" (ignoring case sensitivity). However, in the case where the image URL is NIT: it's really comparing the URL's scheme, not the entire URL itself > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:831 > - if ([element.imageURL.scheme caseInsensitiveCompare:@"data"] == NSOrderedSame && element.image && [delegate respondsToSelector:@selector(actionSheetAssistant:shareElementWithImage:rect:)]) > + if ([@"data" caseInsensitiveCompare:element.imageURL.scheme] == NSOrderedSame && element.image && [delegate respondsToSelector:@selector(actionSheetAssistant:shareElementWithImage:rect:)]) Is it worth explicitly checking that `element.imageURL` is truthy so that it's explicit/obvious that this codepath expects it to be non-`nil` (i.e. have `element.image && element.imageURL` at the beginning)? > Tools/TestWebKitAPI/Tests/ios/ShareSheetTests.mm:114 > + EXPECT_WK_STREQ("https://www.apple.com/", [[activityItems objectAtIndex:0] absoluteString]); So how would this fail if the above code changed in the future? Would `absoluteString` be `nil` (and some other "form" would be set instead) or would it be the dataURL? 1671596 6 wenson_hsieh 2020-07-14 16:44:21 -0700 Thanks for the reviews! (In reply to Devin Rousso from comment #5) > Comment on attachment 404301 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404301&action=review > > r=me > > > Source/WebKit/ChangeLog:10 > > + r264101 added logic that attempts to share an activated (i.e. long-pressed) element as an image, if the image > > + URL for the element is equal to "data" (ignoring case sensitivity). However, in the case where the image URL is > > NIT: it's really comparing the URL's scheme, not the entire URL itself Yep, I missed a word here ("scheme"). > > > Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:831 > > - if ([element.imageURL.scheme caseInsensitiveCompare:@"data"] == NSOrderedSame && element.image && [delegate respondsToSelector:@selector(actionSheetAssistant:shareElementWithImage:rect:)]) > > + if ([@"data" caseInsensitiveCompare:element.imageURL.scheme] == NSOrderedSame && element.image && [delegate respondsToSelector:@selector(actionSheetAssistant:shareElementWithImage:rect:)]) > > Is it worth explicitly checking that `element.imageURL` is truthy so that > it's explicit/obvious that this codepath expects it to be non-`nil` (i.e. > have `element.image && element.imageURL` at the beginning)? I don’t think there’s much benefit to doing so, but I’m changing this to URL(element.imageURL).protocolIsData() anyways. > > > Tools/TestWebKitAPI/Tests/ios/ShareSheetTests.mm:114 > > + EXPECT_WK_STREQ("https://www.apple.com/", [[activityItems objectAtIndex:0] absoluteString]); > > So how would this fail if the above code changed in the future? Would > `absoluteString` be `nil` (and some other "form" would be set instead) or > would it be the dataURL? Depending on the nature of the failure, any of the above! 1671602 7 404308 wenson_hsieh 2020-07-14 16:55:25 -0700 Created attachment 404308 Patch for landing 1671613 8 ews-feeder 2020-07-14 17:20:25 -0700 Committed r264383: <https://trac.webkit.org/changeset/264383> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404308. 404301 2020-07-14 16:23:53 -0700 2020-07-14 16:34:59 -0700 Patch bug-214329-20200714162352.patch text/plain 4838 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0Mzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFhZWVmMjk4NTBhYmJiNzA0 NWI5YTMxZjc2ZmQ2OTE4NTNmMWNjODMuLjQxNTg2YzljNWUzNGQyODA5YTFjYWFhODRlMTdmY2Yw MmRlOGZmMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDctMTQgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI2 NDEwMSk6IFNoYXJpbmcgYSBsaW5rIGF0dGFjaGVzIGFuIGltYWdlIGluc3RlYWQgb2YgdGhlIFVS TAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0MzI5 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NTUxMzYwNz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjY0MTAxIGFkZGVkIGxvZ2ljIHRoYXQgYXR0 ZW1wdHMgdG8gc2hhcmUgYW4gYWN0aXZhdGVkIChpLmUuIGxvbmctcHJlc3NlZCkgZWxlbWVudCBh cyBhbiBpbWFnZSwgaWYgdGhlIGltYWdlCisgICAgICAgIFVSTCBmb3IgdGhlIGVsZW1lbnQgaXMg ZXF1YWwgdG8gImRhdGEiIChpZ25vcmluZyBjYXNlIHNlbnNpdGl2aXR5KS4gSG93ZXZlciwgaW4g dGhlIGNhc2Ugd2hlcmUgdGhlIGltYWdlIFVSTCBpcworICAgICAgICBuaWwsIHRoZSBjYWxsIHRv IGBbZWxlbWVudC5pbWFnZVVSTC5zY2hlbWUgY2FzZUluc2Vuc2l0aXZlQ29tcGFyZTpAImRhdGEi XWAgaXMgMCwgd2hpY2ggKGNvbnZlbmllbnRseSkgaXMgZXF1YWwKKyAgICAgICAgdG8gYE5TT3Jk ZXJlZFNhbWVgLiBUaGlzIGNhdXNlcyB1cyB0byBpbmNvcnJlY3RseSBwcm9jZWVkIGJ5IHNoYXJp bmcgdGhlIGVsZW1lbnQgYXMgYW4gaW1hZ2UuCisKKyAgICAgICAgRml4IHRoaXMgYnkgc2ltcGx5 IHNlbmRpbmcgdGhlIHNlbGVjdG9yIHRvIEAiZGF0YSIsIHNvIHdlIGRvbid0IGVuZCB1cCB3aXRo IDAgKGBOU09yZGVyZWRTYW1lYCkgd2hlbgorICAgICAgICBgZWxlbWVudC5pbWFnZVVSTC5zY2hl bWVgIGlzIGBuaWxgLgorCisgICAgICAgIFRlc3Q6IFNoYXJlU2hlZXRUZXN0cy5TaGFyZUFuY2hv ckVsZW1lbnRBc1VSTAorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNz aXN0YW50Lm1tOgorICAgICAgICAoLVtXS0FjdGlvblNoZWV0QXNzaXN0YW50IGhhbmRsZUVsZW1l bnRBY3Rpb25XaXRoVHlwZTplbGVtZW50Om5lZWRzSW50ZXJhY3Rpb246XSk6CisKIDIwMjAtMDct MTQgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lP U10gVGhlIGNvbXBsZXRpb24gaGFuZGxlciBpbiAtaGFuZGxlS2V5V2ViRXZlbnQ6d2l0aENvbXBs ZXRpb25IYW5kbGVyOiBpcyBzb21ldGltZXMgbmV2ZXIgY2FsbGVkCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5tbSBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCmluZGV4IDQw MjExMWJhMjI3NDAyYmI4MmUwM2U0MGNlNGE2MjM3NGIwMzk5YzguLmYyYzE0OTEwOTA3NWZhZThl NDJmYzJmMWYyM2Q0NWRiYzJiYjE2YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCkBAIC04MjgsNyArODI4LDcgQEAg LSAodm9pZCloYW5kbGVFbGVtZW50QWN0aW9uV2l0aFR5cGU6KF9XS0VsZW1lbnRBY3Rpb25UeXBl KXR5cGUgZWxlbWVudDooX1dLQWN0aXYKICAgICAgICAgW2RlbGVnYXRlIGFjdGlvblNoZWV0QXNz aXN0YW50OnNlbGYgcGVyZm9ybUFjdGlvbjpXZWJLaXQ6OlNoZWV0QWN0aW9uOjpTYXZlSW1hZ2Vd OwogICAgICAgICBicmVhazsKICAgICBjYXNlIF9XS0VsZW1lbnRBY3Rpb25UeXBlU2hhcmU6Ci0g ICAgICAgIGlmIChbZWxlbWVudC5pbWFnZVVSTC5zY2hlbWUgY2FzZUluc2Vuc2l0aXZlQ29tcGFy ZTpAImRhdGEiXSA9PSBOU09yZGVyZWRTYW1lICYmIGVsZW1lbnQuaW1hZ2UgJiYgW2RlbGVnYXRl IHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoYWN0aW9uU2hlZXRBc3Npc3RhbnQ6c2hhcmVF bGVtZW50V2l0aEltYWdlOnJlY3Q6KV0pCisgICAgICAgIGlmIChbQCJkYXRhIiBjYXNlSW5zZW5z aXRpdmVDb21wYXJlOmVsZW1lbnQuaW1hZ2VVUkwuc2NoZW1lXSA9PSBOU09yZGVyZWRTYW1lICYm IGVsZW1lbnQuaW1hZ2UgJiYgW2RlbGVnYXRlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3Io YWN0aW9uU2hlZXRBc3Npc3RhbnQ6c2hhcmVFbGVtZW50V2l0aEltYWdlOnJlY3Q6KV0pCiAgICAg ICAgICAgICBbZGVsZWdhdGUgYWN0aW9uU2hlZXRBc3Npc3RhbnQ6c2VsZiBzaGFyZUVsZW1lbnRX aXRoSW1hZ2U6ZWxlbWVudC5pbWFnZSByZWN0OmVsZW1lbnQuYm91bmRpbmdSZWN0XTsKICAgICAg ICAgZWxzZQogICAgICAgICAgICAgW2RlbGVnYXRlIGFjdGlvblNoZWV0QXNzaXN0YW50OnNlbGYg c2hhcmVFbGVtZW50V2l0aFVSTDplbGVtZW50LlVSTCA/OiBlbGVtZW50LmltYWdlVVJMIHJlY3Q6 ZWxlbWVudC5ib3VuZGluZ1JlY3RdOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v bHMvQ2hhbmdlTG9nCmluZGV4IDQ3ODVhMjdmMDU1MTcwMDcxNmI5YTQ2OTI2ZDZhZjAxNTA0N2Rh ZDAuLjdmNzgwNjhlNzhjOGM5ZjQ2OWEzMWNmMzZiMTg0Yjg4MGNmZTE1NzggMTAwNjQ0Ci0tLSBh L1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAor MjAyMC0wNy0xNCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKworICAg ICAgICBSRUdSRVNTSU9OIChyMjY0MTAxKTogU2hhcmluZyBhIGxpbmsgYXR0YWNoZXMgYW4gaW1h Z2UgaW5zdGVhZCBvZiB0aGUgVVJMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTQzMjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY1NTEzNjA3Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG5l dyBBUEkgdGVzdCB0byB2ZXJpZnkgdGhhdCB0aGUgInNoYXJlIGFjdGlvbiIgZm9yIGEgbGluayBz aGFyZXMgdGhlIFVSTCwgcmF0aGVyIHRoYW4gYSBzbmFwc2hvdCBvZiB0aGUKKyAgICAgICAgYW5j aG9yIGVsZW1lbnQuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9TaGFyZVNo ZWV0VGVzdHMubW06CisKIDIwMjAtMDctMTQgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBh cHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVGhlIGNvbXBsZXRpb24gaGFuZGxlciBpbiAtaGFu ZGxlS2V5V2ViRXZlbnQ6d2l0aENvbXBsZXRpb25IYW5kbGVyOiBpcyBzb21ldGltZXMgbmV2ZXIg Y2FsbGVkCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9TaGFyZVNo ZWV0VGVzdHMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL2lvcy9TaGFyZVNoZWV0VGVz dHMubW0KaW5kZXggMDIwNzJlZTE3NjkzNzZmZDkyMzJhYTk0MzMzYWVkMzBmZmQzNzQ5Yy4uYTQz MzVhM2NhYzhkMjA3OTkwYThhNzI1MzY5NjJiZjE5ZDliZWMwNSAxMDA2NDQKLS0tIGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvU2hhcmVTaGVldFRlc3RzLm1tCisrKyBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvaW9zL1NoYXJlU2hlZXRUZXN0cy5tbQpAQCAtMTAxLDYgKzEwMSwy NCBAQCBURVNUKFNoYXJlU2hlZXRUZXN0cywgU2hhcmVJbWdFbGVtZW50V2l0aEJhc2U2NFVSTCkK ICAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRvbmUpOwogfQogCitURVNUKFNoYXJlU2hl ZXRUZXN0cywgU2hhcmVBbmNob3JFbGVtZW50QXNVUkwpCit7CisgICAgYXV0byB3ZWJWaWV3ID0g YWRvcHROUyhbW1Rlc3RXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0TWFrZSgw LCAwLCAzMjAsIDUwMCldKTsKKyAgICBhdXRvIG9ic2VydmVyID0gYWRvcHROUyhbW1NoYXJlU2hl ZXRPYnNlcnZlciBhbGxvY10gaW5pdF0pOworICAgIFt3ZWJWaWV3IHNldFVJRGVsZWdhdGU6b2Jz ZXJ2ZXIuZ2V0KCldOworICAgIFt3ZWJWaWV3IHN5bmNocm9ub3VzbHlMb2FkVGVzdFBhZ2VOYW1l ZDpAImxpbmstYW5kLWlucHV0Il07CisKKyAgICBfX2Jsb2NrIGJvb2wgZG9uZSA9IGZhbHNlOwor ICAgIFtvYnNlcnZlciBzZXRBY3Rpdml0eUl0ZW1zSGFuZGxlcjpeKE5TQXJyYXkgKmFjdGl2aXR5 SXRlbXMpIHsKKyAgICAgICAgRVhQRUNUX0VRKDFVTCwgYWN0aXZpdHlJdGVtcy5jb3VudCk7Cisg ICAgICAgIEVYUEVDVF9XS19TVFJFUSgiaHR0cHM6Ly93d3cuYXBwbGUuY29tLyIsIFtbYWN0aXZp dHlJdGVtcyBvYmplY3RBdEluZGV4OjBdIGFic29sdXRlU3RyaW5nXSk7CisgICAgICAgIGRvbmUg PSB0cnVlOworICAgIH1dOworCisgICAgc2hvd1NoYXJlU2hlZXQod2ViVmlldy5nZXQoKSwgb2Jz ZXJ2ZXIuZ2V0KCksIENHUG9pbnRNYWtlKDEwMCwgMTAwKSk7CisgICAgVGVzdFdlYktpdEFQSTo6 VXRpbDo6cnVuKCZkb25lKTsKK30KKwogI2VuZGlmIC8vICFQTEFURk9STShXQVRDSE9TKSAmJiAh UExBVEZPUk0oQVBQTEVUVikKIAogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSQo= 404308 2020-07-14 16:55:25 -0700 2020-07-14 17:20:26 -0700 Patch for landing bug-214329-20200714165525.patch text/plain 4833 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0Mzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFhZWVmMjk4NTBhYmJiNzA0 NWI5YTMxZjc2ZmQ2OTE4NTNmMWNjODMuLjY4ZTliMzc0MzY5ZjI5NzIyNWI2YjhjYjRkZTkxMjEz NWViMjk5YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDctMTQgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI2 NDEwMSk6IFNoYXJpbmcgYSBsaW5rIGF0dGFjaGVzIGFuIGltYWdlIGluc3RlYWQgb2YgdGhlIFVS TAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0MzI5 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NTUxMzYwNz4KKworICAgICAgICBSZXZpZXdlZCBi eSBUaW0gSG9ydG9uIGFuZCBEZXZpbiBSb3Vzc28uCisKKyAgICAgICAgcjI2NDEwMSBhZGRlZCBs b2dpYyB0aGF0IGF0dGVtcHRzIHRvIHNoYXJlIGFuIGFjdGl2YXRlZCAoaS5lLiBsb25nLXByZXNz ZWQpIGVsZW1lbnQgYXMgYW4gaW1hZ2UsIGlmIHRoZSBpbWFnZQorICAgICAgICBVUkwgc2NoZW1l IGZvciB0aGUgZWxlbWVudCBpcyBlcXVhbCB0byAiZGF0YSIgKGlnbm9yaW5nIGNhc2Ugc2Vuc2l0 aXZpdHkpLiBIb3dldmVyLCBpbiB0aGUgY2FzZSB3aGVyZSB0aGUgaW1hZ2UKKyAgICAgICAgVVJM IGlzIG5pbCwgdGhlIGNhbGwgdG8gYFtlbGVtZW50LmltYWdlVVJMLnNjaGVtZSBjYXNlSW5zZW5z aXRpdmVDb21wYXJlOkAiZGF0YSJdYCBpcyAwLCB3aGljaCAoY29udmVuaWVudGx5KSBpcworICAg ICAgICBlcXVhbCB0byBgTlNPcmRlcmVkU2FtZWAuIFRoaXMgY2F1c2VzIHVzIHRvIGluY29ycmVj dGx5IHByb2NlZWQgYnkgc2hhcmluZyB0aGUgZWxlbWVudCBhcyBhbiBpbWFnZS4KKworICAgICAg ICBGaXggdGhpcyBieSBnb2luZyB0aHJvdWdoIFVSTDo6cHJvdG9jb2xJc0RhdGEoKSwgc28gd2Ug ZG9uJ3QgZW5kIHVwIHdpdGggMCAoYE5TT3JkZXJlZFNhbWVgKSB3aGVuCisgICAgICAgIGBlbGVt ZW50LmltYWdlVVJMLnNjaGVtZWAgaXMgYG5pbGAuCisKKyAgICAgICAgVGVzdDogU2hhcmVTaGVl dFRlc3RzLlNoYXJlQW5jaG9yRWxlbWVudEFzVVJMCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9z L1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW06CisgICAgICAgICgtW1dLQWN0aW9uU2hlZXRBc3Np c3RhbnQgaGFuZGxlRWxlbWVudEFjdGlvbldpdGhUeXBlOmVsZW1lbnQ6bmVlZHNJbnRlcmFjdGlv bjpdKToKKwogMjAyMC0wNy0xNCAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNv bT4KIAogICAgICAgICBbaU9TXSBUaGUgY29tcGxldGlvbiBoYW5kbGVyIGluIC1oYW5kbGVLZXlX ZWJFdmVudDp3aXRoQ29tcGxldGlvbkhhbmRsZXI6IGlzIHNvbWV0aW1lcyBuZXZlciBjYWxsZWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNz aXN0YW50Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Np c3RhbnQubW0KaW5kZXggNDAyMTExYmEyMjc0MDJiYjgyZTAzZTQwY2U0YTYyMzc0YjAzOTljOC4u OGU0NzgxODk1NDg4OTQ5MTljNDM1NmRhNjljN2YxYzY1MGE2MWVjZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW0KKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW0KQEAg LTgyOCw3ICs4MjgsNyBAQCAtICh2b2lkKWhhbmRsZUVsZW1lbnRBY3Rpb25XaXRoVHlwZTooX1dL RWxlbWVudEFjdGlvblR5cGUpdHlwZSBlbGVtZW50OihfV0tBY3RpdgogICAgICAgICBbZGVsZWdh dGUgYWN0aW9uU2hlZXRBc3Npc3RhbnQ6c2VsZiBwZXJmb3JtQWN0aW9uOldlYktpdDo6U2hlZXRB Y3Rpb246OlNhdmVJbWFnZV07CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgX1dLRWxlbWVudEFj dGlvblR5cGVTaGFyZToKLSAgICAgICAgaWYgKFtlbGVtZW50LmltYWdlVVJMLnNjaGVtZSBjYXNl SW5zZW5zaXRpdmVDb21wYXJlOkAiZGF0YSJdID09IE5TT3JkZXJlZFNhbWUgJiYgZWxlbWVudC5p bWFnZSAmJiBbZGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihhY3Rpb25TaGVl dEFzc2lzdGFudDpzaGFyZUVsZW1lbnRXaXRoSW1hZ2U6cmVjdDopXSkKKyAgICAgICAgaWYgKFVS TChlbGVtZW50LmltYWdlVVJMKS5wcm90b2NvbElzRGF0YSgpICYmIGVsZW1lbnQuaW1hZ2UgJiYg W2RlbGVnYXRlIHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoYWN0aW9uU2hlZXRBc3Npc3Rh bnQ6c2hhcmVFbGVtZW50V2l0aEltYWdlOnJlY3Q6KV0pCiAgICAgICAgICAgICBbZGVsZWdhdGUg YWN0aW9uU2hlZXRBc3Npc3RhbnQ6c2VsZiBzaGFyZUVsZW1lbnRXaXRoSW1hZ2U6ZWxlbWVudC5p bWFnZSByZWN0OmVsZW1lbnQuYm91bmRpbmdSZWN0XTsKICAgICAgICAgZWxzZQogICAgICAgICAg ICAgW2RlbGVnYXRlIGFjdGlvblNoZWV0QXNzaXN0YW50OnNlbGYgc2hhcmVFbGVtZW50V2l0aFVS TDplbGVtZW50LlVSTCA/OiBlbGVtZW50LmltYWdlVVJMIHJlY3Q6ZWxlbWVudC5ib3VuZGluZ1Jl Y3RdOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4 IDQ3ODVhMjdmMDU1MTcwMDcxNmI5YTQ2OTI2ZDZhZjAxNTA0N2RhZDAuLjQ3YTE3NzA1NTU2NTUw OGQ5MzRhN2JjMDEzZWY5Yjk3MjAyMzM2ZjUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZwor KysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wNy0xNCAgV2Vuc29u IEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChy MjY0MTAxKTogU2hhcmluZyBhIGxpbmsgYXR0YWNoZXMgYW4gaW1hZ2UgaW5zdGVhZCBvZiB0aGUg VVJMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQz MjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY1NTEzNjA3PgorCisgICAgICAgIFJldmlld2Vk IGJ5IFRpbSBIb3J0b24gYW5kIERldmluIFJvdXNzby4KKworICAgICAgICBBZGQgYSBuZXcgQVBJ IHRlc3QgdG8gdmVyaWZ5IHRoYXQgdGhlICJzaGFyZSBhY3Rpb24iIGZvciBhIGxpbmsgc2hhcmVz IHRoZSBVUkwsIHJhdGhlciB0aGFuIGEgc25hcHNob3Qgb2YgdGhlCisgICAgICAgIGFuY2hvciBl bGVtZW50LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvU2hhcmVTaGVldFRl c3RzLm1tOgorCiAyMDIwLTA3LTE0ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUu Y29tPgogCiAgICAgICAgIFtpT1NdIFRoZSBjb21wbGV0aW9uIGhhbmRsZXIgaW4gLWhhbmRsZUtl eVdlYkV2ZW50OndpdGhDb21wbGV0aW9uSGFuZGxlcjogaXMgc29tZXRpbWVzIG5ldmVyIGNhbGxl ZApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvU2hhcmVTaGVldFRl c3RzLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9pb3MvU2hhcmVTaGVldFRlc3RzLm1t CmluZGV4IDAyMDcyZWUxNzY5Mzc2ZmQ5MjMyYWE5NDMzM2FlZDMwZmZkMzc0OWMuLmE0MzM1YTNj YWM4ZDIwNzk5MGE4YTcyNTM2OTYyYmYxOWQ5YmVjMDUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvaW9zL1NoYXJlU2hlZXRUZXN0cy5tbQorKysgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL2lvcy9TaGFyZVNoZWV0VGVzdHMubW0KQEAgLTEwMSw2ICsxMDEsMjQgQEAg VEVTVChTaGFyZVNoZWV0VGVzdHMsIFNoYXJlSW1nRWxlbWVudFdpdGhCYXNlNjRVUkwpCiAgICAg VGVzdFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkb25lKTsKIH0KIAorVEVTVChTaGFyZVNoZWV0VGVz dHMsIFNoYXJlQW5jaG9yRWxlbWVudEFzVVJMKQoreworICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0 TlMoW1tUZXN0V0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOkNHUmVjdE1ha2UoMCwgMCwg MzIwLCA1MDApXSk7CisgICAgYXV0byBvYnNlcnZlciA9IGFkb3B0TlMoW1tTaGFyZVNoZWV0T2Jz ZXJ2ZXIgYWxsb2NdIGluaXRdKTsKKyAgICBbd2ViVmlldyBzZXRVSURlbGVnYXRlOm9ic2VydmVy LmdldCgpXTsKKyAgICBbd2ViVmlldyBzeW5jaHJvbm91c2x5TG9hZFRlc3RQYWdlTmFtZWQ6QCJs aW5rLWFuZC1pbnB1dCJdOworCisgICAgX19ibG9jayBib29sIGRvbmUgPSBmYWxzZTsKKyAgICBb b2JzZXJ2ZXIgc2V0QWN0aXZpdHlJdGVtc0hhbmRsZXI6XihOU0FycmF5ICphY3Rpdml0eUl0ZW1z KSB7CisgICAgICAgIEVYUEVDVF9FUSgxVUwsIGFjdGl2aXR5SXRlbXMuY291bnQpOworICAgICAg ICBFWFBFQ1RfV0tfU1RSRVEoImh0dHBzOi8vd3d3LmFwcGxlLmNvbS8iLCBbW2FjdGl2aXR5SXRl bXMgb2JqZWN0QXRJbmRleDowXSBhYnNvbHV0ZVN0cmluZ10pOworICAgICAgICBkb25lID0gdHJ1 ZTsKKyAgICB9XTsKKworICAgIHNob3dTaGFyZVNoZWV0KHdlYlZpZXcuZ2V0KCksIG9ic2VydmVy LmdldCgpLCBDR1BvaW50TWFrZSgxMDAsIDEwMCkpOworICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6 OnJ1bigmZG9uZSk7Cit9CisKICNlbmRpZiAvLyAhUExBVEZPUk0oV0FUQ0hPUykgJiYgIVBMQVRG T1JNKEFQUExFVFYpCiAKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkK