214325 2020-07-14 14:58:45 -0700 Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers 2020-07-15 07:48:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212248 InRadar P2 Enhancement --- 1 ashvayka ashvayka darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1671536 0 ashvayka 2020-07-14 14:58:45 -0700 Emit HasOwnPropertyFunctionCallDotNode for "Reflect" identifiers 1671538 1 404290 ashvayka 2020-07-14 15:01:48 -0700 Created attachment 404290 Patch 1671539 2 ashvayka 2020-07-14 15:02:23 -0700 (In reply to Alexey Shvayka from comment #1) > Created attachment 404290 [details] > Patch Warmed-up runs, --outer 50: r264266 patch has-own-property-for-in-loop-with-heap-variable 35.9192+-2.6893 ^ 29.2597+-0.7042 ^ definitely 1.2276x faster 1671560 3 404290 mark.lam 2020-07-14 15:49:05 -0700 Comment on attachment 404290 Patch Let's hold off on committing this until after the EWS bots finish testing. Thanks. 1671606 4 404290 saam 2020-07-14 16:56:56 -0700 Comment on attachment 404290 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404290&action=review Good call. I think I was mistakenly thinking of "Reflect.has" when I wrote the code. r=me too > JSTests/microbenchmarks/has-own-property-for-in-loop-with-heap-variable.js:-7 > - let o = { let's add a new test. 1671611 5 404290 mark.lam 2020-07-14 17:14:49 -0700 Comment on attachment 404290 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404290&action=review >> JSTests/microbenchmarks/has-own-property-for-in-loop-with-heap-variable.js:-7 >> - let o = { > > let's add a new test. By "let's add a new test", I think Saam meant, let's not modify this one, but add a clone of this one that uses Reflect instead. 1671612 6 404290 mark.lam 2020-07-14 17:17:25 -0700 Comment on attachment 404290 Patch Removing the cq? because the test needs to be updated. I would still like to see the EWS tests run to completion on this patch (since they are almost there already). 1671678 7 404323 ashvayka 2020-07-15 00:36:13 -0700 Created attachment 404323 Patch Clone test instead of modifying. 1671733 8 ews-feeder 2020-07-15 07:47:48 -0700 Committed r264397: <https://trac.webkit.org/changeset/264397> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404323. 1671734 9 webkit-bug-importer 2020-07-15 07:48:15 -0700 <rdar://problem/65605240> 404290 2020-07-14 15:01:48 -0700 2020-07-15 00:36:09 -0700 Patch bug-214325-20200715010147.patch text/plain 4234 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjQzNzYpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDIwLTA3LTE0ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBFbWl0IEhhc093blByb3BlcnR5RnVuY3Rpb25DYWxsRG90 Tm9kZSBmb3IgIlJlZmxlY3QiIGlkZW50aWZpZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQzMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIG1pY3JvYmVuY2htYXJrcy9oYXMtb3duLXByb3BlcnR5 LWZvci1pbi1sb29wLXdpdGgtaGVhcC12YXJpYWJsZS5qczoKKyAgICAgICAgKiBzdHJlc3MvcmVm bGVjdC1oYXMuanM6CisgICAgICAgICogc3RyZXNzL3JlZmxlY3QuanM6CisKIDIwMjAtMDctMTQg IEFuZ2Vsb3MgT2lrb25vbW9wb3Vsb3MgIDxhbmdlbG9zQGlnYWxpYS5jb20+CiAKICAgICAgICAg U2tpcCBpbnRlcm1pdHRlbnRseSBmYWlsaW5nIHR5cGUtY2hlY2staG9pc3RpbmctcGhhc2UtaG9p c3QtY2hlY2stc3RydWN0dXJlLW9uLXRkei10aGlzLXZhbHVlIG9uIG1pcHMKSW5kZXg6IEpTVGVz dHMvbWljcm9iZW5jaG1hcmtzL2hhcy1vd24tcHJvcGVydHktZm9yLWluLWxvb3Atd2l0aC1oZWFw LXZhcmlhYmxlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2hhcy1v d24tcHJvcGVydHktZm9yLWluLWxvb3Atd2l0aC1oZWFwLXZhcmlhYmxlLmpzCShyZXZpc2lvbiAy NjQzMjApCisrKyBKU1Rlc3RzL21pY3JvYmVuY2htYXJrcy9oYXMtb3duLXByb3BlcnR5LWZvci1p bi1sb29wLXdpdGgtaGVhcC12YXJpYWJsZS5qcwkod29ya2luZyBjb3B5KQpAQCAtNCw3ICs0LDcg QEAgZnVuY3Rpb24gYXNzZXJ0KGIpIHsKIH0KIAogZnVuY3Rpb24gdGVzdDEoKSB7Ci0gICAgbGV0 IG8gPSB7CisgICAgbGV0IFJlZmxlY3QgPSB7CiAgICAgICAgIGE6MjAsCiAgICAgICAgIGI6MzAs CiAgICAgICAgIGM6NDAsCkBAIC0xMyw4ICsxMyw4IEBAIGZ1bmN0aW9uIHRlc3QxKCkgewogCiAg ICAgZnVuY3Rpb24gY291bnQoKSB7CiAgICAgICAgIGxldCBjID0gMDsKLSAgICAgICAgZm9yIChs ZXQgcCBpbiBvKSB7Ci0gICAgICAgICAgICBpZiAoby5oYXNPd25Qcm9wZXJ0eShwKSkKKyAgICAg ICAgZm9yIChsZXQgcCBpbiBSZWZsZWN0KSB7CisgICAgICAgICAgICBpZiAoUmVmbGVjdC5oYXNP d25Qcm9wZXJ0eShwKSkKICAgICAgICAgICAgICAgICArK2M7CiAgICAgICAgIH0KICAgICAgICAg cmV0dXJuIGM7CkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9yZWZsZWN0LWhhcy5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKU1Rlc3RzL3N0cmVzcy9yZWZsZWN0LWhhcy5qcwkocmV2aXNpb24gMjY0MzIwKQorKysg SlNUZXN0cy9zdHJlc3MvcmVmbGVjdC1oYXMuanMJKHdvcmtpbmcgY29weSkKQEAgLTE2LDYgKzE2 LDcgQEAgZnVuY3Rpb24gc2hvdWxkVGhyb3coZnVuYywgbWVzc2FnZSkgewogICAgICAgICB0aHJv dyBuZXcgRXJyb3IoImJhZCBlcnJvcjogIiArIFN0cmluZyhlcnJvcikpOwogfQogCitzaG91bGRC ZShSZWZsZWN0Lmhhc093blByb3BlcnR5KCJoYXMiKSwgdHJ1ZSk7CiBzaG91bGRCZShSZWZsZWN0 Lmhhcy5sZW5ndGgsIDIpOwogCiBzaG91bGRUaHJvdygoKSA9PiB7CkluZGV4OiBKU1Rlc3RzL3N0 cmVzcy9yZWZsZWN0LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3JlZmxlY3QuanMJ KHJldmlzaW9uIDI2NDMyMCkKKysrIEpTVGVzdHMvc3RyZXNzL3JlZmxlY3QuanMJKHdvcmtpbmcg Y29weSkKQEAgLTcsMyArNyw0IEBAIHNob3VsZEJlKHR5cGVvZiBSZWZsZWN0LCAib2JqZWN0Iik7 CiBzaG91bGRCZShSZWZsZWN0LCBSZWZsZWN0KTsKIHNob3VsZEJlKE9iamVjdC5nZXRQcm90b3R5 cGVPZihSZWZsZWN0KSwgT2JqZWN0LmdldFByb3RvdHlwZU9mKHt9KSk7CiBzaG91bGRCZShSZWZs ZWN0LnRvU3RyaW5nKCksICJbb2JqZWN0IE9iamVjdF0iKTsKK3Nob3VsZEJlKFJlZmxlY3QuaGFz T3duUHJvcGVydHksIE9iamVjdC5wcm90b3R5cGUuaGFzT3duUHJvcGVydHkpOwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjQzMjApCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDct MTQgIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgorCisgICAgICAgIEVt aXQgSGFzT3duUHJvcGVydHlGdW5jdGlvbkNhbGxEb3ROb2RlIGZvciAiUmVmbGVjdCIgaWRlbnRp ZmllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx NDMyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1 cnJlbnRseSwgSGFzT3duUHJvcGVydHlGdW5jdGlvbkNhbGxEb3ROb2RlIGlzIGVtaXR0ZWQgZm9y IGFsbCBSZXNvbHZlTm9kZXMKKyAgICAgICAgZXhjZXB0IG9uZXMgd2l0aCAiUmVmbGVjdCIgaWRl bnRpZmllci4gVGhpcyBleGNlcHRpb24gZG9lc24ndCBzZWVtIG5lY2Vzc2FyeQorICAgICAgICBh cyBgUmVmbGVjdGAgb2JqZWN0IGluaGVyaXRzIG9yZGluYXJ5IGBPYmplY3QucHJvdG90eXBlLmhh c093blByb3BlcnR5YCBtZXRob2QuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIHRoZSBl eGNlcHRpb24sIGFkdmFuY2luZyBgaGFzT3duUHJvcGVydHlgIGluIGBmb3IvaW5gIGxvb3AKKyAg ICAgICAgbWljcm9iZW5jaG1hcmsgZm9yICJSZWZsZWN0IiBpZGVudGlmaWVycyBieSAyMCUuCisK KyAgICAgICAgKiBwYXJzZXIvQVNUQnVpbGRlci5oOgorICAgICAgICAoSlNDOjpBU1RCdWlsZGVy OjptYWtlRnVuY3Rpb25DYWxsTm9kZSk6CisKIDIwMjAtMDctMTMgIEdlb2ZmcmV5IEdhcmVuICA8 Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByZS1sYW5kaW5nIHIyNjQy NDIgd2l0aCBjcmFzaCBmaXhlZC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIv QVNUQnVpbGRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIv QVNUQnVpbGRlci5oCShyZXZpc2lvbiAyNjQzMjApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cGFyc2VyL0FTVEJ1aWxkZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTQ1NSw3ICsxNDU1LDcgQEAg RXhwcmVzc2lvbk5vZGUqIEFTVEJ1aWxkZXI6Om1ha2VGdW5jdGlvbgogICAgICAgICAmJiBhcmdz LT5tX2xpc3ROb2RlLT5tX2V4cHIKICAgICAgICAgJiYgYXJncy0+bV9saXN0Tm9kZS0+bV9leHBy LT5pc1Jlc29sdmVOb2RlKCkKICAgICAgICAgJiYgIWFyZ3MtPm1fbGlzdE5vZGUtPm1fbmV4dAot ICAgICAgICAmJiAoKGRvdC0+YmFzZSgpLT5pc1Jlc29sdmVOb2RlKCkgJiYgc3RhdGljX2Nhc3Q8 UmVzb2x2ZU5vZGUqPihkb3QtPmJhc2UoKSktPmlkZW50aWZpZXIoKSAhPSBtX3ZtLnByb3BlcnR5 TmFtZXMtPlJlZmxlY3QpIHx8IGRvdC0+YmFzZSgpLT5pc1RoaXNOb2RlKCkpKSB7CisgICAgICAg ICYmIChkb3QtPmJhc2UoKS0+aXNSZXNvbHZlTm9kZSgpIHx8IGRvdC0+YmFzZSgpLT5pc1RoaXNO b2RlKCkpKSB7CiAgICAgICAgIC8vIFdlIG1hdGNoIHRoZSBBU1QgcGF0dGVybjoKICAgICAgICAg Ly8gPHJlc29sdmVOb2RlfHRoaXNOb2RlPi5oYXNPd25Qcm9wZXJ0eSg8cmVzb2x2ZU5vZGU+KQog ICAgICAgICAvLyBpLmU6Cg== 404323 2020-07-15 00:36:13 -0700 2020-07-15 07:47:49 -0700 Patch bug-214325-20200715103611.patch text/plain 4260 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjQzODgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDIwLTA3LTE0ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBFbWl0IEhhc093blByb3BlcnR5RnVuY3Rpb25DYWxsRG90 Tm9kZSBmb3IgIlJlZmxlY3QiIGlkZW50aWZpZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQzMjUKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBBZGxlciBhbmQgU2FhbSBCYXJhdGkuCisKKyAgICAgICAgKiBtaWNyb2JlbmNobWFya3MvaGFz LW93bi1wcm9wZXJ0eS1mb3ItaW4tbG9vcC1yZWZsZWN0LW5hbWUuanM6IEFkZGVkLgorICAgICAg ICAqIHN0cmVzcy9yZWZsZWN0LWhhcy5qczoKKyAgICAgICAgKiBzdHJlc3MvcmVmbGVjdC5qczoK KwogMjAyMC0wNy0xNCAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZSBtdXN0IGhvbGQgdGhlIENvZGVCbG9jayBsb2NrIHdoZW4gY2FsbGluZyBTdHJ1Y3R1cmVT dHViSW5mbzo6cmVzZXQKSW5kZXg6IEpTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2hhcy1vd24tcHJv cGVydHktZm9yLWluLWxvb3AtcmVmbGVjdC1uYW1lLmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMv bWljcm9iZW5jaG1hcmtzL2hhcy1vd24tcHJvcGVydHktZm9yLWluLWxvb3AtcmVmbGVjdC1uYW1l LmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2hhcy1vd24tcHJv cGVydHktZm9yLWluLWxvb3AtcmVmbGVjdC1uYW1lLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAg KzEsMjggQEAKK2Z1bmN0aW9uIGFzc2VydChiKSB7CisgICAgaWYgKCFiKQorICAgICAgICB0aHJv dyBuZXcgRXJyb3I7Cit9CisKK2Z1bmN0aW9uIHRlc3QxKCkgeworICAgIGZ1bmN0aW9uIGNvdW50 KFJlZmxlY3QpIHsKKyAgICAgICAgbGV0IGMgPSAwOworICAgICAgICBmb3IgKGxldCBwIGluIFJl ZmxlY3QpIHsKKyAgICAgICAgICAgIGlmIChSZWZsZWN0Lmhhc093blByb3BlcnR5KHApKQorICAg ICAgICAgICAgICAgICsrYzsKKyAgICAgICAgfQorICAgICAgICByZXR1cm4gYzsKKyAgICB9Cisg ICAgbm9JbmxpbmUoY291bnQpOworCisgICAgbGV0IG8gPSB7CisgICAgICAgIGE6MjAsCisgICAg ICAgIGI6MzAsCisgICAgICAgIGM6NDAsCisgICAgICAgIGQ6NTAKKyAgICB9OworCisgICAgZm9y IChsZXQgaSA9IDA7IGkgPCA2MDAwMDA7ICsraSkgeworICAgICAgICBhc3NlcnQoY291bnQobykg PT09IDQpOworICAgIH0KK30KK3Rlc3QxKCk7CkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9yZWZsZWN0 LWhhcy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9yZWZsZWN0LWhhcy5qcwkocmV2 aXNpb24gMjY0Mzg4KQorKysgSlNUZXN0cy9zdHJlc3MvcmVmbGVjdC1oYXMuanMJKHdvcmtpbmcg Y29weSkKQEAgLTE2LDYgKzE2LDcgQEAgZnVuY3Rpb24gc2hvdWxkVGhyb3coZnVuYywgbWVzc2Fn ZSkgewogICAgICAgICB0aHJvdyBuZXcgRXJyb3IoImJhZCBlcnJvcjogIiArIFN0cmluZyhlcnJv cikpOwogfQogCitzaG91bGRCZShSZWZsZWN0Lmhhc093blByb3BlcnR5KCJoYXMiKSwgdHJ1ZSk7 CiBzaG91bGRCZShSZWZsZWN0Lmhhcy5sZW5ndGgsIDIpOwogCiBzaG91bGRUaHJvdygoKSA9PiB7 CkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9yZWZsZWN0LmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMv c3RyZXNzL3JlZmxlY3QuanMJKHJldmlzaW9uIDI2NDM4OCkKKysrIEpTVGVzdHMvc3RyZXNzL3Jl ZmxlY3QuanMJKHdvcmtpbmcgY29weSkKQEAgLTcsMyArNyw0IEBAIHNob3VsZEJlKHR5cGVvZiBS ZWZsZWN0LCAib2JqZWN0Iik7CiBzaG91bGRCZShSZWZsZWN0LCBSZWZsZWN0KTsKIHNob3VsZEJl KE9iamVjdC5nZXRQcm90b3R5cGVPZihSZWZsZWN0KSwgT2JqZWN0LmdldFByb3RvdHlwZU9mKHt9 KSk7CiBzaG91bGRCZShSZWZsZWN0LnRvU3RyaW5nKCksICJbb2JqZWN0IE9iamVjdF0iKTsKK3No b3VsZEJlKFJlZmxlY3QuaGFzT3duUHJvcGVydHksIE9iamVjdC5wcm90b3R5cGUuaGFzT3duUHJv cGVydHkpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjQzODgpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjAgQEAKKzIwMjAtMDctMTQgIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwu Y29tPgorCisgICAgICAgIEVtaXQgSGFzT3duUHJvcGVydHlGdW5jdGlvbkNhbGxEb3ROb2RlIGZv ciAiUmVmbGVjdCIgaWRlbnRpZmllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxNDMyNQorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy IGFuZCBTYWFtIEJhcmF0aS4KKworICAgICAgICBDdXJyZW50bHksIEhhc093blByb3BlcnR5RnVu Y3Rpb25DYWxsRG90Tm9kZSBpcyBlbWl0dGVkIGZvciBhbGwgUmVzb2x2ZU5vZGVzCisgICAgICAg IGV4Y2VwdCBvbmVzIHdpdGggIlJlZmxlY3QiIGlkZW50aWZpZXIuIFRoaXMgZXhjZXB0aW9uIGRv ZXNuJ3Qgc2VlbSBuZWNlc3NhcnkKKyAgICAgICAgYXMgUmVmbGVjdE9iamVjdCBpbmhlcml0cyBv cmRpbmFyeSBgT2JqZWN0LnByb3RvdHlwZS5oYXNPd25Qcm9wZXJ0eWAgbWV0aG9kLgorCisgICAg ICAgIFRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGUgZXhjZXB0aW9uLCBhZHZhbmNpbmcgcHJvdmlkZWQg IlJlZmxlY3QiIG1pY3JvYmVuY2htYXJrCisgICAgICAgIGJ5IDIwJS4gTm8gYmVoYXZpb3IgY2hh bmdlLgorCisgICAgICAgICogcGFyc2VyL0FTVEJ1aWxkZXIuaDoKKyAgICAgICAgKEpTQzo6QVNU QnVpbGRlcjo6bWFrZUZ1bmN0aW9uQ2FsbE5vZGUpOgorCiAyMDIwLTA3LTE0ICBTYWFtIEJhcmF0 aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIFdlIG11c3QgaG9sZCB0aGUgQ29kZUJs b2NrIGxvY2sgd2hlbiBjYWxsaW5nIFN0cnVjdHVyZVN0dWJJbmZvOjpyZXNldApJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9BU1RCdWlsZGVyLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9BU1RCdWlsZGVyLmgJKHJldmlzaW9uIDI2NDM4OCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvQVNUQnVpbGRlci5oCSh3b3JraW5nIGNv cHkpCkBAIC0xNDU1LDcgKzE0NTUsNyBAQCBFeHByZXNzaW9uTm9kZSogQVNUQnVpbGRlcjo6bWFr ZUZ1bmN0aW9uCiAgICAgICAgICYmIGFyZ3MtPm1fbGlzdE5vZGUtPm1fZXhwcgogICAgICAgICAm JiBhcmdzLT5tX2xpc3ROb2RlLT5tX2V4cHItPmlzUmVzb2x2ZU5vZGUoKQogICAgICAgICAmJiAh YXJncy0+bV9saXN0Tm9kZS0+bV9uZXh0Ci0gICAgICAgICYmICgoZG90LT5iYXNlKCktPmlzUmVz b2x2ZU5vZGUoKSAmJiBzdGF0aWNfY2FzdDxSZXNvbHZlTm9kZSo+KGRvdC0+YmFzZSgpKS0+aWRl bnRpZmllcigpICE9IG1fdm0ucHJvcGVydHlOYW1lcy0+UmVmbGVjdCkgfHwgZG90LT5iYXNlKCkt PmlzVGhpc05vZGUoKSkpIHsKKyAgICAgICAgJiYgKGRvdC0+YmFzZSgpLT5pc1Jlc29sdmVOb2Rl KCkgfHwgZG90LT5iYXNlKCktPmlzVGhpc05vZGUoKSkpIHsKICAgICAgICAgLy8gV2UgbWF0Y2gg dGhlIEFTVCBwYXR0ZXJuOgogICAgICAgICAvLyA8cmVzb2x2ZU5vZGV8dGhpc05vZGU+Lmhhc093 blByb3BlcnR5KDxyZXNvbHZlTm9kZT4pCiAgICAgICAgIC8vIGkuZToK