21431 2008-10-07 10:04:12 -0700 String.replace does not support $& replacement metacharacter when search term is not a RegExp 2009-01-02 01:06:42 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED javascript:alert("asdf".replace("as", "$&$&$&")) InRadar P2 Normal --- 1 mrowe darin dmandelin oldest_to_newest 94370 0 mrowe 2008-10-07 10:04:12 -0700 "asdf".replace("as", "$&$&$&") gives "$&$&$&df" rather than the expected "asasasdf". "asdf".replace(/as/, "$&$&$&") correctly gives "asasasdf". 94371 1 mrowe 2008-10-07 10:08:20 -0700 <rdar://problem/6274993> 103398 2 darin 2008-12-24 23:02:02 -0800 stringProtoFuncReplace needs to call substituteBackreferences on replacementString 103870 3 26331 darin 2008-12-30 23:26:37 -0800 Created attachment 26331 patch 104024 4 darin 2009-01-01 21:57:40 -0800 http://trac.webkit.org/changeset/39542 26331 2008-12-30 23:26:37 -0800 2009-01-01 21:53:21 -0800 patch StringReplacePatch.txt text/plain 6298 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5NTI0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDgtMTItMzAgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFN0cmluZy5yZXBsYWNlIGRvZXMgbm90IHN1cHBvcnQgJCYgcmVwbGFj ZW1lbnQgbWV0YWNoYXJhY3RlciB3aGVuIHNlYXJjaCB0ZXJtIGlzIG5vdCBhIFJlZ0V4cAorICAg ICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDMxPgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNjI3NDk5Mz4KKworICAgICAgICBUZXN0OiBmYXN0L2pzL3N0 cmluZy1yZXBsYWNlLTMuaHRtbAorCisgICAgICAgICogcnVudGltZS9TdHJpbmdQcm90b3R5cGUu Y3BwOgorICAgICAgICAoSlNDOjpzdWJzdGl0dXRlQmFja3JlZmVyZW5jZXMpOiBBZGRlZCBhIG51 bGwgY2hlY2sgaGVyZSBzbyB3ZSB3b24ndCB0cnkgdG8gaGFuZGxlICQkLSQ5CisgICAgICAgIGJh Y2tyZWZlcmVuY2VzIHdoZW4gdGhlIHNlYXJjaCB0ZXJtIGlzIGEgc3RyaW5nLCBub3QgYSBSZWdF eHAuIEFkZGVkIGEgY2hlY2sgZm9yIDAgc28gd2UKKyAgICAgICAgd29uJ3QgdHJ5IHRvIGhhbmRs ZSAkMCBvciAkMDAgYXMgYSBiYWNrcmVmZXJlbmNlLgorICAgICAgICAoSlNDOjpzdHJpbmdQcm90 b0Z1bmNSZXBsYWNlKTogQWRkZWQgYSBjYWxsIHRvIHN1YnN0aXR1dGVCYWNrcmVmZXJlbmNlcy4K KwogMjAwOC0xMi0zMCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9T dHJpbmdQcm90b3R5cGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUv U3RyaW5nUHJvdG90eXBlLmNwcAkocmV2aXNpb24gMzk1MjQpCisrKyBKYXZhU2NyaXB0Q29yZS9y dW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2Miw3ICsxNjIs NyBAQCBzdGF0aWMgaW5saW5lIFVTdHJpbmcgc3Vic3RpdHV0ZUJhY2tyZWZlCiAgICAgICAgIH0g ZWxzZSBpZiAocmVmID09ICdcJycpIHsKICAgICAgICAgICAgIGJhY2tyZWZTdGFydCA9IG92ZWN0 b3JbMV07CiAgICAgICAgICAgICBiYWNrcmVmTGVuZ3RoID0gc291cmNlLnNpemUoKSAtIGJhY2ty ZWZTdGFydDsKLSAgICAgICAgfSBlbHNlIGlmIChyZWYgPj0gJzAnICYmIHJlZiA8PSAnOScpIHsK KyAgICAgICAgfSBlbHNlIGlmIChyZWcgJiYgcmVmID49ICcwJyAmJiByZWYgPD0gJzknKSB7CiAg ICAgICAgICAgICAvLyAxLSBhbmQgMi1kaWdpdCBiYWNrIHJlZmVyZW5jZXMgYXJlIGFsbG93ZWQK ICAgICAgICAgICAgIHVuc2lnbmVkIGJhY2tyZWZJbmRleCA9IHJlZiAtICcwJzsKICAgICAgICAg ICAgIGlmIChiYWNrcmVmSW5kZXggPiByZWctPm51bVN1YnBhdHRlcm5zKCkpCkBAIC0xNzcsNiAr MTc3LDggQEAgc3RhdGljIGlubGluZSBVU3RyaW5nIHN1YnN0aXR1dGVCYWNrcmVmZQogICAgICAg ICAgICAgICAgICAgICAgICAgYWR2YW5jZSA9IDE7CiAgICAgICAgICAgICAgICAgfQogICAgICAg ICAgICAgfQorICAgICAgICAgICAgaWYgKCFiYWNrcmVmSW5kZXgpCisgICAgICAgICAgICAgICAg Y29udGludWU7CiAgICAgICAgICAgICBiYWNrcmVmU3RhcnQgPSBvdmVjdG9yWzIgKiBiYWNrcmVm SW5kZXhdOwogICAgICAgICAgICAgYmFja3JlZkxlbmd0aCA9IG92ZWN0b3JbMiAqIGJhY2tyZWZJ bmRleCArIDFdIC0gYmFja3JlZlN0YXJ0OwogICAgICAgICB9IGVsc2UKQEAgLTMwMiw3ICszMDQs MTAgQEAgSlNWYWx1ZSogc3RyaW5nUHJvdG9GdW5jUmVwbGFjZShFeGVjU3RhdAogICAgICAgICBy ZXBsYWNlbWVudFN0cmluZyA9IGNhbGwoZXhlYywgcmVwbGFjZW1lbnQsIGNhbGxUeXBlLCBjYWxs RGF0YSwgZXhlYy0+Z2xvYmFsVGhpc1ZhbHVlKCksIGFyZ3MpLT50b1N0cmluZyhleGVjKTsKICAg ICB9CiAKLSAgICByZXR1cm4ganNTdHJpbmcoZXhlYywgc291cmNlLnN1YnN0cigwLCBtYXRjaFBv cykgKyByZXBsYWNlbWVudFN0cmluZyArIHNvdXJjZS5zdWJzdHIobWF0Y2hQb3MgKyBtYXRjaExl bikpOworICAgIGludCBvdmVjdG9yWzJdID0geyBtYXRjaFBvcywgbWF0Y2hQb3MgKyBtYXRjaExl biB9OworICAgIHJldHVybiBqc1N0cmluZyhleGVjLCBzb3VyY2Uuc3Vic3RyKDAsIG1hdGNoUG9z KQorICAgICAgICArIHN1YnN0aXR1dGVCYWNrcmVmZXJlbmNlcyhyZXBsYWNlbWVudFN0cmluZywg c291cmNlLCBvdmVjdG9yLCAwKQorICAgICAgICArIHNvdXJjZS5zdWJzdHIobWF0Y2hQb3MgKyBt YXRjaExlbikpOwogfQogCiBKU1ZhbHVlKiBzdHJpbmdQcm90b0Z1bmNUb1N0cmluZyhFeGVjU3Rh dGUqIGV4ZWMsIEpTT2JqZWN0KiwgSlNWYWx1ZSogdGhpc1ZhbHVlLCBjb25zdCBBcmdMaXN0JikK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM5NTI0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMTItMzAgIERhcmluIEFkbGVyICA8ZGFy aW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFN0cmluZy5yZXBsYWNlIGRvZXMgbm90IHN1cHBvcnQgJCYgcmVwbGFjZW1lbnQgbWV0 YWNoYXJhY3RlciB3aGVuIHNlYXJjaCB0ZXJtIGlzIG5vdCBhIFJlZ0V4cAorICAgICAgICA8aHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDMxPgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNjI3NDk5Mz4KKworICAgICAgICAqIGZhc3QvanMvcmVzb3VyY2VzL3N0cmlu Zy1yZXBsYWNlLTMuanM6IEFkZGVkIHRlc3QgY2FzZXMgdG8gY292ZXIgcmVwbGFjZSB3aXRoIG5v bi1yZWdleHAgYW5kCisgICAgICAgIHRvIGNvdmVyICIkMCIgYW5kICIkMDAiLgorICAgICAgICAq IGZhc3QvanMvc3RyaW5nLXJlcGxhY2UtMy1leHBlY3RlZC50eHQ6IEFkZGVkIG5ldyByZXN1bHRz LgorCiAyMDA4LTEyLTMwICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3N0 cmluZy1yZXBsYWNlLTMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zh c3QvanMvc3RyaW5nLXJlcGxhY2UtMy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDM5NTI0KQorKysg TGF5b3V0VGVzdHMvZmFzdC9qcy9zdHJpbmctcmVwbGFjZS0zLWV4cGVjdGVkLnR4dAkod29ya2lu ZyBjb3B5KQpAQCAtOCw2ICs4LDExIEBAIFBBU1MgdGVzdFN0cmluZy5yZXBsYWNlKC9JIGZlZWwv LCAneWV0ICQKIFBBU1MgdGVzdFN0cmluZy5yZXBsYWNlKC90aGUgZW5kLywgJ25pY2UuICRgYSBw aWN0dXJlJykgaXMgIkl0J3MgbmljZS4gSXQncyBhIHBpY3R1cmUgb2YgdGhlIHdvcmxkIGFzIHdl IGtub3cgaXQsIGFuZCBJIGZlZWwgZmluZS4iCiBQQVNTIHRlc3RTdHJpbmcucmVwbGFjZSgvZmVl bCBmaW4vLCAiYW0gZ29uJCcgQnkiKSBpcyAiSXQncyB0aGUgZW5kIG9mIHRoZSB3b3JsZCBhcyB3 ZSBrbm93IGl0LCBhbmQgSSBhbSBnb25lLiBCeWUuIgogUEFTUyB0ZXN0U3RyaW5nLnJlcGxhY2Uo Lyh0KShoKShlIGUpKG4pKGQpKCBvKShmKSggKSh0KShoKShlICkoW15yXSopKHJsZCkvLCAnbm90 ICQxMm9sbHkgbWFtbW90aCcpIGlzICJJdCdzIG5vdCB3b29sbHkgbWFtbW90aCBhcyB3ZSBrbm93 IGl0LCBhbmQgSSBmZWVsIGZpbmUuIgorUEFTUyB0ZXN0U3RyaW5nLnJlcGxhY2UoJ0kgZmVlbCcs ICd5ZXQgJCYganVzdCcpIGlzICJJdCdzIHRoZSBlbmQgb2YgdGhlIHdvcmxkIGFzIHdlIGtub3cg aXQsIGFuZCB5ZXQgSSBmZWVsIGp1c3QgZmluZS4iCitQQVNTIHRlc3RTdHJpbmcucmVwbGFjZSgn dGhlIGVuZCcsICduaWNlLiAkYGEgcGljdHVyZScpIGlzICJJdCdzIG5pY2UuIEl0J3MgYSBwaWN0 dXJlIG9mIHRoZSB3b3JsZCBhcyB3ZSBrbm93IGl0LCBhbmQgSSBmZWVsIGZpbmUuIgorUEFTUyB0 ZXN0U3RyaW5nLnJlcGxhY2UoImZlZWwgZmluIiwgImFtIGdvbiQnIEJ5IikgaXMgIkl0J3MgdGhl IGVuZCBvZiB0aGUgd29ybGQgYXMgd2Uga25vdyBpdCwgYW5kIEkgYW0gZ29uZS4gQnllLiIKK1BB U1MgdGVzdFN0cmluZy5yZXBsYWNlKC9lbmQvLCAnJDAgJDAwICQxICQwMSAkMiAkMTIgJDkgJDk5 ICQxYSAkMTFhJykgaXMgIkl0J3MgdGhlICQwICQwMCAkMSAkMDEgJDIgJDEyICQ5ICQ5OSAkMWEg JDExYSBvZiB0aGUgd29ybGQgYXMgd2Uga25vdyBpdCwgYW5kIEkgZmVlbCBmaW5lLiIKK1BBU1Mg dGVzdFN0cmluZy5yZXBsYWNlKCdlbmQnLCAnJDAgJDAwICQxICQwMSAkMiAkMTIgJDkgJDk5ICQx YSAkMTFhJykgaXMgIkl0J3MgdGhlICQwICQwMCAkMSAkMDEgJDIgJDEyICQ5ICQ5OSAkMWEgJDEx YSBvZiB0aGUgd29ybGQgYXMgd2Uga25vdyBpdCwgYW5kIEkgZmVlbCBmaW5lLiIKIFBBU1Mgc3Vj Y2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9qcy9yZXNvdXJjZXMvc3RyaW5nLXJlcGxhY2UtMy5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9zdHJpbmctcmVwbGFjZS0zLmpzCShyZXZpc2lv biAzOTUyNCkKKysrIExheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL3N0cmluZy1yZXBsYWNl LTMuanMJKHdvcmtpbmcgY29weSkKQEAgLTE0LDQgKzE0LDE2IEBAIHNob3VsZEJlKCd0ZXN0U3Ry aW5nLnJlcGxhY2UoL2ZlZWwgZmluLywKIHNob3VsZEJlKCJ0ZXN0U3RyaW5nLnJlcGxhY2UoLyh0 KShoKShlIGUpKG4pKGQpKCBvKShmKSggKSh0KShoKShlICkoW15yXSopKHJsZCkvLCAnbm90ICQx Mm9sbHkgbWFtbW90aCcpIiwKICAgICAgICAgICJcIkl0J3Mgbm90IHdvb2xseSBtYW1tb3RoIGFz IHdlIGtub3cgaXQsIGFuZCBJIGZlZWwgZmluZS5cIiIpOwogCitzaG91bGRCZSgidGVzdFN0cmlu Zy5yZXBsYWNlKCdJIGZlZWwnLCAneWV0ICQmIGp1c3QnKSIsCisgICAgICAgICAiXCJJdCdzIHRo ZSBlbmQgb2YgdGhlIHdvcmxkIGFzIHdlIGtub3cgaXQsIGFuZCB5ZXQgSSBmZWVsIGp1c3QgZmlu ZS5cIiIpOworc2hvdWxkQmUoInRlc3RTdHJpbmcucmVwbGFjZSgndGhlIGVuZCcsICduaWNlLiAk YGEgcGljdHVyZScpIiwKKyAgICAgICAgICJcIkl0J3MgbmljZS4gSXQncyBhIHBpY3R1cmUgb2Yg dGhlIHdvcmxkIGFzIHdlIGtub3cgaXQsIGFuZCBJIGZlZWwgZmluZS5cIiIpOworc2hvdWxkQmUo J3Rlc3RTdHJpbmcucmVwbGFjZSgiZmVlbCBmaW4iLCAiYW0gZ29uJFwnIEJ5IiknLAorICAgICAg ICAgIlwiSXQncyB0aGUgZW5kIG9mIHRoZSB3b3JsZCBhcyB3ZSBrbm93IGl0LCBhbmQgSSBhbSBn b25lLiBCeWUuXCIiKTsKKworc2hvdWxkQmUoInRlc3RTdHJpbmcucmVwbGFjZSgvZW5kLywgJyQw ICQwMCAkMSAkMDEgJDIgJDEyICQ5ICQ5OSAkMWEgJDExYScpIiwKKyAgICAgICAgICJcIkl0J3Mg dGhlICQwICQwMCAkMSAkMDEgJDIgJDEyICQ5ICQ5OSAkMWEgJDExYSBvZiB0aGUgd29ybGQgYXMg d2Uga25vdyBpdCwgYW5kIEkgZmVlbCBmaW5lLlwiIik7CitzaG91bGRCZSgidGVzdFN0cmluZy5y ZXBsYWNlKCdlbmQnLCAnJDAgJDAwICQxICQwMSAkMiAkMTIgJDkgJDk5ICQxYSAkMTFhJykiLAor ICAgICAgICAgIlwiSXQncyB0aGUgJDAgJDAwICQxICQwMSAkMiAkMTIgJDkgJDk5ICQxYSAkMTFh IG9mIHRoZSB3b3JsZCBhcyB3ZSBrbm93IGl0LCBhbmQgSSBmZWVsIGZpbmUuXCIiKTsKKwogdmFy IHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==