214304 2020-07-14 09:52:01 -0700 [iOS] Avoid loading media libraries in Document::visibilityStateChanged() if not needed 2020-07-14 12:55:53 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham cdumez darin esprehn+autocc ews-watchlist jer.noble kangil.han simon.fraser webkit-bug-importer oldest_to_newest 1671399 0 pvollan 2020-07-14 09:52:01 -0700 When the shared PlatformMediaSessionManager is created and accessed for the first time, some media libraries are loaded. There should be no need to access the shared PlatformMediaSessionManager if no manager has been created in Document::visibilityStateChanged(). 1671400 1 pvollan 2020-07-14 09:53:17 -0700 rdar://problem/65005038 1671405 2 404245 pvollan 2020-07-14 09:55:44 -0700 Created attachment 404245 Patch 1671450 3 404245 pvollan 2020-07-14 11:33:39 -0700 Comment on attachment 404245 Patch Thanks for reviewing! 1671454 4 ews-feeder 2020-07-14 11:40:22 -0700 Committed r264359: <https://trac.webkit.org/changeset/264359> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404245. 1671463 5 404245 simon.fraser 2020-07-14 12:00:45 -0700 Comment on attachment 404245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404245&action=review > Source/WebCore/dom/Document.cpp:1761 > + if (PlatformMediaSessionManager::sharedManagerIfExists()) { > + if (!PlatformMediaSessionManager::sharedManager().isInterrupted()) > + MediaStreamTrack::updateCaptureAccordingToMutedState(*this); > + } if (auto mediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists()) if (mediaSessionManager->isInterrupted()) .... 1671465 6 pvollan 2020-07-14 12:02:41 -0700 (In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 404245 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404245&action=review > > > Source/WebCore/dom/Document.cpp:1761 > > + if (PlatformMediaSessionManager::sharedManagerIfExists()) { > > + if (!PlatformMediaSessionManager::sharedManager().isInterrupted()) > > + MediaStreamTrack::updateCaptureAccordingToMutedState(*this); > > + } > > if (auto mediaSessionManager = > PlatformMediaSessionManager::sharedManagerIfExists()) > if (mediaSessionManager->isInterrupted()) > .... Yes, that is better, I will a new patch :) Thanks for reviewing! 1671468 7 pvollan 2020-07-14 12:10:13 -0700 Reopening to attach new patch. 1671469 8 404263 pvollan 2020-07-14 12:10:14 -0700 Created attachment 404263 Patch 1671485 9 ews-feeder 2020-07-14 12:55:51 -0700 Committed r264370: <https://trac.webkit.org/changeset/264370> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404263. 404245 2020-07-14 09:55:44 -0700 2020-07-14 11:40:23 -0700 Patch bug-214304-20200714095543.patch text/plain 1783 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NDM0NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA3LTE0ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBdm9pZCBsb2Fk aW5nIG1lZGlhIGxpYnJhcmllcyBpbiBEb2N1bWVudDo6dmlzaWJpbGl0eVN0YXRlQ2hhbmdlZCgp IGlmIG5vdCBuZWVkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxNDMwNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjUwMDUwMzg+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB0aGUgc2hhcmVk IFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciBpcyBjcmVhdGVkIGFuZCBhY2Nlc3NlZCBmb3Ig dGhlIGZpcnN0IHRpbWUsIHNvbWUgbWVkaWEgbGlicmFyaWVzIGFyZSBsb2FkZWQuIFRoZXJlIHNo b3VsZCBiZQorICAgICAgICBubyBuZWVkIHRvIGFjY2VzcyB0aGUgc2hhcmVkIFBsYXRmb3JtTWVk aWFTZXNzaW9uTWFuYWdlciBpZiBubyBtYW5hZ2VyIGhhcyBiZWVuIGNyZWF0ZWQgaW4gRG9jdW1l bnQ6OnZpc2liaWxpdHlTdGF0ZUNoYW5nZWQoKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHNp bmNlIHRoaXMgcGF0Y2ggZG9lcyBub3QgY2hhbmdlIGJlaGF2aW9yLgorCisgICAgICAgICogZG9t L0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp2aXNpYmlsaXR5U3Rh dGVDaGFuZ2VkKToKKwogMjAyMC0wNy0xNCAgQ2xhcmsgV2FuZyAgPGNsYXJrX3dhbmdAYXBwbGUu Y29tPgogCiAgICAgICAgIFVwZGF0ZWQgQXVkaW9Db250ZXh0IGNvbnN0cnVjdG9yIGFjY29yZGlu ZyB0byBzcGVjCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDI2NDIyMSkK KysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3 NTUsOCArMTc1NSwxMCBAQCB2b2lkIERvY3VtZW50Ojp2aXNpYmlsaXR5U3RhdGVDaGFuZ2VkKCkK ICAgICAgICAgY2xpZW50LT52aXNpYmlsaXR5U3RhdGVDaGFuZ2VkKCk7CiAKICNpZiBFTkFCTEUo TUVESUFfU1RSRUFNKSAmJiBQTEFURk9STShJT1NfRkFNSUxZKQotICAgIGlmICghUGxhdGZvcm1N ZWRpYVNlc3Npb25NYW5hZ2VyOjpzaGFyZWRNYW5hZ2VyKCkuaXNJbnRlcnJ1cHRlZCgpKQotICAg ICAgICBNZWRpYVN0cmVhbVRyYWNrOjp1cGRhdGVDYXB0dXJlQWNjb3JkaW5nVG9NdXRlZFN0YXRl KCp0aGlzKTsKKyAgICBpZiAoUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpzaGFyZWRNYW5h Z2VySWZFeGlzdHMoKSkgeworICAgICAgICBpZiAoIVBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdl cjo6c2hhcmVkTWFuYWdlcigpLmlzSW50ZXJydXB0ZWQoKSkKKyAgICAgICAgICAgIE1lZGlhU3Ry ZWFtVHJhY2s6OnVwZGF0ZUNhcHR1cmVBY2NvcmRpbmdUb011dGVkU3RhdGUoKnRoaXMpOworICAg IH0KICNlbmRpZgogfQogCg== 404263 2020-07-14 12:10:14 -0700 2020-07-14 12:55:52 -0700 Patch bug-214304-20200714121013.patch text/plain 1496 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NDM2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA3LTE0ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBBdm9pZCBsb2Fk aW5nIG1lZGlhIGxpYnJhcmllcyBpbiBEb2N1bWVudDo6dmlzaWJpbGl0eVN0YXRlQ2hhbmdlZCgp IGlmIG5vdCBuZWVkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxNDMwNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjUwMDUwMzg+CisKKyAgICAg ICAgVW5yZXZpZXdlZCwgYWRkcmVzcyBhZGRpdGlvbmFsIHJldmlldyBjb21tZW50cy4KKworICAg ICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6dmlz aWJpbGl0eVN0YXRlQ2hhbmdlZCk6CisKIDIwMjAtMDctMTQgIFNhaWQgQWJvdS1IYWxsYXdhICA8 c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBXaGVuIGludmFsaWRhdGluZyB0aGUg Y2xpZW50cyBvZiBhbiBTVkcgcmVzb3VyY2Ugd2Ugc2hvdWxkIG5vdCBnbyBiZXlvbmQgdGhlIFJl bmRlclNWR1Jvb3QKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkocmV2aXNpb24gMjY0MzY1 KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTc1OCw4ICsxNzU4LDggQEAgdm9pZCBEb2N1bWVudDo6dmlzaWJpbGl0eVN0YXRlQ2hhbmdlZCgp CiAgICAgICAgIGNsaWVudC0+dmlzaWJpbGl0eVN0YXRlQ2hhbmdlZCgpOwogCiAjaWYgRU5BQkxF KE1FRElBX1NUUkVBTSkgJiYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKLSAgICBpZiAoUGxhdGZvcm1N ZWRpYVNlc3Npb25NYW5hZ2VyOjpzaGFyZWRNYW5hZ2VySWZFeGlzdHMoKSkgewotICAgICAgICBp ZiAoIVBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2hhcmVkTWFuYWdlcigpLmlzSW50ZXJy dXB0ZWQoKSkKKyAgICBpZiAoYXV0byBtZWRpYVNlc3Npb25NYW5hZ2VyID0gUGxhdGZvcm1NZWRp YVNlc3Npb25NYW5hZ2VyOjpzaGFyZWRNYW5hZ2VySWZFeGlzdHMoKSkgeworICAgICAgICBpZiAo IW1lZGlhU2Vzc2lvbk1hbmFnZXItPmlzSW50ZXJydXB0ZWQoKSkKICAgICAgICAgICAgIE1lZGlh U3RyZWFtVHJhY2s6OnVwZGF0ZUNhcHR1cmVBY2NvcmRpbmdUb011dGVkU3RhdGUoKnRoaXMpOwog ICAgIH0KICNlbmRpZgo=