214298 2020-07-14 02:27:59 -0700 [JSC] Remove compiler warning in JSBigInt 2020-07-14 09:56:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 xan.lopez webkit-unassigned ews-watchlist keith_miller mark.lam msaboff saam sam tzagallo webkit-bug-importer xan.lopez oldest_to_newest 1671304 0 xan.lopez 2020-07-14 02:27:59 -0700 We are ASSERTing >= 0 with an unsigned int, which is redundant. This has been around for a while. [120/188] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore...DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f2e18ffc-17.cpp.o In file included from DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:32, from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:26, from ../../Source/JavaScriptCore/config.h:38, from ../../Source/JavaScriptCore/runtime/JSAsyncGenerator.cpp:26, from DerivedSources/JavaScriptCore/unified-sources/UnifiedSource-f2e18ffc-17.cpp:1: ../../Source/JavaScriptCore/runtime/JSBigInt.cpp: In instantiation of ‘static JSC::JSValue JSC::JSBigInt::parseInt(JSC::JSGlobalObject*, JSC::VM&, CharType*, unsigned int, unsigned int, unsigned int, JSC::JSBigInt::ErrorParseMode, JSC::JSBigInt::ParseIntSign, JSC::JSBigInt::ParseIntMode) [with CharType = const unsigned char]’: ../../Source/JavaScriptCore/runtime/JSBigInt.cpp:329:145: required from here ../../Source/JavaScriptCore/runtime/JSBigInt.cpp:2422:19: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits] 2422 | ASSERT(length >= 0); DerivedSources/ForwardingHeaders/wtf/Assertions.h:346:11: note: in definition of macro ‘ASSERT’ 346 | if (!(assertion)) { \ | ^~~~~~~~~ 1671305 1 404217 xan.lopez 2020-07-14 02:29:21 -0700 Created attachment 404217 Remove warning in JSBigInt Remove warning. 1671404 2 ews-feeder 2020-07-14 09:55:26 -0700 Committed r264346: <https://trac.webkit.org/changeset/264346> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404217. 1671406 3 webkit-bug-importer 2020-07-14 09:56:19 -0700 <rdar://problem/65548727> 404217 2020-07-14 02:29:21 -0700 2020-07-14 09:55:27 -0700 Remove warning in JSBigInt 0001-JSC-Remove-compiler-warning-in-JSBigInt.patch text/plain 1928 xan.lopez RnJvbSBiYzJmMmQzZTk1ODU5OWM4YjkxYTZiNGZhZGUzMjgwODVhMmE5OTNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/WGFuPTIwTD1DMz1CM3Blej89IDx4YW5AaWdh bGlhLmNvbT4KRGF0ZTogVHVlLCAxNCBKdWwgMjAyMCAxMToyODo0NyArMDIwMApTdWJqZWN0OiBb UEFUQ0hdIFtKU0NdIFJlbW92ZSBjb21waWxlciB3YXJuaW5nIGluIEpTQmlnSW50CiBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0Mjk4CgpSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KCiogcnVudGltZS9KU0JpZ0ludC5jcHA6CihKU0M6OkpTQmlnSW50OjpwYXJz ZUludCk6IG5vIG5lZWQgdG8gQVNTRVJUID49IDAgd2l0aCBhbiB1bnNpZ25lZCBpbnQuCi0tLQog U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgIHwgMTAgKysrKysrKysr KwogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNCaWdJbnQuY3BwIHwgIDEgLQogMiBm aWxlcyBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKaW5kZXggZjAzMzg1ZjI2MjFlLi5lZTgzYmFlNzBjYjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA3LTE0ICBYYW4gTG9wZXogIDx4 YW5AaWdhbGlhLmNvbT4KKworICAgICAgICBbSlNDXSBSZW1vdmUgY29tcGlsZXIgd2FybmluZyBp biBKU0JpZ0ludAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE0Mjk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBydW50aW1lL0pTQmlnSW50LmNwcDoKKyAgICAgICAgKEpTQzo6SlNCaWdJbnQ6OnBhcnNl SW50KTogbm8gbmVlZCB0byBBU1NFUlQgPj0gMCB3aXRoIGFuIHVuc2lnbmVkIGludC4KKwogMjAy MC0wNy0xNCAgWGFuIExvcGV6ICA8eGFuQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0pTQ10gQWRk IHN1cHBvcnQgZm9yIHN0YXRpYyBwcml2YXRlIGNsYXNzIGZpZWxkcwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNCaWdJbnQuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNCaWdJbnQuY3BwCmluZGV4IGI4ZGYyZWZkZDAyNS4uMzk3ZWEwMTJj YTJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0JpZ0ludC5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNCaWdJbnQuY3BwCkBAIC0y NDE5LDcgKzI0MTksNiBAQCBKU1ZhbHVlIEpTQmlnSW50OjpwYXJzZUludChKU0dsb2JhbE9iamVj dCogZ2xvYmFsT2JqZWN0LCBDaGFyVHlwZSogIGRhdGEsIHVuc2lnbgogdGVtcGxhdGUgPHR5cGVu YW1lIENoYXJUeXBlPgogSlNWYWx1ZSBKU0JpZ0ludDo6cGFyc2VJbnQoSlNHbG9iYWxPYmplY3Qq IG51bGxPckdsb2JhbE9iamVjdEZvck9PTSwgVk0mIHZtLCBDaGFyVHlwZSogZGF0YSwgdW5zaWdu ZWQgbGVuZ3RoLCB1bnNpZ25lZCBzdGFydEluZGV4LCB1bnNpZ25lZCByYWRpeCwgRXJyb3JQYXJz ZU1vZGUgZXJyb3JQYXJzZU1vZGUsIFBhcnNlSW50U2lnbiBzaWduLCBQYXJzZUludE1vZGUgcGFy c2VNb2RlKQogewotICAgIEFTU0VSVChsZW5ndGggPj0gMCk7CiAgICAgdW5zaWduZWQgcCA9IHN0 YXJ0SW5kZXg7CiAKICAgICBpZiAocGFyc2VNb2RlICE9IFBhcnNlSW50TW9kZTo6QWxsb3dFbXB0 eVN0cmluZyAmJiBzdGFydEluZGV4ID09IGxlbmd0aCkgewotLSAKMi4yNi4yCgo=