214292 2020-07-13 21:36:48 -0700 WPT test css/css-flexbox/flex-minimum-height-flex-items-023.html fails 2022-05-26 12:59:15 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 136754 240970 1 clopez svillar cdumez changseok esprehn+autocc ews-watchlist glenn jfernandez kondapallykalyan pdr philip rego simon.fraser svillar webkit-bug-importer youennf oldest_to_newest 1671279 0 clopez 2020-07-13 21:36:48 -0700 WPT ref-test css/css-flexbox/flex-minimum-height-flex-items-023.html which has been imported in bug 214284 fails on WebKit. The failure on wpt.fyi: https://wpt.fyi/results/css/css-flexbox/flex-minimum-height-flex-items-023.html?label=master&label=experimental&product=chrome&product=edge&product=firefox&product=safari&product=webkitgtk&aligned&q=css%2Fcss-flexbox%2Fflex-minimum-height-flex-items-023.html 1673372 1 webkit-bug-importer 2020-07-20 21:37:14 -0700 <rdar://problem/65864835> 1700972 2 philip 2020-10-23 03:00:48 -0700 The origin of this test is https://bugs.chromium.org/p/chromium/issues/detail?id=1088223, and that might provide clues about what's wrong. There's a very detailed comment in the test itself as well. 1700982 3 svillar 2020-10-23 04:37:08 -0700 (In reply to Philip Jägenstedt from comment #2) > The origin of this test is > https://bugs.chromium.org/p/chromium/issues/detail?id=1088223, and that > might provide clues about what's wrong. There's a very detailed comment in > the test itself as well. Do you think this particular one is a good target from the browsers interoperability POV? Sometimes it's quite difficult to know what's important for web authors and how to priorize bug fixing. 1701364 4 philip 2020-10-26 01:56:39 -0700 Because this was reported as a regression by someone I assume to be a web developer, this situation is something we can be pretty sure has affected at least one person on the real web. Beyond that, it involves the sizing of image as a flex item (although it's also a flex container?) and that's something that came up multiple times in https://mdn-web-dna.s3-us-west-2.amazonaws.com/MDN-Browser-Compatibility-Report-2020.pdf So without going out to look for this case in the wild, I'd say it seems worth investigation at least. More generally with Flexbox, since the signals that it's a pain for web developers are so strong, I'd just err on the side of aligning implementations, and treating as low priority mostly tests that originated from browser vendors or standards folks as an edge case which seems exceedingly unlikely to happen in the wild. 1734409 5 421822 svillar 2021-03-01 07:25:40 -0800 Created attachment 421822 Patch 1734782 6 421914 svillar 2021-03-02 01:30:47 -0800 Created attachment 421914 Patch 1735806 7 421914 jfernandez 2021-03-04 06:27:27 -0800 Comment on attachment 421914 Patch View in context: https://b.webkit.org/attachment.cgi?id=421914&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:432 > + bool childBlockSizeIsEquivalentToAutomaticSize = !mainAxisIsChildInlineAxis(child) && (minSize.isMinContent() || minSize.isMaxContent() || minSize.isFitContent()); I don't understand why we are chceking the block-size in case of an item orthogonal to the main-axis. Is this function meant to evaluate the item's main-axis size ? > Source/WebCore/rendering/RenderFlexibleBox.cpp:1202 > + if (min.isSpecified() || (min.isIntrinsic() && mainAxisIsChildInlineAxis(child))) Again could to elaborate on why we are not considering the case of flex items orthogonal to the main-axis ? 1735828 8 421914 svillar 2021-03-04 08:02:35 -0800 Comment on attachment 421914 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421914&action=review >> Source/WebCore/rendering/RenderFlexibleBox.cpp:432 >> + bool childBlockSizeIsEquivalentToAutomaticSize = !mainAxisIsChildInlineAxis(child) && (minSize.isMinContent() || minSize.isMaxContent() || minSize.isFitContent()); > > I don't understand why we are chceking the block-size in case of an item orthogonal to the main-axis. Is this function meant to evaluate the item's main-axis size ? Yes, min-size auto special handling in flexbox only affects the main axis 1736018 9 421914 jfernandez 2021-03-04 14:22:05 -0800 Comment on attachment 421914 Patch View in context: https://b.webkit.org/attachment.cgi?id=421914&action=review r=me > Source/WebCore/rendering/RenderFlexibleBox.cpp:433 > + if (!minSize.isAuto() && !childBlockSizeIsEquivalentToAutomaticSize) Just a suggestion, not a strong opinion; what about this ways ? return minSize.IsAuto() || childBlockSizeIsEquivalentToAutomaticSize() ? mainAxisOverflowForChild(child) == Overflow::Visible : false; I wouldn't mind to use an if instead, but using the an affirmative clause, like this: if (minSize.IsAuto() || childBlockSizeIsEquivalentToAutomaticSize()) return mainAxisOverflowForChild(child) == Overflow::Visible; return false; Or even better, like this return (minSize.IsAuto() || childBlockSizeIsEquivalentToAutomaticSize()) && mainAxisOverflowForChild(child) == Overflow::Visible; 1736262 10 svillar 2021-03-05 02:19:12 -0800 Committed r273955 (234903@main): <https://commits.webkit.org/234903@main> 421822 2021-03-01 07:25:40 -0800 2021-03-02 01:30:41 -0800 Patch bug-214292-20210301162538.patch text/plain 5068 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjczNjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjAzNWJkZDQ3ODAzYjBh ODNjMmQ4NDI1MjUyODkyYzdmN2FmNDE2ZS4uMDhmZTE5ZDBjODdlNTM3MGY0ZDFjZTBlNWJlNTMx MGJiZTQzNjc2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTAzLTAxICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFdQVCB0ZXN0 IGNzcy9jc3MtZmxleGJveC9mbGV4LW1pbmltdW0taGVpZ2h0LWZsZXgtaXRlbXMtMDIzLmh0bWwg ZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx NDI5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENT UyBmbGV4IHNwZWNzIGRlZmluZSBob3cgdG8gY29tcHV0ZSB0aGUgbWFpbiBheGlzIGF1dG9tYXRp YyBtaW5pbXVtIHNpemUgb2YgYSBmbGV4IGl0ZW0gaW4gb3JkZXIgdG8KKyAgICAgICAgcHJvdmlk ZSBhIG1vcmUgcmVhc29uYWJsZSBtaW5pbXVtIHNpemUgKGFzIGdyaWQgZG9lcykuIFNvIGZhciB3 ZSd2ZSBjb25zaWRlcmVkICJhdXRvbWF0aWMgbWluaW11bSBzaXplIgorICAgICAgICBhcyBlaXRo ZXIgbWluLXt3aWR0aHxoZWlnaHR9OmF1dG8uIEhvd2V2ZXIgdGhlIGNzcy1zaXppbmctMyBzcGVj cyBtZW50aW9uIHRoYXQgZm9yIHRoZSBibG9jayBzaXplCisgICAgICAgIGVpdGhlciBtaW4tY29u dGVudCwgbWF4LWNvbnRlbnQgb3IgZml0LWNvbnRlbnQgYXJlICh1bmxlc3Mgb3RoZXJ3aXNlIHNw ZWNpZmllZCkgZXF1aXZhbGVudCB0byB0aGUKKyAgICAgICAgYXV0b21hdGljIHNpemUgKHNlZSBo dHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLXNpemluZy0zLyN2YWxkZWYtd2lkdGgtbWluLWNv bnRlbnQpLgorCisgICAgICAgIFRoaXMgbWVhbnMgdGhhdCB3ZSBuZWVkIHRvIGV4cGFuZCBvdXIg Y2hlY2sgdG8gY29uc2lkZXIgdGhvc2UgaW50cmluc2ljIHNpemVzIGFzIGF1dG9tYXRpYyB3aGVu ZXZlciB0aGUKKyAgICAgICAgYmxvY2sgYXhpcyBvZiB0aGUgZmxleCBpdGVtIGlzIHRoZSBmbGV4 YmlibGUgYm94IG1haW4gc2l6ZS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbGV4aWJs ZUJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbGV4aWJsZUJveDo6c2hvdWxkQXBw bHlNaW5TaXplQXV0b0ZvckNoaWxkIGNvbnN0KTogQ29uc2lkZXIgaW50cmluc2ljIHNpemVzIGFz IGF1dG9tYXRpYworICAgICAgICBpbiBjYXNlIHRoZSBjaGlsZCBibG9jayBheGlzIGlzIHRoZSBm bGV4IGNvbnRhaW5lciBtYWluIGF4aXMuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbGV4aWJs ZUJveDo6YWRqdXN0Q2hpbGRTaXplRm9yTWluQW5kTWF4KTogTGV0IGludHJpbnNpYyBzaXplcyBi ZSBoYW5kbGVkIGJ5IHRoZSBjb2RlCisgICAgICAgIHRoYXQgY29tcHV0ZXMgbWluLXNpemU6YXV0 by4KKwogMjAyMS0wMy0wMSAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAg IENoYW5nZSBvcmRlciBpbiBSZW5kZXJCbG9jazo6YXZhaWxhYmxlTG9naWNhbEhlaWdodEZvclBl cmNlbnRhZ2VDb21wdXRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckZsZXhpYmxlQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJG bGV4aWJsZUJveC5jcHAKaW5kZXggZDNjZDIyOGM1NmI5MzM5MmNkZjBkYzQ3NDM2YTA5MDIzYzFm N2MyNC4uMjMxMzYwYmUxOGQzZjM3ZTg2MDIyOTEwZmIwYjlkZDQwYWZhYWYzNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwCkBAIC00MjQsMTEg KzQyNCwxNiBAQCBib29sIFJlbmRlckZsZXhpYmxlQm94Ojppc011bHRpbGluZSgpIGNvbnN0CiAg ICAgcmV0dXJuIHN0eWxlKCkuZmxleFdyYXAoKSAhPSBGbGV4V3JhcDo6Tm9XcmFwOwogfQogCisv LyBodHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLWZsZXhib3gvI21pbi1zaXplLWF1dG8KIGJv b2wgUmVuZGVyRmxleGlibGVCb3g6OnNob3VsZEFwcGx5TWluU2l6ZUF1dG9Gb3JDaGlsZChjb25z dCBSZW5kZXJCb3gmIGNoaWxkKSBjb25zdAogewotICAgIC8vIGNzcy1mbGV4Ym94IHNlY3Rpb24g NC41CiAgICAgYXV0byBtaW5TaXplID0gbWFpblNpemVMZW5ndGhGb3JDaGlsZChNaW5TaXplLCBj aGlsZCk7Ci0gICAgcmV0dXJuIG1pblNpemUuaXNBdXRvKCkgJiYgbWFpbkF4aXNPdmVyZmxvd0Zv ckNoaWxkKGNoaWxkKSA9PSBPdmVyZmxvdzo6VmlzaWJsZTsKKyAgICAvLyBtaW4sIG1heCBhbmQg Zml0LWNvbnRlbnQgYXJlIGVxdWl2YWxlbnQgdG8gdGhlIGF1dG9tYXRpYyBzaXplIGZvciBibG9j ayBzaXplcyBodHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLXNpemluZy0zLyN2YWxkZWYtd2lk dGgtbWluLWNvbnRlbnQuCisgICAgYm9vbCBjaGlsZEJsb2NrU2l6ZUlzRXF1aXZhbGVudFRvQXV0 b21hdGljU2l6ZSAgPSAhbWFpbkF4aXNJc0NoaWxkSW5saW5lQXhpcyhjaGlsZCkgJiYgKG1pblNp emUuaXNNaW5Db250ZW50KCkgfHwgbWluU2l6ZS5pc01heENvbnRlbnQoKSB8fCBtaW5TaXplLmlz Rml0Q29udGVudCgpKTsKKyAgICBpZiAoIW1pblNpemUuaXNBdXRvKCkgJiYgIWNoaWxkQmxvY2tT aXplSXNFcXVpdmFsZW50VG9BdXRvbWF0aWNTaXplKQorICAgICAgICByZXR1cm4gZmFsc2U7CisK KyAgICByZXR1cm4gbWFpbkF4aXNPdmVyZmxvd0ZvckNoaWxkKGNoaWxkKSA9PSBPdmVyZmxvdzo6 VmlzaWJsZTsKIH0KIAogTGVuZ3RoIFJlbmRlckZsZXhpYmxlQm94OjpmbGV4QmFzaXNGb3JDaGls ZChjb25zdCBSZW5kZXJCb3gmIGNoaWxkKSBjb25zdApAQCAtMTE5Myw3ICsxMTk4LDcgQEAgTGF5 b3V0VW5pdCBSZW5kZXJGbGV4aWJsZUJveDo6YWRqdXN0Q2hpbGRTaXplRm9yTWluQW5kTWF4KGNv bnN0IFJlbmRlckJveCYgY2hpbGQKICAgICB9CiAKICAgICBMZW5ndGggbWluID0gbWFpblNpemVM ZW5ndGhGb3JDaGlsZChNaW5TaXplLCBjaGlsZCk7Ci0gICAgaWYgKG1pbi5pc1NwZWNpZmllZE9y SW50cmluc2ljKCkpCisgICAgaWYgKG1pbi5pc1NwZWNpZmllZCgpKQogICAgICAgICByZXR1cm4g c3RkOjptYXgoY2hpbGRTaXplLCBzdGQ6Om1heCgwX2x1LCBjb21wdXRlTWFpbkF4aXNFeHRlbnRG b3JDaGlsZChjaGlsZCwgTWluU2l6ZSwgbWluKS52YWx1ZU9yKGNoaWxkU2l6ZSkpKTsKICAgICAK ICAgICBpZiAoc2hvdWxkQXBwbHlNaW5TaXplQXV0b0ZvckNoaWxkKGNoaWxkKSkgewpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4 IGI0YWE1NjY5OGVlMjk1YzFhOTZlZTJiZWVhY2JlZmI5NzMwNWJhM2UuLmJlOGUwYmQzYThhNmJj NGUxZDNiMTYyZmYzZTgyMGQ4OTgwMmYzNjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMS0w My0wMSAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KKworICAgICAg ICBXUFQgdGVzdCBjc3MvY3NzLWZsZXhib3gvZmxleC1taW5pbXVtLWhlaWdodC1mbGV4LWl0ZW1z LTAyMy5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTQyOTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFRlc3RFeHBlY3RhdGlvbnM6IFVuc2tpcHBlZCB0aGUgdGVzdCB0aGF0IHBhc3Nl cyBub3cuCisKIDIwMjEtMDMtMDEgIENocmlzIEdhbWJyZWxsICA8Y2dhbWJyZWxsQGFwcGxlLmNv bT4KIAogICAgICAgICBbTGF5b3V0VGVzdHNdIENvbnZlcnQgaHR0cC90ZXN0cy9mZXRjaCBjb252 ZXJ0IFBIUCB0byBQeXRob24KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlv bnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGQ5NWQ0MGY2MTNjZjc3ODFl NDFjZWYwM2RmNzllN2I2MzY0Njk0ZjMuLmNkODBiMDU3ODE1NGE2NzUxZmYzMjhkMmVmYWVjOWI5 ZjkwMTYyMGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIv TGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNDEyMiw4ICs0MTIyLDYgQEAgZmFzdC90 ZXh0L3RleHQtc3R5bGVzLy1hcHBsZS1zeXN0ZW0gWyBJbWFnZU9ubHlGYWlsdXJlIF0KICMgQXJ0 aWZpY2lhbCB3ZWIgc29ja2V0IGRlbGF5cyBhcmUgb25seSBzdXBwb3J0ZWQgb24gd2syLiAKIGh0 dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvY2xvc2VkLXBvcnQtZGVsYXkuaHRtbCBbIFNr aXAgXQogCi13ZWJraXQub3JnL2IvMjE0MjkyIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvY3NzL2Nzcy1mbGV4Ym94L2ZsZXgtbWluaW11bS1oZWlnaHQtZmxleC1pdGVtcy0wMjMuaHRt bCBbIEltYWdlT25seUZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMjE0MjkxIGltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy13cml0aW5nLW1vZGVzL2Ficy1wb3Mtd2l0aC1y ZXBsYWNlZC1jaGlsZC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjE0 MjkxIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy13cml0aW5nLW1vZGVz L2F2YWlsYWJsZS1zaXplLTAwNC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3Jn L2IvMjE0MjkxIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy13cml0aW5n LW1vZGVzL2F2YWlsYWJsZS1zaXplLTAxOC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCg== 421914 2021-03-02 01:30:47 -0800 2021-03-04 14:22:05 -0800 Patch bug-214292-20210302103045.patch text/plain 5217 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjczNjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjAzNWJkZDQ3ODAzYjBh ODNjMmQ4NDI1MjUyODkyYzdmN2FmNDE2ZS4uMDhmZTE5ZDBjODdlNTM3MGY0ZDFjZTBlNWJlNTMx MGJiZTQzNjc2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTAzLTAxICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFdQVCB0ZXN0 IGNzcy9jc3MtZmxleGJveC9mbGV4LW1pbmltdW0taGVpZ2h0LWZsZXgtaXRlbXMtMDIzLmh0bWwg ZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx NDI5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENT UyBmbGV4IHNwZWNzIGRlZmluZSBob3cgdG8gY29tcHV0ZSB0aGUgbWFpbiBheGlzIGF1dG9tYXRp YyBtaW5pbXVtIHNpemUgb2YgYSBmbGV4IGl0ZW0gaW4gb3JkZXIgdG8KKyAgICAgICAgcHJvdmlk ZSBhIG1vcmUgcmVhc29uYWJsZSBtaW5pbXVtIHNpemUgKGFzIGdyaWQgZG9lcykuIFNvIGZhciB3 ZSd2ZSBjb25zaWRlcmVkICJhdXRvbWF0aWMgbWluaW11bSBzaXplIgorICAgICAgICBhcyBlaXRo ZXIgbWluLXt3aWR0aHxoZWlnaHR9OmF1dG8uIEhvd2V2ZXIgdGhlIGNzcy1zaXppbmctMyBzcGVj cyBtZW50aW9uIHRoYXQgZm9yIHRoZSBibG9jayBzaXplCisgICAgICAgIGVpdGhlciBtaW4tY29u dGVudCwgbWF4LWNvbnRlbnQgb3IgZml0LWNvbnRlbnQgYXJlICh1bmxlc3Mgb3RoZXJ3aXNlIHNw ZWNpZmllZCkgZXF1aXZhbGVudCB0byB0aGUKKyAgICAgICAgYXV0b21hdGljIHNpemUgKHNlZSBo dHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLXNpemluZy0zLyN2YWxkZWYtd2lkdGgtbWluLWNv bnRlbnQpLgorCisgICAgICAgIFRoaXMgbWVhbnMgdGhhdCB3ZSBuZWVkIHRvIGV4cGFuZCBvdXIg Y2hlY2sgdG8gY29uc2lkZXIgdGhvc2UgaW50cmluc2ljIHNpemVzIGFzIGF1dG9tYXRpYyB3aGVu ZXZlciB0aGUKKyAgICAgICAgYmxvY2sgYXhpcyBvZiB0aGUgZmxleCBpdGVtIGlzIHRoZSBmbGV4 YmlibGUgYm94IG1haW4gc2l6ZS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJGbGV4aWJs ZUJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbGV4aWJsZUJveDo6c2hvdWxkQXBw bHlNaW5TaXplQXV0b0ZvckNoaWxkIGNvbnN0KTogQ29uc2lkZXIgaW50cmluc2ljIHNpemVzIGFz IGF1dG9tYXRpYworICAgICAgICBpbiBjYXNlIHRoZSBjaGlsZCBibG9jayBheGlzIGlzIHRoZSBm bGV4IGNvbnRhaW5lciBtYWluIGF4aXMuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbGV4aWJs ZUJveDo6YWRqdXN0Q2hpbGRTaXplRm9yTWluQW5kTWF4KTogTGV0IGludHJpbnNpYyBzaXplcyBi ZSBoYW5kbGVkIGJ5IHRoZSBjb2RlCisgICAgICAgIHRoYXQgY29tcHV0ZXMgbWluLXNpemU6YXV0 by4KKwogMjAyMS0wMy0wMSAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAg IENoYW5nZSBvcmRlciBpbiBSZW5kZXJCbG9jazo6YXZhaWxhYmxlTG9naWNhbEhlaWdodEZvclBl cmNlbnRhZ2VDb21wdXRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckZsZXhpYmxlQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJG bGV4aWJsZUJveC5jcHAKaW5kZXggZDNjZDIyOGM1NmI5MzM5MmNkZjBkYzQ3NDM2YTA5MDIzYzFm N2MyNC4uOTkxMjIwZGI2MmY0NTg3YTMyMTRlOTExNTY0OGQ1N2Q3ZTQ2NzNlMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwCkBAIC00MjQsMTEg KzQyNCwxNiBAQCBib29sIFJlbmRlckZsZXhpYmxlQm94Ojppc011bHRpbGluZSgpIGNvbnN0CiAg ICAgcmV0dXJuIHN0eWxlKCkuZmxleFdyYXAoKSAhPSBGbGV4V3JhcDo6Tm9XcmFwOwogfQogCisv LyBodHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLWZsZXhib3gvI21pbi1zaXplLWF1dG8KIGJv b2wgUmVuZGVyRmxleGlibGVCb3g6OnNob3VsZEFwcGx5TWluU2l6ZUF1dG9Gb3JDaGlsZChjb25z dCBSZW5kZXJCb3gmIGNoaWxkKSBjb25zdAogewotICAgIC8vIGNzcy1mbGV4Ym94IHNlY3Rpb24g NC41CiAgICAgYXV0byBtaW5TaXplID0gbWFpblNpemVMZW5ndGhGb3JDaGlsZChNaW5TaXplLCBj aGlsZCk7Ci0gICAgcmV0dXJuIG1pblNpemUuaXNBdXRvKCkgJiYgbWFpbkF4aXNPdmVyZmxvd0Zv ckNoaWxkKGNoaWxkKSA9PSBPdmVyZmxvdzo6VmlzaWJsZTsKKyAgICAvLyBtaW4sIG1heCBhbmQg Zml0LWNvbnRlbnQgYXJlIGVxdWl2YWxlbnQgdG8gdGhlIGF1dG9tYXRpYyBzaXplIGZvciBibG9j ayBzaXplcyBodHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLXNpemluZy0zLyN2YWxkZWYtd2lk dGgtbWluLWNvbnRlbnQuCisgICAgYm9vbCBjaGlsZEJsb2NrU2l6ZUlzRXF1aXZhbGVudFRvQXV0 b21hdGljU2l6ZSAgPSAhbWFpbkF4aXNJc0NoaWxkSW5saW5lQXhpcyhjaGlsZCkgJiYgKG1pblNp emUuaXNNaW5Db250ZW50KCkgfHwgbWluU2l6ZS5pc01heENvbnRlbnQoKSB8fCBtaW5TaXplLmlz Rml0Q29udGVudCgpKTsKKyAgICBpZiAoIW1pblNpemUuaXNBdXRvKCkgJiYgIWNoaWxkQmxvY2tT aXplSXNFcXVpdmFsZW50VG9BdXRvbWF0aWNTaXplKQorICAgICAgICByZXR1cm4gZmFsc2U7CisK KyAgICByZXR1cm4gbWFpbkF4aXNPdmVyZmxvd0ZvckNoaWxkKGNoaWxkKSA9PSBPdmVyZmxvdzo6 VmlzaWJsZTsKIH0KIAogTGVuZ3RoIFJlbmRlckZsZXhpYmxlQm94OjpmbGV4QmFzaXNGb3JDaGls ZChjb25zdCBSZW5kZXJCb3gmIGNoaWxkKSBjb25zdApAQCAtMTE5Myw3ICsxMTk4LDggQEAgTGF5 b3V0VW5pdCBSZW5kZXJGbGV4aWJsZUJveDo6YWRqdXN0Q2hpbGRTaXplRm9yTWluQW5kTWF4KGNv bnN0IFJlbmRlckJveCYgY2hpbGQKICAgICB9CiAKICAgICBMZW5ndGggbWluID0gbWFpblNpemVM ZW5ndGhGb3JDaGlsZChNaW5TaXplLCBjaGlsZCk7Ci0gICAgaWYgKG1pbi5pc1NwZWNpZmllZE9y SW50cmluc2ljKCkpCisgICAgLy8gSW50cmluc2ljIHNpemVzIGluIGNoaWxkJ3MgYmxvY2sgYXhp cyBhcmUgaGFuZGxlZCBieSB0aGUgbWluLXNpemU6YXV0byBjb2RlIHBhdGguCisgICAgaWYgKG1p bi5pc1NwZWNpZmllZCgpIHx8IChtaW4uaXNJbnRyaW5zaWMoKSAmJiBtYWluQXhpc0lzQ2hpbGRJ bmxpbmVBeGlzKGNoaWxkKSkpCiAgICAgICAgIHJldHVybiBzdGQ6Om1heChjaGlsZFNpemUsIHN0 ZDo6bWF4KDBfbHUsIGNvbXB1dGVNYWluQXhpc0V4dGVudEZvckNoaWxkKGNoaWxkLCBNaW5TaXpl LCBtaW4pLnZhbHVlT3IoY2hpbGRTaXplKSkpOwogICAgIAogICAgIGlmIChzaG91bGRBcHBseU1p blNpemVBdXRvRm9yQ2hpbGQoY2hpbGQpKSB7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjRhYTU2Njk4ZWUyOTVjMWE5NmVl MmJlZWFjYmVmYjk3MzA1YmEzZS4uYmU4ZTBiZDNhOGE2YmM0ZTFkM2IxNjJmZjNlODIwZDg5ODAy ZjM2NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTAzLTAxICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFdQVCB0ZXN0IGNzcy9jc3MtZmxl eGJveC9mbGV4LW1pbmltdW0taGVpZ2h0LWZsZXgtaXRlbXMtMDIzLmh0bWwgZmFpbHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDI5MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0 aW9uczogVW5za2lwcGVkIHRoZSB0ZXN0IHRoYXQgcGFzc2VzIG5vdy4KKwogMjAyMS0wMy0wMSAg Q2hyaXMgR2FtYnJlbGwgIDxjZ2FtYnJlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIFtMYXlvdXRU ZXN0c10gQ29udmVydCBodHRwL3Rlc3RzL2ZldGNoIGNvbnZlcnQgUEhQIHRvIFB5dGhvbgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RF eHBlY3RhdGlvbnMKaW5kZXggZDk1ZDQwZjYxM2NmNzc4MWU0MWNlZjAzZGY3OWU3YjYzNjQ2OTRm My4uY2Q4MGIwNTc4MTU0YTY3NTFmZjMyOGQyZWZhZWM5YjlmOTAxNjIwYiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0 YXRpb25zCkBAIC00MTIyLDggKzQxMjIsNiBAQCBmYXN0L3RleHQvdGV4dC1zdHlsZXMvLWFwcGxl LXN5c3RlbSBbIEltYWdlT25seUZhaWx1cmUgXQogIyBBcnRpZmljaWFsIHdlYiBzb2NrZXQgZGVs YXlzIGFyZSBvbmx5IHN1cHBvcnRlZCBvbiB3azIuIAogaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVz dHMvaHliaS9jbG9zZWQtcG9ydC1kZWxheS5odG1sIFsgU2tpcCBdCiAKLXdlYmtpdC5vcmcvYi8y MTQyOTIgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvZmxl eC1taW5pbXVtLWhlaWdodC1mbGV4LWl0ZW1zLTAyMy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBd Ci0KIHdlYmtpdC5vcmcvYi8yMTQyOTEgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9j c3MvY3NzLXdyaXRpbmctbW9kZXMvYWJzLXBvcy13aXRoLXJlcGxhY2VkLWNoaWxkLmh0bWwgWyBJ bWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMTQyOTEgaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXdyaXRpbmctbW9kZXMvYXZhaWxhYmxlLXNpemUtMDA0Lmh0 bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMTQyOTEgaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXdyaXRpbmctbW9kZXMvYXZhaWxhYmxlLXNpemUt MDE4Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0K