214279 2020-07-13 15:05:22 -0700 [ews] watchos should build both arm64_32 and armv7k architectures 2020-07-14 12:31:02 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214147 https://bugs.webkit.org/show_bug.cgi?id=214306 https://bugs.webkit.org/show_bug.cgi?id=214310 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap darin jbedard keith_miller thorton webkit-bug-importer ysuzuki oldest_to_newest 1671179 0 aakash_jain 2020-07-13 15:05:22 -0700 watchos queue in EWS should build both arm64_32 and armv7k architectures. This will help in preventing build breakage on both architectures. 1671182 1 404181 aakash_jain 2020-07-13 15:09:34 -0700 Created attachment 404181 Patch 1671185 2 aakash_jain 2020-07-13 15:12:14 -0700 Sample run: https://ews-build.webkit-uat.org/#/builders/42/builds/81 1671192 3 keith_miller 2020-07-13 15:18:31 -0700 (In reply to Aakash Jain from comment #2) > Sample run: https://ews-build.webkit-uat.org/#/builders/42/builds/81 I don't see any clang invocations using armv7k? Are you sure that's right? Does it need to be a clean build? 1671199 4 darin 2020-07-13 15:28:42 -0700 I did review+ because the change looks logical and the EWS is green for watchOS. But maybe it’s not working. Keith’s question does seem relevant. 1671250 5 aakash_jain 2020-07-13 18:08:57 -0700 (In reply to Keith Miller from comment #3) > (In reply to Aakash Jain from comment #2) > I don't see any clang invocations using armv7k? Are you sure that's right? Does it need to be a clean build? That was due to missing parameter 'ONLY_ACTIVE_ARCH=NO'. Fixed that in https://trac.webkit.org/r264327. Current patch should be good now. However, it seems like the build is broken for armv7k, e.g.: https://ews-build.webkit-uat.org/#/builders/42/builds/93 In file included from Source/WebCore/editing/TextIterator.h:28: Source/WebCore/editing/CharacterRange.h:74:26: error: implicit conversion loses integer precision: 'const uint64_t' (aka 'const unsigned long long') to 'CFIndex' (aka 'long') [-Werror,-Wshorten-64-to-32] 1671252 6 darin 2020-07-13 18:11:14 -0700 We had a lot of breakage like this a while back. Someone changed the warning settings I think? Maybe Jonathan Bedard? 1671253 7 darin 2020-07-13 18:11:40 -0700 There are other kinds of fixes for those warnings, but I think changing the settings is what someone chose to do. 1671413 8 jbedard 2020-07-14 10:11:39 -0700 (In reply to Darin Adler from comment #6) > We had a lot of breakage like this a while back. Someone changed the warning > settings I think? Maybe Jonathan Bedard? That was the fix, although we need a bit more that that for armv7k, I'll have a patch ready on https://bugs.webkit.org/show_bug.cgi?id=214306 shortly. 1671451 9 ews-feeder 2020-07-14 11:38:50 -0700 Committed r264358: <https://trac.webkit.org/changeset/264358> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404181. 1671452 10 webkit-bug-importer 2020-07-14 11:39:14 -0700 <rdar://problem/65555319> 1671476 11 aakash_jain 2020-07-14 12:31:02 -0700 Deployed on the EWS server. Seems to be working fine, e.g.: https://ews-build.webkit.org/#/builders/41/builds/342/steps/7/logs/stdio 404181 2020-07-13 15:09:34 -0700 2020-07-14 11:38:51 -0700 Patch bug-214279-20200713180933.patch text/plain 1103 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NDMxOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIwLTA3LTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSB3YXRjaG9zIHNob3VsZCBidWlsZCBib3RoIGFybTY0XzMyIGFu ZCBhcm12N2sgYXJjaGl0ZWN0dXJlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjE0Mjc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvY29uZmlnLmpzb246 CisKIDIwMjAtMDctMTMgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLCByZS1sYW5kaW5nIHIyNjQyNDIgd2l0aCBjcmFzaCBmaXhlZC4KSW5k ZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9jb25maWcuanNvbgo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvY29uZmlnLmpzb24JKHJl dmlzaW9uIDI2NDMxOCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9jb25m aWcuanNvbgkod29ya2luZyBjb3B5KQpAQCAtNDQyLDcgKzQ0Miw3IEBACiAgICAgICAiZmFjdG9y eSI6ICJ3YXRjaE9TQnVpbGRGYWN0b3J5IiwKICAgICAgICJwbGF0Zm9ybSI6ICJ3YXRjaG9zLTYi LAogICAgICAgImNvbmZpZ3VyYXRpb24iOiAicmVsZWFzZSIsCi0gICAgICAiYXJjaGl0ZWN0dXJl cyI6IFsiYXJtNjRfMzIiXSwKKyAgICAgICJhcmNoaXRlY3R1cmVzIjogWyJhcm02NF8zMiIsICJh cm12N2siXSwKICAgICAgICJ3b3JrZXJuYW1lcyI6IFsiZXdzMTYzIiwgImV3czE2NCIsICJld3Mx NjUiXQogICAgIH0sCiAgICAgewo=