214263 2020-07-13 10:30:55 -0700 Crash under WebKit::LaunchServicesDatabaseManager::didConnect() 2020-07-13 12:42:11 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan ap bfulgham darin ggaren ryanhaddad webkit-bug-importer oldest_to_newest 1671065 0 pvollan 2020-07-13 10:30:55 -0700 There is a crash under WebKit::LaunchServicesDatabaseManager::didConnect() when trying to send a message to an invalid connection. 1671068 1 404154 pvollan 2020-07-13 10:33:56 -0700 Created attachment 404154 Patch 1671074 2 404155 pvollan 2020-07-13 10:36:31 -0700 Created attachment 404155 Patch 1671086 3 404155 darin 2020-07-13 10:52:21 -0700 Comment on attachment 404155 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404155&action=review > Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm:70 > + auto conn = connection(); WebKit coding style says: auto connection = this->connection(); 1671098 4 404161 pvollan 2020-07-13 11:34:08 -0700 Created attachment 404161 Patch 1671099 5 pvollan 2020-07-13 11:34:43 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 404155 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=404155&action=review > > > Source/WebKit/WebProcess/cocoa/LaunchServicesDatabaseManager.mm:70 > > + auto conn = connection(); > > WebKit coding style says: > > auto connection = this->connection(); Fixed. Thanks for reviewing! 1671109 6 ews-feeder 2020-07-13 12:13:09 -0700 Committed r264309: <https://trac.webkit.org/changeset/264309> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404161. 1671110 7 webkit-bug-importer 2020-07-13 12:14:15 -0700 <rdar://problem/65492080> 1671114 8 pvollan 2020-07-13 12:35:42 -0700 *** Bug 214200 has been marked as a duplicate of this bug. *** 1671116 9 ryanhaddad 2020-07-13 12:42:11 -0700 *** Bug 214227 has been marked as a duplicate of this bug. *** 404154 2020-07-13 10:33:56 -0700 2020-07-13 10:36:30 -0700 Patch bug-214263-20200713103355.patch text/plain 3012 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjQzMDMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA3LTEzICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB1bmRlciBXZWJLaXQ6 OkxhdW5jaFNlcnZpY2VzRGF0YWJhc2VNYW5hZ2VyOjpkaWRDb25uZWN0KCkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDI2MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIGEgY3Jhc2ggdW5k ZXIgV2ViS2l0OjpMYXVuY2hTZXJ2aWNlc0RhdGFiYXNlTWFuYWdlcjo6ZGlkQ29ubmVjdCgpIHdo ZW4gdHJ5aW5nIHRvIHNlbmQgYSBtZXNzYWdlIHRvIGFuIGludmFsaWQgY29ubmVjdGlvbi4KKwor ICAgICAgICBObyBuZXcgdGVzdHMsIHNpbmNlIEkgaGF2ZSBub3QgYmVlbiBhYmxlIHRvIHJlcHJv ZHVjZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvY29jb2EvTGF1bmNoU2VydmljZXNEYXRhYmFz ZU1hbmFnZXIubW06CisgICAgICAgIChXZWJLaXQ6OkxhdW5jaFNlcnZpY2VzRGF0YWJhc2VNYW5h Z2VyOjpkaWRDb25uZWN0KToKKwogMjAyMC0wNy0xMyAgWmFuIERvYmVyc2VrICA8emRvYmVyc2Vr QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBXVFIgYW5kIEFQSS10ZXN0cyB0aW1p bmcgb3V0IGFmdGVyIHIyNjQyODMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29hL1hQ Q0VuZHBvaW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9TaGFyZWQvQ29jb2EvWFBD RW5kcG9pbnQuaAkocmV2aXNpb24gMjY0MTgwKQkoZnJvbSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9jb2NvYS9YUENFbmRwb2ludC5oOjI2NDE4MCkKKysrIFNvdXJjZS9XZWJLaXQvU2hhcmVkL0Nv Y29hL1hQQ0VuZHBvaW50LmgJKHdvcmtpbmcgY29weSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvU2hh cmVkL0NvY29hL1hQQ0VuZHBvaW50Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvU2hh cmVkL0NvY29hL1hQQ0VuZHBvaW50Lm1tCShyZXZpc2lvbiAyNjQxODApCShmcm9tIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2NvY29hL1hQQ0VuZHBvaW50Lm1tOjI2NDE4MCkKKysrIFNvdXJjZS9X ZWJLaXQvU2hhcmVkL0NvY29hL1hQQ0VuZHBvaW50Lm1tCSh3b3JraW5nIGNvcHkpCkluZGV4OiBT b3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9YUENFbmRwb2ludENsaWVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29hL1hQQ0VuZHBvaW50Q2xpZW50LmgJKHJldmlz aW9uIDI2NDE4MCkJKGZyb20gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvWFBDRW5kcG9p bnRDbGllbnQuaDoyNjQxODApCisrKyBTb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9YUENFbmRw b2ludENsaWVudC5oCSh3b3JraW5nIGNvcHkpCkluZGV4OiBTb3VyY2UvV2ViS2l0L1NoYXJlZC9D b2NvYS9YUENFbmRwb2ludENsaWVudC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1No YXJlZC9Db2NvYS9YUENFbmRwb2ludENsaWVudC5tbQkocmV2aXNpb24gMjY0MTgwKQkoZnJvbSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9YUENFbmRwb2ludENsaWVudC5tbToyNjQxODAp CisrKyBTb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9YUENFbmRwb2ludENsaWVudC5tbQkod29y a2luZyBjb3B5KQpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL0xhdW5jaFNl cnZpY2VzRGF0YWJhc2VNYW5hZ2VyLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9jb2NvYS9MYXVuY2hTZXJ2aWNlc0RhdGFiYXNlTWFuYWdlci5tbQkocmV2aXNpb24g MjY0MjIxKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL0xhdW5jaFNlcnZpY2Vz RGF0YWJhc2VNYW5hZ2VyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw3ICs2NywxMSBAQCB2b2lk IExhdW5jaFNlcnZpY2VzRGF0YWJhc2VNYW5hZ2VyOjpkaWRDCiAgICAgYXV0byBtZXNzYWdlID0g YWRvcHRPU09iamVjdCh4cGNfZGljdGlvbmFyeV9jcmVhdGUobnVsbHB0ciwgbnVsbHB0ciwgMCkp OwogICAgIHhwY19kaWN0aW9uYXJ5X3NldF9zdHJpbmcobWVzc2FnZS5nZXQoKSwgWFBDRW5kcG9p bnQ6OnhwY01lc3NhZ2VOYW1lS2V5LCBMYXVuY2hTZXJ2aWNlc0RhdGFiYXNlWFBDQ29uc3RhbnRz Ojp4cGNSZXF1ZXN0TGF1bmNoU2VydmljZXNEYXRhYmFzZVVwZGF0ZU1lc3NhZ2VOYW1lKTsKIAot ICAgIHhwY19jb25uZWN0aW9uX3NlbmRfbWVzc2FnZShjb25uZWN0aW9uKCkuZ2V0KCksIG1lc3Nh Z2UuZ2V0KCkpOworICAgIGF1dG8gY29ubiA9IGNvbm5lY3Rpb24oKTsKKyAgICBpZiAoIWNvbm4p CisgICAgICAgIHJldHVybjsKKworICAgIHhwY19jb25uZWN0aW9uX3NlbmRfbWVzc2FnZShjb25u LmdldCgpLCBtZXNzYWdlLmdldCgpKTsKIH0KIAogYm9vbCBMYXVuY2hTZXJ2aWNlc0RhdGFiYXNl TWFuYWdlcjo6d2FpdEZvckRhdGFiYXNlVXBkYXRlKFNlY29uZHMgdGltZW91dCkK 404155 2020-07-13 10:36:31 -0700 2020-07-13 10:52:21 -0700 Patch bug-214263-20200713103631.patch text/plain 1768 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjQzMDMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA3LTEzICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB1bmRlciBXZWJLaXQ6 OkxhdW5jaFNlcnZpY2VzRGF0YWJhc2VNYW5hZ2VyOjpkaWRDb25uZWN0KCkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDI2MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIGEgY3Jhc2ggdW5k ZXIgV2ViS2l0OjpMYXVuY2hTZXJ2aWNlc0RhdGFiYXNlTWFuYWdlcjo6ZGlkQ29ubmVjdCgpIHdo ZW4gdHJ5aW5nIHRvIHNlbmQgYSBtZXNzYWdlIHRvIGFuIGludmFsaWQgY29ubmVjdGlvbi4KKwor ICAgICAgICBObyBuZXcgdGVzdHMsIHNpbmNlIEkgaGF2ZSBub3QgYmVlbiBhYmxlIHRvIHJlcHJv ZHVjZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvY29jb2EvTGF1bmNoU2VydmljZXNEYXRhYmFz ZU1hbmFnZXIubW06CisgICAgICAgIChXZWJLaXQ6OkxhdW5jaFNlcnZpY2VzRGF0YWJhc2VNYW5h Z2VyOjpkaWRDb25uZWN0KToKKwogMjAyMC0wNy0xMyAgWmFuIERvYmVyc2VrICA8emRvYmVyc2Vr QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBXVFIgYW5kIEFQSS10ZXN0cyB0aW1p bmcgb3V0IGFmdGVyIHIyNjQyODMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2Nv YS9MYXVuY2hTZXJ2aWNlc0RhdGFiYXNlTWFuYWdlci5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvTGF1bmNoU2VydmljZXNEYXRhYmFzZU1hbmFnZXIubW0J KHJldmlzaW9uIDI2NDIyMSkKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9MYXVu Y2hTZXJ2aWNlc0RhdGFiYXNlTWFuYWdlci5tbQkod29ya2luZyBjb3B5KQpAQCAtNjcsNyArNjcs MTEgQEAgdm9pZCBMYXVuY2hTZXJ2aWNlc0RhdGFiYXNlTWFuYWdlcjo6ZGlkQwogICAgIGF1dG8g bWVzc2FnZSA9IGFkb3B0T1NPYmplY3QoeHBjX2RpY3Rpb25hcnlfY3JlYXRlKG51bGxwdHIsIG51 bGxwdHIsIDApKTsKICAgICB4cGNfZGljdGlvbmFyeV9zZXRfc3RyaW5nKG1lc3NhZ2UuZ2V0KCks IFhQQ0VuZHBvaW50Ojp4cGNNZXNzYWdlTmFtZUtleSwgTGF1bmNoU2VydmljZXNEYXRhYmFzZVhQ Q0NvbnN0YW50czo6eHBjUmVxdWVzdExhdW5jaFNlcnZpY2VzRGF0YWJhc2VVcGRhdGVNZXNzYWdl TmFtZSk7CiAKLSAgICB4cGNfY29ubmVjdGlvbl9zZW5kX21lc3NhZ2UoY29ubmVjdGlvbigpLmdl dCgpLCBtZXNzYWdlLmdldCgpKTsKKyAgICBhdXRvIGNvbm4gPSBjb25uZWN0aW9uKCk7CisgICAg aWYgKCFjb25uKQorICAgICAgICByZXR1cm47CisKKyAgICB4cGNfY29ubmVjdGlvbl9zZW5kX21l c3NhZ2UoY29ubi5nZXQoKSwgbWVzc2FnZS5nZXQoKSk7CiB9CiAKIGJvb2wgTGF1bmNoU2Vydmlj ZXNEYXRhYmFzZU1hbmFnZXI6OndhaXRGb3JEYXRhYmFzZVVwZGF0ZShTZWNvbmRzIHRpbWVvdXQp Cg== 404161 2020-07-13 11:34:08 -0700 2020-07-13 12:13:10 -0700 Patch bug-214263-20200713113407.patch text/plain 1789 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjQzMDMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA3LTEzICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCB1bmRlciBXZWJLaXQ6 OkxhdW5jaFNlcnZpY2VzRGF0YWJhc2VNYW5hZ2VyOjpkaWRDb25uZWN0KCkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDI2MworCisgICAgICAgIFJl dmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIFRoZXJlIGlzIGEgY3Jhc2ggdW5kZXIg V2ViS2l0OjpMYXVuY2hTZXJ2aWNlc0RhdGFiYXNlTWFuYWdlcjo6ZGlkQ29ubmVjdCgpIHdoZW4g dHJ5aW5nIHRvIHNlbmQgYSBtZXNzYWdlIHRvIGFuIGludmFsaWQgY29ubmVjdGlvbi4KKworICAg ICAgICBObyBuZXcgdGVzdHMsIHNpbmNlIEkgaGF2ZSBub3QgYmVlbiBhYmxlIHRvIHJlcHJvZHVj ZS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvY29jb2EvTGF1bmNoU2VydmljZXNEYXRhYmFzZU1h bmFnZXIubW06CisgICAgICAgIChXZWJLaXQ6OkxhdW5jaFNlcnZpY2VzRGF0YWJhc2VNYW5hZ2Vy OjpkaWRDb25uZWN0KToKKwogMjAyMC0wNy0xMyAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGln YWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBXVFIgYW5kIEFQSS10ZXN0cyB0aW1pbmcg b3V0IGFmdGVyIHIyNjQyODMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9M YXVuY2hTZXJ2aWNlc0RhdGFiYXNlTWFuYWdlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvY29jb2EvTGF1bmNoU2VydmljZXNEYXRhYmFzZU1hbmFnZXIubW0JKHJl dmlzaW9uIDI2NDIyMSkKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9MYXVuY2hT ZXJ2aWNlc0RhdGFiYXNlTWFuYWdlci5tbQkod29ya2luZyBjb3B5KQpAQCAtNjcsNyArNjcsMTEg QEAgdm9pZCBMYXVuY2hTZXJ2aWNlc0RhdGFiYXNlTWFuYWdlcjo6ZGlkQwogICAgIGF1dG8gbWVz c2FnZSA9IGFkb3B0T1NPYmplY3QoeHBjX2RpY3Rpb25hcnlfY3JlYXRlKG51bGxwdHIsIG51bGxw dHIsIDApKTsKICAgICB4cGNfZGljdGlvbmFyeV9zZXRfc3RyaW5nKG1lc3NhZ2UuZ2V0KCksIFhQ Q0VuZHBvaW50Ojp4cGNNZXNzYWdlTmFtZUtleSwgTGF1bmNoU2VydmljZXNEYXRhYmFzZVhQQ0Nv bnN0YW50czo6eHBjUmVxdWVzdExhdW5jaFNlcnZpY2VzRGF0YWJhc2VVcGRhdGVNZXNzYWdlTmFt ZSk7CiAKLSAgICB4cGNfY29ubmVjdGlvbl9zZW5kX21lc3NhZ2UoY29ubmVjdGlvbigpLmdldCgp LCBtZXNzYWdlLmdldCgpKTsKKyAgICBhdXRvIGNvbm5lY3Rpb24gPSB0aGlzLT5jb25uZWN0aW9u KCk7CisgICAgaWYgKCFjb25uZWN0aW9uKQorICAgICAgICByZXR1cm47CisKKyAgICB4cGNfY29u bmVjdGlvbl9zZW5kX21lc3NhZ2UoY29ubmVjdGlvbi5nZXQoKSwgbWVzc2FnZS5nZXQoKSk7CiB9 CiAKIGJvb2wgTGF1bmNoU2VydmljZXNEYXRhYmFzZU1hbmFnZXI6OndhaXRGb3JEYXRhYmFzZVVw ZGF0ZShTZWNvbmRzIHRpbWVvdXQpCg==