214259 2020-07-13 09:56:07 -0700 REGRESSION(r264280) [GTK][WPE] fast/gradients/conic-gradient-alpha.html is failing 2020-07-16 01:22:06 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214221 P2 Normal --- 1 lmoura webkit-unassigned bugs-noreply cgarcia clopez darin oldest_to_newest 1671057 0 lmoura 2020-07-13 09:56:07 -0700 Instead of the green conics, only grayscale ones. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fgradients%2Fconic-gradient-alpha.html 1671067 1 darin 2020-07-13 10:32:26 -0700 Oops, looks like I broke this. Happy to help fix it. 1671135 2 darin 2020-07-13 13:24:01 -0700 Any indication what’s going wrong yet? 1671247 3 clopez 2020-07-13 18:00:22 -0700 It seems the generated gradient is now black&white: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r264280%20(14625)/fast/gradients/conic-gradient-alpha-diffs.html 1671251 4 darin 2020-07-13 18:10:29 -0700 Maybe a bug in the blend function? 1671719 5 cgarcia 2020-07-15 06:27:41 -0700 There are two problems: 1. Now the blend is done using premultiplied alpha, since the first color stop is #00FF0000, the premultiplied is just 0, so we always end up with black color. So, just changing to use blendWithoutPremultiply() would fix the bug but... 2. There's a bug in blendWithoutPremultiply(), from is used in both fromSRGB and toSRGB. Fixing 1 and 2 I get the right output, but the test doesn't pass yet, there's a one pixel difference for some reason. 1671720 6 404338 cgarcia 2020-07-15 06:31:13 -0700 Created attachment 404338 Patch 1671773 7 404338 darin 2020-07-15 09:48:17 -0700 Comment on attachment 404338 Patch Nice! Thanks, this seems like a great fix. 1672072 8 cgarcia 2020-07-16 01:22:06 -0700 Committed r264449: <https://trac.webkit.org/changeset/264449> 404338 2020-07-15 06:31:13 -0700 2020-07-15 09:48:17 -0700 Patch wcore-conic-gradient-cairo.diff text/plain 2584 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmZWQ4MTczYzE1YmUuLjMyNWYzZjFkNjhhYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIwLTA3LTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNjQyODApIFtHVEtdW1dQRV0gZmFz dC9ncmFkaWVudHMvY29uaWMtZ3JhZGllbnQtYWxwaGEuaHRtbCBpcyBmYWlsaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQyNTkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL0NvbG9yQmxlbmRpbmcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YmxlbmRXaXRob3V0UHJl bXVsdGlwbHkpOiBVc2UgJ3RvJyBpbnN0ZWFkIG9mICdmcm9tJyB3aGVuIGNvbnZlcnRpbmcgdG8g U1JHQkEuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhZGllbnRDYWlyby5j cHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVDb25pYyk6IFVzZSBibGVuZFdpdGhvdXRQcmVt dWx0aXBseSgpIGluc3RlYWQgb2YgYmxlbmQoKSBmb3IgdGhlIGNvbG9yIHN0b3BzIGludGVycG9s YXRpb24uCisKIDIwMjAtMDctMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI2NDI3MikgW0dUS11bV1BFXSBjc3MzL2Nv bG9yL2NvbXBvc2l0ZWQtc29saWQtYmFja2dyb3VuZHMuaHRtbCBpcyBmYWlsaW5nCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Db2xvckJsZW5kaW5nLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yQmxlbmRpbmcuY3BwCmluZGV4 IDdiZTAzYTgzMjEwNS4uYTJkNzMxN2QzOWNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9Db2xvckJsZW5kaW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9Db2xvckJsZW5kaW5nLmNwcApAQCAtMTE4LDcgKzExOCw3IEBAIENv bG9yIGJsZW5kV2l0aG91dFByZW11bHRpcGx5KGNvbnN0IENvbG9yJiBmcm9tLCBjb25zdCBDb2xv ciYgdG8sIGRvdWJsZSBwcm9ncmVzCiAgICAgICAgIHJldHVybiB7IH07CiAKICAgICBhdXRvIGZy b21TUkdCID0gZnJvbS50b1NSR0JBTG9zc3k8dWludDhfdD4oKTsKLSAgICBhdXRvIHRvU1JHQiA9 IGZyb20udG9TUkdCQUxvc3N5PHVpbnQ4X3Q+KCk7CisgICAgYXV0byB0b1NSR0IgPSB0by50b1NS R0JBTG9zc3k8dWludDhfdD4oKTsKIAogICAgIHJldHVybiBjbGFtcFRvQ29tcG9uZW50Qnl0ZXM8 U1JHQkE+KAogICAgICAgICBXZWJDb3JlOjpibGVuZChmcm9tU1JHQi5yZWQsIHRvU1JHQi5yZWQs IHByb2dyZXNzKSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0dyYWRpZW50Q2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2Fpcm8vR3JhZGllbnRDYWlyby5jcHAKaW5kZXggM2I3ZTIxNmE1OGZiLi5lYmI2NTQwMjMw ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dy YWRpZW50Q2Fpcm8uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nh aXJvL0dyYWRpZW50Q2Fpcm8uY3BwCkBAIC0xNDIsNyArMTQyLDcgQEAgc3RhdGljIFJlZlB0cjxj YWlyb19wYXR0ZXJuX3Q+IGNyZWF0ZUNvbmljKGZsb2F0IHhvLCBmbG9hdCB5bywgZmxvYXQgciwg ZmxvYXQgYW4KICAgICAvLyBTbyBhZGQgdGhyZWUgYWRkaXRpb25hbCBpbnRlcnBvbGF0ZWQgc3Rv cHMsIGFsbG93aW5nIGZvciBmb3VyIEJlemllciBjdXJ2ZXMuCiAgICAgaWYgKHN0b3BzLnNpemUo KSA9PSAyKSB7CiAgICAgICAgIGF1dG8gaW50ZXJwb2xhdGVkU3RvcCA9IFsmXSAoZG91YmxlIGZy YWN0aW9uKSAtPiBHcmFkaWVudDo6Q29sb3JTdG9wIHsKLSAgICAgICAgICAgIHJldHVybiB7IGJs ZW5kKHN0b3BzLmZpcnN0KCkub2Zmc2V0LCBzdG9wcy5sYXN0KCkub2Zmc2V0LCBmcmFjdGlvbiks IGJsZW5kKHN0b3BzLmZpcnN0KCkuY29sb3IsIHN0b3BzLmxhc3QoKS5jb2xvciwgZnJhY3Rpb24p IH07CisgICAgICAgICAgICByZXR1cm4geyBibGVuZChzdG9wcy5maXJzdCgpLm9mZnNldCwgc3Rv cHMubGFzdCgpLm9mZnNldCwgZnJhY3Rpb24pLCBibGVuZFdpdGhvdXRQcmVtdWx0aXBseShzdG9w cy5maXJzdCgpLmNvbG9yLCBzdG9wcy5sYXN0KCkuY29sb3IsIGZyYWN0aW9uKSB9OwogICAgICAg ICB9OwogICAgICAgICBzdG9wcyA9IHsgc3RvcHMuZmlyc3QoKSwgaW50ZXJwb2xhdGVkU3RvcCgw LjI1KSwgaW50ZXJwb2xhdGVkU3RvcCgwLjUpLCBpbnRlcnBvbGF0ZWRTdG9wKDAuNzUpLCBzdG9w cy5sYXN0KCkgfTsKICAgICB9Cg==