214243 2020-07-12 14:48:59 -0700 [JSC] We should keep unaligned access feature in certain architectures in macro-assembler 2020-07-12 16:36:29 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1670925 0 ysuzuki 2020-07-12 14:48:59 -0700 [JSC] We should keep unaligned access feature in certain architectures in macro-assembler 1670926 1 404119 ysuzuki 2020-07-12 14:52:05 -0700 Created attachment 404119 Patch 1670927 2 404119 darin 2020-07-12 14:58:48 -0700 Comment on attachment 404119 Patch Seems like it might help us catch mistakes if we had an explicit loadUnalignedPtr just so we could have the assertion for call sites where we think things are aligned. 1670929 3 ysuzuki 2020-07-12 15:20:39 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 404119 [details] > Patch > > Seems like it might help us catch mistakes if we had an explicit > loadUnalignedPtr just so we could have the assertion for call sites where we > think things are aligned. Yeah, this is good, but I think currently, we have no way to enforce this condition at B3, e.g. B3 can freely compute addresses in any forms, while it is unlikely I think, this is possible that we will generate BaseIndex with Scale2 while it is pointing an aligned position to the pointer (Scale8). So, for now, this would be simpler solution. 1670930 4 ysuzuki 2020-07-12 15:22:04 -0700 I'll land it once EWS JSC build is done, since it is removing assertions which can occur only when Debug build is enabled, and this assertion was not hit in mac-debug previously. So, except for building, EWS status must not be changed. 1670931 5 ews-feeder 2020-07-12 15:41:23 -0700 Committed r264287: <https://trac.webkit.org/changeset/264287> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404119. 1670932 6 webkit-bug-importer 2020-07-12 15:42:14 -0700 <rdar://problem/65444830> 1670934 7 404119 keith_miller 2020-07-12 16:36:29 -0700 Comment on attachment 404119 Patch We can probably just remove the assertion. I added it because I wanted to catch cases where we used loadPtr but passed Scale64 for arm64_32. Since it's harder to debug that from the bad data later. I can just restore the assertion locally as I continue working on arm64_32 JITs. 404119 2020-07-12 14:52:05 -0700 2020-07-12 15:41:24 -0700 Patch bug-214243-20200712145205.patch text/plain 2048 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0Mjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MjllZDg0MmVmNTQ1Yjc1MTdlMGQ0ZjFlZTlkMTg1ZjBhM2FlNzI3Li5lOGQ1YzNiZDY5MjNjZWZl MmI5ZjY5MzM5YzMzNzIzMjg4ZmMxNWI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMC0wNy0xMiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFdlIHNob3VsZCBrZWVwIHVuYWxpZ25lZCBhY2Nlc3MgZmVhdHVy ZSBpbiBjZXJ0YWluIGFyY2hpdGVjdHVyZXMgaW4gbWFjcm8tYXNzZW1ibGVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQyNDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBpbnRyb2R1Y2VkIHRoZSBh c3NlcnRpb24gaW4gcjI2MzA0OSwgYnV0IHRoaXMgYXNzZXJ0aW9uIGNyYXNoZXMgaW4gdGVzdGIz IERlYnVnIGJ1aWxkLgorICAgICAgICB0ZXN0YjMgYWN0dWFsbHkgdGVzdHMgdW5hbGlnbmVkIGFj Y2VzcyBmZWF0dXJlIHNpbmNlIEFSTTY0IGFuZCB4NjQgYWxsb3cgaXQuIEFuZCB1bmFsaWduZWQg YWNjZXNzIGlzIHVzZWZ1bAorICAgICAgICBmb3IgWWFyciBldGMuLCBzbyB3ZSB3YW50IHRvIGtl ZXAgdW5hbGlnbmVkIGFjY2VzcyBmZWF0dXJlIGlmIGFyY2hpdGVjdHVyZSBhbGxvd3MgaXQuIFdl IHNob3VsZCBtYWtlIHRoaXMKKyAgICAgICAgYXNzZXJ0aW9uIGVmZmVjdGl2ZSBvbmx5IGlmIENQ VShORUVEU19BTElHTkVEX0FDQ0VTUykgaXMgdHJ1ZS4KKworICAgICAgICAqIGFzc2VtYmxlci9N YWNyb0Fzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlcjo6bG9hZFB0cik6 CisKIDIwMjAtMDctMTIgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAg ICAgICBbSlNDXSBBdm9pZCBKU1N0cmluZyBjcmVhdGlvbiBpbiBJbnRsLkxvY2FsZSN7bWluaW1p emUsbWF4aW1pemV9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyLmgKaW5kZXggM2NlYWY3YjVhM2NkYzVhNWUyZDc2YWMzNTgwZmRjNzczY2FjODE3 ZC4uY2EyNzkxMDZkMDhlNGM4OTRmZjk1MGYwMGZlMjI2ZmE4YWEzYzk0MiAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXIuaApAQCAtNzExLDcg KzcxMSw5IEBAIGNsYXNzIE1hY3JvQXNzZW1ibGVyIDogcHVibGljIE1hY3JvQXNzZW1ibGVyQmFz ZSB7CiAKICAgICB2b2lkIGxvYWRQdHIoQmFzZUluZGV4IGFkZHJlc3MsIFJlZ2lzdGVySUQgZGVz dCkKICAgICB7CisjaWYgQ1BVKE5FRURTX0FMSUdORURfQUNDRVNTKQogICAgICAgICBBU1NFUlQo YWRkcmVzcy5zY2FsZSA9PSBTY2FsZVB0ciB8fCBhZGRyZXNzLnNjYWxlID09IFRpbWVzT25lKTsK KyNlbmRpZgogICAgICAgICBsb2FkMzIoYWRkcmVzcywgZGVzdCk7CiAgICAgfQogCkBAIC0xMDU3 LDcgKzEwNTksOSBAQCBjbGFzcyBNYWNyb0Fzc2VtYmxlciA6IHB1YmxpYyBNYWNyb0Fzc2VtYmxl ckJhc2UgewogCiAgICAgdm9pZCBsb2FkUHRyKEJhc2VJbmRleCBhZGRyZXNzLCBSZWdpc3RlcklE IGRlc3QpCiAgICAgeworI2lmIENQVShORUVEU19BTElHTkVEX0FDQ0VTUykKICAgICAgICAgQVNT RVJUKGFkZHJlc3Muc2NhbGUgPT0gU2NhbGVQdHIgfHwgYWRkcmVzcy5zY2FsZSA9PSBUaW1lc09u ZSk7CisjZW5kaWYKICAgICAgICAgbG9hZDY0KGFkZHJlc3MsIGRlc3QpOwogICAgIH0KIAo=