214238 2020-07-12 12:43:34 -0700 Building CFNetworkSPI with the macOS Big Sur public SDK fails 2020-07-12 23:29:14 -0700 1 1 1 Unclassified WebKit New Bugs Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 214043 1 rbuis rbuis darin webkit-bug-importer oldest_to_newest 1670902 0 rbuis 2020-07-12 12:43:34 -0700 Build errors: In file included from WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource198.cpp:5: In file included from ./loader/CookieJar.cpp:35: In file included from Source/WebCore/platform/network/NetworkStorageSession.h:42: PAL/pal/spi/cf/CFNetworkSPI.h:71:1: error: expected unqualified-id @interface _NSHTTPConnectionInfo : NSObject ^ PAL/pal/spi/cf/CFNetworkSPI.h:73:1: error: expected unqualified-id @property (readonly) BOOL isValid; ^ PAL/pal/spi/cf/CFNetworkSPI.h:74:1: error: expected unqualified-id @end ^ PAL/pal/spi/cf/CFNetworkSPI.h:78:1: error: expected unqualified-id @end ^ 1670905 1 404113 rbuis 2020-07-12 12:48:07 -0700 Created attachment 404113 Patch 1670920 2 404113 darin 2020-07-12 14:29:27 -0700 Comment on attachment 404113 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404113&action=review > Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:72 > #if HAVE(PRECONNECT_PING) > + > +#if defined(__OBJC__) I’d slightly prefer this be && instead of two nested things. 1670923 3 404117 rbuis 2020-07-12 14:41:37 -0700 Created attachment 404117 Patch 1670969 4 ews-feeder 2020-07-12 23:28:28 -0700 Committed r264294: <https://trac.webkit.org/changeset/264294> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404117. 1670970 5 webkit-bug-importer 2020-07-12 23:29:14 -0700 <rdar://problem/65457718> 404113 2020-07-12 12:48:07 -0700 2020-07-12 14:41:33 -0700 Patch bug-214238-20200712204806.patch text/plain 1872 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCBkNzhmYWFk ZGI0YTEyMzM2MDRjZTQ2ZmQ5ZTg3MGM1ODRmMTNlNWVmLi5jOGZkMDNkN2U3MGY4YmQwY2VhNGYw YmI3YjAwMzk0Yjg3YzA5ZGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAyMC0wNy0xMiAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgorCisgICAgICAgIEJ1aWxk aW5nIENGTmV0d29ya1NQSSB3aXRoIHRoZSBtYWNPUyBCaWcgU3VyIHB1YmxpYyBTREsgZmFpbHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDIzOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1aWxkaW5n IENGTmV0d29ya1NQSSB3aXRoIHRoZSBtYWNPUyBCaWcgU3VyIHB1YmxpYyBTREsgZmFpbHMgYmFj YXVzZQorICAgICAgICBpdCBoYXMgT2JqZWN0aXZlLUMgZGVjbGFyYXRpb25zIGluIGEgaGVhZGVy IHRoYXTigJlzIGluY2x1ZGVkIGJ5IGEKKyAgICAgICAgbm9uLU9iamVjdGl2ZS1DIHNvdXJjZSBm aWxlLCB0byBmaXggd3JhcCB0aGUgZGVjbGFyYXRpb25zIGluIGEKKyAgICAgICAgZGVmaW5lZChf X09CSkNfXykgYmxvY2suCisKKyAgICAgICAgKiBwYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5oOgor CiAyMDIwLTA3LTEyICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgc3BlY3VsYXRpdmUgYnVpbGQgZml4IGZvciBpbnRlcm5hbCBidWlsZApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY2YvQ0ZOZXR3b3JrU1BJLmgg Yi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jZi9DRk5ldHdvcmtTUEkuaAppbmRleCBiM2Jl NTNkN2QwZDg1NTU3NWU1M2MxOWNjNTk4Y2IzNjM2ZDQ1NzU3Li5kNzFiNzMzZTM3M2ZkNzE1Nzg5 MGMzNWE3MmFkNzM3NTMxZWM5OWM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFs L3NwaS9jZi9DRk5ldHdvcmtTUEkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9j Zi9DRk5ldHdvcmtTUEkuaApAQCAtNjgsNiArNjgsOSBAQCBXVEZfRVhURVJOX0NfRU5ECiAjZWxz ZSAvLyAhUExBVEZPUk0oV0lOKSAmJiAhVVNFKEFQUExFX0lOVEVSTkFMX1NESykKIAogI2lmIEhB VkUoUFJFQ09OTkVDVF9QSU5HKQorCisjaWYgZGVmaW5lZChfX09CSkNfXykKKwogQGludGVyZmFj ZSBfTlNIVFRQQ29ubmVjdGlvbkluZm8gOiBOU09iamVjdAogLSAodm9pZClzZW5kUGluZ1dpdGhS ZWNlaXZlSGFuZGxlcjoodm9pZCAoXikoTlNFcnJvciAqIF9OdWxsYWJsZSBlcnJvciwgTlNUaW1l SW50ZXJ2YWwgaW50ZXJ2YWwpKXBvbmdIYW5kbGVyOwogQHByb3BlcnR5IChyZWFkb25seSkgQk9P TCBpc1ZhbGlkOwpAQCAtNzYsNiArNzksOSBAQCBXVEZfRVhURVJOX0NfRU5ECiBAaW50ZXJmYWNl IE5TVVJMU2Vzc2lvblRhc2sgKEhUVFBDb25uZWN0aW9uSW5mbykKIC0gKHZvaWQpZ2V0VW5kZXJs eWluZ0hUVFBDb25uZWN0aW9uSW5mb1dpdGhDb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoX05T SFRUUENvbm5lY3Rpb25JbmZvICpjb25uZWN0aW9uSW5mbykpY29tcGxldGlvbkhhbmRsZXI7CiBA ZW5kCisKKyNlbmRpZiAvLyBkZWZpbmVkKF9fT0JKQ19fKQorCiAjZW5kaWYgLy8gSEFWRShQUkVD T05ORUNUX1BJTkcpCiAKICNpZiBIQVZFKExPR0dJTkdfUFJJVkFDWV9MRVZFTCkK 404117 2020-07-12 14:41:37 -0700 2020-07-12 23:28:29 -0700 Patch bug-214238-20200712224136.patch text/plain 1933 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCBkNzhmYWFk ZGI0YTEyMzM2MDRjZTQ2ZmQ5ZTg3MGM1ODRmMTNlNWVmLi41ZDQ3M2E4ZDNjYTg0OWU3Zjk1YTA0 YTg1ZDdkYzc1OGUyY2YwYmQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAyMC0wNy0xMiAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgorCisgICAgICAgIEJ1aWxk aW5nIENGTmV0d29ya1NQSSB3aXRoIHRoZSBtYWNPUyBCaWcgU3VyIHB1YmxpYyBTREsgZmFpbHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDIzOAor CisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIEJ1aWxkaW5nIENG TmV0d29ya1NQSSB3aXRoIHRoZSBtYWNPUyBCaWcgU3VyIHB1YmxpYyBTREsgZmFpbHMgYmFjYXVz ZQorICAgICAgICBpdCBoYXMgT2JqZWN0aXZlLUMgZGVjbGFyYXRpb25zIGluIGEgaGVhZGVyIHRo YXTigJlzIGluY2x1ZGVkIGJ5IGEKKyAgICAgICAgbm9uLU9iamVjdGl2ZS1DIHNvdXJjZSBmaWxl LCB0byBmaXggd3JhcCB0aGUgZGVjbGFyYXRpb25zIGluIGEKKyAgICAgICAgZGVmaW5lZChfX09C SkNfXykgYmxvY2suCisKKyAgICAgICAgKiBwYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5oOgorCiAy MDIwLTA3LTEyICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgc3BlY3VsYXRpdmUgYnVpbGQgZml4IGZvciBpbnRlcm5hbCBidWlsZApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY2YvQ0ZOZXR3b3JrU1BJLmggYi9T b3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jZi9DRk5ldHdvcmtTUEkuaAppbmRleCBiM2JlNTNk N2QwZDg1NTU3NWU1M2MxOWNjNTk4Y2IzNjM2ZDQ1NzU3Li4zMDk0MjNlYTYwYjM0YWZjZWQ0Mjgz OTAzOTljZGEzZDllYTUwYzk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3Nw aS9jZi9DRk5ldHdvcmtTUEkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jZi9D Rk5ldHdvcmtTUEkuaApAQCAtNjcsNyArNjcsOCBAQCBXVEZfRVhURVJOX0NfRU5ECiAKICNlbHNl IC8vICFQTEFURk9STShXSU4pICYmICFVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogCi0jaWYgSEFW RShQUkVDT05ORUNUX1BJTkcpCisjaWYgSEFWRShQUkVDT05ORUNUX1BJTkcpICYmIGRlZmluZWQo X19PQkpDX18pCisKIEBpbnRlcmZhY2UgX05TSFRUUENvbm5lY3Rpb25JbmZvIDogTlNPYmplY3QK IC0gKHZvaWQpc2VuZFBpbmdXaXRoUmVjZWl2ZUhhbmRsZXI6KHZvaWQgKF4pKE5TRXJyb3IgKiBf TnVsbGFibGUgZXJyb3IsIE5TVGltZUludGVydmFsIGludGVydmFsKSlwb25nSGFuZGxlcjsKIEBw cm9wZXJ0eSAocmVhZG9ubHkpIEJPT0wgaXNWYWxpZDsKQEAgLTc2LDcgKzc3LDggQEAgV1RGX0VY VEVSTl9DX0VORAogQGludGVyZmFjZSBOU1VSTFNlc3Npb25UYXNrIChIVFRQQ29ubmVjdGlvbklu Zm8pCiAtICh2b2lkKWdldFVuZGVybHlpbmdIVFRQQ29ubmVjdGlvbkluZm9XaXRoQ29tcGxldGlv bkhhbmRsZXI6KHZvaWQgKF4pKF9OU0hUVFBDb25uZWN0aW9uSW5mbyAqY29ubmVjdGlvbkluZm8p KWNvbXBsZXRpb25IYW5kbGVyOwogQGVuZAotI2VuZGlmIC8vIEhBVkUoUFJFQ09OTkVDVF9QSU5H KQorCisjZW5kaWYgLy8gSEFWRShQUkVDT05ORUNUX1BJTkcpICYmIGRlZmluZWQoX19PQkpDX18p CiAKICNpZiBIQVZFKExPR0dJTkdfUFJJVkFDWV9MRVZFTCkKIHR5cGVkZWYgZW51bSB7Cg==